Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #14427 from Simonx22/qt/cheats-gecko-download-error-message

Browse Source 
DolphinQt: Improve Gecko code download failure message
This commit is contained in:
JMC47
2026-03-12 15:25:41 -04:00
committed by GitHub
parent ff84a4b07a d2e381090c
commit 161f9e82c1
4 changed files with 18 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/DolphinQt/Config/GeckoCodeWidget.cpp
+11 -5
View File
@@ -395,16 +395,22 @@ void GeckoCodeWidget::UpdateList()
void GeckoCodeWidget::DownloadCodes()
{
bool success;
const auto codes_result = Gecko::DownloadCodes(m_gametdb_id);
std::vector<Gecko::GeckoCode> codes = Gecko::DownloadCodes(m_gametdb_id, &success);
if (!success)
if (!codes_result)
{
ModalMessageBox::critical(this, tr("Error"), tr("Failed to download codes."));
QString message = tr("Failed to download Gecko codes. The code server may be temporarily "
"unavailable. Please try again later.");
const int http_response_code = codes_result.error();
if (http_response_code > 0)
message += tr("\n\nServer response: HTTP %1.").arg(http_response_code);
ModalMessageBox::critical(this, tr("Download Failed"), message);
return;
}
const std::vector<Gecko::GeckoCode>& codes = *codes_result;
if (codes.empty())
{
ModalMessageBox::critical(this, tr("Error"), tr("File contained no codes."));