Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PPCAnalyst: In IsBusyWaitLoop, ignore nop

Browse Source 
Found out when attempting to make a speed hack to help Dolphin detect an idle loop. The inserted `nop` was preventing it from considering it an idle loop.
This commit is contained in:
Martino Fontana
2026-06-14 01:08:31 +02:00
parent 1bc93fd16d
commit 2204a789e4
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/Core/PowerPC/PPCAnalyst.cpp
+6
View File
@@ -757,6 +757,12 @@ bool PPCAnalyzer::IsBusyWaitLoop(CodeBlock* block, CodeOp* code, size_t instruct
if (code[i].branchTo == block->m_address && i == instructions) if (code[i].branchTo == block->m_address && i == instructions)
return true; return true;
} }
// A `nop` is actually a `ori r0, r0, 0`, which would violate the rules (unless `r0` was written
// earlier).
else if (code[i].inst.hex == 0x60000000)
{
continue;
}
else if (code[i].opinfo->type != OpType::Integer && code[i].opinfo->type != OpType::Load) else if (code[i].opinfo->type != OpType::Integer && code[i].opinfo->type != OpType::Load)
{ {
// In the future, some subsets of other instruction types might get // In the future, some subsets of other instruction types might get