Yaya48/dolphin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #14554 from akechi-haruka/silence-ra-leaderboards

Browse Source 
Retroachievements: Hide leaderboard OSD messages if the leaderboard tracker is disabled
This commit is contained in:
Jordan Woyak authored and GitHub committed 2026-04-04 14:32:20 -05:00
2 parents c4e99cef61 6c33270e57
commit 2b6ca92146
1 file changed
+18 -9
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/Core/AchievementManager.cpp
+18 -9
View File
@@ -1175,26 +1175,35 @@ void AchievementManager::HandleAchievementTriggeredEvent(const rc_client_event_t
void AchievementManager::HandleLeaderboardStartedEvent(const rc_client_event_t* client_event) void AchievementManager::HandleLeaderboardStartedEvent(const rc_client_event_t* client_event)
{ {
OSD::AddMessage(fmt::format("Attempting leaderboard: {} - {}", client_event->leaderboard->title, if (Config::Get(Config::RA_LEADERBOARD_TRACKER_ENABLED))
client_event->leaderboard->description), {
OSD::Duration::VERY_LONG, OSD::Color::GREEN); OSD::AddMessage(fmt::format("Attempting leaderboard: {} - {}", client_event->leaderboard->title,
client_event->leaderboard->description),
OSD::Duration::VERY_LONG, OSD::Color::GREEN);
}
AchievementManager::GetInstance().FetchBoardInfo(client_event->leaderboard->id); AchievementManager::GetInstance().FetchBoardInfo(client_event->leaderboard->id);
} }
void AchievementManager::HandleLeaderboardFailedEvent(const rc_client_event_t* client_event) void AchievementManager::HandleLeaderboardFailedEvent(const rc_client_event_t* client_event)
{ {
OSD::AddMessage(fmt::format("Failed leaderboard: {}", client_event->leaderboard->title), if (Config::Get(Config::RA_LEADERBOARD_TRACKER_ENABLED))
OSD::Duration::VERY_LONG, OSD::Color::RED); {
OSD::AddMessage(fmt::format("Failed leaderboard: {}", client_event->leaderboard->title),
OSD::Duration::VERY_LONG, OSD::Color::RED);
}
AchievementManager::GetInstance().FetchBoardInfo(client_event->leaderboard->id); AchievementManager::GetInstance().FetchBoardInfo(client_event->leaderboard->id);
} }
void AchievementManager::HandleLeaderboardSubmittedEvent(const rc_client_event_t* client_event) void AchievementManager::HandleLeaderboardSubmittedEvent(const rc_client_event_t* client_event)
{ {
auto& instance = AchievementManager::GetInstance(); auto& instance = AchievementManager::GetInstance();
OSD::AddMessage(fmt::format("Scored {} on leaderboard: {}", if (Config::Get(Config::RA_LEADERBOARD_TRACKER_ENABLED))
client_event->leaderboard->tracker_value, {
client_event->leaderboard->title), OSD::AddMessage(fmt::format("Scored {} on leaderboard: {}",
OSD::Duration::VERY_LONG, OSD::Color::YELLOW); client_event->leaderboard->tracker_value,
client_event->leaderboard->title),
OSD::Duration::VERY_LONG, OSD::Color::YELLOW);
}
instance.FetchBoardInfo(client_event->leaderboard->id); instance.FetchBoardInfo(client_event->leaderboard->id);
instance.update_event.Trigger(UpdatedItems{.leaderboards = {client_event->leaderboard->id}}); instance.update_event.Trigger(UpdatedItems{.leaderboards = {client_event->leaderboard->id}});
} }