Merge pull request #14619 from JosJuice/no-si-change-device

Core: Remove SerialInterfaceManager::ChangeDevice

Source/Core/DolphinQt/Config/GamecubeControllersWidget.cpp

@@ -15,7 +15,6 @@
 
 #include "Core/ConfigManager.h"
 #include "Core/Core.h"
-#include "Core/HW/SI/SI.h"
 #include "Core/HW/SI/SI_Device.h"
 #include "Core/NetPlayProto.h"
 #include "Core/System.h"
@@ -190,17 +189,11 @@ void GamecubeControllersWidget::SaveSettings()
   {
     Config::ConfigChangeCallbackGuard config_guard;
 
-    auto& system = Core::System::GetInstance();
     for (size_t i = 0; i < m_gc_groups.size(); ++i)
     {
       const SerialInterface::SIDevices si_device =
           FromGCMenuIndex(m_gc_controller_boxes[i]->currentIndex());
       Config::SetBaseOrCurrent(Config::GetInfoForSIDevice(static_cast<int>(i)), si_device);
-
-      if (Core::IsRunning(system))
-      {
-        system.GetSerialInterface().ChangeDevice(si_device, static_cast<s32>(i));
-      }
     }
   }