Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #14808 from phire/ZeldaHLE_overflow

Browse Source 
Fix stack overflow in ZeldaHLE
This commit is contained in:
OatmealDome
2026-08-10 21:45:52 -04:00
committed by GitHub
parent 54a651074c 53cd8ffa3f
commit 4ff214cdd2
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp
+10 -3
View File
@@ -1468,9 +1468,16 @@ void ZeldaAudioRenderer::LoadInputSamples(MixingBuffer* buffer, VPB* vpb)
// the end of processing, if needed. // the end of processing, if needed.
// //
// Maximum of 0x500 samples here - see NeededRawSamplesCount to understand // Maximum of 0x500 samples here - see NeededRawSamplesCount to understand
// this practical limit (resampling_ratio = 0xFFFF -> 0x500 samples). Add a // this practical limit (resampling_ratio = 0xFFFF -> 0x500 samples).
// margin of 4 that is needed for samples source that do resampling. //
std::array<s16, 0x500 + 4> raw_input_samples; // If current_pos_frac contains an (invalid) non-fractional part, it can push
// this up by another 15 samples. Which DownloadAFCSamplesFromARAM then rounds
// up to the next multiple of 16. So add an extra 0x10 samples to be safe.
//
// Plus we need an extra four samples at the start to hold the last four
// samples from the previous frame.
std::array<s16, 4 + 0x500 + 0x10> raw_input_samples;
for (size_t i = 0; i < 4; ++i) for (size_t i = 0; i < 4; ++i)
raw_input_samples[i] = vpb->resample_buffer[i]; raw_input_samples[i] = vpb->resample_buffer[i];