Merge pull request #14074 from jordan-woyak/HookableEvent-no-strings

Common: Remove the string parameters from the HookableEvent interface.
This commit is contained in:
Jordan Woyak
2025-11-07 16:32:06 -06:00
committed by GitHub
27 changed files with 83 additions and 125 deletions
@@ -36,8 +36,7 @@ AchievementsWindow::AchievementsWindow(QWidget* parent) : QDialog(parent)
QueueOnObject(this, [this, updated_items = std::move(updated_items)] {
AchievementsWindow::UpdateData(std::move(updated_items));
});
},
"AchievementsWindow");
});
UpdateData(AchievementManager::UpdatedItems{.all = true});
connect(&Settings::Instance(), &Settings::EmulationStateChanged, this,
+2 -2
View File
@@ -79,8 +79,8 @@ void CheatsManager::UpdateAllCheatSearchWidgetCurrentValues()
void CheatsManager::RegisterAfterFrameEventCallback()
{
m_VI_end_field_event = m_system.GetVideoEvents().vi_end_field_event.Register(
[this] { OnFrameEnd(); }, "CheatsManager");
m_VI_end_field_event =
m_system.GetVideoEvents().vi_end_field_event.Register([this] { OnFrameEnd(); });
}
void CheatsManager::RemoveAfterFrameEventCallback()
@@ -429,8 +429,8 @@ void MemoryWidget::hideEvent(QHideEvent* event)
void MemoryWidget::RegisterAfterFrameEventCallback()
{
m_vi_end_field_event = m_system.GetVideoEvents().vi_end_field_event.Register(
[this] { AutoUpdateTable(); }, "MemoryWidget");
m_vi_end_field_event =
m_system.GetVideoEvents().vi_end_field_event.Register([this] { AutoUpdateTable(); });
}
void MemoryWidget::RemoveAfterFrameEventCallback()
+1 -1
View File
@@ -296,7 +296,7 @@ void MenuBar::AddToolsMenu()
#ifdef RC_CLIENT_SUPPORTS_RAINTEGRATION
m_achievements_dev_menu = tools_menu->addMenu(tr("RetroAchievements Development"));
m_raintegration_event_hook = AchievementManager::GetInstance().dev_menu_update_event.Register(
[this] { QueueOnObject(this, [this] { UpdateAchievementDevelopmentMenu(); }); }, "MenuBar");
[this] { QueueOnObject(this, [this] { UpdateAchievementDevelopmentMenu(); }); });
m_achievements_dev_menu->menuAction()->setVisible(false);
#endif // RC_CLIENT_SUPPORTS_RAINTEGRATION
tools_menu->addSeparator();
+1 -1
View File
@@ -75,7 +75,7 @@ Settings::Settings()
}
});
m_hotplug_event_hook = g_controller_interface.RegisterDevicesChangedCallback("Settings", [this] {
m_hotplug_event_hook = g_controller_interface.RegisterDevicesChangedCallback([this] {
if (Core::IsHostThread())
{
emit DevicesChanged();