Yaya48/dolphin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Core/DSP/DSPTables: Make FindOpInfoByName/FindExtOpInfoByName use std::string_view

Browse Source 
These functions only ever compare against another string, so these can
have their parameters turned into std::string_view to make them more
flexible.
This commit is contained in:
Lioncash committed 2019-06-06 12:22:02 -04:00
1 parent 3f4952d57c
commit 60d10d2813
2 files changed
+6 -6
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

Source/Core/Core/DSP/DSPTables.cpp
+3 -3
View File
@@ -511,7 +511,7 @@ std::array<const DSPOPCTemplate*, OPTABLE_SIZE> s_op_table;
std::array<const DSPOPCTemplate*, EXT_OPTABLE_SIZE> s_ext_op_table;
template <size_t N>
auto FindByName(const std::string& name, const std::array<DSPOPCTemplate, N>& data)
auto FindByName(std::string_view name, const std::array<DSPOPCTemplate, N>& data)
{
return std::find_if(data.cbegin(), data.cend(),
[&name](const auto& info) { return name == info.name; });
@@ -527,7 +527,7 @@ const DSPOPCTemplate* FindOpInfoByOpcode(UDSPInstruction opcode)
return &*iter;
}
const DSPOPCTemplate* FindOpInfoByName(const std::string& name)
const DSPOPCTemplate* FindOpInfoByName(std::string_view name)
{
const auto iter = FindByName(name, s_opcodes);
if (iter == s_opcodes.cend())
@@ -545,7 +545,7 @@ const DSPOPCTemplate* FindExtOpInfoByOpcode(UDSPInstruction opcode)
return &*iter;
}
const DSPOPCTemplate* FindExtOpInfoByName(const std::string& name)
const DSPOPCTemplate* FindExtOpInfoByName(std::string_view name)
{
const auto iter = FindByName(name, s_opcodes_ext);
if (iter == s_opcodes_ext.cend())