Yaya48/dolphin
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix uninitialized variable warning in ZeldaAudioRenderer::ApplyReverb

Browse Source 
If CopyFromEmuSwapped considers the address to be invalid, nothing will
be written to the passed-in pointer.
This commit is contained in:
JosJuice committed 2026-05-29 22:09:13 +02:00
1 parent f820b22147
commit 635fa74b4c
1 file changed
+1 -1
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/Core/HW/DSPHLE/UCodes/Zelda.cpp
+1 -1
View File
@@ -1085,7 +1085,7 @@ void ZeldaAudioRenderer::ApplyReverb(bool post_rendering)
auto& memory = m_system.GetMemory(); auto& memory = m_system.GetMemory();
for (u16 rpb_idx = 0; rpb_idx < 4; ++rpb_idx) for (u16 rpb_idx = 0; rpb_idx < 4; ++rpb_idx)
{ {
ReverbPB rpb; ReverbPB rpb{};
u32 rpb_addr = m_reverb_pb_base_addr + rpb_idx * sizeof(ReverbPB); u32 rpb_addr = m_reverb_pb_base_addr + rpb_idx * sizeof(ReverbPB);
memory.CopyFromEmuSwapped(reinterpret_cast<u16*>(&rpb), rpb_addr, sizeof(ReverbPB)); memory.CopyFromEmuSwapped(reinterpret_cast<u16*>(&rpb), rpb_addr, sizeof(ReverbPB));