Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

GeneralPane: Change BETA to RELEASE in updater variable names

Browse Source 
Rename `AUTO_UPDATE_BETA_INDEX` to `AUTO_UPDATE_RELEASE_INDEX` and
`AUTO_UPDATE_BETA_STRING` to `AUTO_UPDATE_RELEASE_STRING`.

Add a comment explaining that `AUTO_UPDATE_RELEASE_STRING = "beta"` for
backward compatibility reasons.
This commit is contained in:
Dentomologist
2026-04-01 10:58:12 -07:00
parent a95b18211b
commit 864ba85a50
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/DolphinQt/Settings/GeneralPane.cpp
+8 -5
View File
@@ -34,11 +34,14 @@
#endif #endif
constexpr int AUTO_UPDATE_DISABLE_INDEX = 0; constexpr int AUTO_UPDATE_DISABLE_INDEX = 0;
constexpr int AUTO_UPDATE_BETA_INDEX = 1; constexpr int AUTO_UPDATE_RELEASE_INDEX = 1;
constexpr int AUTO_UPDATE_DEV_INDEX = 2; constexpr int AUTO_UPDATE_DEV_INDEX = 2;
constexpr const char* AUTO_UPDATE_DISABLE_STRING = ""; constexpr const char* AUTO_UPDATE_DISABLE_STRING = "";
constexpr const char* AUTO_UPDATE_BETA_STRING = "beta"; // Before the official switch to the rolling release cycle in 2407, de facto releases were called
// beta builds. To maintain backward compatibility and let users update from those builds to current
// releases the value of this string remains "beta".
constexpr const char* AUTO_UPDATE_RELEASE_STRING = "beta";
constexpr const char* AUTO_UPDATE_DEV_STRING = "dev"; constexpr const char* AUTO_UPDATE_DEV_STRING = "dev";
constexpr int FALLBACK_REGION_NTSCJ_INDEX = 0; constexpr int FALLBACK_REGION_NTSCJ_INDEX = 0;
@@ -259,7 +262,7 @@ void GeneralPane::LoadConfig()
else if (track == AUTO_UPDATE_DEV_STRING) else if (track == AUTO_UPDATE_DEV_STRING)
SignalBlocking(m_combobox_update_track)->setCurrentIndex(AUTO_UPDATE_DEV_INDEX); SignalBlocking(m_combobox_update_track)->setCurrentIndex(AUTO_UPDATE_DEV_INDEX);
else else
SignalBlocking(m_combobox_update_track)->setCurrentIndex(AUTO_UPDATE_BETA_INDEX); SignalBlocking(m_combobox_update_track)->setCurrentIndex(AUTO_UPDATE_RELEASE_INDEX);
} }
#if defined(USE_ANALYTICS) && USE_ANALYTICS #if defined(USE_ANALYTICS) && USE_ANALYTICS
@@ -297,8 +300,8 @@ static QString UpdateTrackFromIndex(int index)
case AUTO_UPDATE_DISABLE_INDEX: case AUTO_UPDATE_DISABLE_INDEX:
value = QString::fromStdString(AUTO_UPDATE_DISABLE_STRING); value = QString::fromStdString(AUTO_UPDATE_DISABLE_STRING);
break; break;
case AUTO_UPDATE_BETA_INDEX: case AUTO_UPDATE_RELEASE_INDEX:
value = QString::fromStdString(AUTO_UPDATE_BETA_STRING); value = QString::fromStdString(AUTO_UPDATE_RELEASE_STRING);
break; break;
case AUTO_UPDATE_DEV_INDEX: case AUTO_UPDATE_DEV_INDEX:
value = QString::fromStdString(AUTO_UPDATE_DEV_STRING); value = QString::fromStdString(AUTO_UPDATE_DEV_STRING);