Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
1 parent
33f62b0f9f
commit
95dec13203
140 files changed
+318
-277
No files matched your search
@@ -538,7 +538,7 @@ void GekkoIRPlugin::AddSymbolResolve(std::string_view sym, bool absolute)
|
||||
};
|
||||
|
||||
m_fixup_stack.emplace(
|
||||
[this, sym, absolute, source_address, err_on_fail = std::move(err_on_fail)] {
|
||||
[this, sym, absolute, source_address, err_on_fail = std::move(err_on_fail)] mutable {
|
||||
auto label_it = m_labels.find(sym);
|
||||
if (label_it != m_labels.end())
|
||||
{
|
||||
@@ -575,7 +575,7 @@ void GekkoIRPlugin::AddNumLabelSymResolve(std::string_view sym, u32 num)
|
||||
// Searching forward only
|
||||
size_t search_start_idx = static_cast<size_t>(m_numlabs.size());
|
||||
m_fixup_stack.emplace(
|
||||
[this, num, source_address, search_start_idx, err_on_fail = std::move(err_on_fail)] {
|
||||
[this, num, source_address, search_start_idx, err_on_fail = std::move(err_on_fail)] mutable {
|
||||
for (size_t i = search_start_idx; i < m_numlabs.size(); i++)
|
||||
{
|
||||
if (num == m_numlabs[i].first)
|
||||
|
||||
Reference in new issue
Block a user