Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
@@ -5,6 +5,7 @@
|
||||
#include <cstddef>
|
||||
#include <cstring>
|
||||
#include <string>
|
||||
#include <utility>
|
||||
|
||||
#include "Common/CommonTypes.h"
|
||||
#include "Common/Logging/Log.h"
|
||||
@@ -14,9 +15,9 @@
|
||||
|
||||
namespace Common
|
||||
{
|
||||
TraversalClient::TraversalClient(ENetHost* netHost, const std::string& server, const u16 port,
|
||||
TraversalClient::TraversalClient(ENetHost* netHost, std::string server, const u16 port,
|
||||
const u16 port_alt)
|
||||
: m_NetHost(netHost), m_Server(server), m_port(port), m_portAlt(port_alt)
|
||||
: m_NetHost(netHost), m_Server(std::move(server)), m_port(port), m_portAlt(port_alt)
|
||||
{
|
||||
netHost->intercept = TraversalClient::InterceptCallback;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user