Improve usage of std::move and const references parameters

Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`.

Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move.

Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
Martino Fontana committed 2026-04-17 12:39:46 +02:00
1 parent 33f62b0f9f
commit 95dec13203
140 files changed
+318 -277

No files matched your search

+2 -2
View File
@@ -32,13 +32,13 @@ public:
private:
void OnEmulationStateChanged(Core::State state);
void CreateWidgets();
std::pair<QCheckBox*, QLineEdit*> AddHashLine(QFormLayout* layout, QString text);
std::pair<QCheckBox*, QLineEdit*> AddHashLine(QFormLayout* layout, const QString& text);
void ConnectWidgets();
bool CanVerifyRedump() const;
void UpdateRedumpEnabled();
void Verify();
void SetProblemCellText(int row, int column, QString text);
void SetProblemCellText(int row, int column, const QString& text);
std::shared_ptr<DiscIO::Volume> m_volume;
QTableWidget* m_problems;