Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
@@ -517,8 +517,9 @@ void RegisterWidget::PopulateTable()
|
||||
m_table->resizeColumnsToContents();
|
||||
}
|
||||
|
||||
void RegisterWidget::AddRegister(int row, int column, RegisterType type, std::string register_name,
|
||||
std::function<u64()> get_reg, std::function<void(u64)> set_reg)
|
||||
void RegisterWidget::AddRegister(int row, int column, RegisterType type,
|
||||
const std::string& register_name, std::function<u64()> get_reg,
|
||||
std::function<void(u64)> set_reg)
|
||||
{
|
||||
auto* value = new RegisterColumn(type, std::move(get_reg), std::move(set_reg));
|
||||
|
||||
|
||||
Reference in New Issue
Block a user