Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
1 parent
33f62b0f9f
commit
95dec13203
140 files changed
+318
-277
No files matched your search
@@ -19,7 +19,7 @@ ModalMessageBox::ModalMessageBox(QWidget* parent, Qt::WindowModality modality)
|
||||
static inline int ExecMessageBox(ModalMessageBox::Icon icon, QWidget* parent, const QString& title,
|
||||
const QString& text, ModalMessageBox::StandardButtons buttons,
|
||||
ModalMessageBox::StandardButton default_button,
|
||||
Qt::WindowModality modality, QString detailed_text)
|
||||
Qt::WindowModality modality, const QString& detailed_text)
|
||||
{
|
||||
ModalMessageBox msg(parent, modality);
|
||||
msg.setIcon(icon);
|
||||
|
||||
Reference in new issue
Block a user