Improve usage of std::move and const references parameters
Accomplished using `run-clang-tidy` with `performance-move-const-arg,performance-unnecessary-value-param,modernize-pass-by-value`. Changed arguments to const references, removed them where inappropriate (e.g. sink parameters). Same with std::move. Manually reviewed each change to make sure that it makes sense, and do something more appropriate if possible.
This commit is contained in:
1 parent
33f62b0f9f
commit
95dec13203
140 files changed
+318
-277
No files matched your search
@@ -166,8 +166,8 @@ QGridLayout* TASInputWindow::CreateSliderValuePairLayout(
|
||||
TASSpinBox* TASInputWindow::CreateSliderValuePair(
|
||||
std::string_view group_name, std::string_view control_name, InputOverrider* overrider,
|
||||
QGridLayout* layout, int zero, int default_, int min, int max,
|
||||
QKeySequence shortcut_key_sequence, Qt::Orientation orientation, QWidget* shortcut_widget,
|
||||
std::optional<ControlState> scale)
|
||||
const QKeySequence& shortcut_key_sequence, Qt::Orientation orientation,
|
||||
QWidget* shortcut_widget, std::optional<ControlState> scale)
|
||||
{
|
||||
TASSpinBox* value = CreateSliderValuePair(layout, default_, max, shortcut_key_sequence,
|
||||
orientation, shortcut_widget);
|
||||
@@ -194,7 +194,7 @@ TASSpinBox* TASInputWindow::CreateSliderValuePair(
|
||||
// The shortcut_widget argument needs to specify the container widget that will be hidden/shown.
|
||||
// This is done to avoid ambiguous shortcuts
|
||||
TASSpinBox* TASInputWindow::CreateSliderValuePair(QGridLayout* layout, int default_, int max,
|
||||
QKeySequence shortcut_key_sequence,
|
||||
const QKeySequence& shortcut_key_sequence,
|
||||
Qt::Orientation orientation,
|
||||
QWidget* shortcut_widget)
|
||||
{
|
||||
|
||||
@@ -64,12 +64,12 @@ protected:
|
||||
TASSpinBox* CreateSliderValuePair(std::string_view group_name, std::string_view control_name,
|
||||
InputOverrider* overrider, QGridLayout* layout, int zero,
|
||||
int default_, int min, int max,
|
||||
QKeySequence shortcut_key_sequence, Qt::Orientation orientation,
|
||||
QWidget* shortcut_widget,
|
||||
const QKeySequence& shortcut_key_sequence,
|
||||
Qt::Orientation orientation, QWidget* shortcut_widget,
|
||||
std::optional<ControlState> scale = {});
|
||||
TASSpinBox* CreateSliderValuePair(QGridLayout* layout, int default_, int max,
|
||||
QKeySequence shortcut_key_sequence, Qt::Orientation orientation,
|
||||
QWidget* shortcut_widget);
|
||||
const QKeySequence& shortcut_key_sequence,
|
||||
Qt::Orientation orientation, QWidget* shortcut_widget);
|
||||
|
||||
void SetupScrollArea(QLayout* layout);
|
||||
|
||||
|
||||
Reference in new issue
Block a user