Merge pull request #9359 from leoetlino/gdbstub-on

Fix GDBStub build and build it by default

CMakeLists.txt

@@ -50,7 +50,7 @@ option(ENCODE_FRAMEDUMPS "Encode framedumps in AVI format" ON)
 
 option(ENABLE_GPROF "Enable gprof profiling (must be using Debug build)" OFF)
 option(FASTLOG "Enable all logs" OFF)
-option(GDBSTUB "Enable gdb stub for remote debugging." OFF)
+option(GDBSTUB "Enable gdb stub for remote debugging." ON)
 option(OPROFILING "Enable profiling" OFF)
 
 # TODO: Add DSPSpy

Source/Core/Core/PowerPC/GDBStub.cpp

@@ -240,7 +240,7 @@ static void gdb_read_command()
   cmd_len = 0;
   memset(cmd_bfr, 0, sizeof cmd_bfr);
 
-  const u8 c = gdb_read_byte();
+  u8 c = gdb_read_byte();
   if (c == '+')
   {
     // ignore ack