Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

c++23: Replace Common::Unreachable with std::unreachable

Browse Source 
Requires at least GCC 12, Clang 15, MSVC 19.32, or AppleClang 14.0.3.
This commit is contained in:
Joshua Vandaële
2026-01-17 23:53:21 +01:00
parent b556bd99d7
commit e822cc3715
10 changed files with 19 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Source/Core/DolphinQt/Debugger/BranchWatchDialog.cpp
+1 -2
View File
@@ -34,7 +34,6 @@
#include "Common/CommonTypes.h"
#include "Common/FileUtil.h"
#include "Common/IOFile.h"
#include "Common/Unreachable.h"
#include "Core/ConfigManager.h"
#include "Core/Core.h"
#include "Core/Debugger/BranchWatch.h"
@@ -1217,7 +1216,7 @@ QMenu* BranchWatchDialog::GetTableContextMenu(const QModelIndex& index) const
return m_mnu_table_context_symbol;
}
static_assert(Column::NumberOfColumns == 8);
Common::Unreachable();
std::unreachable();
}
void BranchWatchDialog::RefreshVisibleContextMenuActions(bool core_initialized) const
Source/Core/DolphinQt/Debugger/BranchWatchTableModel.cpp
+4 -4
View File
@@ -6,12 +6,12 @@
#include <algorithm>
#include <array>
#include <cstddef>
#include <utility>
#include <QBrush>
#include "Common/Assert.h"
#include "Common/GekkoDisassembler.h"
#include "Common/Unreachable.h"
#include "Core/Debugger/BranchWatch.h"
#include "Core/PowerPC/PPCSymbolDB.h"
@@ -352,7 +352,7 @@ QVariant BranchWatchTableModel::DisplayRoleData(const QModelIndex& index) const
return QString::number(kv->second.total_hits);
}
static_assert(Column::NumberOfColumns == 8);
Common::Unreachable();
std::unreachable();
}
QVariant BranchWatchTableModel::FontRoleData(const QModelIndex& index) const
@@ -402,7 +402,7 @@ QVariant BranchWatchTableModel::TextAlignmentRoleData(const QModelIndex& index)
return QVariant::fromValue(Qt::AlignLeft | Qt::AlignVCenter);
}
static_assert(Column::NumberOfColumns == 8);
Common::Unreachable();
std::unreachable();
}
QVariant BranchWatchTableModel::ForegroundRoleData(const QModelIndex& index) const
@@ -495,5 +495,5 @@ QVariant BranchWatchTableModel::SortRoleData(const QModelIndex& index) const
return qulonglong{kv->second.total_hits};
}
static_assert(Column::NumberOfColumns == 8);
Common::Unreachable();
std::unreachable();
}
Source/Core/DolphinQt/Debugger/JitBlockTableModel.cpp
+4 -4
View File
@@ -5,9 +5,9 @@
#include <array>
#include <span>
#include <utility>
#include "Common/Assert.h"
#include "Common/Unreachable.h"
#include "Core/Core.h"
#include "Core/PowerPC/JitInterface.h"
#include "Core/PowerPC/PPCSymbolDB.h"
@@ -284,7 +284,7 @@ QVariant JitBlockTableModel::DisplayRoleData(const QModelIndex& index) const
}
}
static_assert(Column::NumberOfColumns == 14);
Common::Unreachable();
std::unreachable();
}
QVariant JitBlockTableModel::TextAlignmentRoleData(const QModelIndex& index) const
@@ -310,7 +310,7 @@ QVariant JitBlockTableModel::TextAlignmentRoleData(const QModelIndex& index) con
return QVariant::fromValue(Qt::AlignLeft | Qt::AlignVCenter);
}
static_assert(Column::NumberOfColumns == 14);
Common::Unreachable();
std::unreachable();
}
QVariant JitBlockTableModel::SortRoleData(const QModelIndex& index) const
@@ -358,7 +358,7 @@ QVariant JitBlockTableModel::SortRoleData(const QModelIndex& index) const
return static_cast<double>(profile_data->time_spent.count()) / profile_data->run_count;
}
static_assert(Column::NumberOfColumns == 14);
Common::Unreachable();
std::unreachable();
}
QVariant JitBlockTableModel::data(const QModelIndex& index, int role) const