Tillmann Karras
05381c5b6d
Address Pokechu22's feedback
2025-04-25 00:51:46 +01:00
Tilka
c4f65febf3
Merge pull request #13563 from Tilka/rcheevos
...
Fix building with USE_RETRO_ACHIEVEMENTS=OFF
2025-04-23 03:27:15 +01:00
Tilka
871073eee2
Merge pull request #13564 from jordan-woyak/triforce_ipl-warning
...
Core/Boot: Fix unused variable warning.
2025-04-23 03:26:48 +01:00
Tillmann Karras
609165b62b
Fix building with USE_RETRO_ACHIEVEMENTS=OFF
2025-04-22 23:45:40 +01:00
Tillmann Karras
f6d3f448d9
IOS/Network: fix -Wmissing-braces warnings
2025-04-22 23:36:01 +01:00
Tilka
7e7b75c1e6
Merge pull request #13537 from tygyh/DiscIO-Make-variables-constexpr
...
DiscIO: Make variables constexpr
2025-04-21 00:52:18 +01:00
Tilka
9504916f72
Merge pull request #13538 from tygyh/DiscIO-Use-default-to-define-a-trivial-destructor
...
DiscIO: Use `= default` to define a trivial destructor
2025-04-20 22:32:12 +01:00
Tilka
0a52140145
Merge pull request #13549 from shuffle2/ucrtpatch
...
remove ucrt compat patches
2025-04-20 22:24:57 +01:00
Tilka
45ed4b2be9
Merge pull request #13541 from tygyh/DiscIO-Remove-redundant-zero-initializers-in-aggregate-initializations
...
DiscIO: Remove redundant zero initializers in aggregate initializations
2025-04-20 22:07:58 +01:00
Tilka
2adf3449f3
Merge pull request #13548 from shuffle2/http
...
HttpRequest: remove some legacy code for windows < 8.1
2025-04-20 22:07:32 +01:00
Tilka
c705e366f0
Merge pull request #13478 from jordan-woyak/metal-af
...
VideoBackends/Metal: Fix anisotropic filtering handling.
2025-04-02 09:07:44 +01:00
Tilka
662cfa38c2
Merge pull request #13460 from jordan-woyak/play-time-tracker-thread-name
...
Core: Name the play time tracker thread.
2025-03-27 17:02:36 +00:00
Tillmann Karras
5a708f0f24
GameSettings: fix startup crash in "The Daring Game for Girls"
2025-03-23 23:28:22 +00:00
Tilka
3b8384acf6
Merge pull request #13438 from Tilka/heads/refs/warning
...
Fix -Wunused-lambda-capture warning
2025-03-17 22:16:46 +00:00
Tillmann Karras
6a90affa38
Fix -Wunused-lambda-capture warning
2025-03-17 20:08:19 +00:00
Tillmann Karras
90b6f0d16d
Config: make SP2 configurable
2025-03-15 22:03:17 +00:00
Tillmann Karras
951a84833a
EXI: fix AD16
...
The GameCube IPL is now able to detect this device. However, this
triggers some memory clearing code that trips up Dolphin's I$.
2025-03-15 22:03:16 +00:00
Tilka
f4e6878384
Merge pull request #13406 from Tilka/snow
...
GameSettings: fix shadows in Triple Crown Championship Snowboarding
2025-03-09 22:48:47 +00:00
Tillmann Karras
cbd71f06ba
GameSettings: fix shadows in Triple Crown Championship Snowboarding
2025-03-09 20:50:22 +00:00
Tilka
ecb0a3e5c7
Merge pull request #13389 from iwubcode/static_texcoords_vertex_shadergen
...
VideoCommon: mark 'WriteTexCoordTransforms' as 'static'
2025-03-03 02:45:52 +00:00
Tillmann Karras
4e460a7968
UberShaderPixel: use unswapped texture samples for depth
2025-02-25 18:45:01 +00:00
Tillmann Karras
359fb51d64
PixelShaderGen: use unswapped texture samples for depth
2025-02-25 18:45:01 +00:00
Tillmann Karras
7abb9e7974
Sofware/Tev: use unswapped texture samples for depth
2025-02-25 18:45:01 +00:00
Tilka
030892abd9
Merge pull request #13369 from Tilka/qt_warnings
...
CMake: disable Qt deprecation warnings we can't fix
2025-02-25 18:32:28 +00:00
Tilka
4d1737e423
Merge pull request #13371 from Florin9doi/prusb1
...
USB: Remove unused parameters
2025-02-24 05:20:30 +00:00
Tilka
16ce28b70b
Merge pull request #13372 from Florin9doi/prusb2
...
USB: Fix Infinity Manager icon
2025-02-24 05:20:15 +00:00
Tillmann Karras
a8363854ee
CMake: disable Qt deprecation warnings we can't fix
2025-02-23 14:18:05 +00:00
Tillmann Karras
262e6f9c17
CMake: don't enable -Wshadow-uncaptured-local
...
This warning unhelpfully triggers for the `[x = std::move(x)]` pattern
which is used quite a few times in Dolphin.
2025-02-21 02:51:32 +00:00
Tillmann Karras
5db6bd6054
VideoCommon: simplify dither calculation
...
This saves three instructions on AMD GPUs. Dunno about Nvidia.
2025-02-11 19:23:37 +00:00
Tillmann Karras
19d954eaea
VideoCommon: remove CP readonly field, it's now always false
2025-02-08 11:46:49 +00:00
Tillmann Karras
84e72c185a
VideoCommon: drop CP MMIO registers that were probably added in the wrong place
...
I think someone confused these with the actual token and bounding box
registers in PE, which were added later. In CP they never did anything
and it's suspicious that they have the same addresses as their PE
counterparts. On real hardware they always read as zero.
2025-02-08 11:46:49 +00:00
Tilka
b51ca82032
Merge pull request #13335 from jordan-woyak/wm-speaker-constant
...
WiimoteEmu: Use a named constant instead of a magic number for speaker data writes.
2025-02-04 02:22:01 +00:00
Tilka
510a688a2a
Merge pull request #13279 from jordan-woyak/delimited-token
...
InputCommon/ExpressionParser: Require delimited tokens actually have their terminating delimiter.
2025-01-20 23:14:22 +00:00
Tilka
e24e107b3c
Merge pull request #13265 from Sintendo/warnings
...
Fix several minor warnings
2025-01-08 21:44:24 +00:00
Tilka
ffa312f8e8
Merge pull request #13158 from jordan-woyak/wiiu-rename
...
DolphinQt: Rename "GameCube Adapter for Wii U".
2025-01-08 21:39:08 +00:00
Tilka
05cad38abc
Merge pull request #13243 from nlebeck/stringutil-tests
...
Add some unit test coverage of the `SplitPath` function
2024-12-27 18:10:47 +01:00
Tillmann Karras
445fe2248c
GameSettings: set EFBAccessEnable=True for Neighbours from Hell
...
This fixes the loading screens that show a walking animation.
2024-12-08 11:29:15 +00:00
Tilka
7f25e05b31
Merge pull request #13188 from dreamsyntax/titledb-update
...
Sys: Sync wiitdb files with GameTDB
2024-11-15 00:05:42 +00:00
Tilka
375a990e41
Merge pull request #13185 from JosJuice/rvz-clarify-padding-none
...
docs: Clarify wia_except_list_t padding in uncompressed groups
2024-11-10 15:40:08 +00:00
Tillmann Karras
fbce737415
ProcessorInterface: sync GPU just before PI_FIFO_RESET
...
GXAbortFrame() is problematic for Dolphin because it first writes
PI_FIFO_RESET (for which we discard our internal fifo), then disables CP
reads (for which we execute pending commands in the GP fifo in emulated
memory). I don't know whether there is a race condition on hardware, but
there is one for us. Avoid this by also doing a GPU sync here.
2024-11-09 03:29:05 +00:00
Tilka
4b0b9799a9
Merge pull request #13000 from tygyh/Simplify-type-specifiers
...
Remove redundant elaborated type specifiers
2024-11-08 23:59:08 +00:00
Tilka
97ea64164b
Merge pull request #13182 from jordan-woyak/wiimote-speaker-remove-dumping-code
...
WiimoteEmu: Remove disabled and no-longer-compiling wav dumping code.
2024-11-08 22:53:56 +00:00
Tillmann Karras
0488ade1dc
DSPHLE/AXWii: fix Elebits sound
...
Regressed in 37ebb13ece .
2024-11-04 20:47:55 +00:00
Tilka
97931a718f
Merge pull request #13151 from mitaclaw/core-global-system-6
...
MainWindow: Avoid Global System Accessor
2024-11-02 12:04:28 +00:00
Tilka
466e8de62c
Merge pull request #13163 from jordan-woyak/pragma-once-oopsie
...
Add include guard to QtUtils.h
2024-11-02 12:01:27 +00:00
Tillmann Karras
5adc1bdecd
GameSettings: add patch to fix Eternal Darkness startup hang
...
The game calls GXSetDrawDone and then switches the GP fifo without first
waiting for the draw done interrupt to arrive. Before
e96960e2a6 , Dolphin would not execute the
draw done command and potentially also skip other commands in the old GP
fifo. Since that commit, Dolphin executes the remaining commands on the
old GP fifo just before disabling reads for switching, but because
PixelEngineManager::RaiseEvent() enforces a minimum delay of 500 cycles
for the draw done interrupt, it arrives after the game has switched to
the new GP fifo which seems to trigger the deadlock.
This patch replaces the call to GXSetDrawDone by a call to GXDrawDone
which does the same but also waits for the interrupt.
2024-10-30 21:16:31 +00:00
Tilka
fed8220c39
Merge pull request #12712 from Dentomologist/remove_defined_out_code
...
Remove defined-out code
2024-10-19 19:36:19 +01:00
Tillmann Karras
0e41adb7b7
VideoCommon: fix -Wshadow-uncaptured-local warning and simplify
2024-10-16 18:36:00 +01:00
Tillmann Karras
fd95607700
Core: apply Dolphin OnFrame patches right after boot
2024-10-16 02:58:03 +01:00
Tillmann Karras
37ebb13ece
DSPHLE/AXWii: fix wiimote audio in multiple games
...
Three bugs specific to older Wii games:
- The size difference between high-pass and biquad filter was not
accounted for, causing wiimote related fields to be corrupted.
- Wiimote sample buffer pointers were advanced by 32 samples per
millisecond instead of 6 samples. Usually hidden by the first bug.
- PB updates on Wii were being byte-swapped twice, but I've not actually
found any Wii games that make use of PB updates.
This fixes wiimote audio in at least the following games:
- Excite Truck
- Ice Age 2: The Meltdown
- Kororinpa: Marble Mania
- Rapala Tournament Fishing
- Shrek the Third
- Super Monkey Ball: Banana Blitz
- Tiger Woods PGA Tour 07
- WarioWare: Smooth Moves (issue 11725)
- Wing Island
2024-10-15 18:54:41 +01:00
Tilka
d43c6dc555
Merge pull request #13074 from Pokechu22/normal-cache
...
Cache normals in addition to binormals and tangents
2024-10-12 19:49:48 +01:00
Tillmann Karras
09b163d814
Boot: don't error for NTSC IPL v1.2 of DOL-001 consoles
...
Checksum and descriptions from Redump.
2024-10-12 16:11:42 +01:00
Tilka
35ec2e97a8
Merge pull request #13079 from JosJuice/android-16k
...
Android: Add 16 KiB page size support
2024-10-12 10:11:33 +01:00
Tilka
c5ce90b786
Merge pull request #13080 from JosJuice/androidx-edge-to-edge
...
Android: Use enableEdgeToEdge
2024-10-12 10:11:11 +01:00
Tilka
2024d9f8ff
Merge pull request #13126 from jordan-woyak/no-big-banner
...
DolphinQt: Restrict size of banner image in game properties info tab.
2024-10-12 09:40:20 +01:00
Tilka
f635c71f28
Merge pull request #13125 from jordan-woyak/mapping-tab-bar-auto-hide
...
DolphinQt: Auto hide the mapping window tab bar.
2024-10-12 09:36:19 +01:00
Tilka
9eb0429c2e
Merge pull request #13124 from jordan-woyak/trigger-threshold-99
...
ControllerEmu: Change trigger threshold check to prevent user error.
2024-10-12 09:34:53 +01:00
Tilka
67e8f37c5b
Merge pull request #13123 from jordan-woyak/mapping-indicator-dark-theme-code-cleanup
...
DolphinQt/MappingIndicator: Use Settings::IsThemeDark instead of reimplementing it.
2024-10-12 01:24:43 +01:00
Tilka
d6e10e586a
Merge pull request #13076 from robxnano/dbus-inhibit
...
Linux: Use D-Bus to inhibit screensaver
2024-10-12 00:31:58 +01:00
Tilka
f4e0a42cfc
Merge pull request #13075 from robxnano/qt-color-scheme
...
Remove unneeded Win32 code for color scheme
2024-10-11 22:20:42 +01:00
Tilka
8679d6c334
Merge pull request #13120 from Sintendo/mtspr
...
JitArm64: Optimize mtspr
2024-10-11 21:42:12 +01:00
Tilka
d2a56b321f
Merge pull request #13095 from mitaclaw/ranges-modernization-6-n
...
Ranges Algorithms Modernization - N
2024-10-11 20:28:06 +01:00
Tilka
c1832d17f6
Merge pull request #13117 from mitaclaw/ranges-modernization-9-trivial-find
...
Ranges Algorithms Modernization - Find
2024-10-11 20:27:18 +01:00
Tilka
d374284d92
Merge pull request #13119 from SuperSamus/skylanders-tt-gp-remove
...
Remove Bloom Definitions for Skylanders Trap Team
2024-10-11 19:35:14 +01:00
Tilka
696ff5baea
Merge pull request #13121 from mitaclaw/synthesize-operator!=
...
C++20: Synthesize `operator!=` From `operator==`
2024-10-11 18:31:56 +01:00
Tilka
b5f7a50874
Merge pull request #13118 from BobConanDev/master
...
Update Contributing.md
2024-10-10 20:35:13 +01:00
Tillmann Karras
e96960e2a6
VideoCommon: fix common opcode decoding errors
...
Many games call GXSetGPFifo() without first waiting for the GP to finish
consuming outstanding commands in the previous GP fifo. Normally,
Dolphin runs OpcodeDecoding in 1000-cycle time slices. In that time
frame, GXSetGPFifo() has probably completed and the GP read pointer now
points to entirely new memory. If the last GP fifo copy ended in an
incomplete command, the new GP fifo would most likely desync for a
while. To avoid all this, give the GP a time slice right now to copy the
remaining data from the previous GP fifo.
2024-10-10 04:07:44 +01:00
Tillmann Karras
3c11360335
IOS: log cIOS device checks as warnings, not errors
...
Some games do this to detect piracy.
2024-10-09 21:18:36 +01:00
Tilka
2b22e6ffc9
Merge pull request #13109 from Pokechu22/fifo-player-wii-bats
...
FifoPlayer: Set up additional BATs in Wii mode
2024-10-07 17:42:54 +01:00
Tilka
3466f803b5
Merge pull request #13110 from Pokechu22/fifo-analyzer-xf-index-words
...
Fifo analyzer: Fix indexed XF loads showing "bytes" instead of "words"
2024-10-07 17:38:24 +01:00
Tilka
d1ac40a72b
Merge pull request #13101 from JosJuice/gametdbid-partition
...
Core: Include partition when calling GetGameTDBID for non-game partition
2024-10-05 22:31:58 +01:00
Tillmann Karras
e455833ea4
Bluetooth: show vid:pid in error message
2024-10-02 21:50:25 +01:00
Tillmann Karras
0323b30ed7
GameSettings: safe texture cache for "Winter Sports 3: The Great Tournament"
...
This is required to avoid glitches during Downhill Skiing.
2024-10-01 01:42:18 +01:00
Tillmann Karras
a02cbc9b78
WII_IPC: rewrite multiply as 100_tbticks literal (NFC)
2024-10-01 01:42:16 +01:00
Tilka
c7cbac538a
Merge pull request #13083 from Tilka/apploader
...
Boot: write Apploader version into memory
2024-09-29 14:40:43 +01:00
Tillmann Karras
b168a8092f
Boot: write Apploader version into memory
...
When HLE-ing the apploader, this is necessary to avoid "Error #002 "
errors. Homebrew doesn't care.
2024-09-29 03:57:44 +01:00
Tilka
2cb124bd3a
Merge pull request #13062 from Dentomologist/graphics_clarify_relationship_between_incompatible_settings
...
Graphics: Clarify relationship between incompatible settings
2024-09-27 05:40:30 +01:00
Tilka
61836e5d8e
Merge pull request #13077 from Dentomologist/graphicswindow_fix_first_opening_during_emulation_startup_crash
...
GraphicsWindow: Fix crash when opening for the first time during emulation startup
2024-09-27 05:38:37 +01:00
Tilka
ec6f5e1104
Merge pull request #13072 from Tilka/videosw
...
VideoSoftware: small cleanup
2024-09-25 10:57:05 +01:00
Tillmann Karras
0a299a4e1e
Sw/Tev: drop unused macro
2024-09-24 22:00:03 +01:00
Tillmann Karras
98add9faf0
Sw/Rasterizer: fix two elder typos, AD 2009
2024-09-24 22:00:03 +01:00
Tilka
067bdaa3dd
Merge pull request #13067 from mitaclaw/dead-code-3
...
GeckoCode: Remove Dead Code
2024-09-22 05:00:26 +01:00
Tilka
6851ed73f4
Merge pull request #13064 from PatrickFerry/gameini_fixing_mistakes
...
GameINI: Fixing Various Mistakes
2024-09-16 23:24:56 +01:00
Tilka
af921685f7
Merge pull request #13035 from retroNUC/cheevo-hash
...
Add generation of rcheevos hash as an option in DolphinTool
2024-09-15 22:18:58 +01:00
Tilka
5fe9e2f6ed
Merge pull request #13057 from JosJuice/rvzpack-typo
...
DiscIO: Fix a typo in an RVZPack comment
2024-09-08 16:08:57 +01:00
Tilka
2417545b63
Merge pull request #13052 from Tilka/ax
...
DSPHLE/AX: fix low-pass/biquad clipping
2024-09-07 11:36:06 +01:00
Tillmann Karras
eb54721475
DSPHLE/AX: fix low-pass/biquad clipping
...
The low-pass and biquad filters run in set40 mode where accessing ac#.m
returns the value of ac#.hm clamped to 16 bits.
This fixes the crackling in "Need for Speed: Nitro" (issue 13610).
Also make the lower bound match hardware (-0x8000 instead of -0x7FFF).
2024-09-04 22:33:31 +01:00
Tilka
a293abbfd0
Merge pull request #13044 from JosJuice/subfic-carry
...
Interpreter: Fix subfic carry calculation
2024-08-31 17:24:17 +01:00
Tilka
157be45d6b
Merge pull request #13042 from homeisfar/vk_improve_logger
...
vulkan: Add line number to vulkan error logger
2024-08-31 13:05:28 +01:00
Tilka
d0b10b84c0
Merge pull request #13043 from Tilka/my_first_songs
...
GameSettings: force EFB-to-RAM for My First Songs
2024-08-31 13:04:24 +01:00
Tillmann Karras
4b60ab9ce3
GameSettings: force EFB-to-RAM for My First Songs
2024-08-31 00:11:24 +01:00
Tilka
38b189e13d
Merge pull request #13039 from Dentomologist/mainwindow_fix_hidden_confirm_on_stop_dialog
...
MainWindow: Prevent Confirm On Stop dialog from being hidden by the Render window
2024-08-31 00:08:45 +01:00
Tilka
8b7268ddef
Merge pull request #13038 from Ferdi265/fix-rvz-clang-ub
...
RVZ: Fix undefined behaviour when copying 0 bytes to a null pointer
2024-08-31 00:06:38 +01:00
Tilka
39e266c5bf
Merge pull request #13036 from PatrickFerry/gameini_enable_pal60
...
Gameini: Enable PAL60 for Some PAL Games
2024-08-28 16:56:25 +01:00
Tilka
22ed1dddca
Merge pull request #13037 from Dentomologist/hotkeyscheduler_handle_wiimote_connections_independently
...
HotkeyScheduler: Handle Wii Remote connections independently
2024-08-27 18:54:52 +01:00
Tilka
cc256ef16d
Merge pull request #10663 from Tilka/ax_biquad
...
AX: add support for biquad filtering
2024-08-24 22:31:05 +01:00
Tillmann Karras
2669d0d8af
AX: add analytics quirks for wiimote filters
...
I'm fairly sure the implementation is correct but I've not been able to
find a game that actually makes use of these filters.
2024-08-24 19:47:22 +01:00
Tillmann Karras
6946f17b8c
AX: enable low-pass/biquad filtering of Wiimote audio
2024-08-24 16:31:59 +01:00
Tillmann Karras
9d2841be10
AX: add support for biquad filtering
...
This fixes e.g. the overly loud wind in "I SPY: Spooky Mansion".
2024-08-24 16:31:59 +01:00
Tilka
1f5e100a0e
Merge pull request #13033 from mitaclaw/remove-common-fill
...
TypeUtils: Remove Common::Fill
2024-08-23 09:16:13 +01:00