Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
34,021 Commits 1 Branch 0 Tags
118b2a3580972972c42a492347287fc292add50b
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Léo Lam 118b2a3580 Core/DSP: Fix improper uses of offsetof 
According to the C standard, an offsetof expression must evaluate to an
address constant, otherwise it's undefined behavior.

Fixes https://bugs.dolphin-emu.org/issues/12409

See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95942

There are still improper uses of offsetof (mostly in JitArm64) but
fixing that will take more effort since there's a PPCSTATE_OFF wrapper
macro that is sometimes used with non-array members and sometimes used
with arrays and variable indices... Let's keep that for another PR.
 2021-02-10 02:03:16 +01:00
Léo Lam 3e4769f720 Merge pull request #9483 from Leseratte10/patch-2 
Fix clientcakey typo in Readme.md
 2021-01-29 23:10:26 +01:00
Léo Lam 906fbf6c8e Merge pull request #5978 from sepalani/net-log 
NetworkCaptureLogger: Move SSL logging
 2021-01-28 22:03:40 +01:00
Léo Lam 2f661fec23 Merge pull request #9462 from trofi/master 
Externals/rangeset: use qualified 'size_t'
 2021-01-28 21:44:30 +01:00
Léo Lam a8adaa458e Merge pull request #9476 from shuffle2/cfmt 
require clang-format 10.0
 2021-01-28 21:43:58 +01:00
Léo Lam c386c5acc2 Merge pull request #9366 from iwubcode/freelook_camera_quaternion 
VideoCommon: allow Free Look to be manipulated by a quaternion
 2021-01-28 01:34:09 +01:00
Léo Lam 9ca24ae8e0 Merge pull request #9092 from shuffle2/vshack 
msbuild: Merge "Core" libs into single DolphinLib
 2021-01-28 01:33:46 +01:00
Léo Lam 4740c2a882 Merge pull request #9080 from SirMangler/debugger 
MemoryWidget: Add 'Offset' and General Improvements
 2021-01-28 01:21:21 +01:00
Léo Lam 96e3360f05 Merge pull request #9452 from JosJuice/android-wii-saves 
Android: Add "Import Wii Save"
 2021-01-27 23:00:47 +01:00
Léo Lam 8c127a612f Merge pull request #9416 from Filoppi/patch-9 
InputCommon: Wrap remaining invalid default input expressions around ``
 2021-01-27 19:54:20 +01:00
Léo Lam 6dc0f0dfe6 Merge pull request #9438 from shuffle2/add-shortcut-to-desktop 
DolphinQT: Gives option to add desktop shortcut
 2021-01-27 19:41:09 +01:00
Léo Lam b597b16f63 Merge pull request #9439 from Darwin-Rist/master 
Added Opacity settings for touchscreen controls
 2021-01-27 19:35:58 +01:00
Léo Lam 28cd6f6520 Merge pull request #9440 from lioncash/qt6 
DolphinQt: Qt 6.0 forward-compatibility changes
 2021-01-27 19:28:43 +01:00
Léo Lam 6086111566 Merge pull request #9467 from iwubcode/gamecube_controllers_widget 
DolphinQt: Move gamecube controller ui logic to its own widget
 2021-01-27 19:24:06 +01:00
Léo Lam 84ad550c19 Merge pull request #9449 from Filoppi/patch-11 
Qt: Fix Shake Mapping Indicator not showing deadzone
 2021-01-27 19:19:58 +01:00
Léo Lam 42b55e8fa3 Merge pull request #9450 from Filoppi/patch-12 
Qt: Fix stock input profiles being deletable
 2021-01-27 19:18:51 +01:00
Léo Lam 920dd812ad Merge pull request #9468 from iwubcode/wiimote_controllers_widget 
DolphinQt: Move wiimote controller ui logic to its own widget
 2021-01-27 18:54:29 +01:00
Léo Lam fb09acd01f Merge pull request #9453 from JosJuice/state-metadata-osd 
Android: Don't show OSD messages when opening savestate menu
 2021-01-27 18:22:39 +01:00
Léo Lam 70447d0281 Merge pull request #9454 from JosJuice/android-ingame-settings-save 
Android: Fix in-game settings changes not getting saved
 2021-01-27 18:17:27 +01:00
Léo Lam b886c70a43 Merge pull request #9456 from trevor403/breakpoint-loading 
Breakpoint from string flag parsing using token
 2021-01-27 15:53:24 +01:00
Léo Lam 4ba9bb26e9 Merge pull request #9455 from lioncash/traversal 
TraversalProto: Minor cleanup
 2021-01-27 15:51:29 +01:00
Léo Lam bb121dc9a5 Merge pull request #9477 from shuffle2/asan 
windows: fix unregistering VEH
 2021-01-27 15:47:55 +01:00
Léo Lam 305faa73ec Merge pull request #9436 from shuffle2/asan 
msvc: enable asan compat
 2021-01-27 13:24:26 +01:00
Léo Lam 2537ea77ee Merge pull request #9460 from jordan-woyak/wiimote-dc-crash-fix 
WiimoteReal: Fix crash on real Wii Remote disconnect on Windows.
 2021-01-27 13:14:52 +01:00
Léo Lam bc14e4a0f0 Merge pull request #9463 from Dentomologist/fix_CreateTempDir_calls 
UnitTests: Add setup error checking
 2021-01-27 13:12:05 +01:00
Léo Lam 093978b2e0 Merge pull request #9466 from iwubcode/common_controllers_widget 
DolphinQt: Move common controller interface logic to its own widget
 2021-01-27 13:06:20 +01:00
Léo Lam d8bea87aa3 Merge pull request #9469 from Stevoisiak/remove-redundant-inis 
Remove redundant INI settings
 2021-01-27 12:43:51 +01:00
Léo Lam 2d75b0d2bc Merge pull request #9472 from JosJuice/jitarm64-unexpected-double 
JitArm64: Update registers last used before start of instruction
 2021-01-27 12:43:11 +01:00
Léo Lam 0776263c5e Merge pull request #9428 from JosJuice/tv-folder-picker 
Android: Use old folder picker on Android TV
 2021-01-09 11:54:02 +01:00
Léo Lam 4cdcbb6ab2 Merge pull request #9308 from smurf3tte/re23_patch 
Patches for Resident Evil 2/3 audio issues
 2021-01-06 01:52:15 +01:00
Léo Lam 0b1db65aa1 Merge pull request #9405 from Filoppi/patch-7 
Rename "Use Fullscreen" setting to "Start in Fullscreen"
 2021-01-06 01:44:46 +01:00
Léo Lam eafb9de047 Merge pull request #9323 from waddlesplash/haiku 
Rehabilitate Haiku support.
 2021-01-05 16:09:43 +01:00
Léo Lam 840ecfb32f Merge pull request #9409 from AdmiralCurtiss/wii-save-import-tmd 
Make WiiSave::Import() behave closer to the Wii System Menu's SD Card save copying.
 2021-01-05 15:36:36 +01:00
Léo Lam e48377dfc6 Merge pull request #9404 from Filoppi/patch-5 
Fix typos and code coding conventions
 2021-01-05 15:33:43 +01:00
Léo Lam ee25f03ff9 Merge pull request #9418 from Filoppi/patch-10 
Fix DualShockUDP not adding/removing devices correctly
 2021-01-05 15:15:53 +01:00
Léo Lam 9069ad6cce Merge pull request #9420 from MerryMage/ext 
Externals: Link against required libraries
 2021-01-05 15:15:15 +01:00
Léo Lam fcdcdd7beb Merge pull request #9410 from lioncash/enum2 
Arm64Emitter: Convert ArithOption enums into enum classes
 2021-01-01 13:25:35 +01:00
Léo Lam 452aad29f1 Merge pull request #9401 from lioncash/jittable 
JitArm64_Tables: Construct tables at compile-time
 2021-01-01 01:22:49 +01:00
Léo Lam 344a74aa11 Merge pull request #9396 from lioncash/arm 
JitArm64_RegCache: Interface cleanup
 2021-01-01 01:03:55 +01:00
Léo Lam f59ee87031 Merge pull request #9402 from lioncash/emitter 
Arm64Emitter: Interface cleanup
 2021-01-01 00:52:40 +01:00
Léo Lam 8a3b14d7dc Merge pull request #9391 from lioncash/find-str 
IOS: Allow for heterogenous name lookup
 2020-12-30 01:47:01 +01:00
Léo Lam 806a4f3a9a Merge pull request #9393 from lioncash/sysconf 
SysConf: Make use of std::string_view
 2020-12-30 01:22:39 +01:00
Léo Lam 716497fbce Merge pull request #9394 from lioncash/recurse 
Core: Use C++17 deduction guides with locked recursive mutexes
 2020-12-30 00:47:43 +01:00
Léo Lam 3b2e31230f Merge pull request #9386 from leoetlino/config-cache-invalidate 
Config: Fix cache not being invalidated when callbacks are suppressed
 2020-12-29 22:22:15 +01:00
Léo Lam 9ffd345df0 Config: Fix cache not being invalidated when callbacks are suppressed 
The config version should always be incremented whenever config is
changed, regardless of callbacks being suppressed or not.
Otherwise, getters can return stale data until another config change
(with callbacks enabled) happens.
 2020-12-29 22:07:47 +01:00
Léo Lam 351fb71653 Merge pull request #9387 from lioncash/priv 
DSPCore: Make several SDSP members private
 2020-12-29 22:05:11 +01:00
Léo Lam 41316daf91 Merge pull request #9384 from lioncash/mbox-enum 
DSP: Convert Mailbox enum into an enum class
 2020-12-29 19:57:55 +01:00
Léo Lam ee048ad83c Merge pull request #9377 from lioncash/analyzer 
DSPAnalyzer: Migrate off file-scope state
 2020-12-29 18:04:54 +01:00
Léo Lam 5ff2cb9a74 Merge pull request #9383 from lioncash/cr-fn 
DSP: Eliminate some magic values related to the CR register
 2020-12-29 17:37:24 +01:00
Léo Lam 15d4ddf5da Merge pull request #9379 from Pokechu22/audio-latency-disable 
Fix latency field being initially enabled on audio backends not supporting it
 2020-12-29 17:28:10 +01:00
Léo Lam 5e186f4830 Merge pull request #9382 from lioncash/precise 
DSPCore: Move PRECISE_BACKLOG define to the interpreter code
 2020-12-29 17:17:59 +01:00
Léo Lam f21e1d1859 Merge pull request #9381 from JosJuice/fix-core-filters 
Fix Core.vcxproj.filters
 2020-12-29 17:16:56 +01:00
Léo Lam 9b3cdd0645 IOS/WD: Report game quirk if unimplemented ioctl is used 
Lets us find games to test more easily.
 2020-12-28 16:15:17 +01:00
Léo Lam 9a87d27612 IOS/WD: Implement more parts of the interface 
This commit implements the following commands:

* open
* close
* GetMode
* SetLinkState (used to actually trigger scanning)
* GetLinkState (used to check if the driver is in the expected state)
* GetInfo
* RecvFrame and RecvNotification (stubbed)
* Disassociate (stubbed)

GetInfo was already implemented, but the structure wasn't initialized
correctly so the info was being rejected by official titles.
That has also been fixed in this commit.

Some of the checks may seem unimportant but official titles actually
require WD to return error codes... Failing to do so can cause hangs
and softlocks when DS communications are shut down.

This minimal implementation is enough to satisfy the Mii channel
and all other DS games, except Tales of Graces (https://dolp.in/i11977)
which still softlocks because it probably requires us to actually
feed it frame data.
 2020-12-28 16:15:17 +01:00
Léo Lam dcbe81b880 IOS: Simplify usage of GetVector 
By making GetVector return nullptr for invalid indices, we don't have
to check the total number of vectors all the time before calling
GetVector.
 2020-12-28 16:12:04 +01:00
Léo Lam 4fea832f49 IOS/NCD: Implement Lock/Unlock more accurately 
NCD returns an error if it receives a request to lock the driver
when it is already locked.

Emulating this may seem pointless, but it turns out PPC-side code
expects NCD to return an error and will immediately fail and stop
initialising wireless stuff if NCD succeeds.
 2020-12-28 16:12:04 +01:00
Léo Lam 3f68aceaca Merge pull request #9348 from lioncash/dsp-deglobal 
DSP: Eliminate most global state
 2020-12-28 15:48:11 +01:00
Léo Lam e509353eb0 Merge pull request #9372 from jordan-woyak/cmake-version-warnings 
CMake: Update cmake_minimum_required calls using versions less than 2.8.12.
 2020-12-28 12:20:46 +01:00
Léo Lam 506cbd336a Merge pull request #9375 from iWeaker4you/master 
BitUtils: Fix uint64_t gcc compile (Linux)
 2020-12-28 12:18:27 +01:00
Léo Lam 4705af59c6 Merge pull request #9355 from JosJuice/perfmon 
Call UpdatePerformanceMonitor when needed
 2020-12-27 16:13:36 +01:00
Léo Lam 2917af03ec Merge pull request #9362 from iwubcode/freelook_fix_crash 
VideoCommon: Fix crash that occurs on loading a fifo log when Free Look is enabled
 2020-12-27 11:37:50 +01:00
Léo Lam dcc313fd96 Merge pull request #9346 from Sintendo/jitarm64ub 
JitArm64: Fix signed bitwise left shift UB
 2020-12-26 11:56:33 +01:00
Léo Lam d2f9991b0f Merge pull request #9360 from Minty-Meeo/osreport-split 
Split OSREPORT logging type
 2020-12-26 11:41:18 +01:00
Léo Lam 0aadb9fd7b Build the gdbstub by default 
While the gdbstub is somewhat broken at the moment, building it by
default should keep us from breaking the build (which has happened
several times in the past: #2614, #5904, #8262).

It isn't very intrusive and it does nothing unless it is enabled
in the config file.
 2020-12-25 01:21:36 +01:00
Léo Lam ae187818f5 PowerPC: Fix GDBStub build 2020-12-25 01:15:31 +01:00
Léo Lam 6ddf69d094 Merge pull request #9353 from MaddTheSane/patch-1 
CMake: Apple Silicon detection
 2020-12-24 22:50:27 +01:00
Léo Lam 0ad2f3da45 Core: Remove ImageWrite and get rid of -Wmissing-declarations warnings 2020-12-16 16:04:19 +01:00
Léo Lam eafe005672 Fix -Wclass-memaccess warnings 
We want to clear/memset the padding bytes, not just each member,
so using assignment or {} initialization is not an option.

To silence the warnings, cast the object pointer to u8* (which is not
undefined behavior) to make it explicit to the compiler that we want
to fill the object representation.
 2020-12-16 15:37:43 +01:00
Léo Lam 6018525992 Qt: Fix deprecated use of MidButton 
MidButton has been deprecated since Qt 4.7. The replacement is
MiddleButton.
 2020-12-16 14:45:11 +01:00
Léo Lam efdb620783 Qt/Config: Remove unused includes 2020-12-16 14:43:26 +01:00
Léo Lam c59372dbb0 EXI_Device: Always define EXIDEVICE_ETHTAPSERVER for consistency 
This keeps the enum values consistent across platforms in case new
entries are added after EXIDEVICE_ETHTAPSERVER.
 2020-12-15 20:49:29 +01:00
Léo Lam 2615da820d Merge pull request #9157 from jordan-woyak/wm-emu-tilt-wrap-around 
WiimoteEmu: Allow tilt to wrap around and simulate full 360 degree rotations.
 2020-12-15 03:14:14 +01:00
Léo Lam 2feb5f204a Merge pull request #9117 from fuzziqersoftware/add-tapserver-bba 
Add tapserver network interface for macOS since TunTap is now unmaintained
 2020-12-15 03:08:26 +01:00
Léo Lam dbf7c40886 Merge pull request #9309 from devnexen/netbsd_port 
NetBSD support proposal.
 2020-12-15 02:41:05 +01:00
Léo Lam ded7d1b23d Merge pull request #9285 from AdmiralCurtiss/libpng-1.6.37 
Update bundled libpng to version 1.6.37 (from 1.6.29)
 2020-12-15 02:24:16 +01:00
Léo Lam ed1564515b Merge pull request #9326 from Subject38/wiimote_deadlock 
InputCommon: Fix callback dispatch deadlock
 2020-12-15 01:16:59 +01:00
Léo Lam 2c2ec16b53 Merge pull request #9320 from JosJuice/remove-patch-crash 
DolphinQt: Fix crash after removing extra patch line
 2020-12-15 00:01:07 +01:00
Léo Lam 214ea8ff18 Merge pull request #9328 from AdmiralCurtiss/memory-view-crash 
Core/AddressSpace: Return null accessors when no game is running to prevent out-of-bounds memory accesses.
 2020-12-14 03:18:45 +01:00
Léo Lam 3634508e46 Merge pull request #9311 from JosJuice/config-get-fast-2 
Add caching to Config::Info
 2020-12-13 03:55:39 +01:00
Léo Lam 9bb8107a05 Merge pull request #9319 from JosJuice/default-enabled-no-propagate 
Core: Don't copy default _Enabled sections to user INIs
 2020-12-11 17:24:52 +01:00
Léo Lam 7d9276c340 Merge pull request #9317 from JosJuice/default-enabled-codes 
GameSettings: Enable compatibility patches by default
 2020-12-11 10:40:03 +01:00
Léo Lam fd5c69deca Merge pull request #9289 from AdmiralCurtiss/simple-png-api-write 
Use Simplified libpng API for writing PNGs.
 2020-12-11 10:24:16 +01:00
Léo Lam 2e63cc8313 Merge pull request #9307 from Dentomologist/add-deleted-file-missing-warning-flag 
Add File::Delete and File::DeleteDir warning flags
 2020-12-11 02:06:28 +01:00
Léo Lam 19324e6ed9 Merge pull request #9313 from leoetlino/check-content-hashes 
WiiUtils: Check hashes to determine if a title is installed and up-to-date
 2020-12-08 15:45:12 +01:00
Léo Lam f7d7bbf55f WiiUtils: Check hashes to determine if a title is installed and up-to-date 
Nintendo's official title installation code and ES both only look at
content IDs but we should probably check for content hashes in addition
to checking for IDs for at least two reasons:

1. Some of the installed contents could be corrupted -- this cannot be
   easily detected without checking hashes.

2. Some mod distributors do not bother to update content IDs, which
   means that installing updates from the UI would not actually
   update the installed game. This is confusing for users.

To keep the existing semantic (for IOS especially), the new content
hash checks are opt-in for callers of GetStoredContentsFromTMD.

This commit changes WiiUtils's WAD installation logic to enable
the content hash checks.
 2020-12-06 01:53:55 +01:00
Léo Lam 2952f99f69 Merge pull request #9312 from iwubcode/dynamic-input-textures-fix 
InputCommon: fix dynamic input textures when host key isn't mapped
 2020-12-06 00:46:06 +01:00
Léo Lam c8cb330df0 Merge pull request #9310 from leoetlino/compile-time-errors-format 
Turn format string issues into compile-time errors
 2020-12-05 23:58:04 +01:00
Léo Lam d8b9a040ed Merge pull request #9275 from JosJuice/framedump-boot-time 
FrameDump: Start timing at 0 ticks when starting from boot
 2020-12-05 23:57:41 +01:00
Léo Lam 585899dba3 Turn format string issues into compile-time errors 
If the compiler can detect an issue with a format string at compile
time, then we should take advantage of that and turn the issue into a
hard compile-time error as such problems almost always lead to UB.

This helps with catching logging or assertion messages that have been
converted over to fmt but are still using the old, non-fmt variants
of the logging macros.

This commit also fixes all incorrect usages that I could find.
 2020-12-04 18:06:02 +01:00
Léo Lam dbc0fd1d89 Merge pull request #9305 from r-burns/discord 
Exclude Discord RPC lib from installation
 2020-12-03 11:51:53 +01:00
Léo Lam b148b56fba Merge pull request #9304 from lioncash/panic 
General: Convert PanicAlerts over to fmt equivalent
 2020-12-02 20:45:27 +01:00
Léo Lam a5880fa402 Qt: Add missing tr calls for tooltip descriptions 2020-11-30 14:04:08 +01:00
Léo Lam d043c5f81d Merge pull request #9153 from iwubcode/qt_custom_tooltip 
Remove description box in graphics tabs and use custom tooltips instead
 2020-11-29 12:37:31 +01:00
Léo Lam 361bf25cf8 Merge pull request #9254 from flagrama/fallback-region-selection 
Fallback Region Option
 2020-11-29 00:19:15 +01:00
Léo Lam 738e1a6dbb Merge pull request #9297 from JosJuice/movie-game-id-comparison 
Movie: Fix 83b9fef regressions
 2020-11-29 00:09:30 +01:00
Léo Lam cf32c4d479 Merge pull request #9296 from JosJuice/issue-12327-workaround 
JitArm64: Add a workaround for issue 12327
 2020-11-28 22:44:37 +01:00
Léo Lam c0f7f91507 Core: Fix an assertion that mistakenly uses a fmt format string 
Unfortunately, adding a DEBUG_ASSERT_MSG_FMT isn't actually possible
right now because of compiler bugs:
https://github.com/dolphin-emu/dolphin/pull/9284

We could require a newer version of GCC (10) but that would require
updating GCC on the build machines.

For what it's worth, older versions of GCC (8, 9) are broken in
many ways: adding constexpr to some Matrix functions causes GCC 8
to generate bugged code that causes the Wii IR pointer to disappear,
which means that the generated builds are already unusable
(see https://dolp.in/i12324).

Additionally,  we've already had to add workarounds for those versions
in the format macros to fix compilation bugs. This time, it looks like
workarounds won't cut it; even applying the workaround
described in https://github.com/fmtlib/fmt/pull/1580 does not help.
 2020-11-28 21:11:27 +01:00
Léo Lam a9845e0a3d Merge pull request #9191 from sepalani/net-interface 
IP/Top: Add Android network interface
 2020-11-28 18:22:33 +01:00
Léo Lam a34f19cb96 Merge pull request #9291 from lioncash/alert-audio 
AudioCommon: Convert alerts over to fmt-based variants
 2020-11-28 16:33:50 +01:00
Léo Lam 5a554e8e5d Merge pull request #9292 from Dentomologist/fix-liblzma-config-on-macOS 
Fix liblzma config on macOS
 2020-11-28 16:32:56 +01:00