Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
41,469 Commits 1 Branch 0 Tags
18abf7c768c715e4399bb68aec5d623633a1427f
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash 5ade2e39ef Core/Movie: Remove lingering global system instance accessors 
The movie manager is already passed in a reference to the relevant
system, so we can use that instead.
 2024-01-31 13:30:24 -05:00
Lioncash 0dfefacdf4 VertexLoaderBase: Collapse std namespace for hash and mark noexcept 
Makes the hash specialization a little less noisy. Also we mark it
noexcept, since hashes shouldn't be throwing exceptions (and this can be
optimized on).
 2024-01-31 12:43:00 -05:00
Lioncash 8e4b2565cd TextureConfig: Collapse std namespace for hash 
Lets us collapse the namespacing and make the specialization a little
less noisy.
 2024-01-31 12:41:33 -05:00
Lioncash b63dcd504d RenderState: Collapse std namespace for hash 
We can specify the namespace on the hash to make the specialization a
little less noisy.
 2024-01-31 12:40:10 -05:00
Lioncash 5bfaa3a966 NativeVertexFormat: Collapse std namespace and mark hash noexcept 
We can just tag the std:: onto the end of the specialization to make it
less noisy.

Also mark it as noexcept, since hashes shouldn't throw exceptions.
 2024-01-31 12:37:44 -05:00
Lioncash 40b050fe37 GraphicsModGroup: std::move graphics_mod in Load() 
The config object is quite heavyweight, so we should move this instead
of copying.
 2024-01-31 12:27:43 -05:00
Lioncash ccacda5e2c GraphicsModGroup: Simplify try_add_mod() 
We can use contains() here, and also move the mod config if it's valid
instead of copying it, since it contains quite a bit of allocated data.
 2024-01-31 12:23:21 -05:00
Lioncash 81aca79145 GraphicsModListWidget: Pass optional by const reference 
All we do is read from it, so we don't need to copy the string if we
happen to have one.
 2024-01-31 12:09:35 -05:00
Lioncash a1879ea099 GraphicsModGroup: Allow heterogenous lookup for GetMod() 
Allows using keys that aren't directly std::string as the key. This lets
us use std::string_view for the incoming path name, making it more
flexible with other string types.
 2024-01-31 12:05:17 -05:00
Mai 30fdf25f8f Merge pull request #12542 from AdmiralCurtiss/system-sconfig 
Migrate m_is_mios and bWii from SConfig to System.
 2024-01-31 09:57:17 -05:00
Mai e0828815e7 Merge pull request #12540 from mitaclaw/encode-reg-to-64 
Add Missing EncodeRegTo64 in JitArm64::dcbx
 2024-01-30 13:08:03 -05:00
Mai a553308775 Merge pull request #12443 from iwubcode/custom_pipeline_action_material_cubemap 
VideoCommon: update custom pipeline action to support a variety of texture samplers, support for materials, and more!
 2024-01-26 12:39:37 -05:00
Lioncash 7a59ecc39d GraphicsTarget: Reduce object churn a little 2024-01-24 23:00:01 -05:00
Lioncash 1b7da37114 GraphicsTargetGroup: Reduce object churn a little 2024-01-24 22:52:58 -05:00
Lioncash 24f952c12b GraphicsModFeature: Reduce object churn a little 2024-01-24 22:48:53 -05:00
Lioncash 0385b40bd8 GraphicsModAsset: Reduce object churn a little 2024-01-24 22:47:22 -05:00
Lioncash 2253d9a95d GraphicsModGroup: Mark move constructor and assignment as noexcept 
Allows containers to optimize off of std::move_if_noexcept
 2024-01-24 22:41:30 -05:00
Lioncash 0327b11e0b GraphicsModGroup: Reduce object churn 
We can emplace and move to avoid doing object copies.
 2024-01-24 22:40:05 -05:00
Lioncash e3e20df185 GraphicsMod: Avoid some object churn 
We have quite a bit of allocation churn going on here, so we can emplace
and move where appropriate to alleviate that a little.
 2024-01-24 22:34:50 -05:00
Lioncash 7b6463ef1f ShaderAsset: Emplace value instances when possible in ToJson() 
Constructs elements directly inside the container and also makes it
shorter to read in certain instances.
 2024-01-24 18:47:44 -05:00
Mai 97160ddc83 Merge pull request #12531 from LillyJadeKatrin/retroachievements-bugfix 
Add host URL setting to achievements config
 2024-01-24 16:17:17 -05:00
Lioncash a65aaccd59 DolphinQt/MenuBar: Hide assembler option if debug UI is disabled 
Fixes a little visual inconsistency in the UI, where the assembler would
always be shown, but all other debug-related utilities would be hidden.
 2024-01-23 18:57:23 -05:00
Lioncash 100242a380 GekkoSyntaxHighlight: Collapse cases for builtin color formats 
Same behavior, but without as much duplication.
 2024-01-23 18:39:59 -05:00
Lioncash e4fa5614d1 GekkoSyntaxHighlight: Fix FPR terminal highlighting being treated as GPRs 
Copy-paste error. Ultimately GPR and FPRs use the same highlighting
style anyway, so this is mostly just a correctness change.
 2024-01-23 18:38:06 -05:00
Lioncash 6cb3389696 CodeTrace: Use std::set::lower_bound() over std::lower_bound() 
std::set's lower_bound() is optimized better than the generic
implementation of std::lower_bound()

std::lower_bound() works best on random access iterators, where the
number of comparisons can be logarithmic. However, since std::set's
iterators are bidirectional iterators, the comparisons will actually be
linear in practice when using std::lower_bound().

So, we can use std::set's version which is guaranteed to be logarithmic.
 2024-01-23 17:21:22 -05:00
Lioncash 258161bab7 DolphinAnalytics: Use #ifdef instead of #if for platform testing 2024-01-23 16:51:31 -05:00
Lioncash 4ccc5178a6 PowerPC: Use #ifdef instead of #if for platform testing 
This way we don't assume these symbols are always defined.
 2024-01-23 16:47:43 -05:00
Lioncash f695ae5730 JitInterface: Use #ifdef instead of #if for platform testing 
\#if assumes the symbols will always be defined, but they aren't
depending on the platform.
 2024-01-23 16:42:36 -05:00
Lioncash a9f89a7d3b WiimoteEmu: check for __APPLE__ with defined() 
This is only defined on certain platforms and isn't always defined.
 2024-01-23 16:40:21 -05:00
Lioncash 3c64d030c5 FreeLookManager: check for __APPLE__ with defined() 
Previously this was treating the identifier as if it were always defined
by default
 2024-01-23 16:40:10 -05:00
Lioncash b06e1880b6 Jit64AsmCommon: Remove redundant m_jit member from CommonAsmRoutines 
We pass a JIT instance all the way down to EmuCodeBlock, which is
accessible under protected as well, so this isn't really necessary.
 2024-01-23 16:27:02 -05:00
Lioncash adb79d4e32 WiimoteReal: Explicitly break instead of fallthrough in IsBalanceBoard() 
Same behavior, no compiler warnings.
 2024-01-23 16:22:10 -05:00
Lioncash 28e93827db EXI_DeviceAGP: Annotate fallthrough with [[fallthrough]] 
Same behavior, but eleminates compiler warnings.
 2024-01-23 16:19:23 -05:00
Lioncash 7ef0262f8a PPCAnalyst: Merge duplicate expression in ReorderInstructionsCore() 
The type checking is duplicated here, which makes this seem a little
weird, so we can get rid of it.
 2024-01-23 16:08:24 -05:00
Lioncash 6a86b35e88 State: Make use of re-entrant variant of localtime 
Makes this member function thread-safe. We can also unify the string
handling to make it easier to maintain.
 2024-01-23 15:28:30 -05:00
Lioncash 1b3f61041a Movie: Remove global system accessor from GetRTCDisplay() 
We can just use m_system instance reference instead.
 2024-01-23 15:15:13 -05:00
Lioncash 763562357b Movie: Mark getters as const 
These don't modify internal member state.
 2024-01-23 15:15:13 -05:00
Lioncash c0b0023b64 Movie: Use re-entrant variant of gmtime in GetRTCDisplay() 
Makes this member function thread-safe.
 2024-01-23 15:15:10 -05:00
Lioncash f03da37693 NetKDTime: Use re-entrant variants of gmtime 
Makes these implementations more thread-safe by design. These likely
won't be run on any other thread, but we may as well just use the
re-entrant variant if it's available.
 2024-01-23 14:30:44 -05:00
Mai 0b1087e9c9 Merge pull request #12520 from iwubcode/material_serialize_to_json 
VideoCommon: add function to serialize MaterialAsset to json
 2024-01-23 14:18:25 -05:00
Lioncash 5aeadb1ef8 PostProcessing: Don't potentially leak memory in BlitFromTexture() 
All release() does is relinquish the pointer, rather than free the
memory associated with it.
 2024-01-23 13:34:40 -05:00
Lioncash a3f9f2c7aa PostProcessing: Remove unnecessary get() calls in BlitFromTexture() 
We can just use operator-> instead.
 2024-01-23 13:34:16 -05:00
Mai e12933f8dd Merge pull request #12515 from iwubcode/shader_asset_helper_functions 
VideoCommon: add some helper functions for shader asset
 2024-01-23 13:21:00 -05:00
Lioncash 49eadbb824 AchievementSettings: Move pragma once out of ifdef 
Makes the header a little more consistent with others (and also we
should still have a header guard be present at all times).
 2024-01-23 11:56:50 -05:00
Lioncash 9f82efa3e2 Jit64/JitRegCache: Simplify GetAllocationOrder() 
Given we have fixed allocation orders, we can just directly return a
span instead of a pointer and a size via an out parameter.

Makes it a little more convenient, since we get both pieces of info at
once, and also have the ability to iterate directly off the span out of
the box.
 2024-01-23 11:03:59 -05:00
Mai 713572e874 Merge pull request #12510 from JosJuice/android-revert-attach-early 
Revert "Android: Attach CPU thread to JVM early"
 2024-01-21 10:23:15 -05:00
Mai d64705d691 Merge pull request #12512 from JosJuice/assembler-dirty-flag 
DolphinQt: Rework dirty flag handling in AssemblerWidget::TabTextForEditor
 2024-01-21 10:22:46 -05:00
Mai 6aacbc4c35 Merge pull request #12488 from JosJuice/jitarm64-psq-stxx-w0 
JitArm64: Remove unnecessary locking of W0 in psq_stXX
 2024-01-15 15:14:59 -05:00
Mai 5534f510e0 Merge pull request #12498 from AdmiralCurtiss/globals-socket 
Core/IOS/Network/Socket: Avoid global system accessor.
 2024-01-15 15:13:41 -05:00
Mai e3d39fcc0d Merge pull request #12502 from AdmiralCurtiss/globals-movie 
Core/Movie: Refactor to class, move to System.
 2024-01-15 15:12:00 -05:00
Mai c76dee7807 Merge pull request #12285 from iwubcode/serialize_graphics_mods 
VideoCommon: add ability to serialize graphics mod to json object
 2024-01-13 14:15:14 -05:00
Mai 8760aca8ec Merge pull request #12500 from AdmiralCurtiss/globals-fiforecorder 
FifoRecorder: Move instance to System.
 2024-01-13 06:38:39 -05:00
Mai d36baf633c Merge pull request #12499 from AdmiralCurtiss/globals-mmiorw 
Core/HW/MMIO: Pass System through Read() and Write().
 2024-01-13 06:37:49 -05:00
Mai 35a326a1e1 Merge pull request #12497 from AdmiralCurtiss/globals-fifoplayer 
Core/FifoPlayer: Avoid global System accessor.
 2024-01-13 06:36:46 -05:00
Mai 6725c25600 Merge pull request #12494 from AdmiralCurtiss/globals-wiiipc 
Core/IOS/WiiIPC: Refactor to class, move to System.
 2024-01-12 02:08:00 -05:00
Mai ab3655fbea Merge pull request #12496 from AdmiralCurtiss/globals-gba 
Core/HW/GBACore: Avoid global System accessor.
 2024-01-12 02:05:57 -05:00
Lioncash 409d2ecad3 SI_Device: Remove global system accessors 
We can pass the system timer instance through to avoid needing the
global accessor.
 2024-01-08 11:03:26 -05:00
Lioncash 7398d0b6ef SI_DeviceGBAEmu: Remove global system accessors 
We can pass the system timer instance in from the existing system
instance instead of the global accessor.
 2024-01-08 10:56:41 -05:00
Lioncash c2adc3ffed Externals: Update fmt to 10.2.1 
Keeps the tracked external up to date.
 2024-01-08 10:45:07 -05:00
Mai 63453bda4d Merge pull request #12485 from AdmiralCurtiss/globals-dsp 
Core/DSPHLE: Clean up global System access.
 2024-01-08 04:48:30 -05:00
Mai 00fb709c74 Merge pull request #12487 from AdmiralCurtiss/globals-axaccel 
Core/DSPHLE: Deglobalize HLEAccelerator state in AX and AXWii UCodes.
 2024-01-08 04:17:30 -05:00
Mai 180d053ec1 Merge pull request #12486 from AdmiralCurtiss/globals-aesndaccel 
Core/DSPHLE: Move AESndAccelerator instance into AESndUCode.
 2024-01-07 20:36:01 -05:00
Mai 8a9d168775 Merge pull request #12477 from JosJuice/r8a-efb2tex 
GameSettings: Don't force EFB to RAM for PokéPark Wii
 2024-01-06 20:10:17 -05:00
Mai 79c7fa4d87 Merge pull request #12476 from PatrickFerry/gameini_disable_immediate_xfb 
Gameini: Disable "Immediately Present XFB" for Racquet Sports
 2024-01-06 20:09:54 -05:00
Mai 6fc278b288 Merge pull request #12483 from AdmiralCurtiss/system-fifoplayer 
FifoPlayer: Move instance to System.
 2024-01-05 23:34:02 -05:00
Mai 2f7f7afe6d Merge pull request #12468 from JosJuice/android-targets-fixes 
Android: Fix the targets line in build.gradle.kts
 2024-01-05 01:55:11 -05:00
Mai feb7207a4c Merge pull request #12482 from AdmiralCurtiss/globals-coreinit 
Core: Pass System through more of the emulation thread init process.
 2024-01-05 01:53:11 -05:00
Mai bfb417fa98 Merge pull request #12481 from AdmiralCurtiss/globals-systemtimers 
Core/SystemTimers: Refactor to class, move to System.
 2024-01-05 01:50:29 -05:00
Lioncache a23cf2121d VideoCommon/PixelEngine: Generify lock guards 
We don't need to specify the type of the mutex being passed in.
 2023-12-22 14:19:29 -05:00
Lioncache 0505f057ca VideoCommon/PixelEngine: Remove global system accessor in UpdateInterrupts() 
Now that the system instance is passed through, this is no longer necessary.
 2023-12-22 14:19:29 -05:00
Lioncache e539dbba4c VideoCommon/PixelEngine: Passthrough system instance in constructor 
Simplifies the interface in terms of usage
 2023-12-22 14:19:26 -05:00
Mai b1438c224f Merge pull request #12439 from lioncash/sprintf 
Core: Use fmt over sprintf in trivial cases
 2023-12-21 17:17:21 -05:00
Mai 6c2da5229e Merge pull request #12458 from JosJuice/jitarm64-logic-i2r-not-nothing 
JitArm64: Fix the "do nothing" cases of ANDI2R and friends
 2023-12-21 17:13:20 -05:00
Mai f7b655e5da Merge pull request #12456 from iwubcode/android_reduce_pixel_samplers_to_8 
VideoCommon: revert max pixel samplers back to 8 for Android
 2023-12-21 10:35:48 -05:00
Lioncache f97b2d472a VideoCommon/CommandProcessor: Pass system instance through constructor 
Makes the use of the interface a little less noisy, especially given
how much of the interface depends on an instance being present.
 2023-12-20 09:02:53 -05:00
Lioncache b0d244b772 VideoCommon/Fifo: Pass system instance through FifoManager constructor 
Given how many member functions make use of the system instance,
it's likely just better to pass the system instance in on construction.

Makes the interface a little less noisy to use.
 2023-12-18 22:03:25 -05:00
Lioncache dec53848f5 CheatSearch: Get rid of global system accessors 
We can retrieve the system via the CPUThreadGuard instances.
 2023-12-18 19:24:35 -05:00
Lioncache 00f494307f UICommon: Remove global system accessor in TriggerSTMPowerEvent() 
This can be passed through via the IOS instance.
 2023-12-18 19:17:16 -05:00
Lioncache c0b7e9cd94 Core/HLE/HLE: Remove global system accessor from ExecuteFromJIT() 
We can just pass in our system instance via the ABI function helpers.
 2023-12-18 19:11:52 -05:00
Lioncache f4277a901a Core/HLE/HLE: Remove global system accessors 
We can get rid of the global system accessors by requiring passing in
relevant state that the function needs and making callsites do the work.

This *does* add a global accessor to the PPCAnalyzer, however, this already
has global accessors present elsewhere within its code, so they can be removed
all at once in a follow up change.
 2023-12-18 19:11:49 -05:00
Lioncache f1b18d8ae3 Core/IOS/ES: Remove global system accessor in InitializeEmulationState() 
We can pass the core timing instance into the function.
 2023-12-18 19:06:45 -05:00
Lioncache ca5695aef2 Core/Debugger/PPCDebugInterface: Remove global system accessor 
We can use the CPUThreadGuard instance to get the active system instance.
 2023-12-18 16:57:50 -05:00
Lioncache 3802c7bf11 Core/PatchEngine: Get rid of global system accessors 
We can pass the system instance into ApplyFramePatches() instead,
especially considering the patch engine callback already has it
available.
 2023-12-18 16:48:25 -05:00
Lioncache cea58759d9 Core/GeckoCode: unsigned int -> u32 
Same thing for all intents and purposes, less to read.
 2023-12-18 16:39:04 -05:00
Lioncache bb866248cf Core/GeckoCode: Avoid signed conversion in RunCodeHandler() 
i is being used alongside unsigned types, so it should be unsigned as well.
 2023-12-18 16:38:41 -05:00
Lioncache 1ceaa8c52a Core/GeckoCode: Remove global system accessor 
We can use the CPUThreadGuard instance to retrieve the system instance instead.
 2023-12-18 16:35:52 -05:00
Lioncache 472c65ed35 Core/Debugger_SymbolMap: Make GetCallstack() less verbose 
This also allows the constructed CallstackEntry instances to be moved into
the output vector, rather than being copied.
 2023-12-18 15:46:32 -05:00
Lioncache 75ec350dc4 Core/Debugger_SymbolMap: Remove redundant system parameters from interface 
The CPU thread guard already allows access to the system instance. We can
remove the system parameter to reduce rendundancy here.
 2023-12-18 15:46:22 -05:00
Lioncache 514b3e6f55 Core/Debugger_SymbolMap: Remove AddAutoBreakpoints() 
This is wholly unused in current code.
 2023-12-18 15:24:58 -05:00
Lioncache 04300114f7 Core/HLE/HLE_OS: Mark helpers as static where applicable 
Previously, these were given external linkage when they're only used within
this translation unit.
 2023-12-18 13:44:55 -05:00
Lioncache c4df659e21 HLE_OS: Get rid of global system accessors 
Thread guards provide access to the current active system instance.
 2023-12-18 13:39:53 -05:00
Lioncache c3c39de212 HLE_Misc: Get rid of global system accessors 
Thread guards provide access to the current active system instance.
 2023-12-18 13:33:07 -05:00
Lioncache affe928987 Common/TraversalServer: Make use of fmt more 
We can convert printf and fprintf over to the use of fmt as well,
given that we've converted the sprintf calls over.
 2023-12-18 13:08:57 -05:00
Lioncache dc85194fac Common/TraversalServer: Make use of fmt over sprintf where applicable 
Resolves some deprecation warnings on macOS. This is better anyway, given fmt
has generic type formatting.
 2023-12-18 13:08:57 -05:00
Lioncache 1764b13423 Core/DSP/DSPTables: Make pdregname() and pdregnamelong() return std::string 
Keeps the interface consistent.
 2023-12-18 13:08:57 -05:00
Lioncache 62740d97a8 Core/DSP/DSPTables: Make use of fmt::format in pdname() 
Resolves a deprecation warning on macOS. Also, we can convert
the function to just return a std::string instead of using a
static internal buffer, which is gross and thread-unsafe.
 2023-12-18 13:08:57 -05:00
Lioncache 9abcc1c08b Core/NetPlayServer: Use fmt::format_to_n in GetInterfaceHost() 
Lets us avoid some noisy deprecation warnings on macOS (and also lets us use
a more generic formatting specifier).
 2023-12-18 13:08:57 -05:00
Lioncache 2b877fc92b Core/IOS/Top: Make use of fmt::format_to_n where applicable 
Same behavior, but avoids deprecation warnings on macOS builds and also lets us
use generic print formatting.
 2023-12-18 13:08:57 -05:00
Lioncache 04822d5a2c Core/IOS/ES: Make use of fmt::format where applicable 
Eliminates a deprecation warnings on macOS. While we're in the
same area, we can remove the call to GetPointer() and instead
use CopyToEmu() to copy the string data back to the emulated memory.
 2023-12-18 13:05:04 -05:00
Lioncache e6db08e03a Core/IOS/IOS: Remove global system accessor from Init() 
Removes the final global system accessor from the main IOS code by
passing the system instance through it.
 2023-12-18 12:28:21 -05:00