Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
27,261 Commits 1 Branch 0 Tags
1e0f72f2dacf30b907d9179efaf81844d5f5cf94
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash de0ed1a5fb Interpreter_LoadStore: Update the DAR if a DSI exception occurs in eciwx and ecowx 
Also once a DSI exception occurs, execution is supposed to leave the
instruction immediately. It doesn't finish execution.
 2018-04-02 08:34:32 -04:00
Lioncash a013638dcb Interpreter_LoadStore: Properly update the DAR whenever an alignment exception occurs within eciwx and ecowx 
These should be updating the DAR when an alignment exception occurs,
just like every other instruction that can cause an alignment exception.
 2018-04-02 08:34:32 -04:00
Lioncash c1b78106e7 Interpreter_LoadStore: Flag alignment exceptions on misaligned addresses in lwarx, lmw, stmw, and stwcx 
The effective address given to these instructions must be word (4 byte) aligned,
and if the address is not aligned like that, then an alignment exception
gets triggered.

We currently don't update the DSISR in this case properly, since we
didn't really handle alignment exceptions outside of ecowx and eciwx,
and even then the handling of it isn't really that great, considering
the DAR isn't updated with the address that caused the exception to
occur.

The DSISR will eventually be amended to be properly updated.
 2018-04-02 08:34:26 -04:00
Lioncash 22be923b91 CMakeLists: Remove add_dolphin_library macro 
With all library targets migrated off add_dolphin_library, we can finally remove it
 2018-04-02 08:31:56 -04:00
Lioncash b184923540 Vulkan/CMakeLists: Migrate off add_dolphin_library 
Finishes the migration work started in 3a4c3bbe01
 2018-04-02 08:29:37 -04:00
Lioncash 8b43a31855 Software/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:24:40 -04:00
Lioncash a3c53ff754 OGL/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:22:39 -04:00
Lioncash d4f8502ad1 Null/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:17:00 -04:00
Lioncash 3854e2bcca D3D/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:15:22 -04:00
Lioncash 672665dec0 AsyncRequests: In-class initialize class members 
Prior to this change, it's possible for m_wake_me_up_again to be used
while it's in an uninitialized state from the exposed API.

e.g.

- Using SetEnable after construction would perform an uninitialized read.
- Using PushEvent would perform an uninitialized read by way of operator |=.

internally, an uninitialized read can happen if PullEventsInternal() is
executed before other functions.

Just to avoid the whole possibility of performing uninitialized reads,
we just give the class member a default value of false.
 2018-04-01 19:06:43 -04:00
Lioncash fd9eab73fb CPUDetect: Make CPUVendor enum an enum class 
Avoids dumping the enum contents into the global namespace.
 2018-04-01 17:47:50 -04:00
Lioncash 0f6c3c7b35 Jit64/JitRegCache: Make member functions const qualified where applicable 
None of these member functions modify class state.

Also makes the parameter name for ScoreRegister's implementation
consistent with its declaration.
 2018-04-01 16:53:00 -04:00
Lioncash 6cfa9fda6b DSPJitRegCache: Make FindFreeReg() a const member function 
This member function doesn't modify class state.
 2018-04-01 16:01:25 -04:00
Lioncash fe9d989765 DSPJitRegCache: Remove unnecessary casts in FlushRegs() 
We can just use the proper printf specifiers instead.
 2018-04-01 15:49:21 -04:00
Lioncash ad17d9a979 IOS/Socket: Delete WiiSocket's copy constructor 
If the copy assignment operator is deleted, then the copy constructor
should be deleted as well, otherwise it's a hole in the API where copies
can be made (and if this were an intended case, it should be
documented).

So we delete the copy constructor and explicitly default the move
assignment and move constructor to signify this is intended to be a
move-only type.
 2018-04-01 15:38:37 -04:00
Lioncash ad575a1556 IOS/Socket: Place WiiSocket's private interface below the public interface 
In the rest of the codebase we try to position the private interface
below the public interface (unless it's otherwise not possible).
 2018-04-01 15:38:33 -04:00
Lioncash abb33637a3 IOS/Socket: In-class initialize WiiSocket members 2018-04-01 15:27:58 -04:00
Lioncash 8fbd6e2a87 EXI_DeviceMemoryCard: Get rid of magic number in SetCS() 
Keeps the code consistent with other usages of the same constant
 2018-04-01 15:21:20 -04:00
Mat M d8dd7b9e66 Merge pull request #6533 from spycrab/qt_desc_box 
Qt/GraphicsWindow: Decrease description box size
 2018-04-01 14:06:50 -04:00
Lioncash 8db4ab7dd6 CMakeLists: Remove iconv from the LIBS variable 
Adjusts Common to use the ICONV_LIBRARIES variable directly and doesn't
append it to the LIBS variable.

After this, there's only one remaining usage where libraries are added
to the LIBS variable, after which it can be removed once the rest of
the targets are migrated off add_dolphin_library
 2018-04-01 14:00:55 -04:00
Lioncash 677b9b717f CMakeLists: Remove enet from the LIBS variable 
All libraries that use enet already link it in explicitly. This reduces
the usages of the LIBS variable.
 2018-04-01 11:18:08 -04:00
Lioncash a4420d6d94 Jit64: Make CheckMergedBranch() a const member function 
This function doesn't modify class state.
 2018-03-31 20:12:53 -04:00
Lioncash 136f16599f UnitTests: Add basic tests for RotateRight() and RotateLeft() 2018-03-31 18:09:50 -04:00
Lioncash c3483a1823 CommonFuncs: Generify rotation functions and move them to BitUtils.h 
These are bit manipulation functions, so they belong within BitUtils.

This also gets rid of duplicated code and avoids relying on compiler
reserved names existing or not existing to determine whether or not we
define a set of functions.

Optimizers are smart enough in GCC and clang to transform the code to a
ROR or ROL instruction in the respective functions.
 2018-03-31 18:09:45 -04:00
Lioncash eee32c030b CMakeLists: Remove lzo from the LIBS variable and make linkage private 
The only place this library is needed (core) is already linked in the core target.
Also make the linkage private to create linkage failures if the dependency isn't
explicitly linked in elsewhere where it should be.

Reduces the dependency on the LIBS variable.
 2018-03-31 15:01:05 -04:00
Mat M 76e1a5b892 Merge pull request #6569 from JosJuice/kill-emu-state 
Remove EmuState
 2018-03-31 14:04:30 -04:00
Mat M a6f1c6e2e9 Merge pull request #6568 from leoetlino/dead 
Remove dead code
 2018-03-31 14:02:40 -04:00
Lioncash e93159e54a CMakeLists: Link in system framework libraries explicitly on macOS 
Makes our libraries explicitly link in which libraries they need.
This makes our dependencies explicit and removes the reliance on the
LIBS variable to contain the libraries that they need.
 2018-03-30 16:14:10 -04:00
Mat M c3398c9e2c Merge pull request #6559 from spycrab/qt_crashes 
Qt/PatchesWidget: Fix segfault
 2018-03-29 18:51:22 -04:00
Mat M fc99b21080 Merge pull request #6560 from JosJuice/invalid-games-in-game-list 
DolphinQt2: Don't show invalid games in game list
 2018-03-29 18:49:38 -04:00
Mat M 65a1065cde Merge pull request #6561 from JosJuice/uid-version-last-changed 
Put a "last changed in PR" comment next to UID cache version
 2018-03-29 18:48:12 -04:00
Mat M 8185b5f1fd Merge pull request #6562 from JosJuice/translate-qos 
Translate the netplay chat info message about QoS
 2018-03-29 18:47:29 -04:00
Lioncash b8a4ab23dd InputCommon/CMakeLists: Link in ForceFeedback library explicitly on macOS 
Makes an implicit dependency explicit. Also makes the macOS libraries link privately
as they aren't used in the exposed interface.
 2018-03-29 11:53:50 -04:00
Lioncash b818cc682c VideoCommon/Vulkan: Explicitly link in xxhash 
Lessens the dependency on the LIBS variable (and also makes the required
libraries explicit).
 2018-03-28 17:03:16 -04:00
Lioncash fd7ac0d4a3 VideoCommon/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-03-28 09:57:50 -04:00
Lioncash a2a18380a7 UICommon/CMakeLists: Migrate off of add_dolphin_library 
Continues the migration work started in
3a4c3bbe01
 2018-03-28 06:29:09 -04:00
Lioncash df4ca7f05e SearchBar: Remove unused class variables 2018-03-27 22:47:02 -04:00
Lioncash 306d132232 MainWindow: Remove unused std::string variable in NetPlayHost() 2018-03-27 22:47:02 -04:00
Lioncash 833c030496 WiiPane: Remove unused variable in OnUSBWhitelistRemoveButton() 2018-03-27 22:47:01 -04:00
Lioncash eb8a853d8e Resources: Remove unused string in Init() 2018-03-27 22:47:01 -04:00
Lioncash 568490fdfb MD5Dialog: Call .empty() instead of testing against an empty string 2018-03-27 22:47:01 -04:00
Lioncash d3283a881f MenuBar: Remove unnecessary c_str() call 
Also uses the character overload for find_last_of
 2018-03-27 22:47:01 -04:00
Lioncash b637163704 CodeWidget: Remove unnecessary c_str() calls 2018-03-27 22:46:51 -04:00
Lioncash 4a1123f519 HacksWidget: Remove duplicate AddDescription() call in AddDescriptions() 2018-03-27 22:36:37 -04:00
Lioncash aa42534fed FilesystemWidget: Pass path QString by const reference instead of by value in ExtractDirectory() 
Makes it consistent with the surrounding API.

Also corrects a typo in ExtractFile's parameter list.
 2018-03-27 22:00:40 -04:00
Lioncash fc531993a9 DiscExtractor: Pass partition by reference rather than by value in ExtractDirectory() 2018-03-27 21:49:42 -04:00
Lioncash 008442898c LinearDiskCache: Don't cast away const in Read() 
We really shouldn't make the out pointer in the read function const and
then summarily cast it away. Also alters Write to be consistent with
casting.
 2018-03-27 21:09:18 -04:00
Lioncash f10198500e PixelShaderGen: Invert conditional in WriteColor() 
Puts the true condition body first instead of the false one for better
reading.
 2018-03-27 18:53:17 -04:00
Lioncash c9e0045881 PixelShaderGen: Remove dead code in WriteColor() 
The outer conditional executes only whenever destination alpha is used.
 2018-03-27 18:46:25 -04:00
Lioncash 2da8d98b2f HiresTextures: Use std::minmax or std::minmax_element where applicable in GenBaseName() 
Minimizes repetition.

std::minmax_element can be used for the 256 * 2 case, as it's only performing byte comparisons
and thus, there will always be an element smaller than 0xffff, so it doesn't need to be included
in the set of compared values.
 2018-03-27 15:39:05 -04:00
Lioncash d5a1edba09 HiresTextures: Remove unnecessary pointer casts in GenBaseName() 
swap16 has an overload that accepts a u8*, performing the same behavior
in a well-defined manner.
 2018-03-27 15:19:02 -04:00
Lioncash 9feb18866b BPStructs: Remove an unnecessary pointer cast in GetBPRegInfo 
swap32 has an overload that accepts a u8*, performing the same behavior
in a well-defined manner.
 2018-03-27 12:04:16 -04:00
Lioncash 476c71efc1 x64Emitter: Make eligible register and immediate functions constexpr 
Pointer variants aren't eligible as expressions with reinterpret cast
within them cannot be constexpr.
 2018-03-26 18:21:22 -04:00
Lioncash 8b072e1383 x64Emitter: Make remaining eligible functions in OpArg constexpr 2018-03-26 18:21:21 -04:00
Lioncash 964201f2d3 x64Emitter: Use std::tie in OpArg's operator==. Provide operator!= for symmetry 2018-03-26 18:21:21 -04:00
Lioncash 7f583b66cb x64Emitter: Clean up constructors for OpArg 
Default initializes members and moves initial assignments into the
initializer list.
 2018-03-26 18:21:17 -04:00
Lioncash 4a4538abbf Interpreter_LoadStore: Amend variable naming 
Amends variable names to follow our code style. Also makes code const correct where possible.
 2018-03-26 07:47:50 -04:00
Lioncash 1519e4dbb3 DSPEmitter: Remove uses of the DSP JIT global in CompileCurrent() 
With this, the DSPEmitter itself no longer makes use of the DSP JIT global
 2018-03-26 01:14:17 -04:00
Lioncash 8b29997ed1 Interpreter: Remove an unnecessary UReg_MSR& cast from SingleStepInner 
This is technically undefined behavior, but regardless of that, it's not
even necessary since we can just make a temporary around the MSR value
and just discard it when done with it, since all we do is query the FP
bit value with it.
 2018-03-25 21:36:39 -04:00
Lioncash b0efcdc8ef Interpreter: Get rid of static state within SingleStepInner() 
Given how the hooking operates, we may not execute an instruction.
Instead of making the state a static local to the function, just make it
part of the lifecycle of the Interpreter class.
 2018-03-25 21:30:00 -04:00
Lioncash c4a597171c MMU: Make XCheckTLBFlag an enum class 2018-03-25 19:51:47 -04:00
Lioncash 9967c24f5d MMU: Make TLBLookupResult an enum class 2018-03-25 19:44:14 -04:00
Lioncash 0f25627614 DSPCodeUtil: Don't return data via an out parameter 
We can just return directly in these cases.
 2018-03-25 18:55:08 -04:00
Lioncash e42db3594b DSPAssembler: Make error code enum an enum class 
Prevents the error codes from littering the surrounding scope.
 2018-03-25 18:19:08 -04:00
Lioncash 8c421ffbb7 DSPTables: Remove opc_t typedef 
This was only ever used by the DSP assembler, and even then it was
sparsely used. Get rid of it to be consistent with types in other
sections of the DSP code.
 2018-03-25 17:53:23 -04:00
Lioncash 2861e8f868 x64Emitter: Clean up constructor and destructors of XEmitter 
In-class initializes members, defaults the default constructor and
virtual destructor, and puts members in the initializer list.
 2018-03-25 16:50:02 -04:00
Lioncash 7bd41a3b55 Jit64/Jit_Integer: Remove dead code in arithXex() 
The conditional this code is within already checks whether d == b, so this
conditional will never be true.
 2018-03-25 15:35:02 -04:00
Lioncash efcdb3debb JitArm64/JitAsm: Remove usages of the JIT global 
With this, the entire ARM JIT makes no use of the JIT global whatsoever.
 2018-03-25 15:23:49 -04:00
Lioncash a45631c4ca Interpreter_LoadStore: Remove unnecessary casts 
These aren't necessary as the type being stored into a u32 are of the
same signedness and are smaller in data size, so there's no truncation
being performed.
 2018-03-25 15:09:32 -04:00
Lioncash 48e2e9a41d CachedInterpreter: Use using aliases instead of typedef 2018-03-25 02:57:25 -04:00
Lioncash 9829083241 CachedInterpreter: Use an enum class for instruction type 2018-03-25 02:57:16 -04:00
Lioncash 89df65aa25 Interpreter_Integer: Correct precedence of overflow check in nego 
The overflow check needs to occur before the condition register update
due to the fact that the summary overflow (SO) bit is used in the
updating of the condition register. If we set any overflow bits after
updating the CR, then we can potentially incorrectly report that an
overflow did not happen (in the case the SO bit wasn't set previously).
 2018-03-24 20:48:05 -04:00
Lioncash 96014e74a3 Interpreter_Paired: Don't dump the entire MathUtils namespace into scope 
Functions from the namespace are only used four times within the entire
file.
 2018-03-24 19:42:14 -04:00
Lioncash 46f61a48c7 Interpreter_FloatingPoint: Don't dump the entire MathUtils namespace into scope 
Given functions from the MathUtils namespace are only used six times in
the whole file, dumping the namespace seems a little excessive.
 2018-03-24 19:40:22 -04:00
Lioncash 27611d55ff Interpreter_FPUtils: Get rid of a pointer cast 
This is undefined behavior according to the standard. We can just use
the built in means of retrieving a quiet NaN.
 2018-03-24 19:33:44 -04:00
Lioncash 8a7abd72b4 PPCTables: Remove prefixed underscores from parameter names 2018-03-24 16:46:49 -04:00
Lioncash 2381aeecc3 PPCTables: Namespace all exposed functions 
It's somewhat inconsistent to have two straggler functions outside the
namespace.
 2018-03-24 16:46:12 -04:00
Lioncash 397b3fb976 CPUCoreBase: Make the GetName() member function const qualified 
This function should have no need to modify internal class state.
 2018-03-24 16:17:39 -04:00
Lioncash c738ddc4aa CPUCoreBase: Default the virtual destructor 2018-03-24 16:09:19 -04:00
Lioncash ef6e747a68 PowerPC: Remove commented out PanicAlert 2018-03-24 14:52:22 -04:00
Lioncash 3dc3b0caa5 Interpreter_LoadStore: Remove commented out code 
Also removes long separation lines that aren't really necessary.
 2018-03-24 14:49:18 -04:00
Lioncash f9e0645b99 Interpreter_SystemRegisters: Remove commented out code 2018-03-24 14:45:46 -04:00
Lioncash 288b579c09 Interpreter_Integer: Remove commented out code in subfic 2018-03-24 14:43:25 -04:00
Lioncash 01308330d9 InputCommon/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-03-24 14:13:53 -04:00
Lioncash 680ceb7f43 DiscIO/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-03-24 13:54:06 -04:00
Mat M 5669841e83 Merge pull request #6505 from lioncash/arm 
Arm64Emitter: Minor cleanup
 2018-03-23 19:25:50 -04:00
Lioncash f889cae8c4 Arm64Emitter: Satisfy unrelated linter issues that cropped up by modifying the cpp file 2018-03-23 19:17:44 -04:00
Lioncash 91cefe6c8a Arm64Emitter: Make IsImmArithmetic, IsImmLogical, FPImm8ToFloat, and FPImm8FromFloat internally linked 
These aren't used anywhere outside of the emitter. Centralizes them under an anonymous namespace.
 2018-03-23 19:17:26 -04:00
Lioncash 2548ccda8e Common/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work that was started in 3a4c3bbe01
 2018-03-23 19:08:30 -04:00
Lioncash b11c237c43 Arm64Emitter: Remove unnecessary V8_UINT64_C preprocessor macro 
UINT64_C is provided via <cstdint>, so we can just use that instead.
 2018-03-23 13:31:48 -04:00
Lioncash 03671a5534 Arm64Emitter: Remove duplicate IsPowerOf2 function 
We can just use the generified version in MathUtil.
 2018-03-23 13:31:44 -04:00
Lioncash a52cc8d52b PixelShaderGen/UberShaderPixel: Silence -Wmissing-braces warnings 2018-03-23 10:06:27 -04:00
Lioncash 2ab29a40eb AbstractFramebuffer: Silence a -Wlogical-op-parentheses warning in ValidateConfig() 2018-03-23 09:58:19 -04:00
Lioncash 79f40fb8d7 MathUtil: Generify IsPow2 
This will allow it to also be used in the AArch64 emitter.
 2018-03-23 09:50:49 -04:00
Lioncash 38f045cee5 DolphinQt2/GameCubePane: Correct duplicate condition in LoadSettings() 
Also turns a std::string const reference into a value instance.
While this is well-defined, it does look out of place, given a new string
is being created.
 2018-03-23 07:38:26 -04:00
Lioncash fc16a78f6a Jit_Integer: Handle NOP case for xori and xoris 
Like ori and oris, xori and xoris can also be used to introduce a NOP.
In that case, just don't do anything.
 2018-03-22 22:51:43 -04:00
Lioncash 007f9e5309 Jit_Integer: Handle NOP case for oris as well 
Like ori, this can also be used as a NOP under the same conditions.
 2018-03-22 22:49:02 -04:00
Lioncash 42fce74f39 Jit_Integer: Handle NOP case where RA == RS for ori 
ori can be used as a NOP if the two register operands are the same, and
the immediate is zero, not only if the two register operands are r0.

Also removes the check for !inst.Rc, as ori only has one encoding, and
said encoding doesn't even have a record bit in it.
 2018-03-22 22:47:19 -04:00
Lioncash b96bbc8f8d AudioCommon/CMakelists: Migrate off add_dolphin_library 
Continues the changes that were introduced in 3a4c3bbe01
 2018-03-22 22:07:11 -04:00
Mat M 71846a6daa Merge pull request #6469 from lioncash/cmake 
Core/CMakeLists: Migrate off add_dolphin_library
 2018-03-22 21:52:44 -04:00