Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
32,113 Commits 1 Branch 0 Tags
2c843ae06b61066c597804d35b7f3ba2280e8d0f
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Mat M edad018213 Merge pull request #8638 from jordan-woyak/is-detectable-constify 
InputCommon: Constify Device::Input::IsDetectable function.
 2020-02-22 16:50:27 -05:00
Lioncash 91deb40a22 Common: Amend includes to handle the upgrade to fmt 2020-02-04 15:03:51 -05:00
Lioncash aea76c7901 Core: Amend includes to handle the upgrade to fmt 2020-02-04 15:03:48 -05:00
Lioncash abd2897377 VideoCommon: Amend formatting code to handle the upgrade to fmt 
It seems that the newer version of fmt gets tripped up by bitfields
within structs. However, we can just specify the intended type where
necessary to get around this.
 2020-02-04 14:55:20 -05:00
Lioncash 1873b7a398 Externals: Update fmt to 6.1.2 2020-02-04 14:50:46 -05:00
Lioncash 7eaa769527 DolphinQt/GCMemcardManager: Make use of QLatin1Char within GetErrorMessagesForErrorCode() 
Same behavior, but eliminates the use of a program lifetime Qt string
literal.
 2020-01-27 15:59:33 -05:00
Lioncash 585ae8aedf DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode() 
This is a string that can potentially be seen by a user, so it should be
marked as translatable, like the other strings are.
 2020-01-27 15:57:36 -05:00
Lioncash dca201d5f3 DolphinQt/GameConfigWidget: Remove unimplemented EditUserConfig() member function 
This isn't implemented anywhere, so we can remove the member function
prototype.
 2020-01-27 15:46:52 -05:00
Lioncash 2fd628d017 DolphinQt/GameConfigEdit: Remove unimplemented SetReadOnly() member function 
This isn't implemented anywhere, so we can remove this prototype.
 2020-01-27 15:44:52 -05:00
Lioncash c69cbceb59 DolphinQt/MainWindow: Surround prototype of OnSignal() with relevant ifdef 
This is only used on Apple and Unix-like machines, so we can enclose the
prototype with an ifdef like the implementation is. This prevents
false-positives about an unimplemented function prototype.
 2020-01-27 15:26:41 -05:00
Lioncash e8ee4e835e DolphinQt/NetPlayDialog: Remove unimplemented SetGame() prototype 
This isn't implemented anywhere, so the prototype can be removed.
 2020-01-27 15:25:04 -05:00
Lioncash b493bdb912 DolphinQt/TASCheckBox: Mark GetValue() as const 
This doesn't actually modify the checkbox's state, so this can be marked
as a const-qualified member function.
 2020-01-26 21:41:31 -05:00
Lioncash 687f1f0330 VideoCommon/TextureConversionShader: Make use of fmt where applicable 
Now that we've converted the shader generation over to ShaderCode, we
can now make use of the fmt-capable WriteFmt function.
 2020-01-23 14:19:40 -05:00
Lioncash aa77dff3a2 VideoCommon/TextureConversionShader: Convert over to using ShaderCode 
Migrates the shader generator off the use of a global array, eliminating
the use of some global state. This also allows us to move the shader
generation over to using fmt in a subsequent change.
 2020-01-23 14:19:36 -05:00
Mat M eea4e4385e Merge pull request #8528 from CaseyCarter/includes 
Include <memory> for std::unique_ptr in DXContext.h
 2019-12-19 17:29:43 -05:00
Lioncash 7c12081693 PowerPC/PPCAnalyst: Remove unimplemented LogFunctionCall prototype 
This doesn't have an implementation, so it can be removed.
 2019-12-15 00:23:32 -05:00
Lioncash 81edcca8db Common/Network: Use std::nullopt in StringToMacAddress 
Prevents unnecessary zeroing out of std::optional's internal buffer in
some implementations.
 2019-12-06 09:59:11 -05:00
Lioncash cbfacc41ba Common/Network: Remove unused header inclusions 
Removes unused header dependencies.
 2019-12-06 09:51:28 -05:00
Lioncash f06461d208 Common/Network: Make StringToMacAddress use a string_view 
This function only ever reads the contents of the string in a non-owning
manner, so we can change the parameter over to being a string view.
 2019-12-06 09:45:25 -05:00
Lioncash 2c9ec6cb8a VideoCommon/BoundingBox: Move PixelShaderManager::SetBoundingBoxActive() calls into Enable()/Disable() 
Now that we have an actual interface to manage things, we can stop
duplicating the calls to to the pixel shader manager and remove the
need to remember to actually do so when disabling or enabling the
bounding box.
 2019-12-05 11:57:58 -05:00
Lioncash 9bd533ebe4 VideoCommon/BoundingBox: Make interface for querying bounding box data 
Rather than expose the bounding box members directly, we can instead
provide an interface for code to use. This makes it nicer to transition
from global data, as the interface function names are already in
place.
 2019-12-05 11:48:42 -05:00
Lioncash 10f7674651 VideoCommon/IndexGenerator: Eliminate static state 
Now that we've extracted all of the stateless functions that can be
hidden, it's time to make the index generator a regular class with
active data members.

This can just be a member that sits within the vertex manager base
class. By deglobalizing the state of the index generator we also get rid
of the wonky dual-initializing that was going on within the OpenGL
backend.

Since the renderer is always initialized before the vertex manager, we
now only call Init() once throughout the execution lifecycle.
 2019-12-05 10:49:32 -05:00
Lioncash 159947ab68 VideoCommon/IndexGenerator: Make use of if constexpr 
We can use if constexpr with the template functions that pass in a
non-type template parameter, allowing the removal of branches that
aren't taken at compile time.

Compilers will generally do this by default, however, we now give a
gentle prodding to the compiler if this would otherwise not be the case.
 2019-12-05 10:49:32 -05:00
Lioncash fb3fda775f VideoCommon/IndexGenerator: Move stateless functions into anonymous namespace 
These don't rely on any of the static members within the IndexGenerator
class, so we can make all of these functions fully internal to the
translation unit.
 2019-12-05 10:49:29 -05:00
Lioncash 69f2ca2230 VideoCommon/IndexGenerator: Make use of anonymous namespace 
More things will be moved into this in subsequent changes. While we're
at it, we can also make use of std::array.
 2019-12-05 09:36:41 -05:00
Lioncash 1f46a6a64b VideoCommon/OpcodeDecoding: Make use of if constexpr 
We can make use of if constexpr in several scenarios here to allow
compilers to exise the relevant code paths out.

Technically a decent compiler would do this already, but now we can give
compilers a little more nudging here in the event that isn't the case.
 2019-12-05 09:13:06 -05:00
Lioncash 99353c3baa VideoCommon/OpcodeDecoding: Remove unused headers 
Nothing provided by these headers are used, so we can remove them.
 2019-12-05 09:13:06 -05:00
Lioncash 6339a5ea8e VideoCommon/OpcodeDecoding: Resolve implicit signedness conversion 
cmd2 is a u32, so any bitwise arithmetic on it with a type of the same
size or smaller will result in a u32 value. This is also implicitly
converted to an unsigned type in the if statement as well, given that
size_t * int -> size_t.

This is just more explicit about the operations occurring and also
likely silences a sign conversion warning.
 2019-12-05 09:13:06 -05:00
Lioncash 4710b82f43 VideoCommon/OpcodeDecoding: Remove use of goto in Run() 
With the use of a lambda and a change in switch fallthrough, we can
completely eliminate the use of goto within Run().
 2019-12-05 09:13:06 -05:00
Lioncash f74503cce0 VideoCommon/OpcodeDecoding: Make use of anonymous namespace 
Provides a region for all internal utilities.
 2019-12-05 09:13:06 -05:00
Lioncash 6b4e340995 VideoCommon/OpcodeDecoding: Amend comment formatting 
Amends a documentation comment that acquired some wonky formatting
during the introduction of clang-format a few years ago.
 2019-12-05 09:13:06 -05:00
Lioncash b2a9c36501 VideoCommon/OpcodeDecoding: Move g_bRecordFifoData into namespace 
Keeps the global localized with the code that it's primarily related to.

Now it's obvious from a glance what the global variable is affecting.
 2019-12-05 09:13:03 -05:00
Lioncash d8063e9c54 VideoCommon/OpcodeDecoding: Normalize variable naming 
Provides consistent naming of variables within the translation unit.

While we're at it, we can mark them const where applicable.
 2019-12-05 08:05:29 -05:00
Lioncash f29730944f VideoCommon/FramebufferShaderGen: Make use of std::ostringstream internally 
We only use these string streams to output into a final std::string
instance, we don't read into types with them. Because of this, we can
just make use of std::ostringstream, rather than the fully-fledged
std::stringstream.
 2019-12-05 00:18:00 -05:00
Lioncash fff445cc10 VideoCommon/FramebufferShaderGen: Make use of std::string_view where applicable 
Prevents the use of the null pointer as an input to any functions.
 2019-12-05 00:15:37 -05:00
Lioncash 3405815f09 VideoCommon/FramebufferShaderGen: Remove unused Config struct 
This isn't used anywhere within the codebase, so it can be removed
entirely.
 2019-12-04 23:54:15 -05:00
Lioncash 3a8d17c140 VideoCommon/FramebufferShaderGen: Use an anonymous namespace where applicable 
Places all internal helpers and types within an anonymous namespace.
 2019-12-04 23:51:26 -05:00
Lioncash eefd6a10f5 VideoCommon/FramebufferShaderGen: Add missing initial source file comments 
Makes the source files consistent with the rest of the VideoCommon code.
 2019-12-04 23:48:59 -05:00
Lioncash f8c90f0484 VideoCommon/FramebufferShaderGen: Collapse stream insertions 
No behavioral change. This is intended to make the transition to fmt
less noisy in subsequent changes by combining insertions of multiple
string literals into one where applicable.
 2019-12-04 23:45:15 -05:00
Lioncash 0f28f4049b VideoCommon/TextureConverterShaderGen: Convert over to fmt 
Easily the most straightforward to convert over, given the lack of
significant formatting arguments.
 2019-12-03 05:05:02 -05:00
Lioncash 8af6bfb8b0 VideoCommon/ShaderGenCommon: Add function for writing fmt-based strings 
Begins the conversion of the shader generators over to using fmt
formatting specifiers.

This also has a benefit over the older StringFromFormat-based API in
that all formatted data is appended to the existing buffer rather than
creating a completely separate string and then appending it to the
internal string buffer.
 2019-12-03 04:49:48 -05:00
Lioncash 474e210cd5 PPCCache: Make arrays constexpr where applicable 
Two of these arrays were stored within the save state when the exact
same data is constructed all the time.

We can just build this into the binary rather than the save state,
shrinking a little bit of the save state's overall size.
 2019-12-03 04:05:09 -05:00
Lioncash 1d5ce4708f PPCCache: Make use of std::array where applicable 
Allows simplifying a bunch of initialization and filling code.
 2019-12-03 04:05:05 -05:00
Lioncash c792961000 Common: Unify logging namespace with Common 
Previously the logging was a in a little bit of a disarray. Some things
were in namespaces, and other things were not.

Given this code will feature a bit of restructuring during the
transition over to fmt, this is a good time to unify it under a single
namespace and also remove functions and types from the global namespace.

Now, all functions and types are under the Common::Log namespace. The
only outliers being, of course, the preprocessor macros.
 2019-11-28 05:13:21 -05:00
Lioncash e33c366502 GCMemcard: Remove byteswapping macros 
We can just specify the functions directly instead of relying on
preprocessor textual replacement.
 2019-11-27 23:15:31 -05:00
Lioncash 1f1a02151e GCMemcard: Replace ByteSwap with std::swap 
There's already a standard library function that does what this function
is doing.
 2019-11-27 23:15:26 -05:00
Lioncash b28db1d4e6 UICommon: Make use of fmt where applicable 
Continues the migration to using fmt.

Notably, this allows safely converting a map within USBUtils over to
containing string view instances, rather than std::string instances, as
fmt safely handles the formatting of string views.
 2019-11-23 19:41:40 -05:00
Lioncash 6fbbc2683e VideoCommon: Make use of fmt outside of shader generators 
Migrates most of VideoCommon over to using fmt, with the exception being
the shader generator code. The shader generators are quite large and
have more corner cases to deal with in terms of conversion (shaders have
braces in them, so we need to make sure to escape them).

Because of the large amount of code that would need to be converted, the
conversion of VideoCommon will be in two parts:

- This change (which converts over the general case string formatting),
- A follow up change that will specifically deal with converting over
  the shader generators.
 2019-11-23 16:00:45 -05:00
Lioncash 334e2768f5 InputCommon/DualShockUDPClient: Use an alias for the clock type 
Makes code slightly less verbose without exposing the whole chrono
header to the current source file.
 2019-11-22 17:06:10 -05:00
Lioncash db9e592765 InputCommon/DualShockUDPClient: Use deduction guides for lock_guard 
With C++17, we can use template deduction guides provided by the
standard library. This allows the omission of the mutex type itself.
 2019-11-22 17:06:10 -05:00
Lioncash 278d03f737 InputCommon/DualShockUDPClient: Make use of std::array where applicable 
Provides the same semantics of a C array, but is much nicer to work
with.

Notably, it makes all cases of performing comparisons with said arrays
significantly less reading-involved.
 2019-11-22 17:06:07 -05:00
Lioncash 67097b4574 InputCommon/DualShockUDPClient: Relocate settings to top of source file 
This is a small namespace, so we can move it to the top of the file to
get it out of the way of everything else.
 2019-11-22 15:56:29 -05:00
Lioncash 4488719a76 InputCommon/DualShockUDPClient: In-class initialize members where applicable 
Deduplicates members within the constructor's initializer list.
 2019-11-22 15:56:29 -05:00
Lioncash 544d6cbe52 InputCommon/DualShockUDPClient: Add missing header guard 
Prevents potential inclusion issues from occurring.
 2019-11-22 15:56:26 -05:00
Lioncash 91993b46d9 InputCommon/IMU*: Remove unnecessary includes 
Trims out unnecessary includes to avoid unnecessary header dependencies.

This also resolves indirect inclusions of <optional> within
IMUAccelerometer.h and IMUGyroscope.h
 2019-11-22 15:41:38 -05:00
Lioncash 814fd165af InputCommon/FunctionExpression: Use Yoda conditions, we do not 
The general convention in the codebase is to compare the non-constant
value/string with the constant value/string, not the other way around.
 2019-11-22 15:36:18 -05:00
Lioncash 1f6077922b InputCommon/FunctionExpression: Remove unnecessary 'else' in MakeFunctionExpression() 
Given all conditional bodies only contain a return, the use of else here
isn't necessary.

This has the benefit of consistently vertically aligning the names.
 2019-11-22 15:36:18 -05:00
Lioncash 10fea99d80 InputCommon/FunctionExpression: Make MakeFunctionExpression() take a std::string_view 
There's nothing within this function that requires a copy of the string
to be made, so we can make use of a non-owning view
 2019-11-22 15:36:18 -05:00
Lioncash ddf8abf507 InputCommon/FunctionExpression: Remove unused LOOP_MAX_REPS constant 
This isn't used anywhere in the translation unit, so we can remove it.
 2019-11-22 15:36:18 -05:00
Lioncash 64bc6f53fd InputCommon/FunctionExpression: Remove cyclical include 
This header was including itself, which is likely not intended.
 2019-11-22 15:36:18 -05:00
Lioncash cb8fbe872e InputCommon/FunctionExpression: Collapse namespaces 
Since we target C++17, we can collapse the namespaces into a single
declaration specifier.
 2019-11-22 15:36:14 -05:00
Lioncash 6586ecc7a8 InputCommon/FunctionExpression: include <algorithm> 
std::min/std::max are used within this translation unit, so it needs to
be included to prevent potential compilation failures.
 2019-11-22 14:41:13 -05:00
Lioncash e8edc49bbe InputCommon: Make use of fmt where applicable 
Continues the migration over to fmt
 2019-11-22 14:38:26 -05:00
Mat M bc449fb98f Merge pull request #8480 from JosJuice/volumeverifier-block-future 
VolumeVerifier: Fix a copypaste error
 2019-11-22 11:42:50 -05:00
Mat M 162b7c2ca3 Merge pull request #8477 from jordan-woyak/accel-indicator-flip 
DolphinQt: Fix accelerometer mapping indicator flipped X axis.
 2019-11-17 18:35:49 -05:00
Lioncash cfbabd4c41 SI_Device: Provide proper insertion/extraction operators for SIDevices enum 
Allows the enumeration to be safely used with our type parsing
functions.
 2019-11-11 07:33:01 -05:00
Lioncash febd1c3dba Core: Replace usages of StringFromFormat with fmt where applicable 
Migrates usages of StringFromFormat over to using fmt.
 2019-11-11 07:32:57 -05:00
Mat M 71e3c7ff20 Merge pull request #8453 from JosJuice/android-nvidiashieldworkaroundview 
Android: Expand the comment for NVidiaShieldWorkaroundView
 2019-11-05 03:44:49 -05:00
Mat M 0f4c971326 Merge pull request #8446 from JosJuice/redump-regular-datfile-warning 
RedumpVerifier: Show an error when datfile lacks serials or versions
 2019-11-02 19:45:01 -04:00
Mat M fd4bf5f0a2 Merge pull request #8438 from JosJuice/tilt-tooltip-string 
Change Wii Remote tilt tooltip string based on translator feedback
 2019-10-30 05:39:13 -04:00
Mat M d6a3d0873c Merge pull request #8441 from KenJPH/fix-versioncode 
Fix versionCode dummy value
 2019-10-30 05:38:18 -04:00
Mat M 78fad0aafa Merge pull request #8443 from JosJuice/redumpverifier-datel-wii 
RedumpVerifier: Fix handling of Datel Wii disc serials
 2019-10-30 05:37:08 -04:00
Mat M 4f5badb9ed Merge pull request #8442 from JosJuice/data-partition-missing 
VolumeVerifier: Fix "The data partition is missing" false positive
 2019-10-30 05:36:36 -04:00
Mat M 427d4501bc Merge pull request #8429 from JosJuice/redump-create-path 
Create necessary folder when using Redump.org integration
 2019-10-26 15:51:25 -04:00
Mat M cc6a1193b0 Merge pull request #8430 from JosJuice/eof-i18n-comment 
InputCommon: Change "EOF" to "end of expression" in user facing string
 2019-10-26 15:02:48 -04:00
Mat M fed2dce404 Merge pull request #8425 from JosJuice/volumeverifier-datel-wii 
VolumeVerifier: Improve handling of Datel Wii Freeloader discs
 2019-10-26 15:01:52 -04:00
Mat M c6da1f050b Merge pull request #8376 from tkln/watch-widget-sign-compare 
WatchWidget: Fix integer comparison signedness warnings
 2019-10-23 20:20:51 -04:00
Mat M 897d7f634e Merge pull request #8422 from CookiePLMonster/gamelistmodel-fixup 
Fixup GameListModel::UpdateGame and columnCount
 2019-10-23 20:20:03 -04:00
Mat M 6991b39289 Merge pull request #8419 from jordan-woyak/xor-op 
ExpressionParser: Add XOR operator.
 2019-10-23 20:18:39 -04:00
Mat M 291c056c07 Merge pull request #8424 from JosJuice/cpu-core-advanced-cleanup 
DolphinQt: Cleanup after moving CPU Emulation Engine to Advanced tab
 2019-10-23 20:16:32 -04:00
Mat M 780d34dbca Merge pull request #8426 from JosJuice/volumeverifier-region-mismatch 
VolumeVerifier: Improve region/game ID mismatch checking
 2019-10-23 20:15:31 -04:00
Mat M d95745ffdb Merge pull request #8331 from JosJuice/gitignore-enc-temp-folder 
Add enc_temp_folder to .gitignore
 2019-10-23 20:13:01 -04:00
Mat M 6282b0d83e Merge pull request #8326 from lioncash/fmt 
ActionReplay: Make use of fmt where applicable
 2019-10-20 07:30:20 -04:00
Mat M d0114ea61e Merge pull request #8415 from jordan-woyak/try-parse 
StringUtil: Require TryParse of float types to use the entire string.
 2019-10-20 07:29:20 -04:00
Mat M ef77101463 Merge pull request #8412 from jordan-woyak/def-warn-fix 
Core/HW: Fix some explicitly defaulted but implicitly deleted warnings.
 2019-10-19 17:47:40 -04:00
Mat M f6a5811b73 Merge pull request #8414 from JosJuice/translate-ubershaders 
DolphinQt: Mark ubershader setting names as translatable
 2019-10-18 17:38:22 -04:00
Mat M 3beb371cc9 Merge pull request #8404 from JosJuice/gitignore-cxx 
Add /Source/Android/app/.cxx/ to .gitignore
 2019-10-14 14:14:10 -04:00
Mat M 5be061e27f Merge pull request #8398 from jordan-woyak/old-wm-comment 
WiimoteEmu: Fix an outdated comment.
 2019-10-10 08:56:39 -04:00
Mat M 828dc0f204 Merge pull request #8354 from JosJuice/editorconfig-java-spaces 
.editorconfig: Use spaces for Java code
 2019-09-07 13:06:31 -04:00
Mat M 40fc25b06d Merge pull request #8353 from Ebola16/GID 
Android: Add GameID to Game Settings title
 2019-09-07 10:01:28 -04:00
Lioncash f414d926c1 ActionReplay: Make use of fmt where applicable 
Converts the ActionReplay logging over to using fmt instead of
StringFromFormat.
 2019-08-21 17:59:33 -04:00
Lioncash 07aa18eb2b VideoCommon/TextureCacheBase: Collapse for loop into a fill() in Invalidate() 
Same thing, less code.
 2019-08-04 23:30:27 -04:00
Lioncash d52dd2e04f VideoCommon/TextureCacheBase: Use emplace_back where applicable 
Same thing, less code.
 2019-08-04 23:28:14 -04:00
Lioncash fd12ae1408 VideoCommon/TextureCacheBase: Remove use of the texture cache global 
We can just call the functions that are part of the interface instead of
using the global in order to execute those functions.
 2019-08-04 23:23:04 -04:00
Lioncash 7366b4281f VideoCommon/RenderBase: Remove dependency on renderer global within renderer 
There's no need to have a dependency when we can simply call the
function itself as part of the instance itself.
 2019-08-04 23:01:19 -04:00
Lioncash cfdfbbff38 VideoCommon/RenderBase: Use structured bindings where applicable 
Same behavior, but immediately assigns to variables, allowing them to be
const.
 2019-08-04 22:59:07 -04:00
Lioncash dd5b8895fe VideoCommon/RenderBase: Make functions const where applicable 2019-08-04 22:52:00 -04:00
Lioncash 86a651e27f VideoCommon/TextureCacheBase: Remove dependence on global variables from OnConfigChanged() 
The active config will always be passed as the reference parameter, we
can make use of the parameter instead of accessing the global variable.
 2019-08-04 22:33:18 -04:00
Lioncash 7d017be666 VideoCommon/TextureCacheBase: Make OnConfigChanged's parameter a const reference 
This reference isn't actually modified within this function
 2019-08-04 22:31:27 -04:00
Lioncash 8285a94d93 UICommon/NetPlayIndex: Take std::vector by const reference in ParseResponse() 
This variable isn't std::moved anywhere and is just read out of into a
string. Instead of making a copy, and then another copy of the data into
a std::string, we can take it by reference, only copying the data once.
 2019-08-04 12:36:52 -04:00