Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
26,912 Commits 1 Branch 0 Tags
35e3775a7713a7d70b201f4edfc31bebfc535434
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash 75f5fcdfee Assert: Remove unused parameter from DEBUG_ASSERT 
This brings the macro in line with the regular ASSERT macro, which only has one
macro parameter.
 2018-03-16 13:01:11 -04:00
Mat M 328585ef17 Merge pull request #6445 from lioncash/assert-guard 
Assert: Wrap assertion macro bodies in do {} while (0)
 2018-03-16 12:42:56 -04:00
Lioncash f44e2dc425 Assert: Wrap assertion macro bodies in do {} while (0) 
Enforces the termination of the macro with a semicolon. Aside from that
requirement, behavior remains the same.
 2018-03-16 12:35:23 -04:00
Mat M 9f4d5122a2 Merge pull request #6438 from lioncash/assert 
Assert: Uppercase assertion macros
 2018-03-16 11:59:14 -04:00
Lioncash 50a476c371 Assert: Uppercase assertion macros 
Macros should be all upper-cased. This is also kind of a wart that's
been sticking out for quite a while now (we avoid prefixing
underscores).
 2018-03-14 22:03:12 -04:00
Lioncash 9f2a46b08d DSPCore: Use nested namespace specifiers for the x64 JIT 
Slims down the amount of lines needed for namespacing.
 2018-03-13 18:57:25 -04:00
Lioncash b3fd79b45a DSPCore: Rename namespace to match moved x64 JIT files 
Maintains consistency between location and code
 2018-03-13 18:48:16 -04:00
Lioncash ab5b90bf15 DSPCore: Move x64 JIT source files into an x64 subdirectory 
While the code is namespaced out properly, the files weren't separated
into their own directory. This moves the files so that introducing a general
interface is easier in the future for supporting other architectures.
 2018-03-13 18:26:26 -04:00
Mat M bf825e6354 Merge pull request #6404 from hubslave/patch-1 
Include <endian.h> for byte swap macros on OpenBSD
 2018-02-27 23:28:22 -05:00
Mat M f2891418da Merge pull request #6410 from leoetlino/timing-groundwork 
IOS: Change devices to always return IPCCommandResult
 2018-02-27 23:26:11 -05:00
Lioncash abfaff8ca9 Qt: Remove unnecessary <iostream> includes 
<iostream> injects a static constructor into the translation units that
it's included into. This is trivially avoidable in these cases.
 2018-02-21 16:38:08 -05:00
Mat M dff7837715 Merge pull request #6378 from stenzek/vulkan-redundant-converter 
Vulkan: Remove redundant YUYV conversion shaders
 2018-02-14 02:45:33 -05:00
Mat M bb805bdd9f Merge pull request #6360 from spycrab/qt_mbp_delete 
Qt/BreakpointWidget: Fix MBP delete
 2018-02-07 01:29:45 -05:00
Mat M 32360e23e0 Merge pull request #6356 from spycrab/qt_mapping_nsaving 
Qt/MappingButton: Save settings when a mapping is changed
 2018-02-04 18:53:00 -05:00
Mat M f3826b4e92 Merge pull request #6337 from spycrab/qt_fix_debugger 
Qt/RegisterColumn: Fix value columns not being editable
 2018-01-28 16:42:46 -05:00
Lioncash e88c457276 DolphinWX: Resolve missing declaration warnings 
Without the include, the prototypes of the functions can't be found
 2017-12-07 18:58:20 -05:00
Lioncash ed2be3b8e3 DolphinWX/Main: Fix shader compilation dialog translations 
Fixes issue 10685
 2017-12-04 04:33:49 -05:00
Lioncash de82330a74 GekkoDisassembler: Correct disassembly of fabs, fnabs, and fneg 
These three instructions use the B field (bits 16-20 of the opcode)
to determine what the operand register is. However, the code was
using the path that uses the C field (bits 21-25).

This amends the code to use the B field (and also fixes the 64-bit PPC
opcodes, because why not?).

Fixes issue 10683.
 2017-12-04 00:02:35 -05:00
Lioncash 050440fd5b OGL/TextureConverter: Remove unnecessary using declaration 2017-12-03 18:51:22 -05:00
Lioncash 93e85f9a7c OGL/TextureConverter: Resolve -Wmissing-variable-declaration warnings 2017-12-03 18:51:17 -05:00
Lioncash 666af4605e WiiSaveBanner: Resolve a -Wreorder warning 2017-12-03 18:34:49 -05:00
Lioncash 6ca85dbf0a VKTexture: Add missing override specifier to the other ScaleRectangeFromTexture() prototype 2017-12-02 20:20:13 -05:00
Lioncash c7bc16811c VKTexture: Remove unimplemented ScaleRectangleFromTexture() prototype 2017-12-02 20:15:32 -05:00
Lioncash b0fadbb5de D3D/VertexManager: Add missing includes 
Gets rid of reliance on indirect includes
 2017-12-02 20:09:33 -05:00
Lioncash 1e7096dd27 D3DBase: Mark file-scope variables as internally linked where applicable 2017-11-30 23:46:46 -05:00
Lioncash d6f10fdc15 D3DUtil: Remove unused defines 2017-11-19 12:14:18 -05:00
Lioncash 01a92af014 D3DUtil: Make file-scope variables internally linked where applicable 
All file scope variables are able to be made internally linked.

CD3DFont is essentially used as an extension to the utility interface, so
this is able to be made internal as well, removing a global from
external view.
 2017-11-19 12:12:39 -05:00
Lioncash 518f6a3624 VideoCommon: Resolve -Wmissing-brace warnings 
Resolves around 5 -Wmissing-brace warnings on macOS.
 2017-11-19 01:49:39 -05:00
Lioncash 2bd88bdb9f AbstractTexture: Remove a redundant constructor initializer list entry 
This is already initialized in the class definition. This would
previously cause a -Wreorder warning on macOS, as m_config is
defined after m_currently_mapped.
 2017-11-19 01:25:55 -05:00
Lioncash 16a0a58b91 VolumeGC: Correct printf specifier in LoadBannerFile() 
Gets rid of a warning when compiling on macOS.
 2017-11-19 00:54:47 -05:00
Lioncash 364eaadfe5 VideoBackends: Remove header inclusions made unnecessary with Hybrid XFB 
Just some inclusions that weren't removed in the initial Hybrid XFB PR.
 2017-11-19 00:53:10 -05:00
Lioncash 05d0d184d7 DolphinQt2: Fix incorrect description string for the immediate XFB option 2017-11-19 00:40:46 -05:00
Lioncash 2ef8ded8ce D3D: Remove non-existent files from CMakeLists.txt 
Just a leftover that was missed in the Hybrid XFB PR.
 2017-11-19 00:29:23 -05:00
Lioncash 5337e58284 VideoConfig: Make StereoMode an enum class 
Makes for more strongly-typed identifiers (and doesn't pollute
surrounding namespaces)
 2017-11-18 23:19:53 -05:00
Lioncash 10697bcbe3 VideoConfig: Make AspectMode an enum class 
Makes for more strongly-typed identifiers (and doesn't pollute
surrounding namespaces)
 2017-11-18 23:17:56 -05:00
Mat M d800b0f798 Merge pull request #6196 from Helios747/remove_displayres_ui 
[UI] Remove fullscreen resolution UI.
 2017-11-18 18:55:18 -05:00
Lioncash 2a782b8f16 D3D/main: Remove unused variable in InitBackendInfo() 2017-11-12 13:24:02 -05:00
Lioncash 3dbd6a53cc D3DUtil: Remove unused file-scope variables 
These used to be used when the drawShadedTexSubQuad() function existed,
but since it's been removed they now have no use.
 2017-11-11 18:56:44 -05:00
Lioncash 8e654528fc VideoConfig: Add const specifier to IsVSync() member function 
This member function doesn't alter VideoConfig's state.
 2017-11-10 22:23:15 -05:00
Mat M 224996d652 Merge pull request #6150 from MerryMage/macos-wx-underscore-macros 
wxWidgets3: Fix compilation due to change in assert macros in macOS 10.13 SDK
 2017-10-30 21:04:11 -04:00
Mat M 78d5dbe032 Merge pull request #6127 from mbc07/android-codestyle-fix 
[Android] Don't install Genymotion plugin when importing Code Style preferences file
 2017-10-21 18:50:31 -04:00
Mat M bf71d1497e Merge pull request #6123 from hackbar/input-fix 
Android: refactor and bugfix for input settings
 2017-10-21 18:48:54 -04:00
Lioncash c8af9e5f7b TextureConfig: Specialize std::hash for TextureConfig 
This allows the hashing for TextureConfig instances to automatically be resolved instead of needing to directly specify it all the time.
 2017-10-08 23:55:14 -04:00
Lioncash 6c326e7215 InputConfigDiag: Fix building DolphinWX on the latest MSVC 
const char[1] and wxString() can both be converted to multiple common
types, so this results in an ambiguous conditional expression
compilation error (C2445)
 2017-09-17 02:38:12 -04:00
Lioncash dbd9aeb210 OGL/TextureCache: use std::array for the palette shader array 2017-09-17 02:34:02 -04:00
Lioncash 6d9ed9dc32 OGL/TextureCache: Move file statics to the TextureCache class 
These rely on instance state, or are used within instance-based class
member functions, so they should belong to the instance itself instead
of being file statics.
 2017-09-17 02:33:56 -04:00
Mat M 5576af061b Merge pull request #5798 from ligfx/qttranslation 
Qt: use translations
 2017-09-14 20:19:09 -04:00
Lioncash 343bde2712 Software/TextureSampler: const correctness 2017-09-11 20:13:47 -04:00
Mat M a9b339fb65 Merge pull request #6048 from spycrab/qt_fix_tools 
Qt: Fix "Load Wii System Menu" being in the wrong place
 2017-09-10 02:18:13 -04:00
Lioncash 696e1b40b5 Common: Move version strings to their own header 
Ideally Common.h wouldn't be a header in the Common library, and instead be renamed to something else, like PlatformCompatibility.h or something, but even then, there's still some things in the header that don't really fall under that label

This moves the version strings out to their own version header that doesn't dump a bunch of other unrelated things into scope, like what Common.h was doing.

This also places them into the Common namespace, as opposed to letting them sit in the global namespace.
 2017-09-09 19:28:10 -04:00
Lioncash 46579fe41c SWVertexLoader: Make SWVertexLoader a final class 
It doesn't make sense to allow extending this class based off the way
the VertexLoader API is set up.
 2017-09-09 15:33:30 -04:00
Lioncash dd8b41326c SWVertexLoader: Make SetFormat() and ResetBuffer() private 
SetFormat() is only ever used internally. ResetBuffer() is only
used to implement the VertexManagerBase class interface, so
there's no need to make it protected.
 2017-09-09 15:33:30 -04:00
Lioncash 29a362be43 SWVertexLoader: Remove GetIndexBuffer() 
It's only ever used in one place internally and is arguably unnecessary.
 2017-09-09 15:33:22 -04:00
Lioncash 4d2a4924cb SWVertexLoader: Normalize class variable names 
Follows our coding style.
 2017-09-09 15:32:41 -04:00
Mat M e86713ca67 Merge pull request #6044 from JonnyH/WIP/x11-buildfix 
Buildfix for X11 where HAVE_XRANDR is disabled
 2017-09-09 14:59:40 -04:00
Mat M 3e47baa40c Merge pull request #6022 from spycrab/qt_sw_dialog 
Qt/SettingsWindow: Fix window not being detected as a dialog
 2017-09-04 14:06:13 -04:00
Lioncash baee3a9c74 Software/Tev: const correctness 2017-09-03 14:15:21 -04:00
Mat M edf4bfaf5f Merge pull request #5989 from lioncash/constantmgr 
ConstantManager: Use std::array where applicable
 2017-09-03 13:18:10 -04:00
Lioncash 36e299ca80 D3DTexture: Remove unused bindflags D3DTexture2D member variable 2017-09-03 13:12:26 -04:00
Lioncash 52099d1b0a D3DTexture: in-class initialize class members where applicable 2017-09-03 13:08:06 -04:00
Lioncash 2237a6a04c OGL/VertexManager: Make vertex and index buffer handles private 
These are only ever read, but not written to outside of the VertexManager class.
 2017-09-02 20:51:54 -04:00
Lioncash 2d45204f12 VideoBackends: Add the explicit keyword to WorkItem-derived class constructors 
Prevents implicit conversions
 2017-09-02 17:35:20 -04:00
Lioncash 5059332d95 OGL/ProgramShaderCache: Remove unnecessary virtual keyword 
This is superfluous, considering the override keyword is present.
 2017-09-02 17:27:19 -04:00
Mat M 657195fad5 Merge pull request #6006 from JonnyH/WIP/parse-imgtec-gl_version-string 
Parse IMGTEC's GL_VERSION string format
 2017-09-02 17:10:59 -04:00
Lioncash 64de8a9d0b D3D: Eliminate redundant ID3D11DeviceChild* casts 2017-09-02 14:45:14 -04:00
Lioncash 6f97e3faa6 AsyncShaderCompiler: use std::make_unique in CreateWorkItem() 
Same behavior, simpler code.
 2017-09-02 14:08:00 -04:00
Lioncash 62615c601e AsyncShaderCompiler: Forward arguments to the specified type's constructor in CreateWorkItem() 
As this just hands off the arguments to another type's constructor,
perfect forwarding should be used here to preserve any potential move semantics.
 2017-09-02 14:06:48 -04:00
Lioncash f6e3a39c0e CommandProcessor: Remove unnecessary include 
Gets rid of some indirect inclusion.
 2017-09-02 13:34:21 -04:00
Mat M b073db51e5 Merge pull request #6000 from spycrab/qt_fix_older 
Qt: Fix building on <= 5.7.x
 2017-09-01 22:02:18 -04:00
Lioncash 9c1f9c1c00 ConstantManager: Use std::array where applicable 
Modernizes the arrays and makes future simplifications possible (e.g. usages within the software renderer).

It also makes cases where we use array->pointer decay explicit.
 2017-08-27 15:41:36 -04:00
Lioncash bc57ab3923 Clipper: Copy both color sequences in CopyVertex as opposed to one 
This is likely an oversight.
 2017-08-22 22:45:28 -04:00
Lioncash ffaa9a3bea SW NativeVertexFormat: Utilize std::array where applicable 
Gets rid of some hardcoded looping bounds, and also simplifies code in
some places, sometimes allowing for removal of a loop altogether.
 2017-08-22 22:39:28 -04:00
Mat M 5aed9a67ef Merge pull request #5904 from leoetlino/indirect-include 
PowerPC: Fix indirect includes for GDBStub
 2017-08-20 19:59:53 -04:00
Lioncash 7a5577498b CommonTypes: Qualify standard integral types in typedefs with std:: 
Given a relatively recent proposal (P0657R0), which calls for deprecation of putting stuff into the global namespace when using C++ headers, this just futureproofs our code a little more.

Technically this is what we should have been doing initially, since an
implementation is allowed to not provide these types in the global
namespace and still be compliant.
 2017-08-20 19:34:52 -04:00
Lioncash 745f92b4e5 TransformUnit: Get rid of pointer casting in TransformColor() where applicable 
The casts to u32* are technically undefined behavior. The u8* cast is
left, as char/unsigned char is exempted from this rule to allow for
bvtewise inspection of objects (and this is what s8/u8 are typedefs of
on platforms we support).
 2017-08-06 19:04:31 -04:00
Lioncash 4d35a3105e TransformUnit: Make LightColor()'s chan parameter const 
Also marks references/pointers const where applicable
 2017-08-06 18:15:05 -04:00
Lioncash 2363be4c63 ElidedButton: Make constructor explicit 
Prevents implicit conversions to ElidedButton.
 2017-08-06 17:31:29 -04:00
Lioncash 5153271278 ElidedButton: Add missing override specifier on paintEvent() 2017-08-06 17:26:07 -04:00
Lioncash f0308151a8 File: Make GetSize() a const member function 2017-08-06 07:57:43 -04:00
Lioncash 01c262fe47 Filesystem: Declare FileInfo iterator's move constructor and assignment operator noexcept 
Prevents potential extra copies being created in the context of
std::move_if_noexcept.
 2017-08-05 12:29:02 -04:00
Lioncash f6c21e002b General: Remove unnecessary semicolons 2017-07-30 16:39:53 -04:00
Lioncash b3c1bff34b SysConf: Add explicit to single-argument constructor 
Prevents implicit construction from FromWhichRoot values.
 2017-07-30 15:35:16 -04:00
Lioncash fb42c3eddc DolphinQt2: Add missing include guards 2017-07-26 16:31:58 -04:00
Lioncash 80b938b403 DolphinQt2: Remove unimplemented prototypes 
Also removes an unnecessary includes in related files
 2017-07-26 16:26:55 -04:00
Mat M 63f1f122fa Merge pull request #5729 from ligfx/qtremoveoldsyntax 
DolphinQt2: update old SLOT/SIGNAL syntax
 2017-07-24 18:48:20 -05:00
Lioncash 7373474888 ListProxyModel: Add missing include guard 2017-07-24 19:46:25 -04:00
Lioncash 5859914da5 TraversalClient: Fix memory leaks in ReleaseTraversalClient() 
release() relinquishes ownership of a pointer, it doesn't actually free
it.
 2017-07-22 18:19:25 -04:00
Mat M 898bbffaa7 Merge pull request #5724 from JonnyH/WIP/fix-some-ODR-warnings 
Fix some GCC ODR warnings
 2017-06-29 18:48:47 -04:00
Mat M 4320c641f7 Merge pull request #5675 from Tilka/warning 
Fix two warnings
 2017-06-23 20:46:32 -04:00
Lioncash 82c66e2bab FifoRecorder: Don't allocate ~100.7MB on program startup 
So, a FifoRecorder instance is instantiated as a file-local variable and
used as a singleton (ugh). Most users likely don't regularly use the
FIFO player/FIFO recorder, so this is kind of a substantial waste of
memory.

FifoRecorder's internal RAM and ExRAM vectors are 33554432 and 67108864
bytes respectively, which is around 100.66MB in total.

Just on the game list view on a clean build with nothing loaded, this
knocks debug build memory usage down from ~232.4MB to ~137.5MB, and
release build memory usage down from ~101MB to ~5.7MB.
 2017-06-19 02:47:26 -04:00
Lioncash 59a947d41d AbstractTexture: Return config by const reference 
Returning by const value isn't really necessary (and usually an indicator const reference was intended).
 2017-06-18 23:38:42 -04:00
Lioncash 07cddf6f7f AbstractTexture: Add missing includes (and remove unnecessary ones) 2017-06-18 23:29:22 -04:00
Mat M 4c2b078017 Merge pull request #5644 from lioncash/vsfilter 
VideoCommon: Fix VS filter for AbstractTexture.cpp
 2017-06-18 23:15:43 -04:00
Lioncash 0c57543205 VideoCommon: Fix VS filter for AbstractTexture.cpp 
This would cause failures when building with VS.
 2017-06-18 22:58:02 -04:00
Lioncash 251de89b5c HttpRequest: Use std::chrono for indicating time periods 
Allows the use of chrono time points, on top of being more indicative of
time periods used at call sites, if custom timeouts are specified.
 2017-06-18 15:48:37 -04:00
Mat M 220ce425cd Merge pull request #5580 from lioncash/header 
Core: Remove unnecessary header inclusions
 2017-06-15 19:08:56 -04:00
Lioncash dd4203bec8 Core: Remove unnecessary includes 
Also moves a cpp file's related header file to the top of the inclusions if it isn't already there.
 2017-06-15 18:52:22 -04:00
Lioncash b003108b8b Core: Add WiimoteCommon headers to the VS project 2017-06-15 18:38:21 -04:00
Lioncash a093b58aad Core: Move SignatureDB and Config source files into filters 
Keeps things organized instead of being in the root of Core's source
tree when using the filter view.
 2017-06-07 21:57:49 -04:00
Lioncash d9bb2ce3af DVDInterface: Amend lint formatting issues 2017-06-07 01:20:54 -04:00