Lioncash
7d7b3d6156
Stringify ArmCPUDetect.cpp.
2014-06-02 21:08:26 -04:00
Lioncash
49b0eef393
Remove the min/max functions in CommonFuncs.
...
The algorithm header has the same functions.
2014-05-29 21:44:41 -04:00
Lioncash
c96407bd2a
Make GetBPRegInfo just take two strings as parameters
...
Gets rid of the size parameters.
2014-05-29 19:44:14 -04:00
Lioncash
eca70d1562
Get rid of the temporary buffer in IniFile's Load function.
...
std::getline is the string-based equivalent.
2014-05-28 20:26:15 -04:00
lioncash
4cb111e5db
Clarify what FindBrackets does in the DSP assembler
2014-05-26 17:04:58 -04:00
Lioncash
1583ce9363
Use strings instead of arbitrary buffers for video statistics
2014-05-25 21:11:29 -04:00
Lioncash
9e7c5c0e58
Explicitly center the X and Y joystick values.
...
More self-explanatory at a glance than a memset.
2014-05-24 20:10:41 -04:00
Lioncash
728078bc09
Use a bool instead of an int to represent the initialized state in IOWin.cpp
2014-05-24 19:43:11 -04:00
Lioncash
dd35a968f8
Fix a struct overflow case in WII_IPC_HLE_Device_hid.cpp
...
WiiHIDDeviceDescriptor is 20 bytes in size (2 of which are padding bytes)
libusb_device_descriptor on the other hand is 18 bytes (does not have the
2 padding bytes).
So we were pulling 20 bytes out of an 18 byte struct, which isn't really
correct.
2014-05-24 18:36:28 -04:00
Lioncash
554207a87c
Remove an unnecessary null check in CodeWindow.cpp.
...
The validity of ToolBar is checked at the beginning of the function
2014-05-18 11:43:21 -04:00
Lioncash
75cb8a7452
Fix a typo in the JIT debugger window
2014-05-18 10:31:39 -04:00
Lioncash
5f796e919b
Move bn.h and ec.h into the correct filter section
2014-05-17 16:47:41 -04:00
Lioncash
e1359382be
Kill off _T and wxT macros
...
Minor other alterations that relate to above as well.
Also added the PanicAlertT version of alerts for some error messages that
use PanicAlert. We want the user to actually understand why the error
occurred.
2014-05-17 16:25:51 -04:00
Lioncash
90df5efd01
Get rid of old wx event type usages. Use recommended replacements
2014-05-17 13:17:43 -04:00
Lioncash
d0bd4119d1
Use size_t in std::string operations in IniFile.cpp, not int
2014-05-14 20:38:08 -04:00
Lioncash
f4d80bd8a5
Move the #pragma once header guard before the includes in Statistics.h in VideoCommon.
2014-05-04 00:24:21 -04:00
lioncash
e79895e372
Replace use of the deprecated mem_fun function with mem_fn.
2014-04-01 12:09:22 -04:00
Lioncash
c351e12fe5
Fix assertion fails in FifoPlayerDlg.cpp.
2014-03-29 12:39:54 -04:00
Lioncash
366c83c4e0
Remove unnecessary wxT declarations in FifoPlayerDlg.
...
These are not needed anymore since wx 3.0. Also some minor formatting stuff.
2014-03-29 12:27:51 -04:00
Lioncash
73a3a6726d
Add the algorithm header to a few FifoPlayer cpp files.
...
Both of them use std::min and std::max, but this header wasn't included.
2014-03-29 10:42:28 -04:00
Lioncash
52c1db81ee
Fix include order in EGL.h.
2014-03-27 20:26:52 -04:00
Lioncash
59eb59dd98
Remove an unused parameter from UpdateDebugger_MapLoaded.
2014-03-23 17:19:12 -04:00
Lioncash
a35e1d42d9
Provide clearly defined densities of the controller icons.
2014-03-23 01:23:39 -04:00
Lioncash
13c780d6a7
Fix two untranslated Japanese strings.
2014-03-22 22:42:29 -04:00
Lioncash
7922428dd7
Fix a call to a parent class method in InputOverlay.
...
Should have been a call to draw, not onDraw. Behavior-wise, it's still the
same however.
2014-03-22 22:41:42 -04:00
Lioncash
9ed562d7de
Mark the PPCDebugInterface and DSPDebugInterface as final.
2014-03-18 20:42:08 -04:00
lioncash
aecc8ea666
Remove usesMixer function from the sound streams.
...
This isn't used anywhere in the codebase. Not even the base SoundStream has it as part of its interface.
2014-03-18 10:42:07 -04:00
lioncash
5e5ab61d0c
Mark the audio streams as final.
...
These aren't intended to be continually extended.
2014-03-18 10:37:45 -04:00
Lioncash
692deb24ba
Remove unused function PanicAlertToVideo from Core.cpp.
2014-03-16 21:07:34 -04:00
Lioncash
5edce0eeb6
Simplify log queue clearing.
...
Simply just keep popping the queue until it's empty. No point in using a for loop for this.
Combined some if statements too.
2014-03-16 20:58:13 -04:00
Lioncash
110f603cb6
Remove an unnecessary wx translation underscore macro from PHackSettings.
...
Also removed an unnecessary string -> wx string conversion.
2014-03-16 19:05:57 -04:00
Lioncash
291c95b780
Cleanup a little bit of the PHackSettings.
2014-03-16 18:42:56 -04:00
Lioncash
a9adaa5601
Prevent VideoConfig inheritance.
2014-03-16 17:00:29 -04:00
Lioncash
bd1ce18f90
Simplify file tree building for the filesystem view.
...
Technically this also simplifies on disc filename building in general.
2014-03-16 16:54:00 -04:00
Lioncash
f325fc9634
Clean up FileHandlerARC.cpp/.h
...
- Removed parentheses from the returns.
- Put the function declaration headers back on a single line.
- Make FindFileInfo's parameter a const string reference.
2014-03-15 02:14:49 -04:00
Lioncash
3b27a2d22e
Make WiiSocket function names conform to the coding style.
2014-03-14 20:11:52 -04:00
Lioncash
a82675b7d5
Kill off some usages of c_str.
...
Also changes some function params, but this is ok.
Some simplifications were also able to be made (ie. killing off strcmps with ==, etc).
2014-03-14 13:51:23 -04:00
Lioncash
0edda2bd7f
Fix a typo in DSPSymbols. (DisasssembleRange -> DisassembleRange)
...
Also remove IsHexDigit and IsAlpha and replace them with their cctype equivalents.
2014-03-12 20:51:06 -04:00
Lioncash
dccc6d8b47
Simplify boolean toggling in the TASInputDlg.
...
Also fixed the indentation for some code in a switch statement.
2014-03-12 10:12:29 -04:00
Lioncash
932e3c1db2
[Android] Tidy up the dialog buttons that don't do anything.
...
All we want to do with these is dismiss the dialog. The same can be done by simply passing null.
2014-03-09 23:02:08 -04:00
Lioncash
76b2dde3d7
Fix DSPTool string output for disassembly.
...
Would previously print that assembly had succeeded.
2014-03-09 15:01:56 -04:00
Lioncash
e9d1796c24
Rename assemble.cpp/.h and disassemble.cpp./.h to DSPAssembler.cpp/.h and DSPDisassembler.cpp/.h
2014-03-09 13:25:50 -04:00
Lioncash
440efaa5f5
Fix DSPTool.
...
Forgot to adjust the stubs.
2014-03-09 13:00:51 -04:00
Lioncash
b027c4d64e
Add more sound file extensions to FileMonitor's IsSoundFile.
2014-03-09 12:46:01 -04:00
Lioncash
db0596e088
Add a namespace to DSPHost.
...
Gets rid of the "DSPHost_" prefix in function names.
2014-03-09 12:30:13 -04:00
Lioncash
53ed0051c8
[Android] Split the AboutFragmentItem and InfoFragmentAdapter into their own class files.
...
It doesn't make sense conceptually to keep them within the AboutActivity, as they are entirely self-contained classes.
2014-03-08 19:37:32 -05:00
Lioncash
c5fb4ac96f
[Android] Remove unnecessary comment from VideoSettingsFragment.
...
Misleading comment. We won't need to access index four for anything.
2014-03-08 19:08:26 -05:00
Lioncash
b2d47401b2
Remove some superfluous arguments from some wx control creations
...
wx has these as default parameters.
2014-03-05 23:02:34 -05:00
Lioncash
aa82680be7
Mark functions in the PPCDebugInterface and DSPDebugInterface as final.
...
The way they currently were, they would allow for a class to inherit and override these interfaces functions. However, this doesn't make sense conceptually.
2014-03-05 21:54:34 -05:00
Lioncash
610a6f9b23
Add ClearAllMemChecks to DebugInterface
...
Breakpoints have one, but memchecks don't, despite being cleared directly in the breakpoint window.
Now DolphinWX should call the interface functions and not the direct functions of the breakpoints or memchecks for clearing.
2014-03-05 21:50:23 -05:00
lioncash
96328902a5
Actually make PPCDebugInterface::ClearAllBreakpoints have functionality.
...
Fairly simple - just clear the breakpoints.
2014-03-05 20:27:27 -05:00
lioncash
2c8b9735ae
Add two other formats to the list of extensions in IsSoundFile
...
.adx is used in various games, so this should definitely be here.
2014-03-04 08:57:07 -05:00
lioncash
f39c757edf
Simplify ShowSound() in FileMonitor.cpp.
...
Now if more sound types are found, they just need to simply be added to
the unordered set.
- Also changed ShowSound() to IsSoundFile()
- Fixed IsSoundFile’s definition in FileMonitor.h. This whole time it
has been defined as a void method, when in reality it was a bool
function.
- Changed the FileMonitor’s string parameters to be constant references.
2014-03-04 08:39:25 -05:00
Lioncash
279a8c0148
Change the DebugInterface, PPCDebugInterface, and DSPDebugInterface to use CamelCase names.
...
This is the standard coding convention in the codebase, so our interfaces should use it too.
2014-03-03 00:39:08 -05:00
Lioncash
10f3d90f83
Make the base calculation in CheatsWindow simpler.
...
First and foremost this should test the checked state, not its direct value.
This should never have used multiplication at all. Seriously, what the hell?
The only values it would have given is true or false, so the only cases are 0*6 and 1*6.
2014-03-02 22:15:01 -05:00
Lioncash
34b5a7871f
Rename the JIT function Default() to FallBackToInterpreter(). Communicates intent way better in terms of telling the reader what's going on.
...
Also did some minor cleanup in functions that used Default.
2014-03-02 19:59:20 -05:00
Lioncash
445d257641
Fix a case where the wrong placeholders were being assigned for the up and down D-Pad buttons in the TAS dialog.
2014-03-02 18:58:54 -05:00
Lioncash
13a007abed
Remove another clamp function laying in the codebase and replace it with the one in MathUtil.h.
2014-03-02 13:57:27 -05:00
Lioncash
3bc082be52
Fix WII_SEEK_END seeking.
2014-02-28 19:56:42 -05:00
Lioncash
d5fd68e4a4
Eliminate the magic constants in the switch statement in WII_IPC_HLE_Device_FileIO.cpp's Seek function.
2014-02-24 15:01:08 -05:00
Lioncash
4094c35203
Tiny cleanup to WII_IPC_HLE.cpp.
...
- Inlined loop vars in statements where possible.
- Eliminate some explicit iterators with foreach loops.
- Kill off some newlines that weren't necessary.
2014-02-24 14:09:42 -05:00
Lioncash
98d2e76fcc
Unnecessary c_str call in WII_IPC_HLE_Device_es.cpp's OpenTitleContent function.
...
m_ContentFile is a string, so it's kind of pointless to pass a c_str of a string to constructor of a new string.
2014-02-24 08:32:45 -05:00
Lioncash
e71db8fe04
In UCode_AX.cpp in function HandleCommandList() - case CMD_MIX_AUXB_NOWRITE should have 1 being passed, not false, as the aux ID in MixAUXSamples.
2014-02-23 17:22:20 -05:00
Lioncash
e3e78128a2
isSameValue in IR.cpp/.h should be returning a boolean value.
2014-02-23 04:14:57 -05:00
Lioncash
679a1bb2eb
WII_IPC_HLE_Device_usb_kbd.cpp's Update method should return 0, not false, it communicates the wrong intent otherwise.
2014-02-23 04:08:52 -05:00
Lioncash
8d57f38be7
Purge wx elements of the console.
2014-02-23 03:12:24 -05:00
Lioncash
d45351a43f
Initial removal of the actual console functionality on windows.
2014-02-23 02:01:35 -05:00
Lioncash
24ba058404
Fix the Windows build for the final time.
2014-02-19 19:38:23 -05:00
Lioncash
c1a934f7ed
Fix the Android build.
...
Required the removal of EGL.h from EGL.cpp.
Removed the similar includes from AGL.cpp, GLX.cpp, and WGL.cpp to retain consistency.
All GL interfaces are now centralized on GLInterface.h
2014-02-20 01:01:11 +01:00
Lioncash
ed9eea72a1
Forgot to move DSPTool over. Fixed now.
2014-02-20 01:01:11 +01:00
Lioncash
91286f5021
Fix the Windows build in relation to the recent changes.
2014-02-20 01:01:11 +01:00
Lioncash
146b301a91
Fix more header sorting issues in Core/ (now check-includes clean).
2014-02-20 01:01:11 +01:00
Lioncash
edb43cfe61
Fix the OSX build.
...
Turns out Dolphin uses some macros that clash on OSX. However thankfully, this include is only used in Frame.cpp.
2014-02-18 19:08:17 -05:00
Lioncash
eee549f92b
Scope the Windows include directory to only point to Source/Core/.
...
Also fix the Windows build with this change.
2014-02-18 13:21:12 -05:00
Lioncash
2afe215271
Convert all includes to relative paths.
2014-02-18 02:19:10 -05:00
Lioncash
3fd87a7636
Second and final pass of clearing out tabs.
2014-02-17 02:19:41 -05:00
Lioncash
d9ce4a892b
Remove the leftover folder for Wii IO bridge. Was removed in the mmio merge
2014-02-16 21:08:32 -05:00
Lioncash
cd8196f5db
Turns out Console.cpp and ConsoleListener.cpp were being built into the Linux builds too. Fixes the build.
2014-02-16 20:55:07 -05:00
Lioncash
ca7bdf1d5d
Remove the embedded Console from the possible logging options.
...
Note I do not mean the Logging window, but the console window.
It's literally rarely, if at all used, and offers less advantages over the built-in logging window (ie. it breaks on different locales: http://i.imgur.com/Cs92tQE.png )
This commit should remove all of the console logging.
2014-02-16 20:40:33 -05:00
Lioncash
6c4ee1753a
Fix some vertical alignments
...
ie. uses spaces for alignment.
2014-02-16 20:12:05 -05:00
Lioncash
655d22512b
Kill off some usages of the ArraySize macro.
...
This required the use of std::array in some cases.
2014-02-15 02:43:54 -05:00
Lioncash
867d0f01a2
Remove #if 0 statement in lfd() in Jit64/Jit_LoadStoreFloating.cpp
2014-02-14 23:46:09 -05:00
Lioncash
49d6be26cd
Remove dead else branch in StoreFromRegister() in Jit64/JitRegCache.cpp
2014-02-14 23:43:51 -05:00
Lioncash
d42e8817a0
Clean out some old left-behind quantizer stuff in Jit64/Jit_LoadStorePaired.cpp and Jit64/Jit_SystemRegisters.cpp.
2014-02-14 23:32:37 -05:00
Lioncash
c78faafeae
Kill off some silly casting in the FifoPlayer.
...
Also makes more sense conceptually, since it's not like we'll ever have negative frames.
2014-02-14 22:07:12 -05:00
lioncash
d2038049f5
Replace all include guard ifdefs with "#pragma once"
2014-02-10 18:07:16 -05:00
lioncash
f5408c3f52
Clarify an if statement in NetPlayClient.cpp. See: https://github.com/LaurentGomila/SFML/issues/26 .
...
This was simply an error in documentation. It actually returns an sf::Socket::Status enum value as a result.
2014-02-10 09:26:29 -05:00
Lioncash
fc30597f7a
Remove function Xchg from SWStatistics.cpp. Like the one previous, this can be replaced with std::swap
2014-02-09 19:55:44 -05:00
Lioncash
ebb48d019e
Clean up some struct indentations
...
Also cleaned up the indentations of some variable declarations.
2014-02-09 19:40:11 -05:00
Lioncash
40182a48a5
Cleanup enum indentations.
2014-02-09 16:16:10 -05:00
Lioncash
05742ffd48
Remove function StringFromInt from StringUtil.cpp/.h. C++11 has std::to_string for this now.
2014-02-06 18:08:31 -05:00
Lioncash
9ac6e35b5f
Add static and const qualifiers to the maps.
2014-02-06 03:23:13 -05:00
Lioncash
78356ce184
Simplified GetAreaCode() and GetHardwareModel() to simply use a map in comparisons.
2014-02-05 19:59:13 -05:00
Lioncash
249b00c469
Change the modified parameter in the Clamp function to be a pointer.
...
Makes it easier to identify the one being modified.
2014-02-05 04:04:35 -05:00
Lioncash
6b87a0ef20
Introduce a generic clamp function to clean up some similarly duplicated code.
2014-02-04 20:43:07 -05:00
Lioncash
8039963858
Add const qualifiers to two foreach loop variables for consistency.
...
Also fix a vector include I happened to notice. Should be "<vector>" not "vector"
2014-02-04 19:44:02 -05:00
Lioncash
6d9cd07bb9
[VideoCommon] Eliminate the function Xchg in Statistics.cpp. std::swap does the same thing.
2014-02-04 19:35:27 -05:00
Lioncash
a73a600343
Fix name conventions of some of the foreach loop variables.
2014-02-04 19:30:46 -05:00
Lioncash
63700ad28a
Change some for+iterator loops in GeckoCode.cpp and GeckoCodeConfig.cpp into foreach loops.
2014-02-04 19:19:48 -05:00
Lioncash
7ebc829b17
Remove a pointless c_str() call in FileUtil.cpp. The function takes a string in it's parameter
2014-02-03 21:31:12 -05:00