Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
23,463 Commits 1 Branch 0 Tags
3be53737683d03b7511a1207be8a0cd1cba57477
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash f91292eff2 GeckoCodeConfig: Return vector by value for LoadCodes() 
Using an out-param is a leftover from C++03. Action Replay codes already
return the vector of codes by value as well.
 2017-03-21 16:58:13 -04:00
Lioncash 780dffcb13 FifoDataFile: In-class initialize member variables where applicable 2017-03-21 15:41:05 -04:00
Lioncash 4e5e7cff0a FifoRecorder: In-class initialize member variables where applicable 2017-03-21 15:41:05 -04:00
Lioncash eda27ee397 FifoPlayer: In-class initialize member variables where applicable 2017-03-21 15:40:56 -04:00
Lioncash 0d1bc53e55 JitBase: Rename MergeAllowedNextInstructions to CanMergeNextInstructions 
This is more indicative that it's checking for something
 2017-03-21 13:50:03 -04:00
Lioncash f98211bfcf JitBase: Make MergeAllowedNextInstructions a const member function 2017-03-21 13:45:18 -04:00
Lioncash 35c230a418 NetPlayServer: const correctness 2017-03-19 09:36:40 -04:00
Lioncash 025eac9062 NetPlayClient: const correctness 2017-03-19 09:32:58 -04:00
Lioncash 8e999b209a NetPlayClient: Eliminate variable shadowing 
Gets rid of two -Wshadow warnings
 2017-03-18 22:58:07 -04:00
Lioncash 3404057732 ES: Remove unused string format argument in LaunchPPCTitle 
Gets rid of a -Wformat-extra-args warning.
 2017-03-18 22:44:46 -04:00
Lioncash 2b8abddadf Memmap: Replace '0' constant with nullptr 2017-03-18 22:35:35 -04:00
Lioncash 6cf3c2262c SI: Convert SI buffer from a C array to std::array 
Stronger typing (no implicit pointer decay), nicer aggregate
initialization.

Also gets rid of magic constants where applicable.
 2017-03-16 05:37:03 -04:00
Lioncash f0eeb3c63a SI: Namespace device classes 
Places all of the SI code under the SerialInterface namespace instead of
only the main source file. This keeps all SI code under a common name,
as well as out of the global namespace
 2017-03-16 04:41:39 -04:00
Lioncash 9c3b35fccb EXI: Move enum constants into the ExpansionInterface namespace 
Given these are related to EXI itself, these should be within the
namespace itself.
 2017-03-16 02:06:29 -04:00
Lioncash a728d858b3 SI: Move MAX_SI_CHANNELS into the SerialInterface namespace 
Given this constant is related to the serial interface, it shouldn't be
outside of the namespace.
 2017-03-16 01:57:57 -04:00
Lioncash 46991e2bdd SI: Amend variable naming 2017-03-16 01:37:50 -04:00
Lioncash 4df8ac7820 GCMemcardRaw: Amend variable naming 2017-03-15 00:16:45 -04:00
Lioncash 79246d9642 GCMemcardDirectory: Amend variable naming 2017-03-14 23:58:31 -04:00
Lioncash 647bec4c17 GCMemcard: Amend variable naming for MemoryCardBase 2017-03-14 23:58:27 -04:00
Lioncash 09d4871067 GCMemcard: Move memcard source files to their own directory 
GCMemcard.h has quite a bit of different classes implemented within it
that could likely be split up into other files to make it a little
easier to read. However, they should be moved into their own folder
first so that they don't clutter up the base HW directory.
 2017-03-14 21:55:25 -04:00
Lioncash 8b8a1f3b35 SI_DeviceKeyboard: Amend variable naming 2017-03-14 18:15:25 -04:00
Lioncash 4478b9bc9a SI_DeviceKeyboard: In-class initialize variables 2017-03-14 18:03:36 -04:00
Lioncash c45f8e2e3c SI_DeviceGCSteeringWheel: Amend variable naming 2017-03-14 17:54:18 -04:00
Lioncash 89f5b3b5d9 SI_DeviceGCAdapter: Amend variable naming 2017-03-14 17:47:56 -04:00
Lioncash e68e99ef71 SI_DeviceDanceMat: Amend variable naming 2017-03-14 17:46:09 -04:00
Lioncash 46fd06b956 SI_DeviceGCController: Amend variable names 2017-03-14 05:15:48 -04:00
Lioncash 890f799fdd SI_DeviceGCController: In-class initialize variables 2017-03-14 03:34:52 -04:00
Lioncash deda29d7ff SI_DeviceGBA: Amend printf formatting specifier for size_t 
%zu is the correct specifier for printing size_t.
 2017-03-13 15:28:07 -04:00
Lioncash 8d2078de2d SI_DeviceGBA: Amend variable naming 2017-03-13 15:27:36 -04:00
Lioncash 9f40596de5 SI_DeviceGBA: Make GBASockServer's constructor explicit 
Prevents potential implicit construction scenarios involving ints.
 2017-03-13 14:53:50 -04:00
Lioncash 14f261079f SI_DeviceGBA: Place implementations within the cpp file 
Prevents potential recompilation of other files if these ever need to
change.
 2017-03-13 14:51:18 -04:00
Lioncash 64aa7f3b8f SI_DeviceGBA: Use std::array class members instead of C arrays 2017-03-13 14:46:35 -04:00
Lioncash ea59d30e9f SI_DeviceGBA: In-class initialize variables 2017-03-13 13:52:45 -04:00
Lioncash 70b1933661 SI_DeviceGBA: Store the device number as an int 
This prevents truncation when assigning to this member in the
constructor. This isn't size-critical code, so opting for the more
straightforward assignment is fine here.
 2017-03-13 13:30:02 -04:00
Lioncash 31644eaf93 DSPLLE: Remove commented out code 
Just throwing out the trash
 2017-03-13 12:36:53 -04:00
Lioncash f183d6759a HW/DSP: Remove prefixed underscores from parameter names 
Avoids stepping on potentially reserved names and is more consistent
with the rest of the surrounding code.
 2017-03-13 12:27:38 -04:00
Lioncash ade7718636 DSPInterpreter: Remove unnecessary const specifiers from function declaration parameters 2017-03-12 17:38:04 -04:00
Lioncash a33cd805f9 DSPEmitter: Remove unnecessary const specifiers from function declaration parameters 
These only matter for types being passed by value within the definition,
not the declaration.
 2017-03-12 17:37:07 -04:00
Lioncash 26e9c54886 DSPEmitter: Make helper functions private 
Given none of these are used outside of the DSPEmitter class (nor does
it really make sense to allow them to be used outside of the class),
these should all be made private.
 2017-03-11 20:33:07 -05:00
Mat M 71273c05a9 Merge pull request #5054 from leoetlino/es-get-contents 
IOS/ES: Implement ES_GetStoredContents ioctlvs properly
 2017-03-11 10:52:53 -05:00
Mat M 3d041fa4ea Merge pull request #5055 from leoetlino/es-ticket-view-fix 
IOS/ES: Fix GetViews to not check for the TMD
 2017-03-11 10:50:50 -05:00
Lioncash b61ce51d3b IOS/Network/IP/Top: Separate behaviors into their own functions 
Localizes behavior and separates the code out from the IOCtl/IOCtlV
switch blocks.
 2017-03-09 20:58:45 -05:00
Lioncash 40cdd32760 GCMemcard: Mark class constructors explicit where applicable 
Prevents potential implicit instantation.
 2017-03-08 19:11:16 -05:00
Lioncash b914edd441 GCAdapter_Android: Fix an array bounds overrun in Read() 
s_controller_payload is 37 bytes long, but Read() would copy 0x37 (a.k.a
55) bytes, overrunning the array.
 2017-03-06 23:05:17 -05:00
Lioncash 26f7f55a66 GeneralConfigPane: Fix analytics sizer's right side being misaligned by 5 units 2017-03-06 22:19:54 -05:00
Lioncash 4d1a4ba759 PowerPC: Remove unnecessary const on function declaration parameters 2017-03-06 14:10:33 -05:00
Lioncash 248a04f68f Memmap: Remove unnecessary const on function declaration parameters 
const, when used on value type parameters in the declaration,
is superfluous. This doesn't really convey any information to take note
of when using the function. This only matters in the definition when you
want to prevent accidental modification.

e.g.

// Header
void CalculateSomething(int lhs, int rhs);

// Definition
void CalculateSomething(const int lhs, const int rhs)
{
  // lhs and rhs can't accidentally be modified
}
 2017-03-06 14:08:07 -05:00
Lioncash a9c570a9f8 CachedInterpreter: Get rid of an unnecessary cast 
This is only ever used to read a value and not modify data, so this can
just be constructed by value.
 2017-03-06 13:18:46 -05:00
Mat M 029ff4d9e5 Merge pull request #5022 from lioncash/header 
BTStub: Get rid of an unnecessary forward declaration in the cpp file
 2017-03-05 19:03:56 -05:00
Mat M 2c74b1d0c3 Merge pull request #5028 from leoetlino/es-log-type 
IOS/ES: Fix logging type for dumping unknown ioctlvs
 2017-03-05 19:03:34 -05:00
Lioncash f80f875e27 BTStub: Get rid of an unnecessary forward declaration in the cpp file 
This should be using the header file in order to find the function name.
 2017-03-05 09:51:47 -05:00
Mat M 7fa14169e9 Merge pull request #5007 from lioncash/swap 
Common: Move byte swapping utilities into their own header
 2017-03-05 09:45:29 -05:00
Lioncash 0fa8d6b49b Contributing.md: Minor re-organization of headings 
This gives headings consistent link references that won't arbitrarily
change if the text representing it does, which makes for better
organization. This is also less error-prone when it comes to specifying
links in the presence of two headings with the same text content, but
under different sections.

This also treats each section and sub-section such that they all have
their own dividers.
 2017-03-04 23:10:46 -05:00
Lioncash 0e5a367ca3 SysConf: const-correctness 2017-03-04 19:19:42 -05:00
Lioncash 1ebd2cd7c3 SysConf: Get rid of pointer casts 2017-03-04 19:06:22 -05:00
Mat M 606e25607d Merge pull request #5013 from degasus/androidstudio 
Android: Update android studio + gradle.
 2017-03-04 18:41:16 -05:00
Lioncash 552c0d8404 Common: Move byte swapping utilities into their own header 
This moves all the byte swapping utilities into a header named Swap.h.

A dedicated header is much more preferable here due to the size of the
code itself. In general usage throughout the codebase, CommonFuncs.h was
generally only included for these functions anyway. These being in their
own header avoids dumping the lesser used utilities into scope. As well
as providing a localized area for more utilities related to byte
swapping in the future (should they be needed). This also makes it nicer
to identify which files depend on the byte swapping utilities in
particular.

Since this is a completely new header, moving the code uncovered a few
indirect includes, as well as making some other inclusions unnecessary.
 2017-03-03 17:18:18 -05:00
Lioncash b592e4887e BooleanSetting: Initialize m_value to default_value in the constructor 
Ensures all class state is initialized to valid values on construction.
 2017-03-03 14:09:48 -05:00
Lioncash 25e70570b5 NumericSettings: Initialize m_value to default_value in the constructor 
Ensures that all class state is initialized to valid values.
 2017-03-03 14:06:16 -05:00
Lioncash 13757b7d35 UICommon: Make GetNewDisassembler() return a unique_ptr 
Much better than just returning raw memory.
 2017-03-02 21:26:17 -05:00
Mat M 78e7f4aae3 Merge pull request #4984 from leoetlino/content-fixes 
IOS/ES: Title import fixes + hack removals (fix for System Menu disc updates)
 2017-03-02 14:17:29 -05:00
Lioncash c6200a5b07 JitInterface: Convert includes into forward declarations where applicable 2017-03-02 13:20:29 -05:00
Lioncash ee61bd6f2e CMakeLists: Normalize whitespace 
Normalizes tabs to spaces to follow our codebase's indentation style.
 2017-03-01 14:53:23 -05:00
Lioncash 8b094081a0 Contributing.md: Update C++11 mention to C++14 2017-03-01 13:22:49 -05:00
Lioncash b7bf1dc558 Contributing.md: Add missing table of contents sections 2017-03-01 11:39:08 -05:00
Mat M 8364a0002f Merge pull request #4956 from leoetlino/es-checks 
ES: Replace useless asserts with proper checks
 2017-03-01 11:30:25 -05:00
Lioncash 5ed55ffb34 PixelEngine: Move enum constants into the PixelEngine namespace 
Gets some identifier names out of the global namespace.
 2017-02-28 07:01:50 -05:00
Lioncash d104e5e916 ExpressionParser: Convert parse state enum into an enum class 2017-02-28 05:07:21 -05:00
Lioncash f0203157d4 ExpressionParser: Const-correctness changes 2017-02-26 02:09:34 -05:00
Lioncash 26f17a1723 ControlGroup: Convert group type enum into an enum class 
Gets some constants out of the ControllerEmu namespace, and modifies
ControlGroup so that it uses the enum type itself to represent the
underlying type, rather than a u32 value.
 2017-02-25 01:15:04 -05:00
Lioncash beec40f178 IniFile: Handle s64/u64 values 2017-02-25 00:03:20 -05:00
Lioncash 0783476464 CachedInterpreter: Forward declare instruction struct 
Allows changes to be made to the instruction struct without recompiling
other source files.
 2017-02-23 18:08:20 -05:00
Lioncash 359528b805 JitBase: Put constructor and destructor in the cpp file 
As this is a base class with virtuals, there needs to be an out-of-line
function definition to prevent the vtable of the class being placed within
every translation unit it's used in (i.e. every JIT implementation).
 2017-02-23 13:50:47 -05:00
Mat M c81cf111ef Merge pull request #4921 from waddlesplash/netmap 
IOS/Network/Net: Use a conversion function instead of a static array for SOCKOPT mapping
 2017-02-22 16:11:53 -05:00
Lioncash 70d336d2a9 DolphinWX: Eliminate direct usage of the JIT global 
Instead, the JitInterface namespace functions should be used instead. This
gets rid of all usages of the JIT global from the wxWidgets UI code.

The null check isn't needed as the JIT core would already need to be
initialized in order to be within a paused state. The null check is just a
remnant from 2011 that existed before the check for a paused state was
added.
 2017-02-21 16:15:47 -05:00
Lioncash ff0f60c9f9 JitInterface: Amend ExceptionType enum value names 
Since ExceptionType is an enum class, its name already acts like the
common prefix.
 2017-02-21 15:40:00 -05:00
Mat M 95b2b033b0 Merge pull request #4925 from RisingFog/remove_readonly_check 
Remove IsReadOnly check when stop recording
 2017-02-21 10:53:24 -05:00
Lioncash f65c34d63d JitArm64_Tables: Make initialization instruction tables constexpr 2017-02-21 10:23:39 -05:00
Lioncash 4b342fbbfc JitIL_Tables: Make initialization instruction tables const 2017-02-21 09:55:08 -05:00
Lioncash 092d21253d Jit64_Tables: Make initialization instruction tables const 2017-02-21 09:54:51 -05:00
Mat M 6fbb23e365 Merge pull request #4938 from sjnewbury/GCC7-build-fix 
Add missing "functional" include for GCC7
 2017-02-20 10:51:10 -05:00
Lioncash 2f2aab963d SymbolDB: Simplify GetSymbolsFromHash 
Given a std::map can't have duplicate keys, iterating over the map
explicitly isn't necessary, and find() can just be used instead.

Also, instead of manually calling push_back() for every entry to
be added, the range constructor of std::vector can be used instead to add
the whole range all at once.
 2017-02-18 06:30:20 -05:00
Lioncash aaa6430db6 PPCAnalyst: Make SetInstructionStats' opinfo parameter a const pointer 
trivial const-correctness stuff
 2017-02-18 04:14:26 -05:00
Lioncash 1fa81f24d3 VertexManagerBase: Make CreateNativeVertexFormat return a unique_ptr 
Much safer as opposed to just returning raw allocated memory.
 2017-02-18 03:16:24 -05:00
Lioncash a8eb2e2a8f IOS Network: Split wd/command code into its own source files 2017-02-18 02:35:53 -05:00
Lioncash ec298d9ea9 IOS Network: Split ncd/manage code into its own source files 2017-02-17 23:55:33 -05:00
Mat M 82734fffaa Merge pull request #4910 from lioncash/netsplit 
IOS Network: Move net/ip/top code into its own source files
 2017-02-17 22:42:28 -05:00
Mat M 1e2dba2046 Merge pull request #4920 from leoetlino/ios40 
IOS: Add constants for IOS40
 2017-02-17 22:41:39 -05:00
Lioncash 92e17d2eb8 IOS: Move net/ip/top code to its own source files 2017-02-15 14:42:43 -05:00
Lioncash 245de3fa4f IOS: Move network MAC utilities to their own source files 
All three implementations within Net.cpp currently rely on these
functions.
 2017-02-15 13:38:52 -05:00
Lioncash 0da963c32c NetKDRequest: Make lookup maps const 2017-02-15 11:50:37 -05:00
Mat M 6f272b3a4c Merge pull request #4862 from lioncash/compile 
CPU Backends: Make instruction table initialization private
 2017-02-15 11:44:37 -05:00
Mat M 8fd16db80d Merge pull request #4778 from leoetlino/update-mbedtls 
Externals: Update mbedtls to 2.4.1
 2017-02-15 11:30:18 -05:00
Mat M 5a53763c1a Merge pull request #4892 from lioncash/control 
Control: Convert raw pointer parameter into unique_ptr
 2017-02-15 11:26:53 -05:00
Mat M 3d1f00e98d Merge pull request #4874 from ligfx/movie_magic_number 
Movie: replace magic number 8 with sizeof(ControllerState)
 2017-02-15 11:25:26 -05:00
Mat M 28a6575244 Merge pull request #4900 from lioncash/netkd 
IOS: Separate net/kd code out from Net.cpp
 2017-02-15 11:21:01 -05:00
Mat M 30ee4dfcdf Merge pull request #4908 from leoetlino/apostrophe 
Remove C++14 optional digit separator
 2017-02-14 11:06:08 -05:00
Mat M f68955502a Merge pull request #4905 from JosJuice/rename-copy-wii-save 
Rename "Copy Wii Save" to "Load Wii Save"
 2017-02-13 09:55:54 -05:00
Mat M da5683cf27 Merge pull request #4880 from ligfx/windowsmanifest 
Use .manifest file for apps on Windows
 2017-02-12 08:44:38 -05:00
Lioncash 921ab22cb7 Boot: Remove unused game ID string 2017-02-12 07:55:49 -05:00