Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
28,109 Commits 1 Branch 0 Tags
43680f314c87339524ca04e817483e89c367529d
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Léo Lam 43680f314c Merge pull request #6942 from lioncash/const 
BreakPoints: Make OverlapsMemcheck() a const member function
 2018-05-22 19:14:27 +02:00
Léo Lam 32c4f3d158 Merge pull request #6930 from lioncash/post 
VideoCommon/PostProcessing: Minor changes
 2018-05-21 21:12:27 +02:00
Léo Lam db5c2ffb41 Merge pull request #6931 from lioncash/vulkan-post 
Vulkan/PostProcessing: Make file-scope std::string instances const char arrays
 2018-05-21 21:11:40 +02:00
Léo Lam 4e63117501 Merge pull request #6933 from lioncash/sign 
Interpreter_SystemRegisters: Get rid of implicit sign conversions
 2018-05-21 21:08:14 +02:00
Léo Lam cb850707c0 WiiSave: Fix typo 2018-05-21 16:41:15 +02:00
Léo Lam af97df74e1 Merge pull request #6895 from leoetlino/hardcoded 
IOSC: Fix hardcoded MS and CA IDs
 2018-05-21 15:27:31 +02:00
Léo Lam 12e2012465 IOSC: Fix hardcoded MS and CA IDs 
The values that are used for the MS and CA IDs come from the SEEPROM.
Also, the default CA and MS values are respectively 2 and 3,
not 1 and 2.
 2018-05-21 15:11:25 +02:00
Léo Lam 3d8e63fffd Merge pull request #6914 from leoetlino/verifysign 
ES: Implement VerifySign (last remaining unimplemented, actually used ioctlv)
 2018-05-20 23:11:49 +02:00
Léo Lam 79edd57b96 Merge pull request #6920 from lioncash/priv 
Interpreter_SystemRegisters: Check processor privilege level in mfspr and mtspr
 2018-05-20 23:08:59 +02:00
Léo Lam 73fde6d84d Merge pull request #6923 from lioncash/prototype 
DolphinQt2/GeckoCodeWidget: Remove unimplemented OnDelete() prototype
 2018-05-20 23:02:26 +02:00
Léo Lam 4284952538 Merge pull request #6919 from lioncash/nop 
Interpreter_LoadStore: No-op dcbt and dcbtst if HID0.NOOPTI is set
 2018-05-20 20:33:38 +02:00
Léo Lam 5ce1b83d97 Merge pull request #6918 from lioncash/cast 
Interpreter_LoadStore: Remove unnecessary cast in lhzx()
 2018-05-20 20:21:16 +02:00
Léo Lam 4b0f8d9f85 ES: Implement VerifySign 
This implements ES_VerifySign which is notably used by the system menu
when importing saves.

Now *all* ES commands that are actually used by titles are implemented.
 2018-05-20 20:04:53 +02:00
Léo Lam cec7fded60 IOSC: Implement VerifyPublicKeySign for ECC 2018-05-20 20:04:53 +02:00
Léo Lam b86f1ea7b3 ES / IOSC: Add support for ECC certificates 2018-05-20 20:04:53 +02:00
Léo Lam a974c69058 Merge pull request #6866 from leoetlino/ec-cleanup 
ec: General cleanup
 2018-05-20 20:04:19 +02:00
Léo Lam 67ce7e34e9 UnitTests: Add basic tests for ec crypto code 
Verifies that PrivToPub and ComputeSharedSecret give expected results.
 2018-05-20 19:59:26 +02:00
Léo Lam 355b1b5d5b ec: Improve readability and clarity 
- Move all of the ec functions into the Common::ec namespace.

- Give the public functions better names and some usage information.

- Move all of the "elt" related functions into an "elt" class including
  all of the arithmetic operations, so that the logic becomes clearer
  and feels less like assembly.

  This also makes it much more obvious what the parameters are, instead
  of only using unsigned char* (which doesn't tell anything about what
  the pointer is used for or the size).

- Similarly, add a new "Point" class and move point functions there.
  Overload the arithmetic operators to make calculations easier to read
 2018-05-20 19:59:26 +02:00
Léo Lam e83591f188 ec: Avoid exposing internal function 2018-05-20 19:59:26 +02:00
Léo Lam b9dd94b9b2 bn: Use int instead of u32 for sizes 
The loops relied on unsigned integer overflow, which is not immediately
obvious. Replace them with less clever variants that are clearer.

Also implement bn_compare using std::memcmp.
 2018-05-20 19:59:26 +02:00
Léo Lam 56e91bfdc1 Merge pull request #6429 from JosJuice/png-banners-uicommon 
Reimplement custom PNG banners in game list
 2018-05-20 15:39:07 +02:00
Léo Lam 86c676ab04 Merge pull request #6291 from JosJuice/remove-soil 
Replace usage of SOIL with libpng
 2018-05-20 14:16:31 +02:00
Léo Lam 0706add584 Merge pull request #6699 from 404-Name-Not-Found/alphabetize-gecko-qt 
Adds a toggleable function for sorting the gecko codes alphabetically to the gecko code menu
 2018-05-20 11:13:38 +02:00
Léo Lam eae45e0e2c Merge pull request #6911 from lioncash/analyst 
PPCAnalyst: Replace memset usages with list initialization
 2018-05-20 10:45:44 +02:00
Léo Lam 464bfb073e Merge pull request #6912 from spycrab/qt_jit_widget 
Qt/JITWidget: Add object name
 2018-05-20 10:44:21 +02:00
Léo Lam 9387b7dd32 Merge pull request #6910 from lioncash/analyst 
PPCAnalyst: Clean up indexing expressions in Analyze()
 2018-05-19 23:25:59 +02:00
Léo Lam c6bd237534 Merge pull request #6908 from Tilka/warnings 
Fix -Wignored-qualifiers warnings
 2018-05-19 21:06:29 +02:00
Léo Lam 9ec557761d Merge pull request #6909 from spycrab/qt_gfx_progscan 
Qt/AdvancedWidget: Save progressive scan when toggled
 2018-05-19 21:05:52 +02:00
Léo Lam e54880e9f3 Merge pull request #6903 from spycrab/qt_toolbar 
Qt/ToolBar: Fix checkbox not properly reflecting toolbar visibility
 2018-05-19 17:19:06 +02:00
Léo Lam fc525bdf8f Merge pull request #6898 from leoetlino/certreader 
ES/Formats: Deduplicate signed blob reading code
 2018-05-19 12:11:02 +02:00
Léo Lam d399b0f59e Merge pull request #6900 from lioncash/buffer 
PPCAnalyst: Make CodeBuffer an alias for std::vector<CodeOp>
 2018-05-19 12:10:19 +02:00
Léo Lam 33c5fd6f5a IOSC: Verify that RSA signature size is correct 2018-05-18 23:12:07 +02:00
Léo Lam 964d00447d IOSC: Reuse CertReader for cert imports 2018-05-18 23:12:07 +02:00
Léo Lam 90e86fa9a6 ES/Formats: Move sha1 calculation to SignedBlobReader 2018-05-18 22:40:38 +02:00
Léo Lam fbf79f837f Merge pull request #6896 from leoetlino/title-import 
ES: Fix content check in ImportTitleDone
 2018-05-18 22:38:55 +02:00
Léo Lam 69a6724b34 Merge pull request #6897 from lioncash/sw-efb 
EfbInterface: Minor changes
 2018-05-18 22:38:00 +02:00
Léo Lam 8af0f1bfc5 Merge pull request #6899 from lioncash/mem 
MMU: Use Common::BitCast where applicable
 2018-05-18 22:18:48 +02:00
Léo Lam f82e2f0b92 ES: Fix content check in ImportTitleDone 
ImportTitleDone only checks if all required contents have been imported
for system titles.

This fixes the system menu not being able to recreate title directories
to copy a save back to the NAND by using title import functionality.
 2018-05-18 20:59:33 +02:00
Léo Lam 473cbfa951 ES: Add more logging in title import functions 
...to make troubleshooting easier.
 2018-05-18 20:59:29 +02:00
Léo Lam bb2c3bd572 Merge pull request #6894 from lioncash/mem 
BPMemory: Use Common::BitCast where applicable
 2018-05-18 20:35:18 +02:00
Léo Lam 49c9c1ee40 Merge pull request #6853 from aldelaro5/qt-debugger-hotkey-fixes 
Qt debugger hotkey fixes
 2018-05-18 19:06:17 +02:00
Léo Lam 47fd8c6eff Merge pull request #6855 from aldelaro5/qt-render-min-width 
Qt: allow to resize the render widget however wanted on render to main
 2018-05-16 14:11:51 +02:00
Léo Lam 4de2c5040d Merge pull request #6867 from jackoalan/code-view-bg 
Qt/CodeViewWidget: Dynamic background dimming for dark themes
 2018-05-16 14:08:02 +02:00
Léo Lam 9335400f65 Merge pull request #6862 from aldelaro5/qt-unify-pause-play 
Qt: make the pause play button only one button
 2018-05-16 14:07:35 +02:00
Léo Lam 159f6115e2 Merge pull request #6851 from lioncash/usage 
BreakpointWidget: Move variables closer to usage sites in OnLoad()
 2018-05-14 19:18:05 +02:00
Léo Lam b5761f9dc7 Merge pull request #6852 from lioncash/code 
CodeViewWidget: Minor changes
 2018-05-14 19:17:35 +02:00
Léo Lam 5b15060127 Merge pull request #6857 from spycrab/qt_minor_win 
Qt: Minor window fixes
 2018-05-14 19:11:56 +02:00
Léo Lam f8e5e7126c Merge pull request #6849 from leoetlino/oops 
WiiSave: Fix out-of-bounds read
 2018-05-13 23:34:32 +02:00
Léo Lam 345838d517 Merge pull request #6842 from spycrab/qt_map_apply 
Qt/Mapping: Fix mapping changes not being applied instantly
 2018-05-13 23:34:18 +02:00
Léo Lam 3fbfa4335e WiiSave: Fix out-of-bounds read 
Fixes the count argument for WriteArray. (I used it like WriteBytes.)
Whoops.
 2018-05-13 23:18:28 +02:00
Léo Lam 2be8c35d6d Merge pull request #6844 from leoetlino/wii-save-cleanup2 
WiiSave: Reuse IOS services where possible
 2018-05-13 23:08:28 +02:00
Léo Lam 8f44423a5b Merge pull request #6846 from spycrab/qt_native_sep 
Qt: Use native dir separators
 2018-05-13 22:10:10 +02:00
Léo Lam 6c38e4b47f Merge pull request #6847 from lioncash/fs-include 
FilesystemWidget: Replace DiscIO includes with forward declarations
 2018-05-13 22:08:09 +02:00
Léo Lam 1fe92b8be7 Merge pull request #6845 from lioncash/patch-dlg 
NewPatchDialog/PatchesWidget: Use forward declarations where applicable
 2018-05-13 22:00:43 +02:00
Léo Lam 07b57c7ac6 Merge pull request #6843 from lioncash/patch 
PatchEngine: Minor changes
 2018-05-13 21:58:55 +02:00
Léo Lam b405a1fbb1 WiiSave: Reuse ES::GetInstalledTitles 
Same thing, less code, no manual FS access.
 2018-05-13 21:28:35 +02:00
Léo Lam a2ffe010f3 WiiSave: Reuse IOSC::Sign for signing 2018-05-13 21:28:35 +02:00
Léo Lam 07caac1d23 WiiSave: Reuse IOSC for AES decryption/encryption 
The SD key is already in IOSC.

This also prevents WiiSave from exposing an external library as part
of its interface.
 2018-05-13 21:25:58 +02:00
Léo Lam e67cbd462b Merge pull request #6841 from spycrab/qt_fix_rtmfocus 
Qt/RenderWidget: Fix render-to-main focus
 2018-05-13 21:16:26 +02:00
Léo Lam 9d1157f695 Merge pull request #6839 from spycrab/qt_start_top 
Qt: Fix render widget not being on top when using -n / -e
 2018-05-13 18:20:00 +02:00
Léo Lam e828c243f3 Merge pull request #6836 from leoetlino/wii-save-cleanup 
WiiSave: (not so) Minor cleanup
 2018-05-13 18:19:22 +02:00
Léo Lam 80b3d7ccb8 WiiSave: Allow users to specify export directory 
Export and ExportAll now open a directory picker (that defaults to the
previous default directory, i.e. the Dolphin user dir).

Also removes the need to return the path in the export functions since
the user knows which path they chose.
 2018-05-13 17:42:56 +02:00
Léo Lam 87e5cd73dc WiiSave: Use std::array instead of C arrays 
Makes copying, comparing more readable
 2018-05-13 17:42:55 +02:00
Léo Lam a93d816c28 WiiSave: Move dialogs to UI code 
This moves the result dialogs to DolphinQt2, since WiiSave should not
really be responsible for interacting with the user as a simple
Wii save importing/exporting class.

This also fixes Wii save import/export showing result dialogs twice,
once from WiiSave, and another time from DolphinQt2.
 2018-05-13 17:42:55 +02:00
Léo Lam 41c4486c65 WiiSave: Clean up constructors 
Move the import/export operation into separate functions, as it doesn't
really make sense for the constructor to do *everything*, including
printing success/failure message boxes.

The existing constructor was split into two: one that takes a path,
and another taking a title ID. This makes it more obvious what is
actually done when a path/TID is passed and also clarifies what
parameters should be passed. (No more magic 0 or "" value.)
 2018-05-13 17:42:55 +02:00
Léo Lam fbf36b85d2 WiiSave: Remove unused Extract() member function 2018-05-13 17:42:55 +02:00
Léo Lam 956df21bd7 WiiSave: Use Common::BigEndianValue to simplify parsing 
Gets rid of the need to manually cast when reading/writing, which is
error prone and repetitive.
 2018-05-13 17:42:55 +02:00
Léo Lam fb39efbf90 WiiSave: Fix struct member naming 2018-05-13 17:42:55 +02:00
Léo Lam bae8bcde0a WiiSave: Do not expose internal constants 2018-05-13 17:42:55 +02:00
Léo Lam 00bc1f28f2 Rename CWiiSaveCrypted to WiiSave 2018-05-13 17:42:55 +02:00
Léo Lam 5564150dd6 Merge pull request #6833 from leoetlino/dns 
Use resolver to get default DNS nameserver
 2018-05-13 15:49:50 +02:00
Léo Lam 99dff10d43 Merge pull request #6837 from spycrab/qt_position 
Qt/RenderWidget: Save position and size using QSettings
 2018-05-13 11:47:04 +02:00
Léo Lam 66c1b909c2 Merge pull request #6765 from aldelaro5/Qt-debugger-fixes 
Qt/debugger: fix a bunch of things
 2018-05-13 01:20:11 +02:00
Léo Lam ad5a69be79 Merge pull request #6826 from spycrab/qt_netplay2 
Qt/NetPlayDialog: Improve player list
 2018-05-13 01:17:51 +02:00
Léo Lam ecfb9d6691 Merge pull request #6835 from lioncash/move 
Boot: Make BootExecutableReader's constructor take a std::vector by value
 2018-05-12 23:52:30 +02:00
Léo Lam 48fa835bd3 WiiRoot: Copy initial NAND files with proper metadata 2018-05-12 22:54:34 +02:00
Léo Lam f91b729b61 Merge pull request #6825 from leoetlino/onion-types 
Config: Fix implicit conversions/enum config types
 2018-05-12 21:59:43 +02:00
Léo Lam e1169ef9ee Merge pull request #6824 from aldelaro5/custom-rtc-no-bias 
RTC: Write 0 to the counter bias if we are on custom RTC
 2018-05-12 21:59:13 +02:00
Léo Lam 037040c7a0 Data: Remove /shared2/{ec,succession} 
These are created by the ECDK library (used in the Wii Shop Channel
for example) on first use. There's no need to provide dummy files.
 2018-05-12 18:59:22 +02:00
Léo Lam 6763a3fce1 Config: Add support for enums 
This makes it possible to use enums as the config type.
Default values are now clearer and there's no need for casts
when calling Config::Get/Set anymore.

In order to add support for enums, the common code was updated to
handle enums by using the underlying type when loading/saving settings.

A copy constructor is also provided for conversions from
`ConfigInfo<Enum>` to `ConfigInfo<underlying_type<Enum>>`
so that enum settings can still easily work with code that doesn't care
about the actual enum values (like Graphics{Choice,Radio} in DolphinQt2
which only treat the setting as an integer).
 2018-05-12 18:10:26 +02:00
Léo Lam 94dc746351 Copy Wii NAND data to user NAND in WiiRoot 
Dolphin doesn't use any of the WC24 files, so this can be done when
actually starting emulation in WiiRoot. The benefit of moving the
copy is that we don't need to handle temporary NANDs in a special way.
 2018-05-12 17:08:50 +02:00
Léo Lam 5f567b38fe WiiRoot: Move content manipulation to separate functions 
{Initialize,Shutdown}WiiRoot should only be responsible for setting the
SESSION_WII_ROOT or managing the temporary NAND directory.

Move all the content manipulation out of these functions to ensure
separation of concerns and call them after/before WiiRoot init/shutdown
to make sure they operate on the correct root.
 2018-05-12 17:06:31 +02:00
Léo Lam 7dca7c237e Config: Fix template deduction for implicit conversions 
This excludes the second argument from template deduction.

Otherwise, it is required to manually cast the second argument to
the ConfigInfo type (because implicit conversions won't work).

e.g. to set the value for a ConfigInfo<std::string> from a string
literal, you'd need a ugly `std::string("yourstring")`.
 2018-05-12 14:30:18 +02:00
Léo Lam e78235943e Merge pull request #6823 from spycrab/qt_reset_hotkey 
Qt: Implement "Reset" hotkey
 2018-05-12 13:12:24 +02:00
Léo Lam a712cfe339 Merge pull request #6624 from spycrab/qt_dbg_jit 
Qt/Debugger: Implement "JIT" widget
 2018-05-12 13:02:47 +02:00
Léo Lam 85e3e6153b Merge pull request #6821 from lioncash/file 
FileUtil: Remove unnecessary IOFile GetHandle() call in ReadFileToString()
 2018-05-12 12:45:44 +02:00
Léo Lam e942b14676 Merge pull request #6817 from spycrab/qt_hotkey_onion 
Qt/HotkeyScheduler: Use onion config
 2018-05-11 21:01:56 +02:00
Léo Lam 1b070c4b6f IOS/KD: Migrate to new filesystem interface 2018-05-11 20:30:22 +02:00
Léo Lam b10bbea393 Merge pull request #6815 from spycrab/osd_refactor 
VideoCommon/RenderBase: Refactor OSD messages
 2018-05-11 18:33:45 +02:00
Léo Lam e1866d35e5 Merge pull request #6807 from leoetlino/boot 
Boot: Migrate to new filesystem interface
 2018-05-11 10:41:00 +02:00
Léo Lam 5071973a51 Merge pull request #6805 from spycrab/qt_netplay 
Qt/NetPlayDialog: Multiple improvements
 2018-05-11 10:39:53 +02:00
Léo Lam d1bb5249ec Merge pull request #6801 from stenzek/copy-filter-typo 
D3D/Vulkan: Fix incorrect clamp in EFB RAM copy
 2018-05-11 10:36:47 +02:00
Léo Lam 066e4ea463 Merge pull request #6809 from lioncash/macro 
CommonFuncs: Convert ROUND_UP_POW2 macro to a function
 2018-05-11 10:16:29 +02:00
Léo Lam a977a56434 Boot: Migrate to new filesystem interface 2018-05-10 22:34:03 +02:00
Léo Lam e6c489f1d4 ES: Move title dir creation logic into separate function 
Since we're going to need it in the boot code, move it out to a
separate, easily reusable function. This also makes the InitImport
logic clearer.
 2018-05-10 22:33:49 +02:00
Léo Lam 722d31124c SettingsHandler: Fix const correctness 2018-05-10 21:35:27 +02:00
Léo Lam 09d2afa91f SettingsHandler: Migrate to new filesystem interface 
Change SettingsHandler to take a buffer instead of assuming that the
setting file to read is always on the host filesystem for more
flexibility and make it possible to use the new filesystem interface.
 2018-05-10 21:35:27 +02:00
Léo Lam d8e1d2d573 Merge pull request #6803 from lioncash/tidy 
FloatUtils: Remove IntDouble and IntFloat
 2018-05-10 19:04:49 +02:00
Léo Lam 28915049b5 Merge pull request #6797 from leoetlino/uid 
Move all UID constants to a single file
 2018-05-10 18:16:04 +02:00
Léo Lam 02e313050e Merge pull request #6800 from spycrab/qt_win32_weight 
Qt/Win32: Fix font weight calculation
 2018-05-10 18:15:38 +02:00