Tillmann Karras
ce85da6b96
DSPHLE/Zelda: prevent out-of-bounds stack read
...
Reported by @RickdeJager.
2026-08-09 15:56:21 +01:00
Tilka
8328469f5e
Merge pull request #14694 from JoshuaVandaele/fmt12.2
...
fmt: Allow building with version >=12.2.0
2026-06-23 21:13:02 +01:00
Tilka
f96a7682d4
Merge pull request #14680 from Tilka/fs_null_fix
...
DolphinTool: fix crash when listing partition without filesystem
2026-06-13 19:01:57 +01:00
Tillmann Karras
9463c9717f
GameSettings: fix pony not showing up in Pony Friends 2
...
EFB-to-RAM needs to be enabled at the start of grooming.
2026-06-13 18:55:16 +01:00
Tillmann Karras
37a3b0fe6a
DolphinTool: fix crash when listing partition without filesystem
...
We were also passing the wrong partition name.
2026-06-13 17:39:08 +01:00
Tilka
9e7d340f22
Merge pull request #14664 from JosJuice/zelda-apply-reverb-uninitialized
...
Fix uninitialized variable warning in ZeldaAudioRenderer::ApplyReverb
2026-05-29 22:23:00 +01:00
Tillmann Karras
4618e4bb40
IOS/Network: reduce log verbosity of SO_EAGAIN to info level
...
Otherwise IOCTL_SO_ACCEPT is very noisy until a client connects.
2026-05-15 23:01:27 +01:00
Tillmann Karras
f06aef4f83
Improve NAND import progress dialog
...
Now with cancel button and an actual progress bar. For simplicity, we do
two passes on the progress bar, one for loading the NAND into memory and
one for extracting it. The user directory is likely on an SSD, making
the extraction pass invisibly fast.
2026-04-04 22:02:45 +01:00
Tillmann Karras
51e488e84a
VideoCommon: ignore zero-stride EFB/XFB copies
...
just clear if requested
2026-03-28 03:05:08 +00:00
Tillmann Karras
de214d74c3
GameSettings: improve We Cheer and We Cheer 2 default settings
...
Also use lowercase 'ini' file extension.
2026-01-06 22:30:44 +00:00
Tillmann Karras
c52dd23c58
GekkoDisassembler: drop unsupported opcodes
2025-12-12 01:37:19 +00:00
Tillmann Karras
df7caeab3f
GekkoDisassembler: fix ps_sel operands
2025-12-12 01:14:16 +00:00
Tillmann Karras
1c157d1fc8
GekkoDisassembler: fix conditional twi opcode
2025-12-12 01:14:09 +00:00
Tillmann Karras
1380555116
Revert "GameSettings: Force DSP LLE in NFL Blitz Pro to avoid terrible sounding audio."
...
This reverts commit b7f3d96df4 .
2025-11-27 00:08:37 +00:00
Tillmann Karras
07ef12eecc
AX: fix signedness of second low-pass filter coefficient
...
This fixes NFL Blitz Pro.
2025-11-27 00:08:11 +00:00
Tillmann Karras
9396f0f58e
GameSettings: clean up texture filtering settings
...
`MaxAnisotropy = 0` is no longer the safest setting because it forces 1x
even if the game asks for more.
`ForceFiltering` was replaced by `ForceTextureFiltering` in
afe9d5b098 . The one remaining occurrence
was merged later.
`ForceTextureFiltering` is an int option and shouldn't be set to False.
Just Dance 3, Just Dance: Best of, and Just Dance: Greatest Hits look
fine on AMD GPUs without manual texture sampling. On Nvidia GPUs they
have a single stripe that I think doesn't warrant forcing manual texture
sampling for everyone.
The NES games I tried worked fine with anisotropic filtering, it just
doesn't do anything.
Various games don't actually have any issue with anisotropic filtering
as long as it's not forced. The only game I could find that actually
requires the default aniso setting is Spider-Man: Shattered Dimensions.
Boogie SuperStar works fine with any texture filtering setting.
2025-08-31 01:03:23 +01:00
Tilka
033a0540f7
Merge pull request #13899 from SuperSamus/patch-cheats-osd
...
PatchEngine: OSD message showing number of enabled patches and cheats
2025-08-31 00:27:23 +01:00
Tilka
76c114a02b
Merge pull request #13910 from Tilka/ub
...
Fix some undefined behavior
2025-08-30 06:17:45 +01:00
Tillmann Karras
c248f1afa4
IOS/WD: fix wrong BitSet ctor being called
...
We don't want list initialization here.
Thank you, UB-san.
2025-08-30 03:05:35 +01:00
Tillmann Karras
63257d1ee9
CoreTiming: set default overclock factors to 1.0
...
I'm not aware of any issue here but let's set meaningful defaults
anyway.
2025-08-30 03:05:35 +01:00
Tillmann Karras
18f0bd1d4b
VI: set default overclock factor to 1.0
...
GetTicksPerHalfLine() gets called via Preset() before RefreshConfig()
has a chance to replace the dummy value 0.0.
Thank you, UB-san.
2025-08-30 03:03:21 +01:00
Tilka
2ff3a7215b
Merge pull request #13902 from Tilka/fix_color_clamp
...
VideoSW: fix clamping after vertex color interpolation
2025-08-30 03:02:42 +01:00
Tilka
b47a75fa2d
Merge pull request #13912 from jordan-woyak/simplify-saturating-cast
...
MathUtil: Simplify SaturatingCast implementation and fix edge case.
2025-08-30 03:00:15 +01:00
Tilka
25be1cfe97
Merge pull request #13911 from Dentomologist/gamelist_gridview_sorting
...
GameList: Use List View's sorting for Grid View
2025-08-30 02:56:18 +01:00
Tillmann Karras
bc417bdcee
VideoSW: fix clamping after vertex color interpolation
2025-08-24 02:47:56 +01:00
Tilka
7782e32d9e
Merge pull request #13901 from iwubcode/render_state_rename
...
VideoBackends / VideoCommon: rename member variables in RenderState
2025-08-23 20:56:47 +01:00
Tilka
ab8a02566d
Merge pull request #13893 from TryTwo/PR_Slider_Fixes
...
Qt: Prevent QSlider's QLabels from resizing.
2025-08-23 12:44:17 +01:00
Tilka
50d3a5510c
Merge pull request #13898 from SuperSamus/patch-invalidate-cache-fixup
...
ActionReplay: Fixup #13764
2025-08-23 12:20:25 +01:00
Tilka
a1423e386c
Merge pull request #13896 from Tilka/mismatched_tags
...
VideoCommon: fix -Wmismatched-tags warning
2025-08-23 04:04:01 +01:00
Tillmann Karras
10d0bc66b3
VideoCommon: fix -Wmismatched-tags warning
2025-08-23 03:05:04 +01:00
Tillmann Karras
30017632dd
FIFOAnalyzer: fix command description updates
...
When dragging the selection, the mismatch between signal
(itemSelectionChanged) and data consumed (currentRow) seemed to cause
the description to lag behind by one row.
2025-08-22 02:02:28 +01:00
Tilka
90a137ffdc
Merge pull request #13888 from Sintendo/unused-psg
...
VideoCommon: Remove unused EnumMaps from PixelShaderGen
2025-08-20 23:03:54 +01:00
Tilka
be6a6bce9f
Merge pull request #13873 from Dentomologist/dolphinanalytics_use_pascal_case_for_gamequirk_enum
...
DolphinAnalytics: Use Pascal case for GameQuirk enum
2025-08-19 21:57:34 +01:00
Tilka
2696e053ea
Merge pull request #13887 from Tilka/unused_sign_bit
...
Jit64: drop unused constant
2025-08-19 19:40:49 +01:00
Tillmann Karras
84b5a73b2a
Jit64: drop unused constant
...
Unused since c4799e5977 .
2025-08-18 23:09:37 +01:00
Tilka
8701944dd1
Merge pull request #13883 from Dentomologist/fifoplayerwindow_geometry_fixes
...
FIFOPlayerWindow geometry fixes
2025-08-18 20:23:24 +01:00
Tillmann Karras
37758fa290
OpcodeDecoder: provide default GetVertexSize() implementation
2025-08-18 01:41:14 +01:00
Tilka
ab1f75b4d6
Merge pull request #13853 from LillyJadeKatrin/retroachievements-patch-fix
...
Fixed Patch Allowlist Check
2025-08-17 10:25:30 +01:00
Tilka
72ef27c157
Merge pull request #13861 from Tilka/unused_lambda_captures
...
DolphinQt: fix two -Wunused-lambda-capture warnings
2025-08-10 20:26:32 +01:00
Tillmann Karras
f04c2799dd
VideoSW: fix comment
2025-08-10 19:37:21 +01:00
Tillmann Karras
df3dc80190
DolphinQt: fix two -Wunused-lambda-capture warnings
2025-08-10 19:37:21 +01:00
Tilka
ba656e641e
Merge pull request #13854 from dreamsyntax/fix-regression-callers-broken
...
PPCSymbolDB: Fix callers not updating
2025-08-10 19:13:29 +01:00
Tilka
e099a9c180
Merge pull request #13838 from Tilka/videosw2
...
VideoSW: reuse Common::Vec2/3/4
2025-08-10 08:26:02 +01:00
Tilka
4fc3106761
Merge pull request #13859 from Tilka/root_path_assert
...
IOS/FS: add safety assert
2025-08-10 05:29:05 +01:00
Tillmann Karras
fa4127b145
VideoSW: reuse Common::Vec2/3/4
2025-08-10 05:17:26 +01:00
Tilka
a07974e2c3
Merge pull request #13846 from JoshuaVandaele/better-xcb
...
Qt: Better wayland detection to enforce xcb
2025-08-10 05:09:25 +01:00
Tilka
5a6c5e2639
Merge pull request #13787 from jordan-woyak/game-config-highlighter-fix
...
DolphinQt: Make GameConfigHighlighter better handle large files.
2025-08-10 05:02:21 +01:00
Tillmann Karras
ec8b8bdb8d
IOS/FS: add safety assert
...
This is to prevent someone (me) from accidentally deleting their entire
/tmp directory just by not initializing the config system correctly.
2025-08-10 04:58:57 +01:00
Tillmann Karras
9ff5943ac6
VideoSW: allow disabling the copy filter
2025-07-31 15:51:51 +01:00
Tilka
812c6c2ea4
Merge pull request #13830 from CrossVR/broken-depth-clamp-control
...
DriverDetails: Disable depth_clamp_control on official AMD drivers
2025-07-31 01:06:00 +01:00
Tilka
d6a4421386
Merge pull request #13835 from Tilka/unused_xf_enumerators
...
VideoCommon: drop unused XF enumerators
2025-07-30 20:31:56 +01:00
Tillmann Karras
cc71401e29
VideoCommon: drop unused XF enumerators
...
We handle all six registers (scale/offset * xyz) via the viewport name.
Keeping around unused enumerators only for the z component is confusing.
2025-07-30 19:56:30 +01:00
Tilka
131ca1ba9b
Merge pull request #13786 from JosJuice/symboldb-locking
...
PPCSymbolDB: Improve locking
2025-07-30 17:15:28 +01:00
Tilka
cd142aa18d
Merge pull request #13834 from AGuy27/master
...
GameINI: Disable ImmediateXFB for Pétanque Master
2025-07-30 13:33:10 +01:00
Tilka
4d0cf1315e
Merge pull request #13832 from Tilka/docs_dsp
...
docs/DSP: fix some bit pattern inconsistencies
2025-07-28 01:10:35 +01:00
Tillmann Karras
288da38dc3
docs/DSP: fix some bit pattern inconsistencies
...
Thanks to @Oaisus who reported this.
2025-07-27 14:22:10 +01:00
Tilka
79a3af2e6e
Merge pull request #13805 from SuperSamus/vulkan-present-sempahore-reuse-fix
...
Vulkan: Fix present semaphores reuse
2025-07-22 03:03:04 +01:00
Tilka
dccd8709d8
Merge pull request #13803 from JoshuaVandaele/msgmerge-sort
...
Translation: Remove deprecated --sorted-output/-s option
2025-07-20 17:40:02 +01:00
Tilka
5cc0a5a3be
Merge pull request #13816 from Tilka/fix_di_init
...
WII_IPC: fix homebrew that uses the disc drive
2025-07-19 20:13:18 +01:00
Tillmann Karras
6a55a1bf68
WII_IPC: fix homebrew that uses the disc drive
...
Dolphin never emulated the AHBPROT register before, but the default
value when reading from unimplemented MMIO registers used to be -1,
which happened to match what AHBPROT reads as when all restrictions are
disabled. In 6f25e20c6a I changed the
default to 0 to match observed hardware behavior in the memory range of
the command processor. This broke libogc's DI_Init() which checks
AHBPROT for full hardware access (presumably to ensure that bypassing
IPC for Video DVDs will work).
2025-07-19 16:42:15 +01:00
Tillmann Karras
fe6fd2279c
WiiSaveBanner: fall back to $userdir/Load/WiiBanners
...
Unlike custom banners which work as an override, this mechanism works as
a fallback. The use case is if you have games you don't really play but
want to keep around for testing purposes without filling up your NAND
with lots of saves. For ease of use, the directory structure is the same
but only title/$title_hi/$title_lo/data/banner.bin files are
relevant.
2025-07-04 23:15:50 +01:00
Tillmann Karras
59d2611a94
VideoCommon: remove unused struct fields
2025-06-24 19:38:45 +01:00
Tillmann Karras
ca004e35f7
GameSettings: add performance hack for Baby And Me
...
The patch is not enabled by default.
2025-06-16 20:08:36 +01:00
Tillmann Karras
c39b067479
GameSettings: don't force EFB-to-tex for Fireblade
...
This ini is from the initial mega commit. The game seems to work fine
without it.
2025-06-16 19:48:31 +01:00
Tillmann Karras
58b86074ae
GameSettings: fix purple flickering in Trivial Pursuit - Bet You Know It
2025-06-16 19:48:31 +01:00
Tillmann Karras
cc5933a6ce
GameSettings: fix purple screen in The Price Is Right
2025-06-16 19:48:31 +01:00
Tilka
19fbbf0dba
Merge pull request #13727 from JoshuaVandaele/fmt-11.2.0-localtime-deprec
...
fmt: Replace deprecated `fmt::localtime` usage with `Common::LocalTime`
2025-06-08 04:04:37 +01:00
Tillmann Karras
61e8fa060b
QtUtils/ImageConverter: simplify
2025-06-07 23:06:07 +01:00
Tillmann Karras
b6ff1b5573
GameSettings: add bean menu patch for A Boy and His Blob
...
The bean menu in this game does not react when the analog control stick
is moved perfectly to the right (0 degress). This happens when the
analog stick is mapped to digital inputs.
Currently, Dolphin contains a hardcoded controller hack to work around
this issue. With this patch, it should no longer be needed; see #13177 .
2025-06-07 23:01:17 +01:00
Tillmann Karras
2849173984
GameSettings: auto-disable immediate XFB for Dokapon Kingdom
...
This avoids flickering throughout the game.
2025-06-01 03:06:35 +01:00
Tillmann Karras
6315527d21
GameSettings: disable efb2tex for two Cabela's games
2025-05-15 22:45:36 +01:00
Tillmann Karras
a8fb4153d7
AchievementManager: fix -Wpessimizing-move warning
2025-05-08 00:15:17 +01:00
Tillmann Karras
6f25e20c6a
VideoCommon: reset some CP registers during PI_FIFO_RESET
...
This fixes the shutdown error in SpongeBob Globs of Doom.
2025-05-05 21:18:37 +01:00
Tilka
8ee64a84c7
Merge pull request #13590 from tygyh/UCodes-Remove-redundant-qualifiers
...
UCodes: Remove redundant qualifiers
2025-04-26 16:23:27 +01:00
Tilka
805307f432
Merge pull request #13451 from vyuuui/numeric_labels
...
Add numeric label support to assembler
2025-04-25 01:56:43 +01:00
Tilka
fe307a06c6
Merge pull request #13476 from jordan-woyak/sdl-header
...
InputCommon: Move SDL Device class into its own cpp/h files.
2025-04-25 01:49:52 +01:00
Tilka
a95779add0
Merge pull request #13506 from JosJuice/android-time-played
...
Android: Show time played in game details
2025-04-25 01:43:53 +01:00
Tilka
5523b9a01b
Merge pull request #13487 from Dentomologist/performancemetrics_fix_window_arrangement
...
PerformanceMetrics: Fix window arrangement
2025-04-25 01:40:58 +01:00
Tilka
50026ab795
Merge pull request #13497 from hoogmin/modernize_fs_path
...
Core/Common/FileUtil.cpp: Use std path utility for automatic path separator handling.
2025-04-25 01:38:35 +01:00
Tillmann Karras
a6290caa2e
DSPHLE: set accelerator gain
2025-04-25 01:09:15 +01:00
Tillmann Karras
80adfc606d
docs/DSP: Rename SCALE to PRED_SCALE
2025-04-25 01:09:15 +01:00
Tillmann Karras
8412a7c336
DSPAccelerator: update comment (NFC)
2025-04-25 01:09:15 +01:00
Tillmann Karras
f0bacb826a
DSPAccelerator: rename MMIOPCMHalt to MMIOPCMNoInc
2025-04-25 01:09:15 +01:00
Tillmann Karras
7c7c179b44
DSP tests: update DSP MMIO labels
2025-04-25 00:51:46 +01:00
Tillmann Karras
6c870860ea
DSP tests: clean up unused code
2025-04-25 00:51:46 +01:00
Tillmann Karras
05381c5b6d
Address Pokechu22's feedback
2025-04-25 00:51:46 +01:00
Tillmann Karras
4d9dc1e1cd
GekkoDisassembler: standardize SPR names and add missing ones
2025-04-25 00:24:12 +01:00
Tilka
c4f65febf3
Merge pull request #13563 from Tilka/rcheevos
...
Fix building with USE_RETRO_ACHIEVEMENTS=OFF
2025-04-23 03:27:15 +01:00
Tilka
871073eee2
Merge pull request #13564 from jordan-woyak/triforce_ipl-warning
...
Core/Boot: Fix unused variable warning.
2025-04-23 03:26:48 +01:00
Tillmann Karras
609165b62b
Fix building with USE_RETRO_ACHIEVEMENTS=OFF
2025-04-22 23:45:40 +01:00
Tillmann Karras
f6d3f448d9
IOS/Network: fix -Wmissing-braces warnings
2025-04-22 23:36:01 +01:00
Tilka
7e7b75c1e6
Merge pull request #13537 from tygyh/DiscIO-Make-variables-constexpr
...
DiscIO: Make variables constexpr
2025-04-21 00:52:18 +01:00
Tilka
9504916f72
Merge pull request #13538 from tygyh/DiscIO-Use-default-to-define-a-trivial-destructor
...
DiscIO: Use `= default` to define a trivial destructor
2025-04-20 22:32:12 +01:00
Tilka
0a52140145
Merge pull request #13549 from shuffle2/ucrtpatch
...
remove ucrt compat patches
2025-04-20 22:24:57 +01:00
Tilka
45ed4b2be9
Merge pull request #13541 from tygyh/DiscIO-Remove-redundant-zero-initializers-in-aggregate-initializations
...
DiscIO: Remove redundant zero initializers in aggregate initializations
2025-04-20 22:07:58 +01:00
Tilka
2adf3449f3
Merge pull request #13548 from shuffle2/http
...
HttpRequest: remove some legacy code for windows < 8.1
2025-04-20 22:07:32 +01:00
Tilka
c705e366f0
Merge pull request #13478 from jordan-woyak/metal-af
...
VideoBackends/Metal: Fix anisotropic filtering handling.
2025-04-02 09:07:44 +01:00
Tillmann Karras
7e57834691
GameSettings: fix startup hang in Moki Moki
...
The game sets up a fifo breakpoint callback that just writes a flag to
memory. The hang occurs right after calling GXEnableBreakPt(). It is a
busy loop that repeatedly compares the same register without reloading
it from memory. I guess the developers forgot to make the variable
atomic and never noticed because on hardware the breakpoint is hit
immediately so the flag is already set when it is loaded for the first
(and only) time. This patch grows the loop by one instruction to include
the flag load in the loop.
2025-03-30 00:48:22 +00:00
Tilka
662cfa38c2
Merge pull request #13460 from jordan-woyak/play-time-tracker-thread-name
...
Core: Name the play time tracker thread.
2025-03-27 17:02:36 +00:00
Tillmann Karras
5a708f0f24
GameSettings: fix startup crash in "The Daring Game for Girls"
2025-03-23 23:28:22 +00:00