Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
41,106 Commits 1 Branch 0 Tags
79c84c98edd0ede5897378577f18835f69e9d434
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash 79c84c98ed WC24PatchEngine: Resolve -Wshadow warning 
While not captured, we're definitely shadowing the result variable
outside the lambda.
 2023-12-12 17:03:42 -05:00
Lioncash 81d5370141 HLE_OS: Resolve -Wshadow warnings 
We get a warning about shadowing the va_list type and just
run-of-the-mill variable shadowing, which we can easily fix.
 2023-12-12 17:01:32 -05:00
Lioncash a812a1f938 LightingShaderGen: Resolve -Wshadow warnings 
Given how the lambda doesn't capture anything, we can move this to a
internally linked function, which prevents any name shadowing.
 2023-12-12 16:55:06 -05:00
Lioncash b0b1308160 PPCDebugInterface: Silence trivial -Wmaybe-uninitialized warning 
We can just initialize register_index, even if it gets overwritten later
on via Common::FromChars.
 2023-12-12 15:42:28 -05:00
Lioncash 18032f19a5 AchievementManager: Resolve -Wshadow warnings 
Renames some variables to avoid shadowing warnings on gcc.

Also gets rid of a FilereaderState struct, since one is already defined
in the declaration of the AchievementManager class.
 2023-12-12 15:37:20 -05:00
Lioncash ded2d55438 ExpressionParser: Avoid some miscellaneous copies 
Just some trivial copies that can be eliminated or turned into moves.
 2023-12-12 14:03:41 -05:00
Lioncash a5bbeb721a ExpressionParser: Mark constructors explicit where applicable 
Makes for consistency with the surrounding code.
 2023-12-12 14:00:27 -05:00
Lioncash ea71a76ea9 ExpressionParser: Pass control qualifiers by const reference 
These aren't necessarily cheap to copy, since a control qualifier will
have around 3 std::strings inside of it, so passing by value can churn
allocations a little bit.
 2023-12-12 13:50:46 -05:00
Lioncash 9aea481e59 ExpressionParser: Make use of std::erase_if 2023-12-12 13:31:58 -05:00
Lioncash 196f8e5123 MappingCommon: Make use of std::erase_if 2023-12-12 13:31:18 -05:00
Lioncash 888a8692b4 SysConf: Make use of std::erase_if 2023-12-12 13:30:39 -05:00
Lioncash 01d15994fe PatchEngine: Make use of std::erase 2023-12-12 13:30:08 -05:00
Lioncash e69ac2d43e Socket: Make use of std::erase_if 2023-12-12 13:29:33 -05:00
Lioncash 96eac73d11 NetKDRequest: Make use of std::erase 2023-12-12 13:27:54 -05:00
Lioncash e7f7dde546 Formats: Make use of std::erase_if 2023-12-12 13:27:17 -05:00
Lioncash df227aa03c I2CBus: Make use of std::erase_if 2023-12-12 13:26:47 -05:00
Lioncash ff0e7fbf08 GeckoCodeConfig: Make use of std::erase_if 2023-12-12 13:26:16 -05:00
Lioncash 84ae0c1c7e ActionReplay: Make use of std::erase_if 2023-12-12 13:25:26 -05:00
Lioncash 50e4dc5dba Watches: Make use of std::erase_if 2023-12-12 13:24:40 -05:00
Lioncash b728e37086 RiivolutionParser: Remove usages of global system accessor 
We can retrieve the encompassing system instance through the
CPUThreadGuard instance instead.
 2023-12-12 12:48:40 -05:00
Lioncash c2e39e0d68 RiivolutionParser: Make use of std::span where applicable 
The main interface for these only take in patches and iterate over them
in a contiguous sequence, so we can reasonably generify the interface.
 2023-12-12 12:38:43 -05:00
Lioncash 4c7a4831cb CustomAssetLibrary: Remove unused GetAssetSize() function 
There's a direct analogue of this function within
DirectFilesystemAssetLibrary that *is* used, however, so we can get rid
of this one.
 2023-12-11 22:00:52 -05:00
Lioncash e011c3b383 Core/SyncIdentifier: Default operator== 
Lets us remove a bunch of code and a dependency on the <tuple> header.
 2023-12-11 19:39:55 -05:00
Lioncash 4229d76ad6 VertexLoaderTest: Resolve -Wdangling-else warnings 
The ways the assertion macros expand end up generating -Wdangling-else
warnings. Trivial enough to fix by just bracing the if statements.
 2023-12-11 18:45:25 -05:00
Lioncash 0e51c0f8fc JitArm64_RegCache: Resolve -Wsign-compare warning 2023-12-11 18:15:50 -05:00
Lioncash 4c3a5eb1c5 JitArm64_SystemRegisters: Resolve -Wsign-compare warning 2023-12-11 18:11:34 -05:00
Lioncash 017b9a0af7 FloatUtilsTest: Resolve -Wsign-compare warning 2023-12-11 18:08:52 -05:00
Lioncash 4bef3b93b4 AndroidCommon: Resolve -Wsign-compare warning 2023-12-11 18:06:40 -05:00
Lioncash f97316a1e6 TraversalClient: Resolve -Wsign-compare warning 2023-12-11 18:01:29 -05:00
Lioncash 49f44c1334 VertexManagerBase: Resolve -Wsign-compare warning 2023-12-11 18:00:34 -05:00
Lioncash f490b990f5 DolphinQT/Host: Remove unimplemented prototypes 
Remnants of prior existing code.
 2023-12-11 17:30:56 -05:00
Lioncash d705c31d1a DolphinQT/Host: Remove unused TLS variable tls_is_host_thread 
This is never accessed or read from.
 2023-12-11 17:27:57 -05:00
Lioncash e8b4796273 PostProcessing: Mark helper functions as static 
These didn't have any prototypes and were generating
-Wmissing-declaration warnings.
 2023-12-11 17:07:59 -05:00
Lioncash abb5cc3a3a ShaderAsset: Mark ParseShaderProperties() as static 
This had no function prototype, so this can be internally linked.

Resolves a -Wmissing-declaration warning.
 2023-12-11 17:05:06 -05:00
Lioncash b4b624b97b WC24PatchEngine: Mark LoadPatches() as static 
Resolves a -Wmissing-declaration warning, since no prototype existed for
the function.
 2023-12-11 17:02:15 -05:00
Lioncash 2b2ee61e79 CustomShaderCache: Resolve -Wreorder warnings 
Lays out the initializer lists to be in the same order that
initialization would occur in.
 2023-12-11 16:59:03 -05:00
Lioncash 9472da788d ConfigFloatSlider: Resolve -Wreorder warnings 
Orders the initializer list the way that the members would actually be
initialized in.

Resolves some -Wreorder warnings
 2023-12-11 16:15:48 -05:00
Lioncash 5d1514418e GraphicsModListWidget: Add string specifier to By and Description fields 
Translators should always know where text is going to be appended and
have the ability to move things around to fit the language better.
 2023-12-11 15:43:41 -05:00
Lioncash d90537cc18 AchievementManager: Return by reference from GetLock() 
This makes the API a little nicer to use, since you don't need to do
a mandatory dereference when passing the lock into any kind of scope
guard.
 2023-12-11 13:51:50 -05:00
Lioncash 3c7fa0738c AchievementsWindow: Add missing override specifier 2023-12-11 13:47:59 -05:00
Lioncash dbf28df64c DolphinQT: Remove unnecessary includes from achievement files 
Reduces the amount of dependencies being pulled in on both local and
external headers.
 2023-12-11 13:40:55 -05:00
Lioncash e55f9ed102 AchievementManager: Make GetInstance() return a reference 
The internal static member will always have a valid lifetime. Makes this
consistent with other instance based objects in our code.
 2023-12-11 13:36:39 -05:00
Lioncash cdf8849e17 GameFile: Default GameBanner operator== 
Same behavior, but less code.
 2023-12-11 11:36:35 -05:00
Lioncash ff38362216 GameFileCache: Use std::span with Update() 
All we're really doing is iterating over a sequence of strings, so we
don't need to tie this specifically to std::vector.
 2023-12-11 11:12:09 -05:00
Lioncash 2ca80adeb2 GameFileCache: Pass std::function by reference rather than by value 
std::function is internally allowed to allocate, and these functions
aren't being stored anywhere (only called), so we can freely get rid
of some minor overhead here by passing by reference.

This change also creates aliases for the functions, so that there isn't
a lot of visual noise when reading the function signatures.
 2023-12-11 11:09:18 -05:00
Lioncash 88a973131c Common/SettingsHandler: Use std::string_view more 
We don't need to enforce the use of std::string instances with
AddSetting(). We can accept views and only construct one string,
rather than three temporaries.
 2023-12-11 07:54:43 -05:00
Lioncash 04b9f6c28d Common/SettingsHandler: Use std::erase in Decrypt() 
Same behavior, way less verbose code.
 2023-12-11 07:49:43 -05:00
Mai d84ed054ee Merge pull request #12374 from iwubcode/custom_texture_potential_crash_fix 
VideoCommon: prevent a potential custom texture crash
 2023-12-11 07:42:48 -05:00
Mai 6e0bc2a4db Merge pull request #12384 from AdmiralCurtiss/font-load-offset 
HW/CEXIIPL: Fix loading files at nonzero offset in LoadFileToIPL().
 2023-12-10 20:53:22 -05:00
Mai c2b642d0b7 Merge pull request #12381 from AdmiralCurtiss/re-enable-achievement-nag 
AchievementManager: Only nag user about disabled achievements when they were actually enabled before.
 2023-12-10 20:16:24 -05:00
Mai bdd28f1f26 Merge pull request #12378 from JosJuice/jitarm64-a-early-discard 
JitArm64: Add additional condition for lmw/stmw a discard
 2023-12-10 20:15:57 -05:00
Mai db1620db42 Merge pull request #12377 from JosJuice/jitarm64-a-d-discard-guard 
JitArm64: Guard against discarding a in lmw/stmw
 2023-12-10 12:19:41 -05:00
Lioncash f4b1a199e8 VFFUtil: Use std::span with WriteToVFF 
Same behavior, but allows different containers to be used.

In one case it also gets rid of needing to construct a std::vector.
 2023-12-10 10:17:39 -05:00
Mai e2472e4f50 Merge pull request #12352 from JosJuice/jitarm64-flush-in-long-inst 
JitArm64: Flush in the middle of lmw/stmw/mfcr
 2023-12-10 09:15:07 -05:00
Mai f249e414ad Merge pull request #12366 from AdmiralCurtiss/exi-ipl-fixes 
HW/CEXIIPL: Various fixes.
 2023-12-10 09:12:18 -05:00
Mai c23febe947 Merge pull request #12368 from AdmiralCurtiss/enet-submodule 
Externals/enet: Convert to submodule.
 2023-12-10 09:08:10 -05:00
Mai fb0934de71 Merge pull request #11289 from AdmiralCurtiss/mmu-msi-ir 
MMU: Use MSR.IR for Host instruction reads.
 2023-12-10 09:06:05 -05:00
Lioncash 0df7908025 VideoCommon/Present: Remove use of g_presenter inside Presenter class 
There's no need to self reference a global of the class itself when we
can just call the function directly.
 2023-12-09 20:15:32 -05:00
Lioncash 5f6c76af51 VideoCommon: Use std::span for BoundingBox::Write() 
Crosses off a lingering TODO.

Also amends a few nearby cases where a u32 cast was being repromoted to
size_t.
 2023-12-09 16:33:21 -05:00
Mai bec4c77325 Merge pull request #12367 from AdmiralCurtiss/mail-includes 
IOS/KD/Mail: Add missing includes.
 2023-12-09 15:25:24 -05:00
Mai dd227fea5a Merge pull request #12364 from JosJuice/android-emulation-settings-reload 
Android: Fix crash after process recreation
 2023-12-08 21:24:05 -05:00
Mai 636b892b7c Merge pull request #12360 from TryTwo/bugfix_wiimote_signal_spam 
WiimoteDevice. Bugfix. Remove signal spam while starting a game.
 2023-12-08 21:07:51 -05:00
Mai e0f4111561 Merge pull request #11663 from JosJuice/android-config-change-callback 
Android: Use config changed callback for tracking recursive scan setting
 2023-12-07 16:48:02 -05:00
Mai 3a4cf579ff Merge pull request #12247 from LillyJadeKatrin/retroachievements-challenges 
RetroAchievements - Challenge Icons
 2023-12-07 16:46:43 -05:00
Mai 2ece642cf8 Merge pull request #12357 from AdmiralCurtiss/ipl-bounds 
Core/Boot: Check bounds in Load_BS2().
 2023-12-06 19:57:26 -05:00
Mai b4276049fc Merge pull request #12216 from LillyJadeKatrin/retroachievements-rehash 
RetroAchievements - Improved Game Loading
 2023-12-05 18:22:38 -05:00
Mai a65246ec3f Merge pull request #11988 from JosJuice/jit-feature-flags 
Jit: Replace "msrBits" with "featureFlags" and use for performance monitor
 2023-12-05 03:13:50 -05:00
Mai 2199dd26bb Merge pull request #12345 from minhaferzz/startup-handler 
Android: Fix issue when launching a game when Dolphin is not open
 2023-12-05 03:10:41 -05:00
Mai bf415f9b54 Merge pull request #12350 from PatrickFerry/add_accurate_nans_game 
Gameini: Enable AccurateNaNs for "Jeep Thrills"
 2023-12-05 01:35:00 -05:00
Mai 6e6695c24b Merge pull request #11904 from LillyJadeKatrin/retroachievements-hardcore-v2 
RetroAchievements - Hardcore Mode (V2)
 2023-12-05 01:31:54 -05:00
Mai 27be8c087e Merge pull request #12295 from sepalani/arp-check 
BBA/HLE: Fix GC homebrew if_config not working
 2023-12-03 11:26:00 -05:00
Mai 98eda4dc9f Merge pull request #12351 from TryTwo/bugfix_data_symbols 
PPCSymbolDB. Bugfix. Fix .data symbols not loading
 2023-12-03 11:17:44 -05:00
Mai 87256e3ec3 Merge pull request #12353 from JosJuice/hle-discard-cr 
PPCAnalyst: Clear crInUse on HLE
 2023-12-03 09:20:29 -05:00
Mai 4f3f208fe4 Merge pull request #12348 from JosJuice/jitarm64-imm-msr-fastmem 
JitArm64: Fix updating MEM_REG with imm MSR without fastmem
 2023-12-02 17:53:28 -05:00
Mai c54e8d733f Merge pull request #12347 from JosJuice/jitarm64-paired-offset 
JitArm64: Use ADDI2R for psq_lXX/psq_stXX immediate offsets
 2023-12-01 20:15:06 -05:00
Mai 5f7e9d3bf1 Merge pull request #12320 from JosJuice/jitarm64-mmu-order 
PowerPC: Unify "FromJit" MMU functions
 2023-11-30 18:34:32 -05:00
Mai d85cb749c0 Merge pull request #11382 from skyfloogle/traversal-fix-2 
Traversal: Use low TTL for probe packet
 2023-11-30 18:03:50 -05:00
Mai d67f54b175 Merge pull request #12186 from TellowKrinkle/MultiTextureComputeMetal 
VideoBackends:Metal: Support multiple compute textures
 2023-11-30 17:46:02 -05:00
Mai 89963c287c Merge pull request #11958 from JosJuice/jitarm64-dispatcher-microopt 
JitArm64: Dispatcher optimizations
 2023-11-29 16:54:09 -05:00
Mai 2d0e577f8f Merge pull request #12340 from JosJuice/jit-gp-check-discard-cr 
PPCAnalyst: Don't discard CR before gather pipe interrupt check
 2023-11-29 16:51:03 -05:00
Mai 0a62b30cd4 Merge pull request #11906 from noahpistilli/request-register-user-id 
IOS/KD: Implement Request Register User ID
 2023-11-29 03:31:59 -05:00
Mai 02de58eb2c Merge pull request #12337 from Tilka/imm16 
Jit64: fix invalid instruction encoding
 2023-11-29 01:10:22 -05:00
Mai a7216a3035 Merge pull request #9857 from JosJuice/jitarm64-cr-analysis 
PPCAnalyst: Allow more reordering of CR operations
 2023-11-28 21:01:07 -05:00
Mai b7435be90a Merge pull request #12298 from Shoegzer/master 
Update default IP for HLE BBA
 2023-11-28 22:45:17 +01:00
Mai d095bddbe7 Merge pull request #12141 from JosJuice/jit-blr-msr 
Jit: Check MSR state in BLR optimization
 2023-11-28 22:35:35 +01:00
Mai 934418a289 Merge pull request #12092 from JosJuice/jitarm64-last-nan 
JitArm64: Skip checking last input for NaN for non-SIMD operations
 2023-11-28 22:30:50 +01:00
Mai 95f06ef231 Merge pull request #12122 from JosJuice/jit-imm-msr 
Jit: Handle imm msr in EmitStoreMembase
 2023-11-28 21:34:23 +01:00
Mai 8cf0597d5f Merge pull request #12091 from JosJuice/jitarm64-skip-quiet-bit 
JitArm64: Use one instruction for making NaNs quiet
 2023-11-28 21:33:25 +01:00
Mai e99ead0a68 Merge pull request #12124 from JosJuice/jitarm64-mfsrin-mtsrin-addr 
JitArm64: Optimize mfsrin/mtsrin address calculations
 2023-11-28 21:30:30 +01:00
Mai b53ecd73fb Merge pull request #12143 from JosJuice/jitarm64-loadstore-pc 
JitArm64: Write PC when calling MMU.cpp
 2023-11-28 21:29:37 +01:00
Mai 1df685b2d7 Merge pull request #12123 from JosJuice/jit-mcrxr 
Jit: Some mcrxr optimizations
 2023-11-28 19:32:47 +01:00
Mai 20b13df507 Merge pull request #12179 from JosJuice/jitarm64-gp-deduplicate 
JitArm64: Deduplicate the gather pipe exception check
 2023-11-28 19:21:58 +01:00
Mai ac53766058 Merge pull request #12215 from JosJuice/android-si-devices 
Android: Add more GameCube controller types
 2023-11-28 19:21:29 +01:00
Mai bfc6bca583 Merge pull request #12235 from JosJuice/jitarm64-float-cls 
JitArm64: Use LSL+CLS for classifying floats
 2023-11-28 19:20:01 +01:00
Mai 9d415c1dbc Merge pull request #12192 from JosJuice/jitarm64-nan-check 
JitArm64: Check packed NaNs without using extra register
 2023-11-28 04:22:27 +01:00
Mai 99cf862596 Merge pull request #12317 from JosJuice/setting-saveable-cleanup 
Config: Clean up IsSettingSaveable
 2023-11-28 04:20:21 +01:00
Mai 7e9c19fdb1 Merge pull request #12231 from JosJuice/jitarm64-frsqrte-optimization 
JitArm64: Optimize frsqrte routine
 2023-11-28 04:19:27 +01:00
Mai 731013c316 Merge pull request #12263 from Dentomologist/realtime_cheatsearch_update 
CheatSearch: Automatically update Current Values
 2023-11-28 04:17:06 +01:00
Mai 2869a4c168 Merge pull request #12278 from JosJuice/jitarm64-gpr-loop 
JitArm64: Optimize Arm64GPRCache::FlushRegisters/FlushCRRegisters
 2023-11-28 04:14:34 +01:00
Mai 6be8e63b23 Merge pull request #12306 from JosJuice/hle-discard 
PPCAnalyst: Don't discard registers across HLE'd functions
 2023-11-28 04:05:31 +01:00