Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
36,934 Commits 1 Branch 0 Tags
87e56267ac8e751d0f0082ad8d3be11decbf2bee
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Scott Mansell 4db1816368 cmake: Require cmake 3.15 for MSVC 
We need these policies, but we kind of want to avoid requiring cmake
3.15 for all platforms
 2022-05-22 00:29:47 +02:00
Scott Mansell 876f6651b4 cmake: fix PCH to work with msvc/ninja 
Ninja puts way more effort into compiling targets in parallel, and
ignores dependenceis until link time.

So we need to jump though hoops to force ninja to compile
pch.cpp before any targets which depend on the PCH.
 2022-05-22 00:29:47 +02:00
Scott Mansell 89fda54820 cmake: fix ninja/msvc builds 
If you don't set this policy, then cmake doesn't even try
to select a runtime library
 2022-05-22 00:29:47 +02:00
Scott Mansell 0909e00117 cmake: fix MSVC PCH support 
I'm not sure if the previous implementation ever worked.
 2022-05-22 00:29:47 +02:00
Scott Mansell 2348017ee8 cmake: ignore external warnings in MSVC 
Since we also treat all warnings as errors, we need to
ignore these to successfully build.
 2022-05-22 00:29:46 +02:00
Scott Mansell 987f270083 cmake: fix buggy target sources on windows 
I have no idea why cmake supports PUBLIC on target_sources,
but it does. It causes all targets that depend on this target
to try and include the files in their sources.
Except it doesn't take paths into account, so it breaks. Mabye
it would work if you used an abolute source? But I'm not sure
there is a sane usecase.
 2022-05-22 00:29:46 +02:00
Scott Mansell 54d89b955a cmake: add missing FFmpeg dependency on windows 2022-05-22 00:29:46 +02:00
Scott Mansell d2df9afda2 cmake: Fix libusb on windows 2022-05-22 00:29:46 +02:00
Scott Mansell c5c4169bc8 Merge pull request #10255 from Pokechu22/sw-zfreeze 
Software: Fix zfreeze with CullMode::All
 2022-04-15 11:12:49 +12:00
Scott Mansell 36678dca59 Merge pull request #10585 from Pokechu22/apple-m1-unit-tests-f-string 
Apple M1: Fix "Building and running unit tests" message
 2022-04-15 10:43:59 +12:00
Scott Mansell 0327bc2ab6 Merge pull request #10256 from malleoz/show-rerecord-count 
Renderbase: Show rerecord count
 2021-12-03 14:42:10 +13:00
Scott Mansell e92e90d147 Merge pull request #10263 from dolphin-emu/revert-10217-bombermanjetters 
Revert "Force Dual Core on for Bomberman Jetters"
 2021-12-03 01:28:33 +13:00
Scott Mansell 26e4e67d45 Merge pull request #10258 from Pokechu22/fifoplayer-efb-clear 
FifoPlayer: Clear EFB before starting playback
 2021-12-03 00:22:27 +13:00
Scott Mansell 57d251c2f0 Merge pull request #10242 from smitdylan2001/master 
Fixed Gamecube naming to GameCube
 2021-11-30 06:58:55 +13:00
Scott Mansell 676c500cdc Merge pull request #10214 from OatmealDome/mvk-better-incremental 
MoltenVK: Don't run fetchDependencies unnecessarily
 2021-11-25 11:47:36 +13:00
Scott Mansell f5c550e9cb Delay singlecore gpu interrupts 
Fixes Bomberman Jetters in single core mode.

When single core mode pauses the CPU to execute the GPU
FIFO it greedily executes the whole thing. Before this commit,
Finish and Token interrupts would happen instantly, not even
taking into account how long the current FIFO window has
taken to execute. The interrupts would be effectively backdated
to the start of this execution window.

This commit does two things: It pipes the current FIFO window
execution time though to the interrupt scheduling and it enforces
a minimum delay of 500 cycles before an interrupt will be fired.
 2021-11-25 11:11:01 +13:00
Scott Mansell 9bbc843542 VideoSoftware: Fix copy filter clamping 2021-11-17 09:29:16 +13:00
Scott Mansell 7128befb39 Fix copy filter clamping regression in Spyro 
This fixes horizontal lines in the bloom effect of Spyro: A Hero's Tail,
which is a regression caused by PR #10204

Screenshot of regression:
https://user-images.githubusercontent.com/138484/142030503-90fcd8d5-63d3-4820-874a-72e9be0c4768.png

Fixed:
https://user-images.githubusercontent.com/138484/142031598-b85ff55c-1302-4e4d-bcb2-57848974056b.png

Spyro uses an 640x80 pixel sub-buffer within the EFB to calculate
it's bloom effects, which it places below the main 640x448 buffer.

EFB layout:
https://user-images.githubusercontent.com/138484/142030573-e933b6ae-c37e-4be6-86d4-0bc779b92535.png
Note: Colors are wrong because the main color buffer uses RGBA6,
      while the bloom is calculated in RGB8

This allows it to do bloom without backing up part of the EFB to
main memory, as most games do.

But, since some of the sub-buffers used in the bloom effect are taller
than 80 pixels, they need to be sliced up into smaller sub, sub buffers
which get combined later when copied to main memory.

At one point, a 320x224 buffer is broken up into 320x80, 320x64 and
320x80 slices. These are copied out with the copy filter set to a
vertical blur.

Because there was an off-by-one errror in the clamping coordinates,
the bottom line of the color buffer would be blurred into
the top of each slice.

Final combined EFB copy:
https://user-images.githubusercontent.com/138484/142031360-2c076839-7c96-4b3b-a093-d899d0a2c7ae.png

Fixed version:
https://user-images.githubusercontent.com/138484/142031370-72e41a35-3b3e-4662-a483-79203e357ecc.png

Before #10204 the copy filter wasn't enabled for efb copies, and most
other games don't do this type of slicing.

FIFO CI shows that a few other games are effected, it's always just a minor difference to the top line where there was previously a slight hint of garbage.
 2021-11-17 06:12:46 +13:00
Scott Mansell b997048cfe Merge pull request #10142 from aldelaro5/gdb-stub-rework 
Rework the entire logic of the GDB stub
 2021-10-24 01:51:29 +13:00
Scott Mansell 13985b774e Merge pull request #10170 from ooshlablu/deb-package-cpack-generation 
Enable deb package generation with cpack
 2021-10-17 13:38:56 +13:00
Scott Mansell 0d5f2810e7 Merge pull request #10166 from fpdotmonkey/heed-tev-switch-warning 
Silence the -Wswitch warnings in Tev
 2021-10-14 20:42:11 +13:00
Scott Mansell edb66dab84 TextureCache: Remove deleted textures from bound_textures 
Fixes issue where vulkan might crash trying to bind a deleted
texture.
 2021-10-12 15:51:24 +13:00
Scott Mansell d771bee0fe TMEM: Add some helpful comments 2021-10-12 15:51:24 +13:00
Scott Mansell a33cf27885 TMEM: Handle savestate and init 2021-10-12 15:51:24 +13:00
Scott Mansell 88bd10cd30 Extend TMEM cache implementation 
Now works with games that deliberately avoid invalidating TMEM because
they know textures are too large to fit:

 * Sonic Riders
 * Metal Arms: Glitch in the System
 * Godzilla: Destroy All Monsters Melee
 * NHL Slapshot
 * Tak and the Power of Juju
 * Night at the Museum: Battle of the Smithsonian
 * 428: Fūsa Sareta Shibuya de
 2021-10-12 15:51:24 +13:00
Scott Mansell eee302c040 Merge pull request #10158 from phire/bb-missing-include 
BoundingBox: Add missing include
 2021-10-10 16:15:10 +13:00
Scott Mansell 5a8455e8ce BoundingBox: Add missing include 2021-10-10 13:21:31 +13:00
Scott Mansell af043c07bb Merge pull request #10096 from phire/consolidate_tex_unit_addressing 
Consolidate TexUnit addressing
 2021-10-10 09:10:52 +13:00
Scott Mansell 9fa26624b0 BPMemory: Refactor/consolidate TexUnit Addressing 
Currently the logic for addressing the individual TexUnits is splattered all
across dolphin's codebase, this commit attempts to consolidate it all into a
single place and formalise it using our new TexUnitAddress struct.
 2021-10-10 09:09:43 +13:00
Scott Mansell ef0e401708 BPMem: Abstract TexUnit Addressing into struct 
The addressing of the texture units is a bit non-obvious.
This struct abstracts the complexity away.
 2021-10-10 09:01:57 +13:00
Scott Mansell 40d9694bd0 Merge pull request #10139 from malleoz/movie-mismatch-fix 
Movie: display correct input difference on movie mismatch
 2021-09-30 15:34:10 +13:00
Scott Mansell a7224b299c Merge pull request #10136 from malleoz/show-input-polls-on-m_ShowFrameCount 
RenderBase: Show input count on m_ShowFrameCount
 2021-09-30 07:49:09 +13:00
Scott Mansell a47b91e946 Merge pull request #9945 from OatmealDome/intel-broken-discard 
DriverDetails: Add broken dual source blending bug to MoltenVK on Intel GPUs
 2021-09-30 06:04:06 +13:00
Scott Mansell bb367394cf Merge pull request #10129 from malleoz/recording-save-playback-window 
QFileDialog: differentiate between recording open/save
 2021-09-29 15:39:25 +13:00
Scott Mansell 34b6a788c2 Merge pull request #10133 from malleoz/play-recording-vi-total-display 
Core: UpdateTitle with total framecount on recording playback
 2021-09-29 15:33:21 +13:00
Scott Mansell a963829ab6 Merge pull request #10134 from malleoz/framecount-in-input-display 
RenderBase: show total framecount on movie playback
 2021-09-29 15:23:59 +13:00
Scott Mansell ce80a96aee BPStructs: ensure side effects are same 
Missed this side effect when fixing crash in Mario Kart Wii wifi
 2021-09-18 23:58:24 +12:00
Scott Mansell 7c7609f5b9 BPStructs: Ignore malformed efb copies 2021-09-17 12:42:23 +12:00
Scott Mansell eb8bfabdfd BPStructs: make copy width/height const 2021-09-15 11:54:40 +12:00
Scott Mansell 37b80e2170 BPStructs: fix out-of-range EFB copy clamping 
Previous code from #7950 only clamps correctly when the efb copies
left and top coordinates are (0, 0)

Now we should handle all situations.

Spyro: A hero's tail is an example of a game that does an oversized
EFB copy with a non-zero origin.
 2021-09-15 02:31:38 +12:00
Scott Mansell a3c89ac701 Merge pull request #9773 from Techjar/bbox-default-values 
VideoCommon: Add fallback handling for bounding box when disabled or unsupported
 2021-06-01 12:27:34 +12:00
Scott Mansell 37e532322b Port dump XFB option to Qt UI. 
Looks like the option was added to the Wx UI at commit 198d3b69, which
was a few months after the advancedWidget was originally ported from
Wx to Qt, but before anyone was actually using Qt.
 2021-05-27 12:48:36 +12:00
Scott Mansell 610613ee76 Use correct mask for Fake VMem 
Shouldn't have any behaviour change for regular usage as both masks are 32MB
by default.
But fixes theoretical buffer overrun when memory size override is used.
 2021-05-23 05:54:02 +12:00
Scott Mansell 9f91fb6447 Merge pull request #9688 from Filoppi/input_cleanup 
Input cleanup
 2021-05-14 20:51:33 +12:00
Scott Mansell ab55c948a1 Update zcompression format change TODO 2021-05-05 11:32:42 +12:00
Scott Mansell a4796e512a Implement EFB Peeks for compressed z16 formats 
This fixes an issue in RS3 where engine lens flares would shine
though ships during cutscenes
 2021-05-05 11:32:29 +12:00
Scott Mansell ffc40c1a00 Merge pull request #8777 from delroth/pospost 
XFMemory: SETPOSMTXINFO should be SETPOSTMTXINFO
 2020-04-29 15:50:07 +12:00
Scott Mansell 54fd83dc4b Merge pull request #8553 from dolphin-emu/document-evdev-heuristic 
Document the evdev "interesting" heuristic
 2020-01-07 22:54:54 +13:00
Scott Mansell a8c33f4ef6 Fix trailing whitespace 2020-01-07 12:52:05 +13:00
Scott Mansell 21528c3e72 Document the evdev "interesting" heuristic 
Was checking over this old code, and saw a comment calling me out for a lack of documentation.

It might be half a decade late, but better late then never.
 2020-01-07 12:46:24 +13:00
Scott Mansell ac77df9e90 Merge pull request #8490 from vadosnaprimer/dumping 
2 minor dumping fixes
 2019-11-25 10:38:44 +13:00
Scott Mansell 93d7b3d159 Merge pull request #8432 from jordan-woyak/hotkey-indicator-fix 
DolphinQt: Make HotkeyScheduler call UpdateInput when hotkeys are disabled.
 2019-11-07 10:05:54 +13:00
Scott Mansell 677a0903a1 FifoPlayer: Use std::move for saving callbacks 2019-09-09 11:38:21 +12:00
Scott Mansell 46f4f69cfd QtFifoPlayer: handle fifo load before window creation 
Fixes a bug where if you loaded a fifo before opening the fifo
player window (which you can do by dragging a .dff onto dolphin's
main window) then the player's widgets wouldn't be initilized
correctly.

Importantly, the object range widgets would be broken.
 2019-09-09 10:36:31 +12:00
Scott Mansell 033f1d725f Fix un-initialized powerpc.xer_* variables 2019-04-27 15:38:02 +12:00
Scott Mansell c27ee22a15 Add vscode to .gitignore 2019-04-27 10:36:16 +12:00
Scott Mansell a192a3bb30 While I'm here, fix some chroma sub-sampling bugs. 
RE4's brightness screen is actually very good for spotting these.

Bug 1: Colors at the end of the scanlines are clamped, instead of a black
       border
Bug 2: U and V color channels share coordinates, instead of being offset
       by a pixel.
 2018-04-29 17:56:53 +10:00
Scott Mansell fc96479f12 VideoSoftware: Implement xfb copy filter (Deflickering/Brightness) 2018-04-29 17:56:51 +10:00
Scott Mansell 0e6d01220a Fix change in comment meaning by autoformat. 2018-04-13 09:20:27 +12:00
Scott Mansell 3b5cad6682 Merge pull request #5860 from jturcotte/fix-macos-nswitch-axis 
Fix axis not working with Switch Pro controller on macOS
 2017-08-07 13:44:07 +12:00
Scott Mansell 479abde9f4 BPMemory: Convert a number of unions to BitFields 2017-07-30 17:43:59 +10:00
Scott Mansell e6476b805e Merge pull request #5008 from ligfx/aspectheuristic 
VideoCommon: rework anamorphic widescreen heuristic
 2017-04-10 11:30:34 +12:00
Scott Mansell 4c0a392698 Merge pull request #4715 from iwubcode/efb_copy_corruption_at_higher_ir 
Add configurable toggle to round vertices to nearest pixel
 2017-04-05 19:41:52 +12:00
Scott Mansell d1b343ab5a Merge pull request #4976 from ligfx/fixwxcommandlineassertion 
DolphinWX: provide empty OnCmdLineParsed
 2017-02-27 15:10:01 +13:00
Scott Mansell 38f399bdfc Merge pull request #4947 from JMC47/WallaceGromitSaving 
Force Wallace and Gromit in Pet Zoo to use smaller memory card
 2017-02-23 09:52:20 +13:00
Scott Mansell d8479869dc Merge pull request #4914 from Rastaban/master 
C++ conformance fixes (MSVC /permissive-)
 2017-02-16 18:48:01 +13:00
Scott Mansell 5da565a1a1 Merge pull request #4735 from degasus/jitcache 
Jit64: Enable branch following.
 2017-01-28 15:48:01 +13:00
Scott Mansell e41858232d Merge pull request #4720 from lioncash/si-stub 
SI_Device: Move the null device implementation to its own source files
 2017-01-23 15:46:37 +13:00
Scott Mansell ed95115c17 Merge pull request #4220 from aldelaro5/memcheck-interface-improvements 
Redo the MemCheck add dialog
 2016-09-28 13:46:25 +13:00
Scott Mansell 4c004b6dc9 Merge pull request #4131 from aldelaro5/memoryViewer-memChecks-improvements 
Add the configuration of how a memory check is added via the memory window
 2016-09-15 10:46:07 +12:00
Scott Mansell 514ce3c6ed Merge pull request #4201 from EmptyChaos/interpreter-coretiming 
Interpreter/CachedInterpreter/JitArm64: Fix CoreTiming::Advance usage
 2016-09-15 09:57:00 +12:00
Scott Mansell a7566ea037 Merge pull request #4213 from sepalani/map_align 
PPCSymbolDB: Rename unknown variable
 2016-09-15 09:54:46 +12:00
Scott Mansell ea7e734496 Merge pull request #4186 from aldelaro5/registerView-update-fix 
Fix registerView updates issues when stepping over or stepping out
 2016-09-14 18:10:41 +12:00
Scott Mansell 4e595ca25f Merge pull request #4208 from aldelaro5/more-debugger-font-fix 
Fix the debugger font not appearing on the captions of panes (DSP)
 2016-09-14 18:09:28 +12:00
Scott Mansell d5c25a8990 Merge pull request #4207 from aldelaro5/debugger-floating-window-fix 
Debugger: Fix some floating window issues
 2016-09-14 18:08:23 +12:00
Scott Mansell 65c1df34f4 Merge pull request #4198 from aldelaro5/memory-breakpoint-fix 
Fix the memChecks breaking a second time after hitting one and unpausing
 2016-09-12 14:51:47 +12:00
Scott Mansell fe41dff228 Fix the master build. 2016-09-07 20:10:03 +12:00
Scott Mansell d951f9e765 Merge pull request #3771 from phire/pr3771 
Remove instant ARAM DMA hack (Fixes Sarge's War)
 2016-09-07 19:09:39 +12:00
Scott Mansell 42e91dd815 Merge pull request #4189 from phire/efb_linear_downsampling 
EFB2RAM: Downsample higher resolutions with linear filtering.
 2016-09-07 17:44:16 +12:00
Scott Mansell 62d7a698da Merge pull request #4145 from tenthmile/WiiOrientationModifier 
Emulated Wiimote Orientation Modifier
 2016-09-07 14:20:02 +12:00
Scott Mansell 7311cd8b6e Merge pull request #4137 from aldelaro5/memCheck-crash-fix 
Fix a crash when adding the first memory check while the game is running
 2016-09-07 14:19:19 +12:00
Scott Mansell ac6013bff3 Merge pull request #4134 from RisingFog/move_advancepane_disable 
Fix advanced config panel staying disabled after TAS recording
 2016-09-07 14:18:00 +12:00
Scott Mansell f5e870bbe5 Merge pull request #4135 from RisingFog/remove_wii_limits_rtc 
Fix issues with Custom RTC when set past the year 2038
 2016-09-07 14:05:58 +12:00
Scott Mansell 366a38a917 Merge pull request #4142 from mbc07/IPC_HLE_usb_ven 
[IPC HLE] Implement /dev/usb/ven with very basic functionality
 2016-09-07 13:51:55 +12:00
Scott Mansell dbface94ea And remove the feature from the Arm64 jit too. 2016-09-07 12:53:14 +12:00
Scott Mansell c354dfcd2f Remove instant ARAM DMA mode. 
Now that our timings are much more accurate it doesn't look like we
need it anymore. And the instant ARAM DMA mode + scheduling fixes
ctually breaks ATV: Quad Power Racing 2 (causing all sorts of werid
bugs).
 2016-09-07 12:53:14 +12:00
Scott Mansell f5c70a4b27 EFB2RAM: Downsample higher resolutions with linear filtering. 2016-09-07 11:17:32 +12:00
Scott Mansell 3e0355e7f6 Merge pull request #4184 from EmptyChaos/wii_ipc-init 
WII_IPC_HLE: Fix Reinit
 2016-09-06 15:51:30 +12:00
Scott Mansell 5932ded806 Merge pull request #4183 from aldelaro5/if-simplification-slowmem 
Simplify an if condition after PR #4078
 2016-09-06 13:20:58 +12:00
Scott Mansell d29dae207a Merge pull request #4078 from comex/alwaysUseMemFuncs-for-write 
Don't use the fast path when there are watchpoints enabled, for writes too
 2016-09-06 04:55:17 +12:00
Scott Mansell 0119f1302f Merge pull request #4177 from phire/useless_cases 
BPStructs: remove case statements which never match.
 2016-09-06 00:56:09 +12:00
Scott Mansell a665743b70 BPStructs: remove case statments which never match. 
Visual Studio's code analyzer complains about these.
 2016-09-06 00:40:49 +12:00
Scott Mansell f5fa5a7d32 Merge pull request #4168 from EmptyChaos/coretiming-cleanup 
Core: CoreTiming Cleanup (Add UnitTests)
 2016-09-04 11:48:54 +12:00
Scott Mansell a32bb8f1b9 Movie: Fix null pointer derefrence. 
Part of the acceleration data is packed in with the buttons. We
always have button data when we have acceleration data.
 2016-09-03 16:46:48 +12:00
Scott Mansell 0e7424b359 VideoSoftware: Fix unsigned overflow bug in fog 
Was causing fog errors on the left half of the screen.

Only appeared to affect visual studio builds, GCC did the correct
thing.
 2016-09-02 10:12:44 +12:00
Scott Mansell def0b42fb7 Merge pull request #4161 from OrN/wxwidgets-build-fix 
Fix wxWidgets build for 32-bit arch
 2016-08-31 11:29:04 +12:00
Scott Mansell efac0cf8fe Merge pull request #4156 from phire/interlaced_panic 
VideoInterface: Fix panic alert on interlaced fields.
 2016-08-29 23:10:55 +12:00
Scott Mansell c4786ad70e Merge pull request #4151 from phire/fix_lswx 
Fix bug in interpreter's lswx. Was overwriting extra register.
 2016-08-29 23:10:23 +12:00
Scott Mansell 17e64b75a5 VideoInterface: Fix panic alert on interlaced fields. 
For some reason this was only showing up in video software.

Not sure why.
 2016-08-29 23:08:23 +12:00
Scott Mansell fc2b0e0f45 Simplify lswx loop. 2016-08-29 22:57:37 +12:00