Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
28,443 Commits 1 Branch 0 Tags
8a24eac0def2dd2cc81c28503916bd893298d5f4
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Léo Lam b7a8deda96 Merge pull request #7074 from lioncash/paired 
Interpreter_LoadStorePaired: Simplify type aliases in QuantizeAndStore() and LoadAndDequantize()
 2018-06-05 00:08:00 +02:00
Léo Lam 226f88bcb6 Merge pull request #7069 from leoetlino/player-id 
PadMappingDialog: Show player ID in player dropdown
 2018-06-05 00:02:04 +02:00
Léo Lam d1e2cc7b92 Merge pull request #7070 from spycrab/qt_prop_width 
Qt/PropertiesDialog: Fix tabs being cut off due to small window size
 2018-06-04 23:49:28 +02:00
Léo Lam 8fe7f8d80d Merge pull request #7072 from lioncash/emitter 
DSPEmitter: Make m_unresolved_jumps private
 2018-06-04 22:26:24 +02:00
Léo Lam d797bf2ee7 PadMappingDialog: Show player ID in player dropdown 
Makes it easier to differentiate players that have the same name.
 2018-06-04 22:24:35 +02:00
Léo Lam 5f29e891d3 Merge pull request #7063 from lioncash/fifr 
Interpreter: Unset FPSCR.FI and FPSCR.FR for QNaN and infinity input operands
 2018-06-04 20:53:58 +02:00
Léo Lam 6ce9c96d91 Merge pull request #7027 from leoetlino/cleanup 
Use some C++17 features available since GCC 6
 2018-06-04 20:50:50 +02:00
Léo Lam 2a89ad9c39 Merge pull request #7066 from spycrab/qt_fs_exit 
Qt: Always return to windowed when confirming exit
 2018-06-04 20:48:22 +02:00
Léo Lam 9b43180731 Merge pull request #7040 from JMC47/enableadouble2single 
[JIT] Enable Accurate Double to Single Conversion
 2018-06-04 20:29:15 +02:00
Léo Lam 34511b397e Merge pull request #7067 from Ebola16/ASU3 
Update Android Gradle Plugin
 2018-06-04 19:37:33 +02:00
Léo Lam b26a47e642 Merge pull request #6180 from ligfx/sdlhotplug 
Add hotplug support to SDL2 controller backend
 2018-06-04 18:12:29 +02:00
Léo Lam 8e0ea92ec3 Merge pull request #7058 from JosJuice/move-titledatabase-usage 
Don't store custom names from TitleDatabase in GameFileCache
 2018-06-04 14:59:05 +02:00
Léo Lam 8074192a85 Merge pull request #7057 from leoetlino/string 
Config/StringUtil/IniFile: Get rid of some duplicated code
 2018-06-04 12:44:57 +02:00
Léo Lam 472e0d55b8 Merge pull request #7061 from leoetlino/wiiroot 
WiiRoot: Use new filesystem interface
 2018-06-04 00:15:49 +02:00
Léo Lam 0ecec33567 WiiRoot: Use a namespace alias for FS to reduce noise 2018-06-03 21:37:28 +02:00
Léo Lam c1428b6da0 WiiRoot: Use new filesystem interface 
This gets rid of remaining direct accesses to the Wii filesystem
in WiiRoot by using WiiSave to copy saves and the FS interface
 2018-06-03 21:21:32 +02:00
Léo Lam 8fce18e4ff Merge pull request #7059 from leoetlino/fs-wiisave 
WiiSave: Use new filesystem interface
 2018-06-03 21:05:22 +02:00
Léo Lam 47bf809796 Merge pull request #7060 from lioncash/reg 
Gekko: Make register constructors explicit where applicable
 2018-06-03 21:04:34 +02:00
Léo Lam 6b9aef7042 FS: Add a struct for modes 
As suggested here: https://dolp.in/pr7059#pullrequestreview-125401778

More descriptive than having a std::tuple of FS::Mode, and lets us
give names to known triplets of modes (like in ES). Functions that
only forward mode arguments are slightly less verbose now too.
 2018-06-03 20:45:35 +02:00
Léo Lam d1a8661709 WiiSave: Save and restore files and banner with correct mode 2018-06-03 17:23:40 +02:00
Léo Lam fd3472442d WiiSave: Use new filesystem interface 
Converts WiiSave to the new filesystem interface.
 2018-06-03 17:01:14 +02:00
Léo Lam c22205cd7e Merge pull request #7053 from lioncash/frfi 
Interpreter_FPUtils/FloatingPoint/Paired: Amend cases where FPSCR.FR and FPSCR.FI should be unset
 2018-06-03 15:36:12 +02:00
Léo Lam 83324fe77d StringUtil: Remove ValueToString(std::string) 
Doesn't make a lot of sense to have a function that gives the string
representation for a string.
 2018-06-03 15:11:59 +02:00
Léo Lam 7e79bf97ab IniFile: Use templates for Get() 
Gets rid of duplicated code.
 2018-06-03 14:53:56 +02:00
Léo Lam cba32b12e7 IniFile: Use templates for Set() 2018-06-03 14:53:56 +02:00
Léo Lam fc0193c4b1 Move Config ValueToString to StringUtil 
An identical implementation is used by IniFile, so move those functions
to StringUtil. A future commit will modify IniFile to use them.
 2018-06-03 14:10:52 +02:00
Léo Lam 66ee47c417 Merge pull request #7056 from spycrab/qt_hk_debug 
Qt/HotkeyWindow: Always show debugging tab
 2018-06-03 13:50:56 +02:00
Léo Lam 1e51e263e0 Merge pull request #6988 from leoetlino/wii-save-refactor 
WiiSave: Refactor the import/export code
 2018-06-03 12:05:43 +02:00
Léo Lam 86368fcd4d Merge pull request #6499 from Ebola16/SettingsGroup 
Android: Initial implementation of Interface submenu
 2018-06-03 12:02:56 +02:00
Léo Lam 24ca621652 Merge pull request #7052 from AdmiralCurtiss/pokemon-colosseum-bonus-disc-ini 
Update GameINI settings for the Japanese Pokémon Colosseum Bonus Discs.
 2018-06-03 11:58:46 +02:00
Léo Lam a2b2a31e64 Merge pull request #7054 from JosJuice/android-no-themes 
Don't include the Themes directory in Android APKs
 2018-06-03 11:55:08 +02:00
Léo Lam 396810c450 Merge pull request #7050 from lioncash/ptr 
WiimoteDevice: Get rid of pointer casting in CBigEndianBuffer
 2018-06-02 21:35:43 +02:00
Léo Lam f09f83c309 Merge pull request #7019 from Ebola16/VSQT 
Make DolphinQT2 the default project in dolphin-emu.sln
 2018-06-02 14:23:20 +02:00
Léo Lam 62fdef0e6c Merge pull request #7046 from lioncash/priv 
EXI_DeviceMic: Make data members of CEXIMic private
 2018-06-02 11:53:07 +02:00
Léo Lam 69abaf3ec4 WiiSave: Merge Header and DataBinHeader to reduce noise 
DataBinHeader is not used anywhere in the code other than via Header,
so let's merge them to reduce noise when accessing header fields
(currently we have to do header.hdr which looks silly).
 2018-06-01 23:45:58 +02:00
Léo Lam 210377816d WiiSave: Get rid of some magic numbers 
It would make sense for 0x80 and 0xf0c0 to be respectively
sizeof(BkHeader) and sizeof(Header) as Nintendo is signing anything
that comes after the header, including the BkHeader.
 2018-06-01 23:44:24 +02:00
Léo Lam 8eafd1928e WiiSave: Move user interaction to UI frontends 2018-06-01 20:46:35 +02:00
Léo Lam 4df266f943 WiiSave: Use the correct length for paths 
Paths can never exceed 0x40 characters as this is the maximum length
that is allowed by IOS (and probably the common FS library too).
 2018-06-01 20:46:35 +02:00
Léo Lam 8af16fdd28 WiiSave: Use an enum class for save file type 2018-06-01 18:58:34 +02:00
Léo Lam 94953670f2 WiiSave: Move overwrite prompt to Import 
WriteHeader should just write the header and not do anything else.
 2018-06-01 00:14:48 +02:00
Léo Lam a46a8dd378 WiiSave: Refactor import/export code 
The current WiiSave code is extremely messy, as it exposes all kinds of
implementation details in the header (including internal struct
definitions and magic numbers that don't have to be).

The read/write code is intermingled, so it's hard to tell which members
are used, or when/where they are set at all.

It also implicitly relies on some functions being called in a specific
order since it doesn't seek manually every time, which makes the code
even more fragile.

The logic is also hardcoded to only support bin->nand or nand->bin,
even though it would be useful to support nand->nand (for the
Movie save copying code, for example).

This commit attempts to solve these problems by getting rid of the
WiiSave class:

* Read/write code is moved to new Storage classes (NandStorage and
  DataBinStorage) with small, clear functions that do one and only
  one thing.

* The import/export logic was refactored into a generic Copy function
  that takes two storages as parameters.

* The existing import and export functions are now just small wrappers
  that call Copy with the appropriate storages.
 2018-05-31 20:52:01 +02:00
Léo Lam 60dd2553c6 Merge pull request #7033 from lioncash/jitarm 
JitArm64_BackPatch: Correct usage of an invalidated iterator after a std::map erase() call in HandleFastmemFault()
 2018-05-31 18:05:47 +02:00
Léo Lam bdfd331355 Merge pull request #7028 from lioncash/obsolete 
GeneralPane: Replace usages of obsolete QString member function sprintf
 2018-05-30 15:02:41 +02:00
Léo Lam b7a268ceea Merge pull request #7029 from lioncash/any 
VolumeWii: Shorten padding checking code within CheckIntegrity()
 2018-05-30 14:58:16 +02:00
Léo Lam 4fb2d580d8 Merge pull request #7026 from lioncash/name 
JitAsmCommon: Normalize member variable names within CommonAsmRoutinesBase
 2018-05-30 12:02:08 +02:00
Léo Lam fb124c2eb0 Use nested namespaces for IOS HLE 
Pretty much all of the source files contain the following:

    namespace IOS
    {
    namespace HLE
    {
    namespace <name>
    {
    // actual code here
    }  // namespace <name>
    }  // namespace HLE
    }  // namespace IOS

which is really verbose boilerplate, because most of the files inside
of Core/IOS are for IOS HLE.

This commit replaces that with a more concise `namespace IOS::HLE`
or `namespace IOS::HLE::(name)`.
 2018-05-30 11:40:05 +02:00
Léo Lam 5b90aba624 ChunkFile: Replace macro with a variable template 
Note that std::is_trivially_copyable_v cannot be used yet (C++17 only).
 2018-05-30 11:39:30 +02:00
Léo Lam 8a00a9e149 Remove old GCC version checks 2018-05-30 10:59:15 +02:00
Léo Lam eb9969a1e2 Merge pull request #7025 from lioncash/integrity 
VolumeWii: Use ReadSwapped for retrieving the partition data size in CheckIntegrity()
 2018-05-30 10:55:13 +02:00
Léo Lam c3de9d7b0e Merge pull request #7020 from sepalani/ida-scripts 
Tools: Dolphin symbol map IDA scripts added
 2018-05-30 10:52:49 +02:00
Léo Lam 24e0b4bf52 Merge pull request #7024 from lioncash/discio 
VolumeGC/VolumeWii: Dehardcode sizes where applicable
 2018-05-30 10:22:18 +02:00
Léo Lam a4ec3ddef1 Don't switch to blank NAND in the middle of emulation 
Switching to blank NAND when emulation is running is an extremely bad
idea. It's akin to opening up a Wii and replacing the NAND chip while
you're playing a game on it.

Except we're not even replacing it with a NAND that has the same
contents. The blank NAND has nothing in it except the save file for
the current game, which is likely to result in the emulated software
getting inconsistent results and possibly even crashing depending on
how it caches title information.

An example of games that check the saves for other games is
Mario Kart Wii -- it checks the filesystem for Super Mario Galaxy saves
to decide whether to unlock characters. With this 'switch NAND
while emulation is active' misfeature, this will likely break.
And that's the main problem: it encourages sloppy emulation and no one
really knows how many things it can break.

Just don't let the user do horrible things like that during emulation.
If they want to use a blank NAND, they can do so by starting input
recording before launching a game. It's likely they will want to do
this if they plan to share their DTM anyway.
 2018-05-29 15:41:11 +02:00
Léo Lam 60c38d7781 Merge pull request #7007 from spycrab/qt_gecko_sort 
Qt/GeckoCodeWidget: Autosort list and fix accessing the wrong element
 2018-05-29 14:48:32 +02:00
Léo Lam 00d91db2ec Merge pull request #7008 from spycrab/ddos_sux 
Fix "Download Codes" hitting DDOS protection
 2018-05-29 14:42:24 +02:00
Léo Lam 86bbf540cf Merge pull request #7009 from lioncash/dsp 
DSPEmulator: Default destructor in the cpp file
 2018-05-29 14:16:50 +02:00
Léo Lam f05eb10026 Merge pull request #7003 from lioncash/host 
Common: Move host communication enum to Host.h
 2018-05-28 20:57:34 +02:00
Léo Lam a9f022a067 Merge pull request #6993 from lioncash/nan 
Interpreter_FPUtils: Set VXSNAN if any input operands are a signaling NaN in remaining NI_* functions
 2018-05-28 18:49:13 +02:00
Léo Lam bda668925a Merge pull request #6989 from lcsondes/fix-vector-assert 
UICommon: fix m_cached_files pruning.
 2018-05-28 12:41:22 +02:00
Léo Lam 0cba9bb218 Merge pull request #7000 from lioncash/wii-extension 
WiimoteEmu: Get rid of pointer casting in extension GetState() functions
 2018-05-28 12:39:01 +02:00
Léo Lam 686e29f2d3 Merge pull request #6995 from lioncash/cd 
CDUtils: Namespace code under the Common namespace
 2018-05-28 01:05:03 +02:00
Léo Lam 5fdf171967 Merge pull request #6994 from lioncash/symbol 
SymbolDB: Minor changes
 2018-05-28 00:16:34 +02:00
Léo Lam 31045f39ca Merge pull request #6992 from JosJuice/update-wiitdb 
Sync wiitdb files with GameTDB
 2018-05-27 23:16:49 +02:00
Léo Lam 44879f163e Config: Fix path settings not being saved 
Forgot to add a few lines while cherry-picking the config changes
for https://dolp.in/pr6950

Fixes https://bugs.dolphin-emu.org/issues/11171
 2018-05-27 21:03:01 +02:00
Léo Lam 145258ad27 Debug: Add missing override specifiers 2018-05-27 14:39:01 +02:00
Léo Lam 3798127cf7 Merge pull request #6926 from leoetlino/hardcoded-numbers 
IOSC: Remove some hardcoded offsets and magic numbers
 2018-05-27 14:17:28 +02:00
Léo Lam bea1e38c67 Move ECCSignature to Common::ec and give it a less confusing name 2018-05-27 14:01:38 +02:00
Léo Lam 44827ba369 Use CertECC struct instead of hardcoded offsets 2018-05-27 14:01:38 +02:00
Léo Lam e9ce75ccc4 Merge pull request #6977 from lioncash/add 
Interpreter_FPUtils: Set FPSCR.VXSNAN if either operand to NI_add() is a signaling NaN
 2018-05-27 10:21:20 +02:00
Léo Lam 8f003f995b Merge pull request #6981 from lioncash/const 
CodeWidget/CodeViewWidget: Make symbol pointers const where applicable
 2018-05-27 10:20:38 +02:00
Léo Lam 2bc9a4a902 Merge pull request #6982 from JosJuice/gametracker-race 
DolphinQt2: Fix a race condition in GameTracker
 2018-05-27 10:19:48 +02:00
Léo Lam f568e41fac Merge pull request #6972 from JosJuice/default-jit 
When CPU core is invalid, fall back to JIT instead of interpreter
 2018-05-26 20:18:31 +02:00
Léo Lam 92ec97f899 Merge pull request #6947 from JosJuice/unencrypted-wii-disc 
Make the support for unencrypted Wii disc images less broken
 2018-05-26 11:56:51 +02:00
Léo Lam 3f81c30e8a Merge pull request #6949 from leoetlino/stop 
Remove useless BootManager::Stop
 2018-05-26 11:45:14 +02:00
Léo Lam 98e288cb4b Merge pull request #6966 from lioncash/fmul 
Interpreter_FPUtils: Set FPSCR.VXSNAN if either operand to NI_mul() is a signaling NaN
 2018-05-26 11:43:11 +02:00
Léo Lam f802dc14c1 Remove useless BootManager::Stop 
It's not used anywhere other than in DolphinQt2, where the usage is
incorrect and stupid since we shouldn't be trying to stop the core
and 'restore config' that was changed by the core at app exit time,
but immediately when the core is being shut down.
 2018-05-26 11:33:13 +02:00
Léo Lam f64cbc86b1 Merge pull request #6968 from lioncash/mmu 
MMU: Normalize parameter naming
 2018-05-26 11:18:32 +02:00
Léo Lam 41fe7970da Merge pull request #6969 from lioncash/namespace 
Common: Namespace GekkoDisassembler.cpp/.h
 2018-05-26 11:18:10 +02:00
Léo Lam 3d44dc3981 Merge pull request #6958 from lioncash/rsqrte 
Interpreter_FloatingPoint: Handle SNaN flag setting in frsqrte
 2018-05-25 15:11:28 +02:00
Léo Lam 56217fd42f Merge pull request #6956 from lioncash/flag 
Interpreter_FPUtils: Set the FPSCR.VX bit if any invalid operation exception bits are set
 2018-05-25 15:10:05 +02:00
Léo Lam 9d1785718f Merge pull request #6955 from lioncash/nan 
Interpreter_FloatingPoint: Set FPSCR.VXSNAN if input to fres is a signaling NaN
 2018-05-25 15:09:04 +02:00
Léo Lam 647309a650 Merge pull request #6959 from leoetlino/gcc 
ES/Formats: Work around a GCC bug
 2018-05-25 13:08:57 +02:00
Léo Lam 7c6844e895 ES/Formats: Work around a GCC bug 
In old GCC versions, capturing 'this' does not work for some lambdas.
The workaround is to not use auto for the parameter (even though the
type is obvious). This can be dropped once we require GCC 7.
 2018-05-24 21:27:40 +02:00
Léo Lam dfb1dbad47 Merge pull request #6951 from JosJuice/game-inis-2018-05-23 
Update game INIs
 2018-05-23 21:32:22 +02:00
Léo Lam c99ac40700 Port FS, SD and dump path to onion config 
This ports the Wii filesystem root, Wii SD card path and dump path
settings to the new config system (OnionConfig).

My initial plan was to wait until DolphinWX was removed before porting
most of the Main (Core, DSP, General) settings to onion config, but
I've decided to submit a small part of those changes to fix
[issue 10566](https://bugs.dolphin-emu.org/issues/10566).

Removes the need to manually set the FileUtil path in the UI frontends
and gets rid of some more members that don't really belong in SConfig.

Also fixes a bug which would cause the dump path not to get created
after change.
 2018-05-23 16:07:18 +02:00
Léo Lam 93f49b1ca4 Config: Make Load() and Save() slightly faster 
Only invoke config changed callbacks from Config::Save, not
Layer::Save. The latter results in callbacks being called
once per layer, up to 7 times per save.
 2018-05-23 16:07:18 +02:00
Léo Lam 4fd1674c49 Core: Only init Wii FS contents in Wii mode 
There's no filesystem when not in Wii mode, so... bad things
would happen.
 2018-05-23 13:39:53 +02:00
Léo Lam da03ff2e25 Merge pull request #6944 from leoetlino/init-fs-contents 
Move Wii FS content init to happen after Boot
 2018-05-23 11:37:10 +02:00
Léo Lam 0e9255c469 Merge pull request #6932 from sepalani/debug-patches 
DebugInterface: MemoryPatches methods added
 2018-05-22 19:15:51 +02:00
Léo Lam 43680f314c Merge pull request #6942 from lioncash/const 
BreakPoints: Make OverlapsMemcheck() a const member function
 2018-05-22 19:14:27 +02:00
Léo Lam 593f58be6c Move Wii FS content init to happen after Boot 
Initialising Wii filesystem contents should be done after Boot and
not in HW to ensure that we operate with the correct title context
and to make sure required title directories exist (so that Movie and
Netplay code can copy data from and to the temporary NAND).
 2018-05-22 19:05:45 +02:00
Léo Lam 32c4f3d158 Merge pull request #6930 from lioncash/post 
VideoCommon/PostProcessing: Minor changes
 2018-05-21 21:12:27 +02:00
Léo Lam db5c2ffb41 Merge pull request #6931 from lioncash/vulkan-post 
Vulkan/PostProcessing: Make file-scope std::string instances const char arrays
 2018-05-21 21:11:40 +02:00
Léo Lam 4e63117501 Merge pull request #6933 from lioncash/sign 
Interpreter_SystemRegisters: Get rid of implicit sign conversions
 2018-05-21 21:08:14 +02:00
Léo Lam cb850707c0 WiiSave: Fix typo 2018-05-21 16:41:15 +02:00
Léo Lam af97df74e1 Merge pull request #6895 from leoetlino/hardcoded 
IOSC: Fix hardcoded MS and CA IDs
 2018-05-21 15:27:31 +02:00
Léo Lam 12e2012465 IOSC: Fix hardcoded MS and CA IDs 
The values that are used for the MS and CA IDs come from the SEEPROM.
Also, the default CA and MS values are respectively 2 and 3,
not 1 and 2.
 2018-05-21 15:11:25 +02:00
Léo Lam 3d8e63fffd Merge pull request #6914 from leoetlino/verifysign 
ES: Implement VerifySign (last remaining unimplemented, actually used ioctlv)
 2018-05-20 23:11:49 +02:00
Léo Lam 79edd57b96 Merge pull request #6920 from lioncash/priv 
Interpreter_SystemRegisters: Check processor privilege level in mfspr and mtspr
 2018-05-20 23:08:59 +02:00
Léo Lam 73fde6d84d Merge pull request #6923 from lioncash/prototype 
DolphinQt2/GeckoCodeWidget: Remove unimplemented OnDelete() prototype
 2018-05-20 23:02:26 +02:00
Léo Lam 4284952538 Merge pull request #6919 from lioncash/nop 
Interpreter_LoadStore: No-op dcbt and dcbtst if HID0.NOOPTI is set
 2018-05-20 20:33:38 +02:00