Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
40,038 Commits 1 Branch 0 Tags
9c0cd5c81a3658a52da0d1d0ef9d40b016b26d12
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash 9c0cd5c81a ParallelProgressDialog: Mark WasCanceled() as const 
This doesn't alter any class state.
 2023-06-12 09:38:10 -04:00
Lioncash b70894b950 ParallelProgressDialog: Initialize all data members 
Ensures we always have a deterministic state.
 2023-06-12 09:36:51 -04:00
Lioncash cbd2a720bb InfinityBaseWindow: Remove unnecessary system instance accessor 
GetFigureList() is a static member function, so we can just call it
directly instead of going through the system instance.
 2023-06-12 09:02:20 -04:00
Lioncash 09271f365a PowerPC/ConditionRegister: Mark PPCToInternal() as constexpr 
This allows the compiler to eliminate a static constructor that
initializes the table, and instead precompute all of the data ahead of
time.

e.g. We get something like so on GCC without constexpr:

_GLOBAL__sub_I_PowerPC::ConditionRegister::s_crTable:
        movdqa  xmm0, XMMWORD PTR .LC0[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip], xmm0
        movdqa  xmm0, XMMWORD PTR .LC1[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+16], xmm0
        movdqa  xmm0, XMMWORD PTR .LC2[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+32], xmm0
        movdqa  xmm0, XMMWORD PTR .LC3[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+48], xmm0
        movdqa  xmm0, XMMWORD PTR .LC4[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+64], xmm0
        movdqa  xmm0, XMMWORD PTR .LC5[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+80], xmm0
        movdqa  xmm0, XMMWORD PTR .LC6[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+96], xmm0
        movdqa  xmm0, XMMWORD PTR .LC7[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+112], xmm0
        ret
PowerPC::ConditionRegister::s_crTable:
        .zero   128
.LC0:
        .quad   -9223372032559808511
        .quad   -8646911280256385023
.LC1:
        .quad   -9223372032559808512
        .quad   -8646911280256385024
.LC2:
        .quad   4294967297
        .quad   576460756598390785
.LC3:
        .quad   4294967296
        .quad   576460756598390784
.LC4:
        .quad   -4611686014132420607
        .quad   -4035225261828997119
.LC5:
        .quad   -4611686014132420608
        .quad   -4035225261828997120
.LC6:
        .quad   4611686022722355201
        .quad   5188146775025778689
.LC7:
        .quad   4611686022722355200
        .quad   5188146775025778688

and with constexpr, this all get collapsed into:

PowerPC::ConditionRegister::s_crTable:
        .quad   -9223372032559808511
        .quad   -8646911280256385023
        .quad   -9223372032559808512
        .quad   -8646911280256385024
        .quad   4294967297
        .quad   576460756598390785
        .quad   4294967296
        .quad   576460756598390784
        .quad   -4611686014132420607
        .quad   -4035225261828997119
        .quad   -4611686014132420608
        .quad   -4035225261828997120
        .quad   4611686022722355201
        .quad   5188146775025778689
        .quad   4611686022722355200
        .quad   5188146775025778688

completely eliminating the static constructor. MSVC also exhibits this,
whereas clang is a little better and does this anyway, even without
constexpr.
 2023-06-08 14:33:13 -04:00
Lioncash 349add0f81 GCMemcardManager: Shorten-up EnumMap definitions 
We can make a small alias that gets rid of the need to repeat the long
constant.
 2023-06-08 13:05:13 -04:00
Lioncash 1044bc40ca GCMemcardUtils: Make use of std::span where applicable 
Generifies bits of the interface so that some functions aren't
explicitly tied down to only using std::vector.
 2023-06-08 12:59:43 -04:00
Lioncash fae5ca39ad InfinityBaseWindow: Move core headers into cpp file 
Restricts the headers to the cpp file where they're needed and prevents
the headers from "leaking" into other translation units.
 2023-06-08 12:39:10 -04:00
Lioncash 2b0a9477d0 MemoryViewWidget: Use QStringView with ConvertTextToBytes 
Allows for avoiding string copies. While we're at it, we can also mark
ConvertTextToBytes as const.
 2023-06-08 12:01:59 -04:00
Lioncash cfd25f1d7c CodeDiffDialog: Construct Diff instance in CalculateSymbolsFromProfile() when necessary 
We can move the construction of the Diff instance into the body of the
if statement, so that we only construct this if the condition is true.

While we're at it, we can move the symbol description string into the
instance, getting rid of a copy. The function itself can also be const
qualified.
 2023-06-08 11:55:57 -04:00
Lioncash 496aea54c0 CodeDiffDialog: Pass QString by const reference to create_item 
Avoids churning string copies when updating
 2023-06-08 11:48:09 -04:00
Lioncash c99b0f2eb8 BreakpointWidget: Pass QString by const reference to create_item 
Avoids churning string copies when performing updates.
 2023-06-08 11:46:16 -04:00
Lioncash 867e7d259d BreakpointDialog: Pass QString by const reference to invalid_input 
Gets rid of redundant copying.
 2023-06-08 11:45:14 -04:00
Lioncash d092381d25 InfinityBaseWindow: Collapse lambda into direct member pointer 
The parameters to this match the requirements of the toggled() function
exactly, so we can pass the function directly into the connect call.
 2023-06-08 11:01:34 -04:00
Lioncash 1f874be36e InfinityBaseWindow: Remove redundant string copies 
tr() already returns a QString, so we don't need to construct a QString
around it, and FindFigure() already returns a std::string.
 2023-06-08 11:01:29 -04:00
Lioncash d35be7ce40 InfinityBaseWindow: Add missing header guard 
Prevents potential inclusion issues.
 2023-06-08 10:49:09 -04:00
Mai bab3229c98 Merge pull request #11874 from AdmiralCurtiss/vi-clock-bounds 
VI: Prevent out-of-bounds access when clock register is a nonstandard value.
 2023-06-06 20:31:42 -04:00
Mai fede2ab9a9 Merge pull request #11828 from JosJuice/wia-convert-comments 
DiscIO: Improve comments in WIARVZFileReader::Convert
 2023-05-16 14:39:59 -04:00
Lioncash 1a2b48c204 StringUtil: Move ThousandSeparate() into Common namespace 2023-05-16 14:26:33 -04:00
Lioncash 954afd81ec StringUtil: Move CommandLineToUtf8Argv() into Common namespace 2023-05-16 14:23:21 -04:00
Lioncash d368c989e7 StringUtil: Move GetEscapedHtml() into Common namespace 2023-05-16 14:21:19 -04:00
Lioncash 21df3ca572 StringUtil: Move IsPrintableCharacter() into Common namespace 2023-05-16 14:17:54 -04:00
Lioncash a9f1edeb61 StringUtil: Move IsAlpha() into Common namespace 2023-05-16 14:11:02 -04:00
Mai 361a8b2c8e Merge pull request #11827 from AdmiralCurtiss/ctest-output-on-failure 
CMake: Set --output-on-failure flag for unittests target.
 2023-05-14 00:40:11 -04:00
Lioncash 2561028b91 PPCTables: Remove unnecessary includes 
Gets rid of a lingering dependency on the interpreter in common code and
a bunch of indirect inclusions.
 2023-05-03 21:47:10 -04:00
Lioncash 15d1ae3a8a SymbolDB: Add constructors to Symbol 
Allows for much more convenient in-place construction.
 2023-05-02 16:04:47 -04:00
Lioncash a14d8003f4 PPCSymbolDB: Use emplace() where applicable 
Avoids default constructing an entry in the map that just gets
immediately overwritten. Also gets rid of some redundant map lookups.
 2023-05-02 15:51:52 -04:00
Lioncash 56775e4901 JitInterface: Remove global system accessor 
We can use JitInterface's system member variable to avoid needing this
 2023-05-02 15:21:58 -04:00
Mai 0b9b09ad32 Merge pull request #11796 from sepalani/gecko-sort 
Gecko/ARCode: Add sort by enabled state
 2023-05-02 14:59:08 -04:00
Lioncash 4db186f9ff Common/JitRegister: Move interface into Common namespace 
Makes the namespace consistent with other common utilities.
 2023-05-02 12:00:05 -04:00
Mai d95a85212f Merge pull request #11793 from brad0/openbsd_iconv_build_fix 
Fix build of iconv code on OpenBSD
 2023-04-29 17:08:36 -04:00
Mai ad1240e72f Merge pull request #11801 from Dentomologist/rename_graphicsinteger_to_configinteger 
Qt: Rename GraphicsInteger to ConfigInteger
 2023-04-29 17:08:17 -04:00
Mai 8e6e6f3c4a Merge pull request #11800 from Dentomologist/rename_graphicsradioint_to_configradioint 
Qt: Rename GraphicsRadioInt to ConfigRadioInt
 2023-04-28 12:42:16 -04:00
Mai adbee91dca Merge pull request #11794 from shuffle2/color-scheme-changed 
DolphinQt: reset stylesheets on colorSchemeChanged
 2023-04-26 04:12:03 -04:00
Mai e483b5693f Merge pull request #11795 from Dentomologist/rename_graphicschoice_to_configchoice 
Qt: Rename GraphicsChoice to ConfigChoice
 2023-04-26 04:10:58 -04:00
Mai 8c2e924255 Merge pull request #11774 from shuffle2/qtnext 
DolphinQt: fix some usability issues
 2023-04-25 15:24:44 -04:00
Mai 71a56d9e04 Merge pull request #11775 from shuffle2/qtnext2 
qt: raise min version to 6
 2023-04-25 15:23:32 -04:00
Mai b9a7f577a5 Merge pull request #11765 from Minty-Meeo/ppc-cache-savestate 
Fix PPCCache savestate behavior
 2023-04-25 05:40:15 -04:00
Mai 6bdfcc606f Merge pull request #11788 from shuffle2/qtdpiround 
DolphinQt: use default dpi rounding mode (passthrough)
 2023-04-25 04:05:41 -04:00
Lioncash d991cbaf3c Common: Move CodeTrace.cpp/.h into Core 
This interface relies on Core details and shouldn't be in Common to
begin with, since it's not a general utility.
 2023-04-24 09:10:43 -04:00
Lioncash 30e7ab94fa Common/TraversalProto: Move interface into Common namespace 
Gets the types out of the global namespace.
 2023-04-24 08:53:14 -04:00
Lioncash 27f38c6c8f Common/TraversalClient: Move interface into Common namespace 
Gets the interface out of the global namespace.
 2023-04-24 08:28:25 -04:00
Mai c3cc1de54e Merge pull request #11777 from Dentomologist/move_balloontip_files 
Qt/Config: Move BalloonTip files from Graphics to ToolTipControls
 2023-04-20 10:45:03 -04:00
Mai e0d6b4642d Merge pull request #11776 from Dentomologist/remove_graphicsboolex 
Qt: Remove unused class GraphicsBoolEx
 2023-04-20 10:44:03 -04:00
Lioncash b4cc1ade02 Common/TraversalClient: Use correct deleter with g_MainNetHost 
Previously this was using the default deleter (which just calls delete
on the pointer), which is incorrect, since the ENetHost instance is
allocated through ENet's C API, so we need to use its functions to
deallocate the host instead.
 2023-04-19 12:38:16 -04:00
Lioncash 07ed932a09 Common/LinearDiskCache: Move interface into Common namespace 
Gets the interface out of the global namespace.
 2023-04-19 09:14:39 -04:00
Lioncash f1ad43afaf Common/CommonFuncs: Move interface into Common namespace 
Gets these functions out of the global namespace.
 2023-04-18 19:23:04 -04:00
Mai 1a2dcc53f2 Merge pull request #11742 from K0bin/document-provider-2 
Android: Document Provider improvements
 2023-04-16 04:21:33 -04:00
Mai e50f87af15 Merge pull request #11754 from OatmealDome/sdl2-2.26.5 
Externals: Update SDL to 2.26.5
 2023-04-16 04:20:45 -04:00
Lioncash 784a216927 Common/MathUtil: Move IntLog2 into MathUtil namespace 
Gets this out of the global namespace.
 2023-04-15 03:35:05 -04:00
Lioncash 5e0c20f8a5 Common/MathUtil: Remove MathFloatVectorSum() 
This isn't used anywhere and not really a generic utility, so we can get
rid of it.

This also lets us remove MathUtil.cpp, since this was the only thing
within that file.
 2023-04-15 03:25:38 -04:00
Lioncash e4caace6bb Common/IniFile: Move interface into Common namespace 
Gets this out of the global namespace and into the Common namespace
 2023-04-13 10:19:28 -04:00
Mai 5c03b8af88 Merge pull request #11755 from OatmealDome/mvk-1.2.3 
Externals: Update MoltenVK to 1.2.3
 2023-04-12 22:06:42 -04:00
Lioncash f5bdfdde1a Common/UPnP: Move interface into Common namespace 
Keeps these utilities consistent with the rest of most of the Common
library.
 2023-04-12 14:15:58 -04:00
Lioncash 09e11b8067 Common: Rename ENetUtil.cpp/.h to ENet.cpp/.h 2023-04-11 11:48:46 -04:00
Lioncash 81493ee910 NetPlayServer: Prevent unnecessary copies in GetInterfaceSet() 
This was previously copying each pair out of the vector returned by
GetInterfaceListInternal() when we just need to emplace the first entry
of each pair.
 2023-04-11 09:17:03 -04:00
Lioncash 64ce2012e3 Common/ENetUtil: Move interface into Common namespace 
Rather than just being under a separate ENetUtil namespace, we can unify
this into the common namespace as Common::ENet.
 2023-04-11 09:12:04 -04:00
Mai aaedc2827d Merge pull request #11735 from Pokechu22/cmake-no-spirv-cross-on-linux 
CMake: Don't include SPIRV-Cross except on Windows and macOS
 2023-04-06 23:11:14 -04:00
Mai 5686c614ec Merge pull request #11717 from AdmiralCurtiss/ppcstate-rest 
Replace most remaining global ppcState references.
 2023-04-06 22:35:32 -04:00
Mai 74da38916e Merge pull request #11729 from AdmiralCurtiss/redundant-mov 
Jit64: Fix possibly redundant MOV in ABI_CallFunctionPR().
 2023-04-06 21:42:28 -04:00
Mai 8b9c1bff0b Merge pull request #11731 from Pokechu22/typeutils-cc0 
Common: Relicense TypeUtils to CC0
 2023-04-06 21:41:56 -04:00
Mai 25fba7247e Merge pull request #11726 from mackal/dolphinqt-memory-leaks 
DolphinQt: Fix memory leaks
 2023-04-05 04:18:32 -04:00
Mai 655fca3efe Merge pull request #11712 from AdmiralCurtiss/nand-import-bounds 
NANDImporter: Check data bounds.
 2023-04-03 08:29:57 -04:00
Mai 5cecac5816 Merge pull request #11718 from JosJuice/fi 
Add Finnish translation
 2023-04-03 08:16:55 -04:00
Mai 806ea59d77 Merge pull request #11703 from degasus/asciiart 
Shaders: Add error message for asciiart shader if shader_subgroup is missing.
 2023-03-29 23:34:30 -04:00
Mai 98fad9004b Merge pull request #11698 from AdmiralCurtiss/mmu-comments 
PowerPC/MMU: Clean up old comments.
 2023-03-27 10:32:19 -04:00
Mai c096ee64f2 Merge pull request #11696 from AdmiralCurtiss/jit-interface-class 
JitInterface: Refactor to class, move to System.
 2023-03-27 10:31:53 -04:00
Mai 51f668ac4b Merge pull request #11691 from AdmiralCurtiss/deglobal-interpreter-2 
Interpreter: Remove remaining System::GetInstance() and global ppcState.
 2023-03-25 02:38:58 -04:00
Lioncash 0f326c6067 Common: Move FixedSizeQueue into Common namespace 
Gets this out of the global namespace.
 2023-03-22 01:23:15 -04:00
Lioncash 0888c93d48 Common: Move FPU-related helpers into Common namespace 
Makes these utilities' namespace consistent with the majority of the
Common library.
 2023-03-21 10:58:13 -04:00
Mai 9807961ff2 Merge pull request #11671 from AdmiralCurtiss/deglobal-interpreter 
Deglobalize Interpreter
 2023-03-20 15:55:14 -04:00
Mai 4281606838 Merge pull request #11641 from JosJuice/android-remove-old-config 
Android: Remove support for the old config system
 2023-03-14 15:48:04 -04:00
Mai 137b9d1da1 Merge pull request #11646 from AdmiralCurtiss/si-class 
HW/SerialInterface: Refactor to class.
 2023-03-13 13:09:51 -04:00
Mai 5d07a45241 Merge pull request #11643 from InfoManiac742/master 
Fix missing GameINI for Japanese version of Sonic Adventure 2: Battle
 2023-03-12 04:27:29 -04:00
Mai ab05dfc263 Merge pull request #11642 from shuffle2/winupdater-fail 
winupdater: improve wording of UI::Error
 2023-03-12 04:11:16 -04:00
Mai ee28d332b0 Merge pull request #11640 from AdmiralCurtiss/vi-class 
HW/VideoInterface: Refactor to class.
 2023-03-11 18:00:24 -05:00
Mai 7b5c989f2d Merge pull request #11639 from AdmiralCurtiss/exi-class 
HW: Refactor ExpansionInterface and MemoryInterface to classes.
 2023-03-10 21:36:14 -05:00
Mai e4df388128 Merge pull request #11638 from JosJuice/tas-input-motionplus 
DolphinQt: Add MotionPlus support to TAS input
 2023-03-10 16:54:35 -05:00
Mai 00a6f8c82c Merge pull request #11637 from AdmiralCurtiss/dvd-class 
HW/DVD: Refactor DVDInterface and DVDThread to classes.
 2023-03-10 16:51:19 -05:00
Mai 3ec32c5aa5 Merge pull request #11634 from AdmiralCurtiss/dsp-class 
HW/DSP: Refactor to class.
 2023-03-09 20:06:53 -05:00
Mai 40ff9b25b7 Merge pull request #11633 from AdmiralCurtiss/ai-class 
HW/AudioInterface: Refactor to class.
 2023-03-09 11:59:47 -05:00
Mai 2856723bc1 Merge pull request #11632 from AdmiralCurtiss/pass-more-system 
Pass System to Boot functions, CPUThreadGuard, IEXIDevice.
 2023-03-08 17:38:40 -05:00
Mai c592c94395 Merge pull request #11630 from AdmiralCurtiss/globals-cpu 
HW/CPU: Refactor to class, move to System.
 2023-03-08 11:52:30 -05:00
Mai f1e4b6a141 Merge pull request #11494 from t895/orientation-jank 
Android: Rewrite Wii system updates in Kotlin
 2023-03-08 01:42:53 -05:00
Mai 16023ece6d Merge pull request #11621 from deReeperJosh/skylandersfilefix 
Skylander Portal: Clearing and Reloading fix
 2023-03-07 15:24:46 -05:00
Mai 0461fae99e Merge pull request #11629 from AdmiralCurtiss/globals-hsp 
HW/HSP: Refactor to class, move to System.
 2023-03-07 12:17:43 -05:00
Mai 6361586a04 Merge pull request #11582 from Pokechu22/software-crash-on-startup 
Software: Fix regressions from "Kill Renderer"
 2023-03-02 15:13:00 -05:00
Mai ab2f8d3475 Merge pull request #11607 from AdmiralCurtiss/sd-progress 
Qt/WiiPane: Add progress window for SD card conversion.
 2023-03-02 15:08:18 -05:00
Mai 6fcec80eb0 Merge pull request #11605 from JosJuice/android-mappings-button 
Android: Add a button for accessing controller mappings
 2023-03-02 15:06:47 -05:00
Mai cbbc518bc4 Merge pull request #11612 from iwubcode/custom_texture_data 
VideoCommon: move hirestexture data to reusable class called CustomTextureData
 2023-03-02 15:05:46 -05:00
Mai 78e8669bac Merge pull request #11614 from t895/kotlin-cheats 
Android: Convert Cheats Activity to Kotlin
 2023-03-02 15:04:19 -05:00
Mai 1b7969bc62 Merge pull request #11615 from t895/kotlin-riivolution 
Android: Convert Riivolution Boot Activity to Kotlin
 2023-03-02 15:03:43 -05:00
Mai b9fd7e7bd4 Merge pull request #11616 from t895/kotlin-skylanders 
Android: Convert Skylanders code to Kotlin
 2023-03-02 15:03:18 -05:00
Mai 5d00bc088a Merge pull request #11619 from t895/kotlin-convert 
Android: Convert Convert Activity to Kotlin
 2023-03-02 15:02:45 -05:00
Mai 6f21ce7d95 Merge pull request #11555 from CookiePLMonster/wil-todos 
Address WIL todos in UICommon.cpp
 2023-02-20 10:14:49 -05:00
Mai c7f48c8f28 Merge pull request #11587 from AdmiralCurtiss/code-view-breakpoint-logic 
Qt/CodeViewWidget: Small fixes to Update().
 2023-02-20 10:10:04 -05:00
Mai f004080382 Merge pull request #11573 from Pokechu22/freesurround-bad-delete 
Externals/FreeSurround: Fix pointer created through new[] being freed via delete
 2023-02-16 03:44:33 -05:00
Mai 19bf13d3bb Merge pull request #11572 from Pokechu22/uninitialized-variables-feb-2023 
Fix uninitialized variable warnings (C26495)
 2023-02-16 00:56:01 -05:00
Lioncash cdd3e636e1 Common/Network: Resolve -Wexpansion-to-defined warning 
Macros that expand to include the standard define macro are undefined.
This is pretty trivial to fix. We can just do the test and then define
the name itself if it's true, rather than making the set of definition
checks the macro itself.
 2023-01-30 14:20:56 -05:00
Lioncash 5c1954c843 AndroidCommon: Make use of std::string_view where applicable 
Several of these can take a string_view rather than needing to
specifically use std::string.
 2023-01-30 13:30:52 -05:00
Lioncash f20790370a Core/ActionReplay: Make use of std::span where applicable 
Generifies the interface a little by not strictly requiring the use of
std::vector.
 2023-01-30 13:02:09 -05:00