Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
41,006 Commits 1 Branch 0 Tags
a0da6788a36399f3e42a28dc6f1d5c28f549955c
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash 0df7908025 VideoCommon/Present: Remove use of g_presenter inside Presenter class 
There's no need to self reference a global of the class itself when we
can just call the function directly.
 2023-12-09 20:15:32 -05:00
Mai bec4c77325 Merge pull request #12367 from AdmiralCurtiss/mail-includes 
IOS/KD/Mail: Add missing includes.
 2023-12-09 15:25:24 -05:00
Mai dd227fea5a Merge pull request #12364 from JosJuice/android-emulation-settings-reload 
Android: Fix crash after process recreation
 2023-12-08 21:24:05 -05:00
Mai 636b892b7c Merge pull request #12360 from TryTwo/bugfix_wiimote_signal_spam 
WiimoteDevice. Bugfix. Remove signal spam while starting a game.
 2023-12-08 21:07:51 -05:00
Mai e0f4111561 Merge pull request #11663 from JosJuice/android-config-change-callback 
Android: Use config changed callback for tracking recursive scan setting
 2023-12-07 16:48:02 -05:00
Mai 3a4cf579ff Merge pull request #12247 from LillyJadeKatrin/retroachievements-challenges 
RetroAchievements - Challenge Icons
 2023-12-07 16:46:43 -05:00
Mai 2ece642cf8 Merge pull request #12357 from AdmiralCurtiss/ipl-bounds 
Core/Boot: Check bounds in Load_BS2().
 2023-12-06 19:57:26 -05:00
Mai b4276049fc Merge pull request #12216 from LillyJadeKatrin/retroachievements-rehash 
RetroAchievements - Improved Game Loading
 2023-12-05 18:22:38 -05:00
Mai a65246ec3f Merge pull request #11988 from JosJuice/jit-feature-flags 
Jit: Replace "msrBits" with "featureFlags" and use for performance monitor
 2023-12-05 03:13:50 -05:00
Mai 2199dd26bb Merge pull request #12345 from minhaferzz/startup-handler 
Android: Fix issue when launching a game when Dolphin is not open
 2023-12-05 03:10:41 -05:00
Mai bf415f9b54 Merge pull request #12350 from PatrickFerry/add_accurate_nans_game 
Gameini: Enable AccurateNaNs for "Jeep Thrills"
 2023-12-05 01:35:00 -05:00
Mai 6e6695c24b Merge pull request #11904 from LillyJadeKatrin/retroachievements-hardcore-v2 
RetroAchievements - Hardcore Mode (V2)
 2023-12-05 01:31:54 -05:00
Mai 27be8c087e Merge pull request #12295 from sepalani/arp-check 
BBA/HLE: Fix GC homebrew if_config not working
 2023-12-03 11:26:00 -05:00
Mai 98eda4dc9f Merge pull request #12351 from TryTwo/bugfix_data_symbols 
PPCSymbolDB. Bugfix. Fix .data symbols not loading
 2023-12-03 11:17:44 -05:00
Mai 87256e3ec3 Merge pull request #12353 from JosJuice/hle-discard-cr 
PPCAnalyst: Clear crInUse on HLE
 2023-12-03 09:20:29 -05:00
Mai 4f3f208fe4 Merge pull request #12348 from JosJuice/jitarm64-imm-msr-fastmem 
JitArm64: Fix updating MEM_REG with imm MSR without fastmem
 2023-12-02 17:53:28 -05:00
Mai c54e8d733f Merge pull request #12347 from JosJuice/jitarm64-paired-offset 
JitArm64: Use ADDI2R for psq_lXX/psq_stXX immediate offsets
 2023-12-01 20:15:06 -05:00
Mai 5f7e9d3bf1 Merge pull request #12320 from JosJuice/jitarm64-mmu-order 
PowerPC: Unify "FromJit" MMU functions
 2023-11-30 18:34:32 -05:00
Mai d85cb749c0 Merge pull request #11382 from skyfloogle/traversal-fix-2 
Traversal: Use low TTL for probe packet
 2023-11-30 18:03:50 -05:00
Mai d67f54b175 Merge pull request #12186 from TellowKrinkle/MultiTextureComputeMetal 
VideoBackends:Metal: Support multiple compute textures
 2023-11-30 17:46:02 -05:00
Mai 89963c287c Merge pull request #11958 from JosJuice/jitarm64-dispatcher-microopt 
JitArm64: Dispatcher optimizations
 2023-11-29 16:54:09 -05:00
Mai 2d0e577f8f Merge pull request #12340 from JosJuice/jit-gp-check-discard-cr 
PPCAnalyst: Don't discard CR before gather pipe interrupt check
 2023-11-29 16:51:03 -05:00
Mai 0a62b30cd4 Merge pull request #11906 from noahpistilli/request-register-user-id 
IOS/KD: Implement Request Register User ID
 2023-11-29 03:31:59 -05:00
Mai 02de58eb2c Merge pull request #12337 from Tilka/imm16 
Jit64: fix invalid instruction encoding
 2023-11-29 01:10:22 -05:00
Mai a7216a3035 Merge pull request #9857 from JosJuice/jitarm64-cr-analysis 
PPCAnalyst: Allow more reordering of CR operations
 2023-11-28 21:01:07 -05:00
Mai b7435be90a Merge pull request #12298 from Shoegzer/master 
Update default IP for HLE BBA
 2023-11-28 22:45:17 +01:00
Mai d095bddbe7 Merge pull request #12141 from JosJuice/jit-blr-msr 
Jit: Check MSR state in BLR optimization
 2023-11-28 22:35:35 +01:00
Mai 934418a289 Merge pull request #12092 from JosJuice/jitarm64-last-nan 
JitArm64: Skip checking last input for NaN for non-SIMD operations
 2023-11-28 22:30:50 +01:00
Mai 95f06ef231 Merge pull request #12122 from JosJuice/jit-imm-msr 
Jit: Handle imm msr in EmitStoreMembase
 2023-11-28 21:34:23 +01:00
Mai 8cf0597d5f Merge pull request #12091 from JosJuice/jitarm64-skip-quiet-bit 
JitArm64: Use one instruction for making NaNs quiet
 2023-11-28 21:33:25 +01:00
Mai e99ead0a68 Merge pull request #12124 from JosJuice/jitarm64-mfsrin-mtsrin-addr 
JitArm64: Optimize mfsrin/mtsrin address calculations
 2023-11-28 21:30:30 +01:00
Mai b53ecd73fb Merge pull request #12143 from JosJuice/jitarm64-loadstore-pc 
JitArm64: Write PC when calling MMU.cpp
 2023-11-28 21:29:37 +01:00
Mai 1df685b2d7 Merge pull request #12123 from JosJuice/jit-mcrxr 
Jit: Some mcrxr optimizations
 2023-11-28 19:32:47 +01:00
Mai 20b13df507 Merge pull request #12179 from JosJuice/jitarm64-gp-deduplicate 
JitArm64: Deduplicate the gather pipe exception check
 2023-11-28 19:21:58 +01:00
Mai ac53766058 Merge pull request #12215 from JosJuice/android-si-devices 
Android: Add more GameCube controller types
 2023-11-28 19:21:29 +01:00
Mai bfc6bca583 Merge pull request #12235 from JosJuice/jitarm64-float-cls 
JitArm64: Use LSL+CLS for classifying floats
 2023-11-28 19:20:01 +01:00
Mai 9d415c1dbc Merge pull request #12192 from JosJuice/jitarm64-nan-check 
JitArm64: Check packed NaNs without using extra register
 2023-11-28 04:22:27 +01:00
Mai 99cf862596 Merge pull request #12317 from JosJuice/setting-saveable-cleanup 
Config: Clean up IsSettingSaveable
 2023-11-28 04:20:21 +01:00
Mai 7e9c19fdb1 Merge pull request #12231 from JosJuice/jitarm64-frsqrte-optimization 
JitArm64: Optimize frsqrte routine
 2023-11-28 04:19:27 +01:00
Mai 731013c316 Merge pull request #12263 from Dentomologist/realtime_cheatsearch_update 
CheatSearch: Automatically update Current Values
 2023-11-28 04:17:06 +01:00
Mai 2869a4c168 Merge pull request #12278 from JosJuice/jitarm64-gpr-loop 
JitArm64: Optimize Arm64GPRCache::FlushRegisters/FlushCRRegisters
 2023-11-28 04:14:34 +01:00
Mai 6be8e63b23 Merge pull request #12306 from JosJuice/hle-discard 
PPCAnalyst: Don't discard registers across HLE'd functions
 2023-11-28 04:05:31 +01:00
Mai d28155a7bb Merge pull request #12265 from TryTwo/FuncFinder_bkup 
CodeDiffDialog: Add saving/loading results to a file.
 2023-11-27 19:00:27 +01:00
Mai eba2b9ab9c Merge pull request #12279 from Dentomologist/opengl_single_core_fix_start_movie_recording_crash 
Movie: Fix crash when starting input recording on OpenGL single core
 2023-11-27 03:19:54 +01:00
Mai e8faad3ccc Merge pull request #12300 from iwubcode/dump_texture_free_function 
VideoCommon: move texture dump to a free function
 2023-11-27 00:18:22 +01:00
Mai 1a2d0882d0 Merge pull request #12319 from JosJuice/jitarm64-branch-not-farcode 
JitArm64: Don't use farcode for conditional branch instructions
 2023-11-26 23:09:25 +01:00
Mai c8a493964a Merge pull request #12307 from iwubcode/xxhash 
Externals: update xxhash to 0.8.2 as submodule
 2023-11-26 23:00:24 +01:00
Mai 10e2ad305d Merge pull request #12316 from JosJuice/android-less-host-thread-lock 
Android: Remove HostThreadLocks that are no longer needed
 2023-11-26 22:56:55 +01:00
Mai 8a19be6052 Merge pull request #12321 from Dentomologist/netplay_setup_dialog_connect_tab_fix_spacing 
NetPlaySetupDialog: Fix spacing in Connect tab
 2023-11-26 22:51:42 +01:00
Lioncash 05015531a8 SkylanderModifyDialog: Remove unnecessary string conversions 2023-11-25 22:29:44 -05:00
Lioncash 8dfbc45df7 SkylanderModifyDialog: Mark label string as translatable 
This is a user-facing string. Also fixes a nearby typo in an error
message string.
 2023-11-25 22:29:41 -05:00
Lioncash cdfabb4524 SkylandersPortalWindow: Directly connect slot in CreateSlotLayout 
The interface corresponds with what QCheckBox::toggled wants, so we can
use the member function directly.
 2023-11-25 22:16:39 -05:00
Lioncash 24c009f7ce SkylandersPortalWindow: Mark helpers as const/static where applicable 
These helpers don't directly modify class state.
 2023-11-25 21:44:07 -05:00
Lioncash 6d47d6c08e SkylandersPortalWindow: Remove unnecessary string conversions 
Same behavior without a bit of churn.
 2023-11-25 21:33:25 -05:00
Lioncash 04011373f3 CustomAssetLibrary: Remove unnecessary qualifier in LoadInfo 
The type is already in visible scope, so we don't need the rather length
qualifier.
 2023-11-25 18:01:44 -05:00
Lioncash b85902ccb5 CustomAssetLibrary: Add virtual destructor 
This is used as a base pointer inside CustomPipelineAction, so this
should probably really have a virtual destructor to ensure derived
objects are torn down properly.
 2023-11-25 18:01:17 -05:00
Lioncash 644f7f6e55 WC24Send: Add missing header guard 
Prevents double inclusions from occurring in the same TU.
 2023-11-25 17:53:46 -05:00
Mai 54d3a226f3 Merge pull request #12088 from JosJuice/jitarm64-zero-fpr 
JitArm64: Prefer MOVI with 64-bit elements for zeroing
 2023-08-09 09:14:40 -04:00
Lioncash 696087cae0 Qt/NetworkWidget: Get rid of some trivial sign conversions 
In all instances, these variables should be signed rather than unsigned.
 2023-06-17 10:48:49 -04:00
Lioncash 653d6d059f UICommon/ResourcePack: Allow priority helpers to take arguments by const reference 
There's nothing going on with behavior here that would prevent these
from being const qualified.

Also better communicates that this function isn't intended to modify the
given resource pack.
 2023-06-16 10:20:50 -04:00
Lioncash 708c986693 PPCCache: Remove redundant reinterpret_casts 
The pointer is being passed to functions that take arguments as void*,
so we don't need to cast here.
 2023-06-13 08:25:26 -04:00
Lioncash 41df38cb7c Common: Move DebugInterface.h into Core 
The base DebugInterface now depends on the Core's CPUThreadGuard, and
utilities in Common shouldn't be depending on Core facilities. So, we
can move this into the core library instead.
 2023-06-12 10:35:31 -04:00
Lioncash 6e9afd9a73 BreakpointDialog: Mark breakpoint help text as translatable 
We already mark the title of the dialog box as translatable, so it
would be a bit odd to not mark the containing text as translatable too.
 2023-06-12 09:50:17 -04:00
Lioncash 9c0cd5c81a ParallelProgressDialog: Mark WasCanceled() as const 
This doesn't alter any class state.
 2023-06-12 09:38:10 -04:00
Lioncash b70894b950 ParallelProgressDialog: Initialize all data members 
Ensures we always have a deterministic state.
 2023-06-12 09:36:51 -04:00
Lioncash 001fe6ff61 SkylanderPortalWindow: Detranslate unnecessary strings 
This doesn't need to be handled by translators, since they're not
user-displayed text or just don't need to be translated.

While we're at it, we don't need to copy each entry of the resulting
list.
 2023-06-12 09:26:16 -04:00
Lioncash cbd2a720bb InfinityBaseWindow: Remove unnecessary system instance accessor 
GetFigureList() is a static member function, so we can just call it
directly instead of going through the system instance.
 2023-06-12 09:02:20 -04:00
Lioncash 09271f365a PowerPC/ConditionRegister: Mark PPCToInternal() as constexpr 
This allows the compiler to eliminate a static constructor that
initializes the table, and instead precompute all of the data ahead of
time.

e.g. We get something like so on GCC without constexpr:

_GLOBAL__sub_I_PowerPC::ConditionRegister::s_crTable:
        movdqa  xmm0, XMMWORD PTR .LC0[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip], xmm0
        movdqa  xmm0, XMMWORD PTR .LC1[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+16], xmm0
        movdqa  xmm0, XMMWORD PTR .LC2[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+32], xmm0
        movdqa  xmm0, XMMWORD PTR .LC3[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+48], xmm0
        movdqa  xmm0, XMMWORD PTR .LC4[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+64], xmm0
        movdqa  xmm0, XMMWORD PTR .LC5[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+80], xmm0
        movdqa  xmm0, XMMWORD PTR .LC6[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+96], xmm0
        movdqa  xmm0, XMMWORD PTR .LC7[rip]
        movaps  XMMWORD PTR PowerPC::ConditionRegister::s_crTable[rip+112], xmm0
        ret
PowerPC::ConditionRegister::s_crTable:
        .zero   128
.LC0:
        .quad   -9223372032559808511
        .quad   -8646911280256385023
.LC1:
        .quad   -9223372032559808512
        .quad   -8646911280256385024
.LC2:
        .quad   4294967297
        .quad   576460756598390785
.LC3:
        .quad   4294967296
        .quad   576460756598390784
.LC4:
        .quad   -4611686014132420607
        .quad   -4035225261828997119
.LC5:
        .quad   -4611686014132420608
        .quad   -4035225261828997120
.LC6:
        .quad   4611686022722355201
        .quad   5188146775025778689
.LC7:
        .quad   4611686022722355200
        .quad   5188146775025778688

and with constexpr, this all get collapsed into:

PowerPC::ConditionRegister::s_crTable:
        .quad   -9223372032559808511
        .quad   -8646911280256385023
        .quad   -9223372032559808512
        .quad   -8646911280256385024
        .quad   4294967297
        .quad   576460756598390785
        .quad   4294967296
        .quad   576460756598390784
        .quad   -4611686014132420607
        .quad   -4035225261828997119
        .quad   -4611686014132420608
        .quad   -4035225261828997120
        .quad   4611686022722355201
        .quad   5188146775025778689
        .quad   4611686022722355200
        .quad   5188146775025778688

completely eliminating the static constructor. MSVC also exhibits this,
whereas clang is a little better and does this anyway, even without
constexpr.
 2023-06-08 14:33:13 -04:00
Lioncash 349add0f81 GCMemcardManager: Shorten-up EnumMap definitions 
We can make a small alias that gets rid of the need to repeat the long
constant.
 2023-06-08 13:05:13 -04:00
Lioncash 1044bc40ca GCMemcardUtils: Make use of std::span where applicable 
Generifies bits of the interface so that some functions aren't
explicitly tied down to only using std::vector.
 2023-06-08 12:59:43 -04:00
Lioncash fae5ca39ad InfinityBaseWindow: Move core headers into cpp file 
Restricts the headers to the cpp file where they're needed and prevents
the headers from "leaking" into other translation units.
 2023-06-08 12:39:10 -04:00
Lioncash 2b0a9477d0 MemoryViewWidget: Use QStringView with ConvertTextToBytes 
Allows for avoiding string copies. While we're at it, we can also mark
ConvertTextToBytes as const.
 2023-06-08 12:01:59 -04:00
Lioncash cfd25f1d7c CodeDiffDialog: Construct Diff instance in CalculateSymbolsFromProfile() when necessary 
We can move the construction of the Diff instance into the body of the
if statement, so that we only construct this if the condition is true.

While we're at it, we can move the symbol description string into the
instance, getting rid of a copy. The function itself can also be const
qualified.
 2023-06-08 11:55:57 -04:00
Lioncash 496aea54c0 CodeDiffDialog: Pass QString by const reference to create_item 
Avoids churning string copies when updating
 2023-06-08 11:48:09 -04:00
Lioncash c99b0f2eb8 BreakpointWidget: Pass QString by const reference to create_item 
Avoids churning string copies when performing updates.
 2023-06-08 11:46:16 -04:00
Lioncash 867e7d259d BreakpointDialog: Pass QString by const reference to invalid_input 
Gets rid of redundant copying.
 2023-06-08 11:45:14 -04:00
Lioncash d092381d25 InfinityBaseWindow: Collapse lambda into direct member pointer 
The parameters to this match the requirements of the toggled() function
exactly, so we can pass the function directly into the connect call.
 2023-06-08 11:01:34 -04:00
Lioncash 1f874be36e InfinityBaseWindow: Remove redundant string copies 
tr() already returns a QString, so we don't need to construct a QString
around it, and FindFigure() already returns a std::string.
 2023-06-08 11:01:29 -04:00
Lioncash d35be7ce40 InfinityBaseWindow: Add missing header guard 
Prevents potential inclusion issues.
 2023-06-08 10:49:09 -04:00
Mai bab3229c98 Merge pull request #11874 from AdmiralCurtiss/vi-clock-bounds 
VI: Prevent out-of-bounds access when clock register is a nonstandard value.
 2023-06-06 20:31:42 -04:00
Mai fede2ab9a9 Merge pull request #11828 from JosJuice/wia-convert-comments 
DiscIO: Improve comments in WIARVZFileReader::Convert
 2023-05-16 14:39:59 -04:00
Lioncash 1a2b48c204 StringUtil: Move ThousandSeparate() into Common namespace 2023-05-16 14:26:33 -04:00
Lioncash 954afd81ec StringUtil: Move CommandLineToUtf8Argv() into Common namespace 2023-05-16 14:23:21 -04:00
Lioncash d368c989e7 StringUtil: Move GetEscapedHtml() into Common namespace 2023-05-16 14:21:19 -04:00
Lioncash 21df3ca572 StringUtil: Move IsPrintableCharacter() into Common namespace 2023-05-16 14:17:54 -04:00
Lioncash a9f1edeb61 StringUtil: Move IsAlpha() into Common namespace 2023-05-16 14:11:02 -04:00
Mai 361a8b2c8e Merge pull request #11827 from AdmiralCurtiss/ctest-output-on-failure 
CMake: Set --output-on-failure flag for unittests target.
 2023-05-14 00:40:11 -04:00
Lioncash 2561028b91 PPCTables: Remove unnecessary includes 
Gets rid of a lingering dependency on the interpreter in common code and
a bunch of indirect inclusions.
 2023-05-03 21:47:10 -04:00
Lioncash 15d1ae3a8a SymbolDB: Add constructors to Symbol 
Allows for much more convenient in-place construction.
 2023-05-02 16:04:47 -04:00
Lioncash a14d8003f4 PPCSymbolDB: Use emplace() where applicable 
Avoids default constructing an entry in the map that just gets
immediately overwritten. Also gets rid of some redundant map lookups.
 2023-05-02 15:51:52 -04:00
Lioncash 56775e4901 JitInterface: Remove global system accessor 
We can use JitInterface's system member variable to avoid needing this
 2023-05-02 15:21:58 -04:00
Mai 0b9b09ad32 Merge pull request #11796 from sepalani/gecko-sort 
Gecko/ARCode: Add sort by enabled state
 2023-05-02 14:59:08 -04:00
Lioncash 4db186f9ff Common/JitRegister: Move interface into Common namespace 
Makes the namespace consistent with other common utilities.
 2023-05-02 12:00:05 -04:00
Mai d95a85212f Merge pull request #11793 from brad0/openbsd_iconv_build_fix 
Fix build of iconv code on OpenBSD
 2023-04-29 17:08:36 -04:00
Mai ad1240e72f Merge pull request #11801 from Dentomologist/rename_graphicsinteger_to_configinteger 
Qt: Rename GraphicsInteger to ConfigInteger
 2023-04-29 17:08:17 -04:00
Mai 8e6e6f3c4a Merge pull request #11800 from Dentomologist/rename_graphicsradioint_to_configradioint 
Qt: Rename GraphicsRadioInt to ConfigRadioInt
 2023-04-28 12:42:16 -04:00
Mai adbee91dca Merge pull request #11794 from shuffle2/color-scheme-changed 
DolphinQt: reset stylesheets on colorSchemeChanged
 2023-04-26 04:12:03 -04:00
Mai e483b5693f Merge pull request #11795 from Dentomologist/rename_graphicschoice_to_configchoice 
Qt: Rename GraphicsChoice to ConfigChoice
 2023-04-26 04:10:58 -04:00
Mai 8c2e924255 Merge pull request #11774 from shuffle2/qtnext 
DolphinQt: fix some usability issues
 2023-04-25 15:24:44 -04:00
Mai 71a56d9e04 Merge pull request #11775 from shuffle2/qtnext2 
qt: raise min version to 6
 2023-04-25 15:23:32 -04:00