Lioncash
d6b6b070bc
D3D/Render: Get rid of undefined behavior in Create3DVisionTexture
...
pSysMem is of the type const void* -- because of this, it makes the
original delete[] call undefined behavior, as deleting a void pointer is
undefined behavior.
Also punning types into existence, like what was done for the stereo
image header is undefined behavior as well. The proper way to do this is
to either manually add all individual bytes manually, or memcpy the
struct into memory.
As we want to deallocate the memory before returning, and because
pSysMem is a const void*, we keep a unique_ptr to the data and just pass
pSysMem a raw pointer to the data.
2017-05-28 23:28:00 -04:00
Lioncash
278e406f0b
D3D/Render: Use std::array where applicable
2017-05-28 23:28:00 -04:00
Lioncash
0c3958bbe5
D3D/Render: Join variable with declaration
2017-05-28 23:27:59 -04:00
Lioncash
3ee447e5f7
D3D/Render: Get rid of unnecessary casts
2017-05-28 23:27:59 -04:00
Lioncash
ba5b215c42
D3D/Render: Mark translation unit local variables as static
2017-05-28 23:27:59 -04:00
Mat M
9fa1e8f45f
Merge pull request #5493 from lioncash/include
...
CubebStream: Add missing <vector> include
2017-05-28 02:08:35 -04:00
Lioncash
3e7af2a2cd
CubebStream: Add missing <vector> include
2017-05-27 23:50:39 -04:00
Mat M
905232fd2b
Merge pull request #5313 from ligfx/addcubeb
...
Add CubebStream output backend and replace PortAudio for microphones
2017-05-27 21:39:03 -04:00
Mat M
7192226971
Merge pull request #5474 from sepalani/bl-fix
...
CodeView: Fix missing bl details
2017-05-27 17:40:18 -04:00
Mat M
7b70fce79b
Merge pull request #5476 from ligfx/ffmpegbuildcleanup
...
CMake/MSVC: cleanups around FFMpeg
2017-05-27 17:36:55 -04:00
Mat M
b7cc4d73dc
Merge pull request #5469 from ligfx/cmakecleanupunittests
...
CMake: various cleanups for UnitTests
2017-05-23 02:08:58 -04:00
Mat M
3f437337a1
Merge pull request #5466 from lioncash/db
...
SignatureDB: Minor cleanup
2017-05-22 21:25:36 -04:00
Mat M
4bfd464b0c
Merge pull request #5468 from leoetlino/headers
...
Fix some header includes
2017-05-22 21:22:04 -04:00
Lioncash
73b72c6a62
TitleDatabase: Remove unused <iostream> header
...
Many implementations of <iostream> inject a static constructor into the
translation unit, it's included in, even if nothing from the header is used.
2017-05-21 17:51:47 -04:00
Lioncash
c3bab0b0e7
SignatureDB: Remove unnecessary header
2017-05-21 17:39:44 -04:00
Lioncash
bbe1e643fb
SignatureDB: in-class initialize DBFunc members
2017-05-21 17:39:42 -04:00
Lioncash
d0089191e1
SignatureDB: default the format handler destructor
2017-05-21 17:39:41 -04:00
Lioncash
5301efddd0
SignatureDB: Remove unnecessary qualifiers and virtual keywords
2017-05-21 17:39:40 -04:00
Lioncash
3c94962332
SignatureDB: Move two functions into the cpp file
...
These are implementation details.
2017-05-21 17:39:34 -04:00
Mat M
b47d44ab15
Merge pull request #5445 from JosJuice/remove-jitil
...
Remove JITIL
2017-05-19 21:33:38 -04:00
Mat M
1880a97bb0
Merge pull request #4424 from Helios747/remove_more_features
...
Remove D3D12
2017-05-18 20:04:40 -04:00
Lioncash
35aa55931f
MainAndroid: Resolve -Wmissing-variable-declarations warnings
2017-05-18 19:55:05 -04:00
Mat M
35a8771e68
Merge pull request #5427 from lioncash/host
...
Host: Get rid of Host_SetStartupDebuggingParameters()
2017-05-18 19:04:25 -04:00
Lioncash
7baabe99d1
Host: Get rid of Host_SetStartupDebuggingParameters()
...
This is something that should be the responsibility of the frontend
booting the game. Making this part of the host 'interface' inherently
requires frontends to leak internal details (much like the other
UI-related functions in the interface).
This also decouples more behavior from the debugger and the
initialization process in the wx frontend. This also eliminates several
usages of the parent menubar in the debugger code window.
2017-05-14 19:12:59 -04:00
Lioncash
198d686a41
MEGASignatureDB: Add missing override specifiers
2017-05-14 16:20:45 -04:00
Mat M
7a25dde8df
Merge pull request #5387 from leoetlino/constexpr
...
Contributing: Use constexpr for compile-time constants
2017-05-07 17:56:37 -04:00
Mat M
ef4a1f0ec7
Merge pull request #5384 from leoetlino/disable
...
WX: Disable NAND import when emulation is running
2017-05-06 19:38:07 -04:00
Mat M
4ba786a164
Merge pull request #5381 from JosJuice/cached-title-id
...
DolphinWX: Use title ID from ISOFile when possible
2017-05-06 19:37:25 -04:00
Mat M
f3052b7a15
Merge pull request #5318 from ligfx/cmakehidapi
...
CMake: clean up HIDAPI build
2017-05-03 19:54:06 -04:00
Mat M
d48c3ce63e
Merge pull request #5361 from ligfx/signaturedbwarning
...
SignatureDB: fix prevented copy elision
2017-05-02 23:09:49 -04:00
Mat M
7c3905a612
Merge pull request #5140 from sepalani/signature_db
...
SignatureDB: Rewrite FormatHandler API
2017-05-02 19:23:46 -04:00
Mat M
c51e40f92f
Merge pull request #5357 from ligfx/jitintegerwarning
...
Jit64: fix braces warning in Jit_Integer
2017-05-02 18:44:02 -04:00
Mat M
d66e0e38d3
Merge pull request #5359 from ligfx/nandimporterwarning
...
NANDImporter: fix printf warning
2017-05-02 18:43:28 -04:00
Lioncash
9e71031e23
Frame: Normalize member names
2017-05-01 05:13:19 -04:00
Mat M
1bad3bef4b
Merge pull request #5344 from lioncash/table
...
MemoryWindow: Minor cleanup
2017-04-30 18:32:29 -04:00
Mat M
344767a258
Merge pull request #5336 from JosJuice/memcard-shiftjis
...
Fix display of Japanese text in the Memory Card Manager
2017-04-30 18:22:47 -04:00
Mat M
d5534e069c
Merge pull request #5334 from spycrab/wx_gamelist_cleanup
...
Refactor GameListCtrl
2017-04-30 18:21:50 -04:00
Mat M
eb8dbe03ad
Merge pull request #5349 from JosJuice/more-incorrect-trans
...
Remove incorrect usage of _trans
2017-04-30 18:20:19 -04:00
Mat M
4f2ecf03b3
Merge pull request #5348 from JosJuice/host-code-ip-address
...
Mark "Host Code:" and "IP Address:" as translatable
2017-04-30 18:19:21 -04:00
Lioncash
683462679b
MemoryWindow: Remove unused member variable
2017-04-30 06:35:59 -04:00
Lioncash
9a778786df
MemoryWindow: Convert event table over to bound events
...
Event tables are the old method of performing event binding.
2017-04-30 06:35:41 -04:00
Lioncash
aad9fd6751
MemoryWindow: Localize sizer creation code
...
Keeps specific UI element initialization separate from one another.
2017-04-30 06:20:26 -04:00
Lioncash
402faf3758
MemoryWindow: Make constructor explicit
2017-04-30 03:22:36 -04:00
Lioncash
7941a05a80
MemoryWindow: Add missing translation markers for UI strings
2017-04-30 03:22:35 -04:00
Lioncash
4c70f05fe0
MemoryWindow: Get rid of unnecessary std::string constructions
...
std::string's operator+ will handle this. Also move std::string to where
they're actually needed. There's no need to construct an unnecessary
string if the first failure case occurs.
2017-04-30 03:22:34 -04:00
Lioncash
7cf78a00eb
MemoryWindow: Normalize variable naming
2017-04-30 03:22:25 -04:00
Mat M
255fd14db6
Merge pull request #5316 from ligfx/cmakewxwidgets
...
Various CMake cleanups for DolphinWX
2017-04-25 21:21:54 -04:00
Mat M
9090f37347
Merge pull request #5299 from FRtranslator/Tools_menu_reorder
...
Reorder the Tools menu, with more separators
2017-04-22 17:41:01 -04:00
Mat M
4c711de309
Merge pull request #5301 from JosJuice/delete-wxinputbase
...
Delete WXInputBase
2017-04-22 17:37:38 -04:00
Mat M
4517231a1a
Merge pull request #5287 from sepalani/rso
...
Generate Symbols From RSO Modules added
2017-04-20 20:06:03 -04:00
Lioncash
a58d5fa8ee
MMU: Get rid of pointer casts
...
These sort of casts invoke undefined behavior (u8, u16, u32, and u64 all have
completely different alignment requirements).
2017-04-17 20:52:57 -04:00
Lioncash
9cfc671c69
MMU: Get rid of unnecessary temporaries in HostRead_[8|16|32] functions
2017-04-17 19:13:47 -04:00
Mat M
e53969b6f2
Merge pull request #5278 from spycrab/issue_10213
...
Lazily initialize m_main_config_dialog to fix analytics issue (Issue #10213 )
2017-04-16 07:12:29 -04:00
Mat M
d22509984c
Merge pull request #5252 from JosJuice/pitch-text
...
Update text about pitch depending on emulation speed
2017-04-16 05:48:57 -04:00
Lioncash
8811937756
JitArm64_RegCache: Use std::array where applicable
...
There's no need to use std::vector for fixed enum values.
2017-04-12 22:34:34 -04:00
Mat M
733df23e98
Merge pull request #5251 from JosJuice/audio-backend-tooltip
...
Remove audio backend tooltip
2017-04-12 17:10:13 -04:00
Mat M
21544f8661
Merge pull request #5228 from JosJuice/why-did-this-exist
...
Get rid of some nonsense related to booting DOL/ELF files
2017-04-12 08:07:54 -04:00
Mat M
8ecc5e9b7a
Merge pull request #5246 from MerryMage/math-util
...
Jit64AsmCommon: Make frsqrte and fres PIE-compliant
2017-04-11 16:11:19 -04:00
Mat M
ae80a7541d
Merge pull request #5239 from sepalani/is-valid-instruction
...
PPCTables: Do not consider OPTYPE_UNKNOWN as valid instruction
2017-04-10 16:50:22 -04:00
Lioncash
c7ab6861c2
RenderBase: Return a tuple from ConvertStereoRectangle instead of using out parameters
2017-04-09 15:11:59 -04:00
Lioncash
671b5f9747
RenderBase: Return a tuple from CalculateTargetScale instead of using out parameters
2017-04-09 14:41:51 -04:00
Mat M
188f2b3cc5
Merge pull request #5231 from JosJuice/vertex-rounding-condition
...
Simplify condition for enabling/disabling vertex rounding checkbox
2017-04-09 05:35:53 -04:00
Lioncash
cc803db042
RenderBase: Eliminate renderer global accesses within the Renderer class
...
There's no need to access these globals, the instance itself has access
to these data members and functions.
2017-04-08 20:15:39 -04:00
Lioncash
caf25653d8
RenderBase: const correctness
2017-04-08 20:11:29 -04:00
Lioncash
0540950e7a
VideoConfigDiag: Move event implementations into the cpp file
...
Also removes the unused Event_Adapter event stub which did nothing. It
wasn't even hooked up to wx's event system.
Allows removing several includes from the header file and moving them to
the cpp file. Prevents includes being dumped into other source files
that include the header.
This uncovered an indirect include in Main for MsgHandler utilities.
2017-04-08 17:35:50 -04:00
Mat M
96e70ad5a3
Merge pull request #5217 from lioncash/cheats
...
Frame: Make cheat dialog private
2017-04-08 17:30:27 -04:00
Mat M
3013252d4f
Merge pull request #5222 from MerryMage/keyb
...
Frame: Fix macOS keyboard while emulation is running
2017-04-08 17:28:13 -04:00
Mat M
59d93f3a0d
Merge pull request #5219 from lioncash/common
...
FileSearch: Namespace functions under the Common namespace
2017-04-08 17:19:00 -04:00
Mat M
579b7538e7
Merge pull request #5224 from ligfx/cachedinterpreterhle
...
CachedInterpreter: fix HLEFunction argument
2017-04-08 17:17:28 -04:00
Mat M
ab18eba9de
Merge pull request #5105 from lioncash/namespace
...
EXI: Namespace device classes
2017-04-08 17:12:56 -04:00
Mat M
f09d17f40f
Merge pull request #5161 from leoetlino/es-formats-tests
...
Add unit tests for IOS/ESFormats
2017-04-08 17:10:57 -04:00
Mat M
11d1124fa5
Merge pull request #5209 from leoetlino/block-es-diverify
...
IOS/ES: Block ES_DIVerify from the IPC interface
2017-04-08 16:57:40 -04:00
Mat M
d55d9f93a7
Merge pull request #5212 from leoetlino/es-unknown-ioctlvs
...
IOS/ES: Return IPC_EINVAL for unknown ioctlvs
2017-04-08 16:56:50 -04:00
Mat M
1e182706ca
Merge pull request #5185 from leoetlino/disable-nand-items
...
WX: Disable a few menu items when a Wii title is running
2017-04-08 16:54:52 -04:00
Mat M
5d7bd357c1
Merge pull request #5227 from JosJuice/revise-new-settings-strings
...
Revise descriptions for new settings
2017-04-08 16:51:35 -04:00
Mat M
4ba6184785
Merge pull request #5216 from ligfx/removeshadowedtlut
...
TextureCacheBase: remove duplicated variable
2017-04-08 16:49:04 -04:00
Mat M
9a7c28026b
Merge pull request #5214 from sepalani/strutil-fix
...
StringUtil: Fix a ctype assertion
2017-04-08 16:45:29 -04:00
Lioncash
069b70b2b4
SI_Devices: Get rid of pointer casts for ID assignment in RunBuffer
...
This is actually undefined behavior (pointer casting to a non-char type and
dereferencing it).
2017-04-08 16:36:14 -04:00
Lioncash
f7a2f6ad01
FileSearch: Namespace functions under the Common namespace
2017-04-07 01:02:14 -04:00
Lioncash
c61d0dfe87
Frame: Make cheat dialog private
...
Rather than destroy and reinitialize the dialog whenever it's closed,
and opened this dialog can just be hidden from view when it's not
needed, and shown again when it is needed.
Also, a dialog should really not be managing any live instances of
itself, including the one directly in the main frame.
This gets rid of another usage of the main frame global.
2017-04-06 21:25:26 -04:00
Mat M
36ab5eafcf
Merge pull request #5208 from stenzek/c14x2-error
...
TextureConversionShader: Fix compile error in C14X2 decoder
2017-04-06 00:25:40 -04:00
Lioncash
14c81764df
ControllerEmu: Replace includes with forward declarations
...
Replaces includes with forward declarations where applicable, and moves
includes to where they're actually needed.
2017-04-04 20:38:30 -04:00
Lioncash
0c1d56c16f
Core: Hide determinism global
...
This is only ever queried and not set outside of the Core.cpp, so this
should just be hidden internally and just have a function exposed that
allows querying it.
2017-04-03 14:56:12 -04:00
Lioncash
ad1a899a7c
Core: Make EmuThread internally linked
2017-04-03 13:27:35 -04:00
Lioncash
ed2e9e9e41
Core: Remove unnecessary forward declaration
2017-04-03 13:26:15 -04:00
Lioncash
b67968c3d8
Core: Remove unimplemented function prototype SetBlockStart
2017-04-03 06:34:49 -04:00
Lioncash
c457ee4995
Frame: Remove callback function prototypes from header
...
Gets rid of more direct usages of the main_frame global, keeping the
callbacks internal to the frame itself.
2017-04-03 06:34:36 -04:00
Lioncash
f3ab0fc3f8
TASInputDlg: Use an enum for ID constants
...
These are all related constants (and it doesn't make sense to allow
taking the address of them).
2017-04-03 04:29:15 -04:00
Lioncash
9dd29895cd
TASInputDlg: Replace includes with forward declarations
2017-04-03 04:29:15 -04:00
Lioncash
2a968f02d7
TASInputDlg: Make constructor explicit
2017-04-03 04:29:14 -04:00
Lioncash
28395c6302
TASInputDlg: Simplify event queueing calls
...
wxQueueEvent/wxPostEvent are useful when the event is being dispatched
to another separate window, but aren't really necessary when the event
will be handled by the same window it's dispatched from.
GetEventHandler() is unnecessary here for the same reason. It's an event
intended to be handled by the dialog itself.
2017-04-03 04:29:14 -04:00
Lioncash
598a92426f
TASInputDlg: Get rid of unnecessary event casts
...
wxCommandEvent already stores the necessary data; the control object
itself doesn't need to be retrieved and casted.
2017-04-03 04:29:14 -04:00
Lioncash
2af5b64f32
TASInputDlg: Apply auto to UI control initializations where appropriate
...
As all UI controls are essentially constructed with new expressions, the
type is already visible on the right-hand side, so repeating the type
twice isn't necessary.
2017-04-03 04:29:11 -04:00
Lioncash
b809db52d1
TASInputDlg: Use std::array where applicable
2017-04-03 04:28:11 -04:00
Mat M
c626fd7c74
Merge pull request #5195 from leoetlino/unneeded-fwd
...
IOS/IPC: Remove unneeded forward declaration
2017-04-02 06:50:17 -04:00
Lioncash
05872336a9
ExpressionParser: Rename ParseStatus' Success member to Successful
...
This clashes with X11's preprocessor define named Success (because using
non-prefixed lowercase identifiers in C was apparently a fantastic idea
at some point), causing compilation errors.
2017-04-02 06:13:18 -04:00
Lioncash
c09f7bd84b
Frame: Convert TAS dialog C array to std::array
2017-04-02 04:11:58 -04:00
Lioncash
678905764a
Movie/Frame: Amend variable naming
...
Amends variable naming related to translation unit locals and TAS input
dialogs that were modified in the previous commit.
2017-04-02 04:11:58 -04:00
Lioncash
7f0203a5b0
Frame: Make TAS dialogs private
...
Amends the TAS callbacks to internally store functions using
std::function instead of raw function pointers. This allows binding
extra contextual state via lambda functions, as well as keeping the
dialogs internal to the main frame (on top of being a more flexible
interface).
2017-04-02 04:11:47 -04:00
Lioncash
5620f78b5c
Core: Amend VS filter tag
2017-04-02 00:30:26 -04:00