Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
23,143 Commits 1 Branch 0 Tags
a3f79f88cdcfd26dc214cc4ee29a08e29474481f
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash b592e4887e BooleanSetting: Initialize m_value to default_value in the constructor 
Ensures all class state is initialized to valid values on construction.
 2017-03-03 14:09:48 -05:00
Lioncash 25e70570b5 NumericSettings: Initialize m_value to default_value in the constructor 
Ensures that all class state is initialized to valid values.
 2017-03-03 14:06:16 -05:00
Lioncash 13757b7d35 UICommon: Make GetNewDisassembler() return a unique_ptr 
Much better than just returning raw memory.
 2017-03-02 21:26:17 -05:00
Mat M 78e7f4aae3 Merge pull request #4984 from leoetlino/content-fixes 
IOS/ES: Title import fixes + hack removals (fix for System Menu disc updates)
 2017-03-02 14:17:29 -05:00
Lioncash c6200a5b07 JitInterface: Convert includes into forward declarations where applicable 2017-03-02 13:20:29 -05:00
Lioncash ee61bd6f2e CMakeLists: Normalize whitespace 
Normalizes tabs to spaces to follow our codebase's indentation style.
 2017-03-01 14:53:23 -05:00
Lioncash 8b094081a0 Contributing.md: Update C++11 mention to C++14 2017-03-01 13:22:49 -05:00
Lioncash b7bf1dc558 Contributing.md: Add missing table of contents sections 2017-03-01 11:39:08 -05:00
Mat M 8364a0002f Merge pull request #4956 from leoetlino/es-checks 
ES: Replace useless asserts with proper checks
 2017-03-01 11:30:25 -05:00
Lioncash 5ed55ffb34 PixelEngine: Move enum constants into the PixelEngine namespace 
Gets some identifier names out of the global namespace.
 2017-02-28 07:01:50 -05:00
Lioncash d104e5e916 ExpressionParser: Convert parse state enum into an enum class 2017-02-28 05:07:21 -05:00
Lioncash f0203157d4 ExpressionParser: Const-correctness changes 2017-02-26 02:09:34 -05:00
Lioncash 26f17a1723 ControlGroup: Convert group type enum into an enum class 
Gets some constants out of the ControllerEmu namespace, and modifies
ControlGroup so that it uses the enum type itself to represent the
underlying type, rather than a u32 value.
 2017-02-25 01:15:04 -05:00
Lioncash beec40f178 IniFile: Handle s64/u64 values 2017-02-25 00:03:20 -05:00
Lioncash 0783476464 CachedInterpreter: Forward declare instruction struct 
Allows changes to be made to the instruction struct without recompiling
other source files.
 2017-02-23 18:08:20 -05:00
Lioncash 359528b805 JitBase: Put constructor and destructor in the cpp file 
As this is a base class with virtuals, there needs to be an out-of-line
function definition to prevent the vtable of the class being placed within
every translation unit it's used in (i.e. every JIT implementation).
 2017-02-23 13:50:47 -05:00
Mat M c81cf111ef Merge pull request #4921 from waddlesplash/netmap 
IOS/Network/Net: Use a conversion function instead of a static array for SOCKOPT mapping
 2017-02-22 16:11:53 -05:00
Lioncash 70d336d2a9 DolphinWX: Eliminate direct usage of the JIT global 
Instead, the JitInterface namespace functions should be used instead. This
gets rid of all usages of the JIT global from the wxWidgets UI code.

The null check isn't needed as the JIT core would already need to be
initialized in order to be within a paused state. The null check is just a
remnant from 2011 that existed before the check for a paused state was
added.
 2017-02-21 16:15:47 -05:00
Lioncash ff0f60c9f9 JitInterface: Amend ExceptionType enum value names 
Since ExceptionType is an enum class, its name already acts like the
common prefix.
 2017-02-21 15:40:00 -05:00
Mat M 95b2b033b0 Merge pull request #4925 from RisingFog/remove_readonly_check 
Remove IsReadOnly check when stop recording
 2017-02-21 10:53:24 -05:00
Lioncash f65c34d63d JitArm64_Tables: Make initialization instruction tables constexpr 2017-02-21 10:23:39 -05:00
Lioncash 4b342fbbfc JitIL_Tables: Make initialization instruction tables const 2017-02-21 09:55:08 -05:00
Lioncash 092d21253d Jit64_Tables: Make initialization instruction tables const 2017-02-21 09:54:51 -05:00
Mat M 6fbb23e365 Merge pull request #4938 from sjnewbury/GCC7-build-fix 
Add missing "functional" include for GCC7
 2017-02-20 10:51:10 -05:00
Lioncash 2f2aab963d SymbolDB: Simplify GetSymbolsFromHash 
Given a std::map can't have duplicate keys, iterating over the map
explicitly isn't necessary, and find() can just be used instead.

Also, instead of manually calling push_back() for every entry to
be added, the range constructor of std::vector can be used instead to add
the whole range all at once.
 2017-02-18 06:30:20 -05:00
Lioncash aaa6430db6 PPCAnalyst: Make SetInstructionStats' opinfo parameter a const pointer 
trivial const-correctness stuff
 2017-02-18 04:14:26 -05:00
Lioncash 1fa81f24d3 VertexManagerBase: Make CreateNativeVertexFormat return a unique_ptr 
Much safer as opposed to just returning raw allocated memory.
 2017-02-18 03:16:24 -05:00
Lioncash a8eb2e2a8f IOS Network: Split wd/command code into its own source files 2017-02-18 02:35:53 -05:00
Lioncash ec298d9ea9 IOS Network: Split ncd/manage code into its own source files 2017-02-17 23:55:33 -05:00
Mat M 82734fffaa Merge pull request #4910 from lioncash/netsplit 
IOS Network: Move net/ip/top code into its own source files
 2017-02-17 22:42:28 -05:00
Mat M 1e2dba2046 Merge pull request #4920 from leoetlino/ios40 
IOS: Add constants for IOS40
 2017-02-17 22:41:39 -05:00
Lioncash 92e17d2eb8 IOS: Move net/ip/top code to its own source files 2017-02-15 14:42:43 -05:00
Lioncash 245de3fa4f IOS: Move network MAC utilities to their own source files 
All three implementations within Net.cpp currently rely on these
functions.
 2017-02-15 13:38:52 -05:00
Lioncash 0da963c32c NetKDRequest: Make lookup maps const 2017-02-15 11:50:37 -05:00
Mat M 6f272b3a4c Merge pull request #4862 from lioncash/compile 
CPU Backends: Make instruction table initialization private
 2017-02-15 11:44:37 -05:00
Mat M 8fd16db80d Merge pull request #4778 from leoetlino/update-mbedtls 
Externals: Update mbedtls to 2.4.1
 2017-02-15 11:30:18 -05:00
Mat M 5a53763c1a Merge pull request #4892 from lioncash/control 
Control: Convert raw pointer parameter into unique_ptr
 2017-02-15 11:26:53 -05:00
Mat M 3d1f00e98d Merge pull request #4874 from ligfx/movie_magic_number 
Movie: replace magic number 8 with sizeof(ControllerState)
 2017-02-15 11:25:26 -05:00
Mat M 28a6575244 Merge pull request #4900 from lioncash/netkd 
IOS: Separate net/kd code out from Net.cpp
 2017-02-15 11:21:01 -05:00
Mat M 30ee4dfcdf Merge pull request #4908 from leoetlino/apostrophe 
Remove C++14 optional digit separator
 2017-02-14 11:06:08 -05:00
Mat M f68955502a Merge pull request #4905 from JosJuice/rename-copy-wii-save 
Rename "Copy Wii Save" to "Load Wii Save"
 2017-02-13 09:55:54 -05:00
Mat M da5683cf27 Merge pull request #4880 from ligfx/windowsmanifest 
Use .manifest file for apps on Windows
 2017-02-12 08:44:38 -05:00
Lioncash 921ab22cb7 Boot: Remove unused game ID string 2017-02-12 07:55:49 -05:00
Lioncash 40cea773bc IOS: Separate net/kd code out from Net.cpp 
Net.cpp is just a huge glob of network related things, this separates the
KD portion out to make things a little more manageable.
 2017-02-11 23:09:08 -05:00
Lioncash 1a99e70ed7 Force: Use std::array for m_swing 2017-02-11 20:22:50 -05:00
Lioncash df3a4580ea Tilt: Use std::array for m_tilt 2017-02-11 20:22:42 -05:00
Mat M 0e961776e6 Merge pull request #4879 from orbea/llvm 
CMake: Fix LLVM error
 2017-02-11 20:07:34 -05:00
Mat M 3e016ecc1d Merge pull request #4888 from leoetlino/good-bye-singleton 
Get rid of a singleton for NAND shared contents
 2017-02-11 20:02:52 -05:00
Mat M 9cdb07b2ef Merge pull request #4886 from leoetlino/no-prefix 
FileIO: Minor cleanup
 2017-02-11 20:00:58 -05:00
Mat M 295600c86e Merge pull request #4884 from leoetlino/wii-connect-on-boot 
Fix connecting Wii remotes on boot
 2017-02-11 19:59:50 -05:00
Mat M daed1189d9 Merge pull request #4891 from ligfx/cmakewarnings 
CMake: use _SCL_SECURE_NO_WARNINGS instead of _SECURE_SCL=0
 2017-02-11 19:55:37 -05:00
Mat M 3ae6261a50 Merge pull request #4890 from ligfx/usbdkcmake 
CMake/Libusb: compile libusb/os/windows_usbdk.c
 2017-02-11 19:52:09 -05:00
Lioncash 98145d2160 ControllerEmu: Add const to UpdateReferences() first reference parameter 
None of these parameters are modified.
 2017-02-11 00:31:49 -05:00
Lioncash e4bdc88494 Cursor: Make m_z private 
This isn't used directly anywhere (and really shouldn't be public
anyways).
 2017-02-10 23:57:50 -05:00
Lioncash fda235b6e3 Buttons: Use a delegating constructor 
Basic code deduplication
 2017-02-10 19:52:15 -05:00
Mat M 2cad67952d Merge pull request #4885 from lioncash/control-ref 
ControlReference: Add missing virtual destructor
 2017-02-10 19:40:33 -05:00
Lioncash d07d9f3110 Control: Convert raw pointer parameter into unique_ptr 
Raw pointers shouldn't be used as boundaries in scenarios where ownership
is being taken.
 2017-02-10 19:35:02 -05:00
Lioncash 68dcb0f195 ControlReference: Add missing virtual destructor 
ControllerEmu::Control instances have a unique_ptr<ControlReference>
member, which is passed either an InputReference or OutputReference.

Without this virtual destructor, deleting a derived class through a
pointer to the base class is undefined behavior.
 2017-02-10 13:58:44 -05:00
Mat M f6d364e37b Merge pull request #4873 from lioncash/controller-emu 
ControllerEmu: Separate ControlGroup from ControllerEmu
 2017-02-10 13:50:33 -05:00
Lioncash 1ce1304d0f CPU Backends: Make each CPU backend responsible for initializing its own 
instruction tables

Previously, all of the internals that handled how the instruction tables
are initialized were exposed externally. However, this can all be made
private to each CPU backend.

If each backend has an Init() function, then this is where the instruction
tables should be initialized, it shouldn't be the responsibility of
external code to ensure internal validity.

This allows for getting rid of all the table initialization shenanigans
within JitInterface and PPCTables.
 2017-02-10 13:08:14 -05:00
Lioncash 5da7d700ca JIT: Make compilation functions a part of the JIT classes 2017-02-10 13:05:44 -05:00
Lioncash 6a75ea5653 ControllerEmu: Separate ControlGroup from ControllerEmu 
ControllerEmu, the class, is essentially acting like a namespace for
ControlGroup. This makes it impossible to forward declare any of the
internals. It also globs a bunch of classes together which is kind of a
pain to manage.

This splits ControlGroup and the classes it contains into their own source
files and situates them all within a namespace, which gets them out of
global scope.

Since this allows forward declarations for the once-internal classes, it
now requires significantly less files to be rebuilt if anything is changed
in the ControllerEmu portion of code.

It does not split out the settings classes yet, however, as it
would be preferable to make a settings base class that all settings derive
from, but this would be a functional change -- this commit only intends to
move around existing code. Extracting the settings class will be done in
another commit.
 2017-02-09 18:18:52 -05:00
Lioncash ea6e75d45f GameListCtrl: Separate some scanning code into functions 
Several of the things done while performing a scan are logically their own
behavior (e.g. loading a titles file, checking if an entry should be added, etc).
 2017-02-09 14:50:20 -05:00
Mat M 1385a012d9 Merge pull request #4871 from lioncash/radius 
ControllerEmu: Fix incorrect default radius being set in AnalogStick
 2017-02-09 05:26:41 -05:00
Lioncash 56531a0b7f ControllerEmu: Fix incorrect default radius being set in AnalogStick 
The three parameter AnalogStick constructor takes an internal name, a
display name, and a default radius argument. The delegated constructor is
the one that calls the ControlGroup constructor, setting the group type,
so passing the group type here is a logic bug.

The only reason this appeared to work despite this bug is because
GROUP_TYPE_STICK has a value of 1, and the default radius value used for
attachment sticks is 1.0.
 2017-02-08 23:08:13 -05:00
Mat M 73382852b7 Merge pull request #4502 from ligfx/extractcontrolreference 
InputCommon: Extract ControlReference from ControllerInterface
 2017-02-08 20:01:18 -05:00
Lioncash 90273191da Boot: Add missing includes 2017-02-08 10:57:24 -05:00
Lioncash 3b41d4806c Boot_BS2Emu: Get rid of unnecessary headers 2017-02-08 10:57:16 -05:00
Lioncash 57d543b10a ElfReader: Get rid of unnecessary includes 2017-02-08 10:57:10 -05:00
Lioncash 95a918b9f8 Boot_WiiWAD: Get rid of unnecessary includes 2017-02-08 10:43:50 -05:00
Lioncash e6ffce3ac9 ElfReader: Make constructor explicit 
Allowing implicit conversions here is definitely not desirable.
 2017-02-08 10:20:06 -05:00
Lioncash 399757a771 FifoPlayerDlg: Use std::lock_guard instead of manual mutex locking/unlocking 
Same thing, but less error prone.
 2017-02-08 00:26:32 -05:00
Lioncash d9d069e024 OpcodeDecoding: Convert #defines into enum constants 
Gets several constants out of global scope.
 2017-02-08 00:05:17 -05:00
Mat M 6ffa0492a6 Merge pull request #4858 from Orphis/patch-1 
DolphinWX: Add missing include for no-PCH builds
 2017-02-07 23:26:57 -05:00
Lioncash 31f037b187 InputCommon CMakeLists: Normalize whitespace 
Tabs -> Spaces
 2017-02-07 22:15:53 -05:00
Lioncash 3a66f2c008 ControllerEmu: Move into its own directory 
ControllerEmu is a massive class with a lot of nested public classes.

The only reason these are nested is because the outer class acts as a
namespace. There's no reason to keep these classes nested just for that.

Keeping these classes nested makes it impossible to forward declare them, which leads to quite a few includes in other headers, making compilation take
longer.

This moves the source files to their own directory so classes can be
separated as necessary to their own source files, and be namespaced under the
ControllerEmu namespace.
 2017-02-07 22:12:06 -05:00
Mat M c9696ccdd5 Merge pull request #4855 from Orphis/cmake_llvm 
cmake: Move LLVM import to UICommon
 2017-02-07 22:05:22 -05:00
Lioncash 4260afc848 DSPCore: Make g_cycles_left a regular member variable of DSPEmitter 
Gets rid of a global within the DSP core.
 2017-02-07 21:56:57 -05:00
Lioncash 13f70d4597 PowerPC: Convert #defines into typed constants 2017-02-07 20:17:15 -05:00
Mat M a9ed44cd48 Merge pull request #4852 from Orphis/cmake_bluez 
cmake: Move BlueZ detection to Core
 2017-02-07 19:27:19 -05:00
Mat M 277f813b72 Merge pull request #4849 from Orphis/cmake_audiocommon 
cmake: Move PulseAudio detection to AudioCommon
 2017-02-07 18:08:10 -05:00
Lioncash 06f6ca8d81 Core: Remove redundant returns in FifoPlayerThread() and CpuThread() 
There's no need to explicitly return at the end of a void function.
 2017-02-07 17:59:03 -05:00
Lioncash 31dc2b9cc1 GCPadEmu: Make constructor explicit 2017-02-07 15:12:15 -05:00
Lioncash a2a188533a GCKeyboardEmu: Make constructor explicit 2017-02-07 15:11:49 -05:00
Lioncash 9f8177c9ac UCodes: Eliminate unnecessary includes in header 2017-02-07 15:08:57 -05:00
Lioncash 1f14b7f907 EXI_DeviceAD16: Amend variable naming 
Drops Hungarian Notation type prefixing and prefixed underscores.
 2017-02-07 14:58:23 -05:00
Lioncash 2f74a6f552 EXI_DeviceAD16: In-class initialize member variables 
Same thing, less code.
 2017-02-07 14:54:54 -05:00
Mat M 3cda4e1d9c Merge pull request #4822 from ligfx/copysys 
CMake: add CMAKE_CONFIGURE_DEPENDS on Data/Sys
 2017-02-07 10:41:25 -05:00
Mat M db9720d038 Merge pull request #4842 from ligfx/fix_prix64_es 
ES: use PRIx64 to print m_addtitle_tmd.GetTitleId()
 2017-02-07 10:39:29 -05:00
Mat M f5e940d59d Merge pull request #4843 from ligfx/enable_Sdl 
CMake: make option ENABLE_SDL work again
 2017-02-07 10:38:08 -05:00
Mat M bdf09c7d3b Merge pull request #4841 from ligfx/accuratescmrev 
CMake: re-run to get version information when .git/HEAD changes
 2017-02-06 22:12:55 -05:00
Mat M 649fc390ff Merge pull request #4833 from Orphis/cmake_audiocommon 
More CMake updates for AudioCommon dependencies
 2017-02-06 22:12:05 -05:00
Lioncash c41f587c29 Frame: Hide functions that don't need to be exposed 
Any functions left exposed are used elsewhere through the main_window
global. May as well prevent any more functions from being used in that
manner where possible.
 2017-02-06 18:29:26 -05:00
Lioncash ead076d335 NetWindow: Get rid of direct use of the main_window global 
Utilizes the event system (which is what should have been done here
initially), in order to prevent coupling between two different window frames.

This also makes booting games more versatile using the UI event system,
as the event can just act as a carrier for the filename, making directly
calling boot functions unnecessary. All that's needed is for the event to
propagate to the frame.
 2017-02-06 18:29:20 -05:00
Lioncash 2597d2b69b NetWindow: Make chat messages queue private 
This doesn't need to be publicly accessable.
 2017-02-06 13:03:35 -05:00
Mat M f978765bf0 Merge pull request #4755 from Orphis/cmake_sdl 
cmake: Modernize SDL discovery
 2017-02-06 11:55:03 -05:00
Lioncash 063e4df5a1 DSPCore: Convert the DSPCoreState enum into an enum class 2017-02-06 11:47:19 -05:00
Mat M 02127e360a Merge pull request #4831 from Orphis/cmake_cleanup 
Small CMake fixes
 2017-02-06 11:29:05 -05:00
Mat M e4c17f126c Merge pull request #4835 from ligfx/configurefilescmrev 
CMake: use configure_file to generate scmrev.h
 2017-02-06 11:14:08 -05:00
Mat M 11d1d227da Merge pull request #4834 from lioncash/enum 
Core: Actually make the State enum an enum class
 2017-02-06 02:43:35 -05:00