Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
29,134 Commits 1 Branch 0 Tags
a482299df627f9aaa7b3ab466f5faa79c6b03283
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Léo Lam a482299df6 Externals/discord: Don't run clang-format on source files 
It's annoying to have source files automatically reformatted every time
Dolphin is built because it causes git to consider the source tree to
be dirty.
 2018-09-16 15:32:48 +02:00
Léo Lam eb9009e5c0 DSPTool: Use std::string == instead of strcmp 
Less C-like and conveniently fixes a build issue caused by strcmp
not being declared for some reason.

Converting to std::string is safe because the argument count is
checked every time so the char* cannot be a nullptr.
 2018-07-05 09:40:43 +02:00
Léo Lam 971972069c Merge pull request #7148 from lioncash/build 
Common, DSP: Only compile in x86-64 emitter related utilities on x86 platforms
 2018-06-22 23:55:37 +02:00
Léo Lam 1da868ee82 Merge pull request #7150 from lioncash/naming 
BTEmu: Amend variable naming
 2018-06-22 22:50:48 +02:00
Léo Lam d07e599a74 Merge pull request #7151 from lioncash/const 
Movie: Make pointer parameters const where applicable
 2018-06-22 22:50:25 +02:00
Léo Lam e16cadf982 Merge pull request #7153 from lioncash/deduplicate 
DSPTables: Deduplicate FindByOpcode() implementations in DSP opcode tables
 2018-06-22 22:49:16 +02:00
Léo Lam 167c19ae19 Merge pull request #7154 from lioncash/emitter 
DSPEmitter: Make member functions, aliases and constants private where applicable
 2018-06-22 22:47:34 +02:00
Léo Lam bdfc6de9fd Merge pull request #7137 from lioncash/copy 
GameFile: Avoid copying map pairs in GetLanguages()
 2018-06-19 22:57:29 +02:00
Léo Lam de0b153867 Merge pull request #7136 from lioncash/unused 
GameFile: Remove unused variable within GetUniqueIdentifier()
 2018-06-19 22:57:00 +02:00
Léo Lam e728c0c948 Merge pull request #7132 from lioncash/table 
BTEmu: Make read-only arrays const
 2018-06-19 22:56:10 +02:00
Léo Lam a2bc62dd89 Merge pull request #7140 from lioncash/move 
DolphinQt2/RegisterWidget: std::move std::function instances in AddRegister()
 2018-06-19 22:53:37 +02:00
Léo Lam bd85d63c62 Merge pull request #7120 from Ebola16/313 
Update Android Gradle to 3.1.3 and minor improvements
 2018-06-15 19:54:49 +02:00
Léo Lam 0ee9b884ca Merge pull request #7123 from lioncash/enum 
DSPCore: Convert core type enum into an enum class
 2018-06-15 19:52:57 +02:00
Léo Lam 2b6d6c12bf Merge pull request #7124 from lioncash/enum-class 
PowerPC: Convert CPUCore enum into an enum class
 2018-06-15 19:52:06 +02:00
Léo Lam 58606702f7 Merge pull request #7107 from lioncash/mac 
Common/Network: Get rid of out parameters for MAC address utilities
 2018-06-14 19:44:09 +02:00
Léo Lam c7280707ec Merge pull request #7113 from lioncash/mask 
Gekko: Centralize bitmasking of the FPSCR within UReg_FPSCR
 2018-06-14 18:28:11 +02:00
Léo Lam 59cd9a5af7 Merge pull request #7118 from lioncash/hotkey-str 
HotkeyManager: Minor changes
 2018-06-14 18:26:03 +02:00
Léo Lam 0f0823f4a4 Merge pull request #7119 from lioncash/random 
Common/Random: Add convenience template for simple arithmetic values
 2018-06-14 18:25:21 +02:00
Léo Lam f3a18db9e0 Merge pull request #7106 from lioncash/name 
WiimoteDevice: Amend variable naming
 2018-06-11 11:12:08 +02:00
Léo Lam 69f079b371 Merge pull request #7098 from Ebola16/ElfDolMessage 
Android: Add AlertDialog for files without Game IDs in Game Settings
 2018-06-10 14:36:46 +02:00
Léo Lam fca6d80740 Merge pull request #7101 from lioncash/ios 
WiimoteDevice: Minor changes
 2018-06-10 14:35:41 +02:00
Léo Lam 6da3c4a6d0 Merge pull request #7102 from lioncash/chunk 
ChunkFile: Remove unnecessary includes
 2018-06-10 14:35:16 +02:00
Léo Lam 8bb08d1ca6 BTReal: Fix unsafe reinterpret_casts 
Using reinterpret_cast like that is possibly UB.
Replace them with structs/memcpy calls where applicable.
 2018-06-09 23:04:04 +02:00
Léo Lam f564c28040 Merge pull request #7099 from lioncash/compiler 
Common: Add Compiler.h header for compiler-specifics
 2018-06-09 20:19:49 +02:00
Léo Lam 5d1b35e867 Merge pull request #7100 from lioncash/table 
WiimoteHIDAttr: Make file-scope packet data arrays immutable
 2018-06-09 20:18:07 +02:00
Léo Lam 1d87584d69 Merge pull request #7097 from lioncash/dsp-disas 
DSPDisassembler: Remove unnecessary includes
 2018-06-09 07:58:39 +02:00
Léo Lam bbc2253949 Merge pull request #7095 from lioncash/cmake 
Common/CMakeLists: Link in libraries privately for traversal_server
 2018-06-09 07:54:04 +02:00
Léo Lam 48b7cfa75c Merge pull request #7062 from robopilot99/master 
Add auto-hide option to Wii IR pointer
 2018-06-08 14:04:03 +02:00
Léo Lam d23c3e9524 Merge pull request #7093 from lioncash/log 
Interpreter_SystemRegisters: Change PanicAlert to INFO_LOG in mtspr()
 2018-06-07 19:01:39 +02:00
Léo Lam b51fbaa5b0 Merge pull request #7084 from lioncash/mask 
Interpreter_SystemRegisters: Ensure FPSCR modifying instructions don't set bit 20
 2018-06-07 16:51:36 +02:00
Léo Lam 34d6a49842 Merge pull request #7088 from Ebola16/TFD 
Give "Dump TEV Stages" and "Dump Texture Fetches" descriptions
 2018-06-07 16:50:15 +02:00
Léo Lam ca32b4127e Merge pull request #7089 from spycrab/qt_refresh_hotkey 
Qt: Implement "Refresh Game List" hotkey
 2018-06-07 16:49:09 +02:00
Léo Lam 18d5ba30d6 Merge pull request #7085 from master0fdisaster/Add-Volume-Hotkeys-OSD-Message 
Add OSD message for Volume Hotkeys
 2018-06-07 16:46:19 +02:00
Léo Lam dd7c558be3 Merge pull request #7092 from JosJuice/wii-devkit 
Set 0x0000002C to NDEV 2.1 when running a debug-signed Wii disc
 2018-06-07 15:52:07 +02:00
Léo Lam c93210155f Merge pull request #7075 from Ebola16/DumpObjects 
Software Renderer "Dump Objects" needs dedicated folder and tooltip
 2018-06-06 15:20:14 +02:00
Léo Lam 21898a0c5a Merge pull request #7086 from 8times9/netplay_window_fixes 
Qt: Remove Dolphin prefix from NetPlay window titles
 2018-06-06 10:43:03 +02:00
Léo Lam 85baca386a ES: Return ReturnCode in DiVerify for consistency 
No reason to return a s32 instead of an IOS return code (like every
other function in the ES API)
 2018-06-05 22:07:59 +02:00
Léo Lam f422b88ed9 Merge pull request #7078 from spycrab/qt_gc_adapter_fix 
Qt/GCPadWiiUConfigDialog: Fix settings not being loaded properly
 2018-06-05 19:37:56 +02:00
Léo Lam 21d0d6711f Merge pull request #7073 from leoetlino/fix 
WiiSave: Fix the way paths are handled
 2018-06-05 18:32:13 +02:00
Léo Lam bfbd890caa Merge pull request #7080 from spycrab/qt_noprop_elfdol 
Qt/GameList: Don't show certain options when a DOL/ELF is selected.
 2018-06-05 15:57:11 +02:00
Léo Lam 7e45ff7a0d Merge pull request #7077 from spycrab/qt_cheat_rich 
Qt/CheatCodeEditor: Don't accept rich text
 2018-06-05 15:56:14 +02:00
Léo Lam b7a8deda96 Merge pull request #7074 from lioncash/paired 
Interpreter_LoadStorePaired: Simplify type aliases in QuantizeAndStore() and LoadAndDequantize()
 2018-06-05 00:08:00 +02:00
Léo Lam 226f88bcb6 Merge pull request #7069 from leoetlino/player-id 
PadMappingDialog: Show player ID in player dropdown
 2018-06-05 00:02:04 +02:00
Léo Lam d1e2cc7b92 Merge pull request #7070 from spycrab/qt_prop_width 
Qt/PropertiesDialog: Fix tabs being cut off due to small window size
 2018-06-04 23:49:28 +02:00
Léo Lam 14d37e0493 WiiSave: Fix the way paths are handled 
All paths in SaveFile are relative to the title data directory, not
absolute. Fixes an accidental regression from 5.0-7988 (PR #7059).
 2018-06-04 23:31:00 +02:00
Léo Lam 8fe7f8d80d Merge pull request #7072 from lioncash/emitter 
DSPEmitter: Make m_unresolved_jumps private
 2018-06-04 22:26:24 +02:00
Léo Lam d797bf2ee7 PadMappingDialog: Show player ID in player dropdown 
Makes it easier to differentiate players that have the same name.
 2018-06-04 22:24:35 +02:00
Léo Lam 5f29e891d3 Merge pull request #7063 from lioncash/fifr 
Interpreter: Unset FPSCR.FI and FPSCR.FR for QNaN and infinity input operands
 2018-06-04 20:53:58 +02:00
Léo Lam 6ce9c96d91 Merge pull request #7027 from leoetlino/cleanup 
Use some C++17 features available since GCC 6
 2018-06-04 20:50:50 +02:00
Léo Lam 2a89ad9c39 Merge pull request #7066 from spycrab/qt_fs_exit 
Qt: Always return to windowed when confirming exit
 2018-06-04 20:48:22 +02:00
Léo Lam 9b43180731 Merge pull request #7040 from JMC47/enableadouble2single 
[JIT] Enable Accurate Double to Single Conversion
 2018-06-04 20:29:15 +02:00
Léo Lam 34511b397e Merge pull request #7067 from Ebola16/ASU3 
Update Android Gradle Plugin
 2018-06-04 19:37:33 +02:00
Léo Lam b26a47e642 Merge pull request #6180 from ligfx/sdlhotplug 
Add hotplug support to SDL2 controller backend
 2018-06-04 18:12:29 +02:00
Léo Lam 8e0ea92ec3 Merge pull request #7058 from JosJuice/move-titledatabase-usage 
Don't store custom names from TitleDatabase in GameFileCache
 2018-06-04 14:59:05 +02:00
Léo Lam 8074192a85 Merge pull request #7057 from leoetlino/string 
Config/StringUtil/IniFile: Get rid of some duplicated code
 2018-06-04 12:44:57 +02:00
Léo Lam 472e0d55b8 Merge pull request #7061 from leoetlino/wiiroot 
WiiRoot: Use new filesystem interface
 2018-06-04 00:15:49 +02:00
Léo Lam 0ecec33567 WiiRoot: Use a namespace alias for FS to reduce noise 2018-06-03 21:37:28 +02:00
Léo Lam c1428b6da0 WiiRoot: Use new filesystem interface 
This gets rid of remaining direct accesses to the Wii filesystem
in WiiRoot by using WiiSave to copy saves and the FS interface
 2018-06-03 21:21:32 +02:00
Léo Lam 8fce18e4ff Merge pull request #7059 from leoetlino/fs-wiisave 
WiiSave: Use new filesystem interface
 2018-06-03 21:05:22 +02:00
Léo Lam 47bf809796 Merge pull request #7060 from lioncash/reg 
Gekko: Make register constructors explicit where applicable
 2018-06-03 21:04:34 +02:00
Léo Lam 6b9aef7042 FS: Add a struct for modes 
As suggested here: https://dolp.in/pr7059#pullrequestreview-125401778

More descriptive than having a std::tuple of FS::Mode, and lets us
give names to known triplets of modes (like in ES). Functions that
only forward mode arguments are slightly less verbose now too.
 2018-06-03 20:45:35 +02:00
Léo Lam d1a8661709 WiiSave: Save and restore files and banner with correct mode 2018-06-03 17:23:40 +02:00
Léo Lam fd3472442d WiiSave: Use new filesystem interface 
Converts WiiSave to the new filesystem interface.
 2018-06-03 17:01:14 +02:00
Léo Lam c22205cd7e Merge pull request #7053 from lioncash/frfi 
Interpreter_FPUtils/FloatingPoint/Paired: Amend cases where FPSCR.FR and FPSCR.FI should be unset
 2018-06-03 15:36:12 +02:00
Léo Lam 83324fe77d StringUtil: Remove ValueToString(std::string) 
Doesn't make a lot of sense to have a function that gives the string
representation for a string.
 2018-06-03 15:11:59 +02:00
Léo Lam 7e79bf97ab IniFile: Use templates for Get() 
Gets rid of duplicated code.
 2018-06-03 14:53:56 +02:00
Léo Lam cba32b12e7 IniFile: Use templates for Set() 2018-06-03 14:53:56 +02:00
Léo Lam fc0193c4b1 Move Config ValueToString to StringUtil 
An identical implementation is used by IniFile, so move those functions
to StringUtil. A future commit will modify IniFile to use them.
 2018-06-03 14:10:52 +02:00
Léo Lam 66ee47c417 Merge pull request #7056 from spycrab/qt_hk_debug 
Qt/HotkeyWindow: Always show debugging tab
 2018-06-03 13:50:56 +02:00
Léo Lam 1e51e263e0 Merge pull request #6988 from leoetlino/wii-save-refactor 
WiiSave: Refactor the import/export code
 2018-06-03 12:05:43 +02:00
Léo Lam 86368fcd4d Merge pull request #6499 from Ebola16/SettingsGroup 
Android: Initial implementation of Interface submenu
 2018-06-03 12:02:56 +02:00
Léo Lam 24ca621652 Merge pull request #7052 from AdmiralCurtiss/pokemon-colosseum-bonus-disc-ini 
Update GameINI settings for the Japanese Pokémon Colosseum Bonus Discs.
 2018-06-03 11:58:46 +02:00
Léo Lam a2b2a31e64 Merge pull request #7054 from JosJuice/android-no-themes 
Don't include the Themes directory in Android APKs
 2018-06-03 11:55:08 +02:00
Léo Lam 396810c450 Merge pull request #7050 from lioncash/ptr 
WiimoteDevice: Get rid of pointer casting in CBigEndianBuffer
 2018-06-02 21:35:43 +02:00
Léo Lam f09f83c309 Merge pull request #7019 from Ebola16/VSQT 
Make DolphinQT2 the default project in dolphin-emu.sln
 2018-06-02 14:23:20 +02:00
Léo Lam 62fdef0e6c Merge pull request #7046 from lioncash/priv 
EXI_DeviceMic: Make data members of CEXIMic private
 2018-06-02 11:53:07 +02:00
Léo Lam 69abaf3ec4 WiiSave: Merge Header and DataBinHeader to reduce noise 
DataBinHeader is not used anywhere in the code other than via Header,
so let's merge them to reduce noise when accessing header fields
(currently we have to do header.hdr which looks silly).
 2018-06-01 23:45:58 +02:00
Léo Lam 210377816d WiiSave: Get rid of some magic numbers 
It would make sense for 0x80 and 0xf0c0 to be respectively
sizeof(BkHeader) and sizeof(Header) as Nintendo is signing anything
that comes after the header, including the BkHeader.
 2018-06-01 23:44:24 +02:00
Léo Lam 8eafd1928e WiiSave: Move user interaction to UI frontends 2018-06-01 20:46:35 +02:00
Léo Lam 4df266f943 WiiSave: Use the correct length for paths 
Paths can never exceed 0x40 characters as this is the maximum length
that is allowed by IOS (and probably the common FS library too).
 2018-06-01 20:46:35 +02:00
Léo Lam 8af16fdd28 WiiSave: Use an enum class for save file type 2018-06-01 18:58:34 +02:00
Léo Lam 94953670f2 WiiSave: Move overwrite prompt to Import 
WriteHeader should just write the header and not do anything else.
 2018-06-01 00:14:48 +02:00
Léo Lam a46a8dd378 WiiSave: Refactor import/export code 
The current WiiSave code is extremely messy, as it exposes all kinds of
implementation details in the header (including internal struct
definitions and magic numbers that don't have to be).

The read/write code is intermingled, so it's hard to tell which members
are used, or when/where they are set at all.

It also implicitly relies on some functions being called in a specific
order since it doesn't seek manually every time, which makes the code
even more fragile.

The logic is also hardcoded to only support bin->nand or nand->bin,
even though it would be useful to support nand->nand (for the
Movie save copying code, for example).

This commit attempts to solve these problems by getting rid of the
WiiSave class:

* Read/write code is moved to new Storage classes (NandStorage and
  DataBinStorage) with small, clear functions that do one and only
  one thing.

* The import/export logic was refactored into a generic Copy function
  that takes two storages as parameters.

* The existing import and export functions are now just small wrappers
  that call Copy with the appropriate storages.
 2018-05-31 20:52:01 +02:00
Léo Lam 60dd2553c6 Merge pull request #7033 from lioncash/jitarm 
JitArm64_BackPatch: Correct usage of an invalidated iterator after a std::map erase() call in HandleFastmemFault()
 2018-05-31 18:05:47 +02:00
Léo Lam fff1db9730 Common: Add Random utilities 
This makes it easier to generate random numbers or fill a buffer with
random data in a cryptographically secure way.

This also replaces existing usages of RNG functions in the codebase:

* <random> is pretty hard to use correctly, and std::random_device does
  not give enough guarantees about its results (it's
  implementation-defined, non cryptographically secure and could be
  deterministic on some platforms).
  Doing things correctly is error prone and verbose.

* rand() is terrible and should not be used especially in crypto code.
 2018-05-31 17:54:43 +02:00
Léo Lam bdfd331355 Merge pull request #7028 from lioncash/obsolete 
GeneralPane: Replace usages of obsolete QString member function sprintf
 2018-05-30 15:02:41 +02:00
Léo Lam b7a268ceea Merge pull request #7029 from lioncash/any 
VolumeWii: Shorten padding checking code within CheckIntegrity()
 2018-05-30 14:58:16 +02:00
Léo Lam 4fb2d580d8 Merge pull request #7026 from lioncash/name 
JitAsmCommon: Normalize member variable names within CommonAsmRoutinesBase
 2018-05-30 12:02:08 +02:00
Léo Lam fb124c2eb0 Use nested namespaces for IOS HLE 
Pretty much all of the source files contain the following:

    namespace IOS
    {
    namespace HLE
    {
    namespace <name>
    {
    // actual code here
    }  // namespace <name>
    }  // namespace HLE
    }  // namespace IOS

which is really verbose boilerplate, because most of the files inside
of Core/IOS are for IOS HLE.

This commit replaces that with a more concise `namespace IOS::HLE`
or `namespace IOS::HLE::(name)`.
 2018-05-30 11:40:05 +02:00
Léo Lam 5b90aba624 ChunkFile: Replace macro with a variable template 
Note that std::is_trivially_copyable_v cannot be used yet (C++17 only).
 2018-05-30 11:39:30 +02:00
Léo Lam 8a00a9e149 Remove old GCC version checks 2018-05-30 10:59:15 +02:00
Léo Lam eb9969a1e2 Merge pull request #7025 from lioncash/integrity 
VolumeWii: Use ReadSwapped for retrieving the partition data size in CheckIntegrity()
 2018-05-30 10:55:13 +02:00
Léo Lam c3de9d7b0e Merge pull request #7020 from sepalani/ida-scripts 
Tools: Dolphin symbol map IDA scripts added
 2018-05-30 10:52:49 +02:00
Léo Lam 24e0b4bf52 Merge pull request #7024 from lioncash/discio 
VolumeGC/VolumeWii: Dehardcode sizes where applicable
 2018-05-30 10:22:18 +02:00
Léo Lam a4ec3ddef1 Don't switch to blank NAND in the middle of emulation 
Switching to blank NAND when emulation is running is an extremely bad
idea. It's akin to opening up a Wii and replacing the NAND chip while
you're playing a game on it.

Except we're not even replacing it with a NAND that has the same
contents. The blank NAND has nothing in it except the save file for
the current game, which is likely to result in the emulated software
getting inconsistent results and possibly even crashing depending on
how it caches title information.

An example of games that check the saves for other games is
Mario Kart Wii -- it checks the filesystem for Super Mario Galaxy saves
to decide whether to unlock characters. With this 'switch NAND
while emulation is active' misfeature, this will likely break.
And that's the main problem: it encourages sloppy emulation and no one
really knows how many things it can break.

Just don't let the user do horrible things like that during emulation.
If they want to use a blank NAND, they can do so by starting input
recording before launching a game. It's likely they will want to do
this if they plan to share their DTM anyway.
 2018-05-29 15:41:11 +02:00
Léo Lam 60c38d7781 Merge pull request #7007 from spycrab/qt_gecko_sort 
Qt/GeckoCodeWidget: Autosort list and fix accessing the wrong element
 2018-05-29 14:48:32 +02:00
Léo Lam 00d91db2ec Merge pull request #7008 from spycrab/ddos_sux 
Fix "Download Codes" hitting DDOS protection
 2018-05-29 14:42:24 +02:00
Léo Lam 86bbf540cf Merge pull request #7009 from lioncash/dsp 
DSPEmulator: Default destructor in the cpp file
 2018-05-29 14:16:50 +02:00
Léo Lam f05eb10026 Merge pull request #7003 from lioncash/host 
Common: Move host communication enum to Host.h
 2018-05-28 20:57:34 +02:00
Léo Lam a9f022a067 Merge pull request #6993 from lioncash/nan 
Interpreter_FPUtils: Set VXSNAN if any input operands are a signaling NaN in remaining NI_* functions
 2018-05-28 18:49:13 +02:00