Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
27,552 Commits 1 Branch 0 Tags
ad836b9071b6ad0341bfb6a36b24862bf7df9f79
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Mat M ad836b9071 Merge pull request #6717 from spycrab/issue_11039 
Qt/GraphicsControls: Reload values when settings are changed
 2018-04-29 20:20:36 -04:00
Mat M 1ce75ce217 Merge pull request #6721 from spycrab/qt_alloc_console 
Qt/Win32: Fix console output
 2018-04-29 20:19:55 -04:00
Mat M d8b56af342 Merge pull request #6714 from spycrab/qt_fix_toolbar 
Qt/ToolBar: Fix inconsistencies
 2018-04-29 15:20:01 -04:00
Mat M cad7d2c71f Merge pull request #6720 from spycrab/qt_ext 
Qt/GameTracker: Match uppercase file extensions
 2018-04-29 14:24:24 -04:00
Mat M 1aebe515d9 Merge pull request #6719 from spycrab/qt_batch 
Qt: Implement Batch flag (-b)
 2018-04-29 14:23:46 -04:00
Lioncash 167b92ff2c Jit_Integer: Make arrays const in MultiplyImmediate() and twX() 
These are only ever read from, so make the data immutable to be explicit about that
 2018-04-28 14:13:02 -04:00
Mat M 0cd46f4d21 Merge pull request #6690 from lioncash/nand 
Common/NandPaths: Minor cleanup
 2018-04-28 13:43:33 -04:00
Mat M 6b8da197e8 Merge pull request #6689 from container1234/qt-minor-fixes 
Qt: Minor changes
 2018-04-28 13:41:59 -04:00
Mat M c057eb3c82 Merge pull request #6705 from leoetlino/variable 
IOS/SO: Clean up variable declarations
 2018-04-28 13:40:38 -04:00
Mat M fa44e28ce0 Merge pull request #6708 from spycrab/qt_dynfilter 
Qt/GameList: Ensure resort when new entries are added
 2018-04-28 13:39:56 -04:00
Mat M 73c91edde6 Merge pull request #6709 from JosJuice/qt-controls-clear 
DolphinQt2: Fix clearing numeric values in controller config
 2018-04-28 13:39:25 -04:00
Lioncash 8183360832 Common/MemTools: Make handler function internally linked on Windows 
This doesn't need to be an externally linked function.
 2018-04-28 12:55:38 -04:00
Lioncash 4637579375 Common: Amend CommonTypes include within BitSet.h 
We do includes relative to the root, rather than direct pathing.
 2018-04-23 00:14:00 -04:00
Lioncash d68f437e67 Common: Move BitSet helper functions into the Common namespace 2018-04-23 00:13:55 -04:00
Lioncash c1c360d9b1 NandPaths: Make function parameters consistent 
Also drops trailing underscores from said parameter names.
 2018-04-22 23:49:20 -04:00
Lioncash 62242331d8 NandPaths: Remove unused header inclusions 2018-04-22 23:49:16 -04:00
Lioncash 2ce0f42c14 Common: Move BitSet into the Common namespace 
This should be under the common namespace, considering where it's living
 2018-04-22 23:43:07 -04:00
Mat M 4a0b6c7b0b Merge pull request #6683 from aldelaro5/qt-log-colors 
Qt/log change the notice log color to lime
 2018-04-22 01:37:33 -04:00
Lioncash e6405f7b2b Core: Use thread_local directly 
Both Android and OSX now support it, allowing us to remove the fallback code.
 2018-04-17 19:03:24 -04:00
Mat M df44aa7335 Merge pull request #6668 from JosJuice/remove-hybrid-wiimote 
Remove Hybrid Wii Remote
 2018-04-17 18:09:58 -04:00
Lioncash d1d8300a46 SI: Remove unnecessary declarations of internally linked functions 
These aren't dependent on calling order so we can just organize all of the statics together
instead of splitting them up over the file. This also allows us to organize a common spot for
file static variables as well.
 2018-04-17 16:33:11 -04:00
Mat M d230194464 Merge pull request #6657 from leoetlino/dedup 
Qt/Debugger: Deduplicate memory view update code
 2018-04-17 10:21:53 -04:00
Mat M b19d77a3ff Merge pull request #6660 from leoetlino/pause 
Qt/Debugger: Don't pause when already paused
 2018-04-17 10:20:30 -04:00
Mat M e04592e6c4 Merge pull request #6663 from spycrab/qt_fix_columns 
Qt: Fix columns not properly showing / hiding
 2018-04-17 10:19:35 -04:00
Mat M 8bb0e0ee96 Merge pull request #6662 from Tilka/fix_warnings 
Fix some warnings
 2018-04-17 10:17:01 -04:00
Mat M 908e00556e Merge pull request #6661 from sepalani/host_va 
HLE_VarArgs: PowerPC::HostRead_F64 used
 2018-04-17 10:16:05 -04:00
Mat M 41f07a8773 Merge pull request #6652 from leoetlino/shared-pugixml 
CMake: Use system-wide pugixml if available
 2018-04-17 08:06:58 -04:00
Mat M c78b3f6ab6 Merge pull request #4507 from sepalani/host_f 
PowerPC: HostR/W float/double added
 2018-04-17 08:02:07 -04:00
Lioncash c23a998f9d TraversalClient: Use u32 instead of enet_uint32 
Lessens the dependence on the enet library (and we really don't need to rely on a third-party library for a 32-bit integer type)
 2018-04-16 16:46:48 -04:00
Lioncash f1e92a1eae TraversalClient: Make TestPacket() private 
This is only used by the private InterceptCallback()
 2018-04-16 16:46:48 -04:00
Lioncash 1b8ad49d1e TraversalClient: In-class initialize members where applicable 2018-04-16 16:46:48 -04:00
Lioncash ca6a2970ea TraversalClient: Make data externally read-only members private 
These are only ever queried for state, not written. Therefore, prevent writing to the members
and make them private.
 2018-04-16 16:46:44 -04:00
Lioncash 236aed9fd1 Common/CMakeLists: Link curl and VTune libraries in privately 
These are only used internally.
 2018-04-16 12:38:24 -04:00
Lioncash b0dc823472 Common/Logging/Log: Wrap GENERIC_LOG macro's body in do { } while (0) 
Enforces the termination of GENERIC_LOGs with semicolons.
 2018-04-16 12:11:32 -04:00
Mat M 6224b9bd37 Merge pull request #6642 from leoetlino/stm 
IOS/STM: Reset the event hook at the correct time
 2018-04-16 09:04:12 -04:00
Lioncash 939c5671a9 Common/Config: Remove unused header inclusions 2018-04-15 22:35:00 -04:00
Lioncash 4836739663 Common/Config: Remove unnecessary function declaration 
This prototype declaration is already provided by the Config.h header
 2018-04-15 22:33:53 -04:00
Mat M eecdb51709 Merge pull request #6645 from JosJuice/tie-constexpr 
x64Emitter: Don't assume that std::tie is constexpr
 2018-04-15 03:11:31 -04:00
Mat M 615c0decb7 Merge pull request #6644 from leoetlino/uicommon-header 
UICommon: Fix header
 2018-04-14 20:25:22 -04:00
Lioncash b31281527a CMakeLists: Define an OProfile target and use it 
Allows us to bring includes and relevant libraries into scope by explicitly declaring linkage against the target
as opposed to using a variable. Also removes the dumping of OProfile includes into the top-level directory.
 2018-04-13 19:35:17 -04:00
Lioncash 2851c7e5ee CMakeLists: Don't dump zlib's includes into the top-level directory 2018-04-13 08:32:48 -04:00
Lioncash b256f873ca CMakeLists: Link in zlib privately where applicable 
Also, use the target name introduced via find_package(ZLIB) instead
of hardcoding the 'z' name in the link libraries.
 2018-04-13 08:29:46 -04:00
Lioncash 7de2d1c9d6 CMakeLists: Don't dump LZO's includes into the top-level directory 
Instead, we add the includes to the LZO target's interface. That way
only libraries that link it in can see them.
 2018-04-13 07:39:09 -04:00
Mat M 9d7009796c Merge pull request #6637 from JosJuice/projection-hack-leftovers 
Remove leftovers of projection hack support
 2018-04-13 07:23:13 -04:00
Lioncash e28d063539 x64Emitter: Make the Align* functions return a non-const data pointer 
There's no real requirement to make this const, and this should also
be decided by the calling code, considering we had places that would
simply cast away the const and carry on.
 2018-04-12 19:46:55 -04:00
Lioncash ab25eb6449 Interpreter_LoadStorePaired: Don't use a union to type-pun between integral and FP types 2018-04-12 19:44:31 -04:00
Lioncash 7a3158a693 Interpreter_FPUtils: Don't use a union to type-pun between integral and FP types 
The previous code invokes undefined behavior. memcpy will optimize away
to the relevant loads and stores while maintaining well-defined
behavior.
 2018-04-12 19:44:31 -04:00
Lioncash 6a637cfc22 CMakeLists: Don't dump libpng's includes into the top-level directory 
Instead, add the includes to the target, which only libraries that link it in can actually see.
 2018-04-11 17:33:52 -04:00
Lioncash 1c17329e2f GekkoDisassembler: Fix disassembly of dcbz_l 
Previously this would fall through and disassemble as a generic "ps_[number]" junk instruction.
 2018-04-10 11:22:01 -04:00
Lioncash 73ebc190fa InputCommon/CMakeLists: Link evdev and udev in privately 
These libraries aren't directly used outside of InputCommon
 2018-04-10 09:59:55 -04:00
Lioncash d63d0b5069 InputCommon/CMakeLists: Include evdev and udev includes on a by-target basis 
Avoids including the evdev/udev includes in the top-level directory
 2018-04-10 09:59:51 -04:00
Lioncash 1b3dae918a StreamADPCM: Turn the ADPCM decoder into a class 
Migrates the state to be instance-based as opposed to being a flat
namespace. This keeps behavior localized to its own instantiable unit
(and forces uses of the class to also be localized, lest they cart around
an instance all over the place).
 2018-04-09 03:49:18 -04:00
Lioncash a8088b7365 ProcessorInterface: Remove prefixed underscores from parameters 
These are reserved by the implementation for any use.
 2018-04-09 03:21:59 -04:00
Lioncash 419ed1b46a DVDInterface: Deduplicate code in UpdateInterrupts() 2018-04-09 03:18:51 -04:00
Lioncash a0f943178b Profiler: Move BlockStat and ProfileStats structures into the Profiler namespace 
These should be part of the namespaced API and not be sitting in the
global namespace.
 2018-04-08 22:29:48 -04:00
Lioncash 0461709c8d PPCSymbolDB: Use auto for iterators where applicable 2018-04-08 22:03:11 -04:00
Lioncash b44eb90ee4 PPCSymbolDB: Default destructor and pass to member variables in the constructor initializer-list 2018-04-08 21:56:24 -04:00
Lioncash d6d17eea60 PPCSymbolDB: Remove unused function pointer typedef 2018-04-08 21:54:50 -04:00
Lioncash 9c5115a627 PPCAnalyst: Simplify boolean assignments in SetInstructionStats() 
Ternaries here aren't necessary if all we're checking against is if
something is non-zero
 2018-04-08 21:42:43 -04:00
Lioncash f2b2f5b4c7 PPCAnalyst: Make ReorderType an enum class 
Makes the values strongly typed and doesn't dump them into the class
itself.
 2018-04-08 21:38:19 -04:00
Lioncash 5e5a56bd9b PPCAnalyst: Remove unnecessary includes from header 2018-04-08 21:34:12 -04:00
Lioncash 4bd3b28823 PPCAnalyst: in-class initialize PPCAnalyzer's members 
Eliminates the need to assign in the constructor initializer list.
 2018-04-08 21:32:15 -04:00
Lioncash 433a56636b PPCAnalyst: Move public interface above private interface 2018-04-08 21:31:19 -04:00
Lioncash b9c872dbca CMakeLists: Don't dump bochs' includes into the top-level directory 
Instead add it to the target interface. This way, only libraries that
link in bochs will see its include directories.
 2018-04-08 20:43:18 -04:00
Lioncash f1be7cd4a0 CMakeLists: Link bochs in privately where applicable 
Everything that links in core doesn't need to see anything related to bochs, because it's only used internally.
Anything else that relies on bochs should be linking it in explicitly.
 2018-04-08 04:59:58 -04:00
Lioncash 88a80f118c Common/Swap: Amend BigEndianValue's operator= to return a reference to the object rather than returning void 
The general convention is to return a reference to the object that was
acted on, otherwise you can get into situations with errors because the
type wasn't being propagated properly
 2018-04-08 01:22:18 -04:00
Lioncash 5d1349f9c7 Gekko: Remove unused UFPR union 
Using this in its current form would invoke undefined behavior, as it's
using a union to type pun between data types. It's also, well, unused,
so we don't need to keep it around.
 2018-04-07 22:30:26 -04:00
Lioncash d5555b49e9 Gekko: In-class initialize members where applicable 
Allows defaulting the default constructor. Also moves assignment to
initializer lists where applicable as well.
 2018-04-07 22:26:24 -04:00
Lioncash 3e50b0e320 PPCDebugInterface: Remove redundant HostRead_U32() call in Disassemble() 
We already read the necessary information with the
HostRead_Instruction() call. Internally, it calls HostRead_U32() as
well, so there's no difference in behavior.
 2018-04-07 22:20:59 -04:00
Lioncash 181539e049 Interpreter_LoadStore: Generate a program exception if dcbz_l is executed when HID2[LCE] is zero 
If the locked cache isn't enabled, dcbz_l is illegal to execute
(locked cache is off, locked cache instructions don't work, makes sense)

This makes exception handling more accurate. It was previously possible to hit the DSI exception
handler when HID2[LCE] is set to zero, which isn't correct.

With this change we no longer hit the DSI handler, however we still have a lingering issue elsewhere
likely to do with exception precedence, we seem to hit the Floating Point exception handler instead
in some cases. This isn't due to the instruction itself directly however, so this is just another bug
to fix elsewhere.
 2018-04-06 23:53:44 -04:00
Mat M 5ed12b45ec Merge pull request #6603 from orbea/ffmpeg 
[AVIDump] fix compilation on Linux
 2018-04-06 23:49:29 -04:00
Lioncash a4ba92c697 CMakeLists: Don't dump xxhash's includes into top-level directory scope 
We already use a custom CMakeLists file for xxhash, so we can just make it's headers
public as part of its target interface.

This way, only libraries that link in the xxhash target will see its headers, as opposed
to every target under the top-level directory.
 2018-04-06 10:41:58 -04:00
Lioncash 3e946d87e4 DolphinWX/DolphinQt2 CMakeLists: Use cmake -E instead of mkdir -p for creating language directories 
CMake already has this functionality built-in. This lessens depending on the host system environment
and is more cross-platform friendly (which is always nice from a build-system point of view).
 2018-04-05 12:49:33 -04:00
Lioncash 839fc7e749 DolphinQt2/MainWindow: Resolve a memory leak on systems with X11 
In the case we had X11 libs available, we'd allocate an XRRConfiguration instance and pass it
to the GraphicsWindow instance, but it would never actually be freed.
 2018-04-05 09:07:08 -04:00
Lioncash b4e36bbd27 CMakeLists: Move build options to the top of the file 
Makes the configurable aspects of the build more immediately discoverable
as opposed to needing to read down the entire file.
 2018-04-05 08:27:49 -04:00
Lioncash 9c27c7eda8 DolphinQt2/CMakeLists: Use the target_* equivalents of add_definitions and include_directories 
add_definitions and include_directories don't operate on a by-target basis, they act on a
by-directory basis (i.e. if we defined two targets, A and B, in this CMakeLists file, add_definitions
would add the definitions to the COMPILE_DEFINITIONS directory property which both A and B would
implicitly use).

The same idea applies to include_directories, only it appends to the INCLUDE_DIRECTORIES directory
property.

Instead, specify these on the target to keep scope as narrow as possible.
 2018-04-05 07:52:25 -04:00
Lioncash 912c9490c0 Interpreter_LoadStore: Generate alignment exceptions if an FP load/store instruction's effective address is not word aligned 
This is one of the conditions for an alignment exception documented in
the 750CL architecture reference manual in section 4.5.6, which also
applies to the Gekko microprocessor.
 2018-04-05 00:30:53 -04:00
Lioncash 980f1641b5 Interpreter_LoadStore: Generate alignment exceptions if dcbz or dcbz_l are executed with the data cache disabled 
This is an exception condition documented within section 4.5.6 in the
architecture reference manual for the PPC 750CL, which also applies to
the Gekko microprocessor.

Also moves dcbz_l's implementation out of Interpreter_Paired and beside
dcbz where it belongs.
 2018-04-04 18:44:17 -04:00
Lioncash fb929ab8e5 DolphinQt2/CMakeLists: Specify Qt modules via COMPONENTS in the find_package call 
Eliminates the need to find the individual modules separately
 2018-04-04 15:05:20 -04:00
Lioncash 84ed6fd445 CMakeLists: Remove the LIBS variable 
Now that we link all libraries in explicitly, the top-level LIBS variable can finally go.
 2018-04-04 11:46:30 -04:00
Lioncash 6f694e435c DolphinNoGUI/CMakeLists: Remove the use of SRCS and LIBS variables 
Instead, operate on the target directly. This removes the last usages of the
SRCS and LIBS variables.
 2018-04-04 11:42:57 -04:00
Lioncash 5e4446c313 DolphinQt2/CMakeLists: Remove usages of LIBS and SRCS variables 
Instead, operate on the target itself. Also removes the variable
representing the name of the target. We can just refer to this directly
 2018-04-04 09:09:45 -04:00
Lioncash 3ea0a37d72 Interpreter_LoadStore: Generate alignment exceptions if lmw, lswi, lswx, stmw, stswi, or stswx is executed when the MSR[LE] bit is set 
Improves exception accuracy regarding an admittedly very unlikely
scenario.
 2018-04-03 20:47:40 -04:00
Mat M 88853551e6 Merge pull request #6590 from lioncash/hires 
HiresTexture: Correct texture hashes
 2018-04-03 19:00:28 -04:00
Lioncash 74aff4d9ef HiresTexture: Correct texture hashes 
Fixes a regression introduced in 2da8d98b2f
 2018-04-03 12:42:05 -04:00
Lioncash 21ee216e63 Android/CMakeLists: Remove usages of LIBS and SRCS variables 
Instead, operate on the target itself.
 2018-04-03 08:05:43 -04:00
Lioncash 516b46845d DolphinWX/CMakeLists: Remove usages of the LIBS and SRCS variables 
Instead, operated on the target itself.
 2018-04-03 08:04:29 -04:00
Lioncash de0ed1a5fb Interpreter_LoadStore: Update the DAR if a DSI exception occurs in eciwx and ecowx 
Also once a DSI exception occurs, execution is supposed to leave the
instruction immediately. It doesn't finish execution.
 2018-04-02 08:34:32 -04:00
Lioncash a013638dcb Interpreter_LoadStore: Properly update the DAR whenever an alignment exception occurs within eciwx and ecowx 
These should be updating the DAR when an alignment exception occurs,
just like every other instruction that can cause an alignment exception.
 2018-04-02 08:34:32 -04:00
Lioncash c1b78106e7 Interpreter_LoadStore: Flag alignment exceptions on misaligned addresses in lwarx, lmw, stmw, and stwcx 
The effective address given to these instructions must be word (4 byte) aligned,
and if the address is not aligned like that, then an alignment exception
gets triggered.

We currently don't update the DSISR in this case properly, since we
didn't really handle alignment exceptions outside of ecowx and eciwx,
and even then the handling of it isn't really that great, considering
the DAR isn't updated with the address that caused the exception to
occur.

The DSISR will eventually be amended to be properly updated.
 2018-04-02 08:34:26 -04:00
Lioncash 22be923b91 CMakeLists: Remove add_dolphin_library macro 
With all library targets migrated off add_dolphin_library, we can finally remove it
 2018-04-02 08:31:56 -04:00
Lioncash b184923540 Vulkan/CMakeLists: Migrate off add_dolphin_library 
Finishes the migration work started in 3a4c3bbe01
 2018-04-02 08:29:37 -04:00
Lioncash 8b43a31855 Software/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:24:40 -04:00
Lioncash a3c53ff754 OGL/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:22:39 -04:00
Lioncash d4f8502ad1 Null/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:17:00 -04:00
Lioncash 3854e2bcca D3D/CMakeLists: Migrate off add_dolphin_library 
Continues the migration work started in 3a4c3bbe01
 2018-04-02 08:15:22 -04:00
Lioncash 672665dec0 AsyncRequests: In-class initialize class members 
Prior to this change, it's possible for m_wake_me_up_again to be used
while it's in an uninitialized state from the exposed API.

e.g.

- Using SetEnable after construction would perform an uninitialized read.
- Using PushEvent would perform an uninitialized read by way of operator |=.

internally, an uninitialized read can happen if PullEventsInternal() is
executed before other functions.

Just to avoid the whole possibility of performing uninitialized reads,
we just give the class member a default value of false.
 2018-04-01 19:06:43 -04:00
Lioncash fd9eab73fb CPUDetect: Make CPUVendor enum an enum class 
Avoids dumping the enum contents into the global namespace.
 2018-04-01 17:47:50 -04:00
Lioncash 0f6c3c7b35 Jit64/JitRegCache: Make member functions const qualified where applicable 
None of these member functions modify class state.

Also makes the parameter name for ScoreRegister's implementation
consistent with its declaration.
 2018-04-01 16:53:00 -04:00
Lioncash 6cfa9fda6b DSPJitRegCache: Make FindFreeReg() a const member function 
This member function doesn't modify class state.
 2018-04-01 16:01:25 -04:00