Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
23,723 Commits 1 Branch 0 Tags
ae80a7541d1561bbd46fc53c6db14d02445497c0
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Mat M ae80a7541d Merge pull request #5239 from sepalani/is-valid-instruction 
PPCTables: Do not consider OPTYPE_UNKNOWN as valid instruction
 2017-04-10 16:50:22 -04:00
Mat M 188f2b3cc5 Merge pull request #5231 from JosJuice/vertex-rounding-condition 
Simplify condition for enabling/disabling vertex rounding checkbox
 2017-04-09 05:35:53 -04:00
Lioncash cc803db042 RenderBase: Eliminate renderer global accesses within the Renderer class 
There's no need to access these globals, the instance itself has access
to these data members and functions.
 2017-04-08 20:15:39 -04:00
Lioncash caf25653d8 RenderBase: const correctness 2017-04-08 20:11:29 -04:00
Lioncash 0540950e7a VideoConfigDiag: Move event implementations into the cpp file 
Also removes the unused Event_Adapter event stub which did nothing. It
wasn't even hooked up to wx's event system.

Allows removing several includes from the header file and moving them to
the cpp file. Prevents includes being dumped into other source files
that include the header.

This uncovered an indirect include in Main for MsgHandler utilities.
 2017-04-08 17:35:50 -04:00
Mat M 96e70ad5a3 Merge pull request #5217 from lioncash/cheats 
Frame: Make cheat dialog private
 2017-04-08 17:30:27 -04:00
Mat M 3013252d4f Merge pull request #5222 from MerryMage/keyb 
Frame: Fix macOS keyboard while emulation is running
 2017-04-08 17:28:13 -04:00
Mat M 59d93f3a0d Merge pull request #5219 from lioncash/common 
FileSearch: Namespace functions under the Common namespace
 2017-04-08 17:19:00 -04:00
Mat M 579b7538e7 Merge pull request #5224 from ligfx/cachedinterpreterhle 
CachedInterpreter: fix HLEFunction argument
 2017-04-08 17:17:28 -04:00
Mat M ab18eba9de Merge pull request #5105 from lioncash/namespace 
EXI: Namespace device classes
 2017-04-08 17:12:56 -04:00
Mat M f09d17f40f Merge pull request #5161 from leoetlino/es-formats-tests 
Add unit tests for IOS/ESFormats
 2017-04-08 17:10:57 -04:00
Mat M 11d1124fa5 Merge pull request #5209 from leoetlino/block-es-diverify 
IOS/ES: Block ES_DIVerify from the IPC interface
 2017-04-08 16:57:40 -04:00
Mat M d55d9f93a7 Merge pull request #5212 from leoetlino/es-unknown-ioctlvs 
IOS/ES: Return IPC_EINVAL for unknown ioctlvs
 2017-04-08 16:56:50 -04:00
Mat M 1e182706ca Merge pull request #5185 from leoetlino/disable-nand-items 
WX: Disable a few menu items when a Wii title is running
 2017-04-08 16:54:52 -04:00
Mat M 5d7bd357c1 Merge pull request #5227 from JosJuice/revise-new-settings-strings 
Revise descriptions for new settings
 2017-04-08 16:51:35 -04:00
Mat M 4ba6184785 Merge pull request #5216 from ligfx/removeshadowedtlut 
TextureCacheBase: remove duplicated variable
 2017-04-08 16:49:04 -04:00
Mat M 9a7c28026b Merge pull request #5214 from sepalani/strutil-fix 
StringUtil: Fix a ctype assertion
 2017-04-08 16:45:29 -04:00
Lioncash 069b70b2b4 SI_Devices: Get rid of pointer casts for ID assignment in RunBuffer 
This is actually undefined behavior (pointer casting to a non-char type and
dereferencing it).
 2017-04-08 16:36:14 -04:00
Lioncash f7a2f6ad01 FileSearch: Namespace functions under the Common namespace 2017-04-07 01:02:14 -04:00
Lioncash c61d0dfe87 Frame: Make cheat dialog private 
Rather than destroy and reinitialize the dialog whenever it's closed,
and opened this dialog can just be hidden from view when it's not
needed, and shown again when it is needed.

Also, a dialog should really not be managing any live instances of
itself, including the one directly in the main frame.

This gets rid of another usage of the main frame global.
 2017-04-06 21:25:26 -04:00
Mat M 36ab5eafcf Merge pull request #5208 from stenzek/c14x2-error 
TextureConversionShader: Fix compile error in C14X2 decoder
 2017-04-06 00:25:40 -04:00
Lioncash 14c81764df ControllerEmu: Replace includes with forward declarations 
Replaces includes with forward declarations where applicable, and moves
includes to where they're actually needed.
 2017-04-04 20:38:30 -04:00
Lioncash 0c1d56c16f Core: Hide determinism global 
This is only ever queried and not set outside of the Core.cpp, so this
should just be hidden internally and just have a function exposed that
allows querying it.
 2017-04-03 14:56:12 -04:00
Lioncash ad1a899a7c Core: Make EmuThread internally linked 2017-04-03 13:27:35 -04:00
Lioncash ed2e9e9e41 Core: Remove unnecessary forward declaration 2017-04-03 13:26:15 -04:00
Lioncash b67968c3d8 Core: Remove unimplemented function prototype SetBlockStart 2017-04-03 06:34:49 -04:00
Lioncash c457ee4995 Frame: Remove callback function prototypes from header 
Gets rid of more direct usages of the main_frame global, keeping the
callbacks internal to the frame itself.
 2017-04-03 06:34:36 -04:00
Lioncash f3ab0fc3f8 TASInputDlg: Use an enum for ID constants 
These are all related constants (and it doesn't make sense to allow
taking the address of them).
 2017-04-03 04:29:15 -04:00
Lioncash 9dd29895cd TASInputDlg: Replace includes with forward declarations 2017-04-03 04:29:15 -04:00
Lioncash 2a968f02d7 TASInputDlg: Make constructor explicit 2017-04-03 04:29:14 -04:00
Lioncash 28395c6302 TASInputDlg: Simplify event queueing calls 
wxQueueEvent/wxPostEvent are useful when the event is being dispatched
to another separate window, but aren't really necessary when the event
will be handled by the same window it's dispatched from.

GetEventHandler() is unnecessary here for the same reason. It's an event
intended to be handled by the dialog itself.
 2017-04-03 04:29:14 -04:00
Lioncash 598a92426f TASInputDlg: Get rid of unnecessary event casts 
wxCommandEvent already stores the necessary data; the control object
itself doesn't need to be retrieved and casted.
 2017-04-03 04:29:14 -04:00
Lioncash 2af5b64f32 TASInputDlg: Apply auto to UI control initializations where appropriate 
As all UI controls are essentially constructed with new expressions, the
type is already visible on the right-hand side, so repeating the type
twice isn't necessary.
 2017-04-03 04:29:11 -04:00
Lioncash b809db52d1 TASInputDlg: Use std::array where applicable 2017-04-03 04:28:11 -04:00
Mat M c626fd7c74 Merge pull request #5195 from leoetlino/unneeded-fwd 
IOS/IPC: Remove unneeded forward declaration
 2017-04-02 06:50:17 -04:00
Lioncash 05872336a9 ExpressionParser: Rename ParseStatus' Success member to Successful 
This clashes with X11's preprocessor define named Success (because using
non-prefixed lowercase identifiers in C was apparently a fantastic idea
at some point), causing compilation errors.
 2017-04-02 06:13:18 -04:00
Lioncash c09f7bd84b Frame: Convert TAS dialog C array to std::array 2017-04-02 04:11:58 -04:00
Lioncash 678905764a Movie/Frame: Amend variable naming 
Amends variable naming related to translation unit locals and TAS input
dialogs that were modified in the previous commit.
 2017-04-02 04:11:58 -04:00
Lioncash 7f0203a5b0 Frame: Make TAS dialogs private 
Amends the TAS callbacks to internally store functions using
std::function instead of raw function pointers. This allows binding
extra contextual state via lambda functions, as well as keeping the
dialogs internal to the main frame (on top of being a more flexible
interface).
 2017-04-02 04:11:47 -04:00
Lioncash 5620f78b5c Core: Amend VS filter tag 2017-04-02 00:30:26 -04:00
Mat M a65a176777 Merge pull request #5192 from vtj/geckofix 
Fix disappearing gecko codes
 2017-04-01 18:01:28 -04:00
Mat M 67e950d02c Merge pull request #5168 from ligfx/vertexloadertestuninitialized 
VertexLoaderTest: fix maybe-uninitialized warning
 2017-03-31 17:26:20 -04:00
Mat M 0aec9fa4db Merge pull request #5149 from JosJuice/di-directory 
Move DVD code to a new directory
 2017-03-31 12:05:37 -04:00
Mat M 542fb347f1 Merge pull request #5160 from mahdihijazi/enhance_style 
android: Change the color of the selected slot to make it more visible
 2017-03-31 03:57:32 -04:00
Mat M f5dcfb157d Merge pull request #5151 from mahdihijazi/update_sdk 
Update to Android SDK 25
 2017-03-31 00:27:10 -04:00
Mat M 006381bb47 Merge pull request #5184 from leoetlino/dead-code 
Common: Remove dead code in NandPaths
 2017-03-31 00:21:49 -04:00
Mat M 6a595aabe9 Merge pull request #5153 from ligfx/stubhostnorequestfullscreen 
StubHost: remove unused Host_RequestFullscreen()
 2017-03-31 00:21:04 -04:00
Mat M 6b198679bc Merge pull request #5129 from ligfx/breakpointprintf 
Breakpoints.cpp: fix format string warnings
 2017-03-31 00:13:06 -04:00
Mat M 80a812322e Merge pull request #5152 from ligfx/disciomaybeuninitialized 
DiscIO: initialize out args to ReadSwapped (fixes warning)
 2017-03-31 00:11:53 -04:00
Mat M 774d2420e3 Merge pull request #5158 from ligfx/coretimingstatic 
CoreTimingTest: make AdvanceAndCheck() static (fix warning)
 2017-03-31 00:09:20 -04:00
Lioncash 6495becaf7 Frame: Remove GetGameListCtrl() 
This is currently unused and shouldn't actually be a part of the frame's
public interface. The event system should be used instead to dispatch
messages to the game list control if necessary.
 2017-03-30 16:05:20 -04:00
Lioncash 497292cb1b MainMenuBar: Amend MEGA signature help tooltip 
Keeps it consistent with the regular signature DB option
 2017-03-28 17:14:04 -04:00
Lioncash 5637bbd1cf MEGASignatureDB: Remove unused variable in Apply 2017-03-28 16:19:19 -04:00
Lioncash eec4b705d5 MEGASignatureDB: Move objects where applicable 
Signatures during loading and strings during reference retrieval can be
moved.
 2017-03-28 16:18:31 -04:00
Lioncash c0171975ea MEGASignatureDB: Move implementation details into the cpp file 
These functions aren't dependent on any database state and can be hidden.
 2017-03-28 15:43:21 -04:00
Lioncash 8d98ac6509 CPU: Convert state enum to an enum class 
Gets enum constants out of the immediate namespace. Also makes it
strongly typed like the other state enums.
 2017-03-28 11:48:28 -04:00
Lioncash 41fbc659bf Fifo: Remove unnecessary integral casts 
FIFO_SIZE is a u32, so %u can just be used instead.
 2017-03-28 10:35:26 -04:00
Lioncash 9ebd84e54a VertexLoaderManager: Return debug strings by value 
This also renames AppendListToString to VertexLoadersToString.
 2017-03-26 23:50:09 -04:00
Lioncash 9859533ab4 VertexLoaderBase: Return debug strings by value 
An out parameter for this sort of thing is a C++03 hold-over. This also
renames AppendToString to ToString.
 2017-03-26 23:49:59 -04:00
Lioncash d44844ba29 XFStructs: Get rid of an unnecessary pointer cast 
Also gets rid of implicit sign conversions.
 2017-03-26 23:09:30 -04:00
Lioncash 62db55dee2 Fifo: const correctness 
PushFifoAuxBuffer only memcpys data using ptr as the source pointer, so
it can be a pointer to const data because of that.
 2017-03-26 23:08:33 -04:00
Lioncash 8033a72f0b VertexLoaderBase: Use std::array where applicable 2017-03-26 22:12:20 -04:00
Lioncash adbffc24e9 VideoInterface: Make clock frequency array constexpr 
This is only ever read from.
 2017-03-26 19:30:44 -04:00
Lioncash ec5637fe46 VideoInterface: Utilize std::array where applicable 2017-03-26 19:28:56 -04:00
Lioncash ae29cd042e VideoInterface: Initialize union members directly where applicable 2017-03-26 18:42:09 -04:00
Lioncash 0a7a6142eb GCMemcardDirectory: Move flush interval constant into the cpp file 
This isn't necessary to be within the header.
 2017-03-26 17:55:30 -04:00
Lioncash a5c5645bed DSPIntMultiplier: Place translation unit local functions in an anonymous namespace 
Unlike inline, this makes the functions internally linked.
 2017-03-26 16:42:35 -04:00
Lioncash 57c21b9576 TextureCacheBase: Convert bound_textures from a C array to a std::array 
Prevents array-to-pointer decay and simplifies some code.
 2017-03-25 14:53:25 -04:00
Lioncash b711daee5f BitField: Get rid of a C-style cast 
This can simply be the max value of the unsigned type.
 2017-03-23 15:28:58 -04:00
Lioncash e43c495ce5 BitField: Convert typedefs to using aliases 2017-03-23 15:28:50 -04:00
Lioncash caef08988e BitField: Make mostly constexpr capable 
Makes the constructor and retrieval functions constexpr.
 2017-03-23 11:45:45 -04:00
Lioncash da2e34f69b VertexLoaderBase: In-class initialize class members where applicable 
Same thing, less code.
 2017-03-23 08:37:18 -04:00
Lioncash a7ec2d3831 Arm64Emitter: Get rid of pointer casts in PoisonMemory 
The previous code invokes undefined behavior.
 2017-03-23 07:10:21 -04:00
Lioncash 1d6d85963f ARDecrypt: const correctness 2017-03-22 20:35:00 -04:00
Lioncash 29ca22905b IniFile: Replace a character erase with pop_back() 
Same thing, more straightforward.
 2017-03-22 19:32:10 -04:00
Lioncash 35959bdaf9 IniFile: Replace string joining code with JoinString 2017-03-22 19:30:15 -04:00
Lioncash b92871111a IniFile: std::move a std::string in GetLines 
Also gets rid of an unnecessary string copy.
 2017-03-22 19:09:25 -04:00
Lioncash dbdf693c81 IniFile: Use character literals instead of string literals where applicable 
Character overloads are generally better overall (range checks aren't
necessary, etc).
 2017-03-22 19:03:17 -04:00
Lioncash d8998b6392 IniFile: Provide an rvalue reference overload for SetLines 
Allows moving in vectors instead of performing an unnecessary copy.
 2017-03-22 18:49:13 -04:00
Lioncash 46d74a7760 IniFile: Make Section's string constructor instances take strings by value 
As the name is immediately stored into a class member, a move here is a
better choice.

This also moves the constructor implementations into the cpp file to
avoid an otherwise unnecessary inclusion in the header. This is also
likely a better choice as Section contains several non-trivial members,
so this would avoid potentially inlining a bunch of setup and teardown
code related to them as a side-benefit.
 2017-03-22 18:47:19 -04:00
Lioncash 99adc73383 IniFile: Make Section constructor explicit 2017-03-22 18:07:23 -04:00
Lioncash 2f52d04e30 GeckoCodeConfig: Use compare instead of substr for comparing substrings 
Gets rid of an unnecessary string construction.
 2017-03-21 18:12:40 -04:00
Lioncash 0d0e9f626d GeckoCodeConfig: Amend unnecessary string literals to char literals 
Also gets rid of an unnecessary std::string construction in a loop.
std::string already has an operator+ overload to prepend characters.
 2017-03-21 18:03:06 -04:00
Lioncash 28235b5cb6 GeckoCodeConfig: Remove unused commented out code 2017-03-21 18:03:06 -04:00
Lioncash f0fa692457 GeckoCodeConfig: Move gecko code title building to its own function 
Keeps it separate from the rest of the saving code and also allows for
easy rvalue-reference moving into the lines vector as a side-benefit.
 2017-03-21 18:03:02 -04:00
Lioncash f91292eff2 GeckoCodeConfig: Return vector by value for LoadCodes() 
Using an out-param is a leftover from C++03. Action Replay codes already
return the vector of codes by value as well.
 2017-03-21 16:58:13 -04:00
Lioncash 780dffcb13 FifoDataFile: In-class initialize member variables where applicable 2017-03-21 15:41:05 -04:00
Lioncash 4e5e7cff0a FifoRecorder: In-class initialize member variables where applicable 2017-03-21 15:41:05 -04:00
Lioncash eda27ee397 FifoPlayer: In-class initialize member variables where applicable 2017-03-21 15:40:56 -04:00
Lioncash 0d1bc53e55 JitBase: Rename MergeAllowedNextInstructions to CanMergeNextInstructions 
This is more indicative that it's checking for something
 2017-03-21 13:50:03 -04:00
Lioncash f98211bfcf JitBase: Make MergeAllowedNextInstructions a const member function 2017-03-21 13:45:18 -04:00
Lioncash 35c230a418 NetPlayServer: const correctness 2017-03-19 09:36:40 -04:00
Lioncash 025eac9062 NetPlayClient: const correctness 2017-03-19 09:32:58 -04:00
Lioncash 8e999b209a NetPlayClient: Eliminate variable shadowing 
Gets rid of two -Wshadow warnings
 2017-03-18 22:58:07 -04:00
Lioncash 3404057732 ES: Remove unused string format argument in LaunchPPCTitle 
Gets rid of a -Wformat-extra-args warning.
 2017-03-18 22:44:46 -04:00
Lioncash 2b8abddadf Memmap: Replace '0' constant with nullptr 2017-03-18 22:35:35 -04:00
Lioncash 44fb429e7e EXI: Namespace device classes 2017-03-18 21:13:12 -04:00
Lioncash 6cf3c2262c SI: Convert SI buffer from a C array to std::array 
Stronger typing (no implicit pointer decay), nicer aggregate
initialization.

Also gets rid of magic constants where applicable.
 2017-03-16 05:37:03 -04:00
Lioncash f0eeb3c63a SI: Namespace device classes 
Places all of the SI code under the SerialInterface namespace instead of
only the main source file. This keeps all SI code under a common name,
as well as out of the global namespace
 2017-03-16 04:41:39 -04:00
Lioncash 9c3b35fccb EXI: Move enum constants into the ExpansionInterface namespace 
Given these are related to EXI itself, these should be within the
namespace itself.
 2017-03-16 02:06:29 -04:00