Commit Graph
100 Commits
Author SHA1 Message Date
Tilka e24e107b3c Merge pull request #13265 from Sintendo/warnings
Fix several minor warnings
2025-01-08 21:44:24 +00:00
Tilka ffa312f8e8 Merge pull request #13158 from jordan-woyak/wiiu-rename
DolphinQt: Rename "GameCube Adapter for Wii U".
2025-01-08 21:39:08 +00:00
Tilka 05cad38abc Merge pull request #13243 from nlebeck/stringutil-tests
Add some unit test coverage of the `SplitPath` function
2024-12-27 18:10:47 +01:00
Tillmann Karras 445fe2248c GameSettings: set EFBAccessEnable=True for Neighbours from Hell
This fixes the loading screens that show a walking animation.
2024-12-08 11:29:15 +00:00
Tilka 7f25e05b31 Merge pull request #13188 from dreamsyntax/titledb-update
Sys: Sync wiitdb files with GameTDB
2024-11-15 00:05:42 +00:00
Tilka 375a990e41 Merge pull request #13185 from JosJuice/rvz-clarify-padding-none
docs: Clarify wia_except_list_t padding in uncompressed groups
2024-11-10 15:40:08 +00:00
Tillmann Karras fbce737415 ProcessorInterface: sync GPU just before PI_FIFO_RESET
GXAbortFrame() is problematic for Dolphin because it first writes
PI_FIFO_RESET (for which we discard our internal fifo), then disables CP
reads (for which we execute pending commands in the GP fifo in emulated
memory). I don't know whether there is a race condition on hardware, but
there is one for us. Avoid this by also doing a GPU sync here.
2024-11-09 03:29:05 +00:00
Tilka 4b0b9799a9 Merge pull request #13000 from tygyh/Simplify-type-specifiers
Remove redundant elaborated type specifiers
2024-11-08 23:59:08 +00:00
Tilka 97ea64164b Merge pull request #13182 from jordan-woyak/wiimote-speaker-remove-dumping-code
WiimoteEmu: Remove disabled and no-longer-compiling wav dumping code.
2024-11-08 22:53:56 +00:00
Tillmann Karras 0488ade1dc DSPHLE/AXWii: fix Elebits sound
Regressed in 37ebb13ece.
2024-11-04 20:47:55 +00:00
Tilka 97931a718f Merge pull request #13151 from mitaclaw/core-global-system-6
MainWindow: Avoid Global System Accessor
2024-11-02 12:04:28 +00:00
Tilka 466e8de62c Merge pull request #13163 from jordan-woyak/pragma-once-oopsie
Add include guard to QtUtils.h
2024-11-02 12:01:27 +00:00
Tillmann Karras 5adc1bdecd GameSettings: add patch to fix Eternal Darkness startup hang
The game calls GXSetDrawDone and then switches the GP fifo without first
waiting for the draw done interrupt to arrive. Before
e96960e2a6, Dolphin would not execute the
draw done command and potentially also skip other commands in the old GP
fifo. Since that commit, Dolphin executes the remaining commands on the
old GP fifo just before disabling reads for switching, but because
PixelEngineManager::RaiseEvent() enforces a minimum delay of 500 cycles
for the draw done interrupt, it arrives after the game has switched to
the new GP fifo which seems to trigger the deadlock.

This patch replaces the call to GXSetDrawDone by a call to GXDrawDone
which does the same but also waits for the interrupt.
2024-10-30 21:16:31 +00:00
Tilka fed8220c39 Merge pull request #12712 from Dentomologist/remove_defined_out_code
Remove defined-out code
2024-10-19 19:36:19 +01:00
Tillmann Karras 0e41adb7b7 VideoCommon: fix -Wshadow-uncaptured-local warning and simplify 2024-10-16 18:36:00 +01:00
Tillmann Karras fd95607700 Core: apply Dolphin OnFrame patches right after boot 2024-10-16 02:58:03 +01:00
Tillmann Karras 37ebb13ece DSPHLE/AXWii: fix wiimote audio in multiple games
Three bugs specific to older Wii games:
- The size difference between high-pass and biquad filter was not
  accounted for, causing wiimote related fields to be corrupted.
- Wiimote sample buffer pointers were advanced by 32 samples per
  millisecond instead of 6 samples. Usually hidden by the first bug.
- PB updates on Wii were being byte-swapped twice, but I've not actually
  found any Wii games that make use of PB updates.

This fixes wiimote audio in at least the following games:
- Excite Truck
- Ice Age 2: The Meltdown
- Kororinpa: Marble Mania
- Rapala Tournament Fishing
- Shrek the Third
- Super Monkey Ball: Banana Blitz
- Tiger Woods PGA Tour 07
- WarioWare: Smooth Moves (issue 11725)
- Wing Island
2024-10-15 18:54:41 +01:00
Tilka d43c6dc555 Merge pull request #13074 from Pokechu22/normal-cache
Cache normals in addition to binormals and tangents
2024-10-12 19:49:48 +01:00
Tillmann Karras 09b163d814 Boot: don't error for NTSC IPL v1.2 of DOL-001 consoles
Checksum and descriptions from Redump.
2024-10-12 16:11:42 +01:00
Tilka 35ec2e97a8 Merge pull request #13079 from JosJuice/android-16k
Android: Add 16 KiB page size support
2024-10-12 10:11:33 +01:00
Tilka c5ce90b786 Merge pull request #13080 from JosJuice/androidx-edge-to-edge
Android: Use enableEdgeToEdge
2024-10-12 10:11:11 +01:00
Tilka 2024d9f8ff Merge pull request #13126 from jordan-woyak/no-big-banner
DolphinQt: Restrict size of banner image in game properties info tab.
2024-10-12 09:40:20 +01:00
Tilka f635c71f28 Merge pull request #13125 from jordan-woyak/mapping-tab-bar-auto-hide
DolphinQt: Auto hide the mapping window tab bar.
2024-10-12 09:36:19 +01:00
Tilka 9eb0429c2e Merge pull request #13124 from jordan-woyak/trigger-threshold-99
ControllerEmu: Change trigger threshold check to prevent user error.
2024-10-12 09:34:53 +01:00
Tilka 67e8f37c5b Merge pull request #13123 from jordan-woyak/mapping-indicator-dark-theme-code-cleanup
DolphinQt/MappingIndicator: Use Settings::IsThemeDark instead of reimplementing it.
2024-10-12 01:24:43 +01:00
Tilka d6e10e586a Merge pull request #13076 from robxnano/dbus-inhibit
Linux: Use D-Bus to inhibit screensaver
2024-10-12 00:31:58 +01:00
Tilka f4e0a42cfc Merge pull request #13075 from robxnano/qt-color-scheme
Remove unneeded Win32 code for color scheme
2024-10-11 22:20:42 +01:00
Tilka 8679d6c334 Merge pull request #13120 from Sintendo/mtspr
JitArm64: Optimize mtspr
2024-10-11 21:42:12 +01:00
Tilka d2a56b321f Merge pull request #13095 from mitaclaw/ranges-modernization-6-n
Ranges Algorithms Modernization - N
2024-10-11 20:28:06 +01:00
Tilka c1832d17f6 Merge pull request #13117 from mitaclaw/ranges-modernization-9-trivial-find
Ranges Algorithms Modernization - Find
2024-10-11 20:27:18 +01:00
Tilka d374284d92 Merge pull request #13119 from SuperSamus/skylanders-tt-gp-remove
Remove Bloom Definitions for Skylanders Trap Team
2024-10-11 19:35:14 +01:00
Tilka 696ff5baea Merge pull request #13121 from mitaclaw/synthesize-operator!=
C++20: Synthesize `operator!=` From `operator==`
2024-10-11 18:31:56 +01:00
Tilka b5f7a50874 Merge pull request #13118 from BobConanDev/master
Update Contributing.md
2024-10-10 20:35:13 +01:00
Tillmann Karras e96960e2a6 VideoCommon: fix common opcode decoding errors
Many games call GXSetGPFifo() without first waiting for the GP to finish
consuming outstanding commands in the previous GP fifo. Normally,
Dolphin runs OpcodeDecoding in 1000-cycle time slices. In that time
frame, GXSetGPFifo() has probably completed and the GP read pointer now
points to entirely new memory. If the last GP fifo copy ended in an
incomplete command, the new GP fifo would most likely desync for a
while. To avoid all this, give the GP a time slice right now to copy the
remaining data from the previous GP fifo.
2024-10-10 04:07:44 +01:00
Tillmann Karras 3c11360335 IOS: log cIOS device checks as warnings, not errors
Some games do this to detect piracy.
2024-10-09 21:18:36 +01:00
Tilka 2b22e6ffc9 Merge pull request #13109 from Pokechu22/fifo-player-wii-bats
FifoPlayer: Set up additional BATs in Wii mode
2024-10-07 17:42:54 +01:00
Tilka 3466f803b5 Merge pull request #13110 from Pokechu22/fifo-analyzer-xf-index-words
Fifo analyzer: Fix indexed XF loads showing "bytes" instead of "words"
2024-10-07 17:38:24 +01:00
Tilka d1ac40a72b Merge pull request #13101 from JosJuice/gametdbid-partition
Core: Include partition when calling GetGameTDBID for non-game partition
2024-10-05 22:31:58 +01:00
Tillmann Karras e455833ea4 Bluetooth: show vid:pid in error message 2024-10-02 21:50:25 +01:00
Tillmann Karras 0323b30ed7 GameSettings: safe texture cache for "Winter Sports 3: The Great Tournament"
This is required to avoid glitches during Downhill Skiing.
2024-10-01 01:42:18 +01:00
Tillmann Karras a02cbc9b78 WII_IPC: rewrite multiply as 100_tbticks literal (NFC) 2024-10-01 01:42:16 +01:00
Tilka c7cbac538a Merge pull request #13083 from Tilka/apploader
Boot: write Apploader version into memory
2024-09-29 14:40:43 +01:00
Tillmann Karras b168a8092f Boot: write Apploader version into memory
When HLE-ing the apploader, this is necessary to avoid "Error #002"
errors. Homebrew doesn't care.
2024-09-29 03:57:44 +01:00
Tilka 2cb124bd3a Merge pull request #13062 from Dentomologist/graphics_clarify_relationship_between_incompatible_settings
Graphics: Clarify relationship between incompatible settings
2024-09-27 05:40:30 +01:00
Tilka 61836e5d8e Merge pull request #13077 from Dentomologist/graphicswindow_fix_first_opening_during_emulation_startup_crash
GraphicsWindow: Fix crash when opening for the first time during emulation startup
2024-09-27 05:38:37 +01:00
Tilka ec6f5e1104 Merge pull request #13072 from Tilka/videosw
VideoSoftware: small cleanup
2024-09-25 10:57:05 +01:00
Tillmann Karras 0a299a4e1e Sw/Tev: drop unused macro 2024-09-24 22:00:03 +01:00
Tillmann Karras 98add9faf0 Sw/Rasterizer: fix two elder typos, AD 2009 2024-09-24 22:00:03 +01:00
Tilka 067bdaa3dd Merge pull request #13067 from mitaclaw/dead-code-3
GeckoCode: Remove Dead Code
2024-09-22 05:00:26 +01:00
Tilka 6851ed73f4 Merge pull request #13064 from PatrickFerry/gameini_fixing_mistakes
GameINI: Fixing Various Mistakes
2024-09-16 23:24:56 +01:00
Tilka af921685f7 Merge pull request #13035 from retroNUC/cheevo-hash
Add generation of rcheevos hash as an option in DolphinTool
2024-09-15 22:18:58 +01:00
Tilka 5fe9e2f6ed Merge pull request #13057 from JosJuice/rvzpack-typo
DiscIO: Fix a typo in an RVZPack comment
2024-09-08 16:08:57 +01:00
Tilka 2417545b63 Merge pull request #13052 from Tilka/ax
DSPHLE/AX: fix low-pass/biquad clipping
2024-09-07 11:36:06 +01:00
Tillmann Karras eb54721475 DSPHLE/AX: fix low-pass/biquad clipping
The low-pass and biquad filters run in set40 mode where accessing ac#.m
returns the value of ac#.hm clamped to 16 bits.

This fixes the crackling in "Need for Speed: Nitro" (issue 13610).

Also make the lower bound match hardware (-0x8000 instead of -0x7FFF).
2024-09-04 22:33:31 +01:00
Tilka a293abbfd0 Merge pull request #13044 from JosJuice/subfic-carry
Interpreter: Fix subfic carry calculation
2024-08-31 17:24:17 +01:00
Tilka 157be45d6b Merge pull request #13042 from homeisfar/vk_improve_logger
vulkan: Add line number to vulkan error logger
2024-08-31 13:05:28 +01:00
Tilka d0b10b84c0 Merge pull request #13043 from Tilka/my_first_songs
GameSettings: force EFB-to-RAM for My First Songs
2024-08-31 13:04:24 +01:00
Tillmann Karras 4b60ab9ce3 GameSettings: force EFB-to-RAM for My First Songs 2024-08-31 00:11:24 +01:00
Tilka 38b189e13d Merge pull request #13039 from Dentomologist/mainwindow_fix_hidden_confirm_on_stop_dialog
MainWindow: Prevent Confirm On Stop dialog from being hidden by the Render window
2024-08-31 00:08:45 +01:00
Tilka 8b7268ddef Merge pull request #13038 from Ferdi265/fix-rvz-clang-ub
RVZ: Fix undefined behaviour when copying 0 bytes to a null pointer
2024-08-31 00:06:38 +01:00
Tilka 39e266c5bf Merge pull request #13036 from PatrickFerry/gameini_enable_pal60
Gameini: Enable PAL60 for Some PAL Games
2024-08-28 16:56:25 +01:00
Tilka 22ed1dddca Merge pull request #13037 from Dentomologist/hotkeyscheduler_handle_wiimote_connections_independently
HotkeyScheduler: Handle Wii Remote connections independently
2024-08-27 18:54:52 +01:00
Tilka cc256ef16d Merge pull request #10663 from Tilka/ax_biquad
AX: add support for biquad filtering
2024-08-24 22:31:05 +01:00
Tillmann Karras 2669d0d8af AX: add analytics quirks for wiimote filters
I'm fairly sure the implementation is correct but I've not been able to
find a game that actually makes use of these filters.
2024-08-24 19:47:22 +01:00
Tillmann Karras 6946f17b8c AX: enable low-pass/biquad filtering of Wiimote audio 2024-08-24 16:31:59 +01:00
Tillmann Karras 9d2841be10 AX: add support for biquad filtering
This fixes e.g. the overly loud wind in "I SPY: Spooky Mansion".
2024-08-24 16:31:59 +01:00
Tilka 1f5e100a0e Merge pull request #13033 from mitaclaw/remove-common-fill
TypeUtils: Remove Common::Fill
2024-08-23 09:16:13 +01:00
Tilka 239a42a860 Merge pull request #13034 from lycheefox/skylanders
Skylanders: Fix Hot Head (Sparkle)
2024-08-23 09:12:33 +01:00
Tilka 7b8b733b11 Merge pull request #13022 from tygyh/Remove-redundant-semicolons
Remove redundant semicolons
2024-08-21 01:52:16 +01:00
Tilka 46454f9b4e Merge pull request #12974 from JosJuice/simplify-speed-limit-description
DolphinQt: Simplify the Speed Limit description
2024-08-18 17:26:40 +01:00
Tilka 10f06a48ef Merge pull request #12863 from JosJuice/android-gamepad-sensors
Android: Fix and enable input device sensor input
2024-08-18 13:48:30 +01:00
Tilka 3cd506b685 Merge pull request #13021 from Pokechu22/stereo-post-processing-ui
Fix postprocessing shader not changing when setting stereo mode
2024-08-18 12:27:21 +01:00
Tilka c9af09eca7 Merge pull request #13005 from Tilka/display_list
VideoCommon: force display list alignment
2024-08-18 06:36:31 +01:00
Tillmann Karras f358b67205 GameSettings: remove patches for "Wallace & Gromit in Project Zoo"
These patches were added in bde9a459cd
and enabled by default in 36ecfdd6b5.
They allowed the game to run in Dolphin but disabled dynamic shadows.
The game adds 4 to the start address of otherwise valid display lists
for no obvious reason. Now that Dolphin forces 32-byte alignment these
patches are no longer needed.
2024-08-18 05:00:38 +01:00
Tillmann Karras 20f4643c74 VideoCommon: force 32-byte alignment for display list address and size 2024-08-18 05:00:38 +01:00
Tilka 36414bdb55 Merge pull request #12773 from Tilka/zelda_filters
DSPHLE/Zelda: Add two missing filters
2024-08-18 04:52:31 +01:00
Tilka f3debc47ac Merge pull request #13019 from JosJuice/clear-sys-2
UnitTests: Remove MSBuild input/output tracking
2024-08-18 00:39:13 +01:00
Tilka 5f39db5876 Merge pull request #13008 from noahpistilli/kd-get-time-triggers
IOS/KD: Implement Get Time Triggers
2024-08-17 04:19:23 +01:00
Tilka b3652a6fe7 Merge pull request #12889 from mitaclaw/constexpr-bitutils-1
BitUtils: Constexpr BitCastToArray, Remove BitCastFromArray
2024-08-17 03:28:06 +01:00
Tilka 0e9337f51d Merge pull request #13011 from JosJuice/clear-sys
Delete output Sys folder before copying to it
2024-08-16 21:49:24 +01:00
Tilka 07557e5d9c Merge pull request #13015 from tygyh/Use-boolean-literals
Replace boolean constants with boolean literals
2024-08-16 20:04:45 +01:00
Tilka 45d6653a6d Merge pull request #13010 from OatmealDome/goodbye-steam
Remove Steam support
2024-08-16 20:03:38 +01:00
Tilka 1759d27267 Merge pull request #13017 from Tilka/foo
DolphinTool: print title IDs in hex
2024-08-16 20:02:01 +01:00
Tillmann Karras 884a38f04d DolphinTool: print title IDs in hex 2024-08-16 18:39:23 +01:00
Tillmann Karras 214756dd18 Small wording changes for dump conversions 2024-08-16 18:39:23 +01:00
Tilka d10c3aaf29 Merge pull request #13012 from mitaclaw/Use-contains-method-2
Use contains method 2
2024-08-16 18:31:07 +01:00
Tilka e91784e7ec Merge pull request #13014 from LillyJadeKatrin/retroachievements-game-badge-fix
Fixed missing game badge in achievements dialog
2024-08-16 03:35:21 +01:00
Tilka 18ac8bf405 Merge pull request #12990 from tygyh/Use-contains-method
Use 'contains' method
2024-08-14 23:54:16 +01:00
Tilka 1e8b3a58b2 Merge pull request #13006 from tygyh/Remove-self-comparison
Remove self-comparison
2024-08-14 19:49:44 +01:00
Tilka d5522e218f Merge pull request #12997 from tygyh/Remove-constness
Constness of 'result' prevents automatic move [performance-no-automatic-move]
2024-08-14 02:28:23 +01:00
Tilka f712ea71f1 Merge pull request #13004 from Dentomologist/menubar_update_select_state_slot_on_hotkey
MenuBar: Update checkmarked Select State Slot when hotkeys are pressed
2024-08-14 02:27:36 +01:00
Tilka d4ec524f21 Merge pull request #12996 from tygyh/Fix-retro-achievement-comment
Fix comment
2024-08-13 16:35:18 +01:00
Tilka 5af0ae25e6 Merge pull request #12979 from lycheefox/skylanders
Skylanders: Fix some skylanders and add missing ones.
2024-08-13 03:41:15 +01:00
Tillmann Karras 88bd81931f DSPHLE/Zelda: Add two missing filters
The biquad filter is used in all Pikmin games for cursor sound effects
in the main menu, although the difference is subtle.

The low-pass filter is used at least by Pikmin 2 Wii during the
spaceship crash in the intro and fixes the missing "puff" sound effects
whenever there is black smoke coming out of the engine.
2024-08-13 03:36:09 +01:00
Tilka 4c559e7f66 Merge pull request #12988 from tygyh/Update-gitignore
Update gitignore
2024-08-10 18:29:25 +01:00
Tilka b76d05e4bb Merge pull request #12991 from tygyh/Remove-dereferencing
Replace indirection operator with arrow operator
2024-08-10 18:22:30 +01:00
Tilka 5d5f1693b5 Merge pull request #12985 from mitaclaw/qpushbutton-clicked
DolphinQT: Listen For `clicked` Signal Rather Than `pressed`
2024-08-09 07:01:18 +01:00
Tilka 8b1046595b Merge pull request #12980 from mitaclaw/is-debugging-enabled-getter
JITs: Consistently Use Trivial `IsDebuggingEnabled` Getter
2024-08-07 15:07:42 +01:00
Tilka 9ae560d8a0 Merge pull request #12947 from Dentomologist/qtutils_clearlayoutrecursively_fix_potential_crash
QtUtils/ClearLayoutRecursively: Fix potential crash
2024-08-07 03:29:52 +01:00
Tilka 603c8fad85 Merge pull request #12961 from JosJuice/expression-parser-translation
InputCommon: Translate ExpressionParser error messages
2024-08-07 03:28:48 +01:00