Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
22,592 Commits 1 Branch 0 Tags
be3f9f7431b2e8befec6f6de198293313bcc0241
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash be3f9f7431 DSPEmitter: Fix -Wreorder warnings 2017-01-28 06:07:25 -05:00
Mat M cf18ed0a52 Merge pull request #4765 from degasus/token 
PixelEngine: Use a DirectRead for the token.
 2017-01-27 01:55:53 -05:00
Lioncash 4003360bcb DSPCore: Move CompileCurrent to the DSPEmitter 
This is only ever used here.
 2017-01-27 01:36:29 -05:00
Lioncash be52fcf651 DSPEmitter: Make most public variables private 
Dispatchers and m_unresolved_jumps is utilized in code outside of the
emitter, so these are left as is for the time being.
 2017-01-26 20:32:57 -05:00
Lioncash 970d969f63 DSPEmitter: Make conditional JIT functions in DSPJitBranch part of the emitter 
These quite clearly have a dependency on the emitter itself, so these
should be a part of the emitter itself.

The template function can be modified to just simply take functions as a
parameter.
 2017-01-26 20:32:34 -05:00
Lioncash 16aac00b8a DSPEmitter: Move private variables below function declarations 2017-01-26 19:25:49 -05:00
Lioncash ef52451954 DSPJitRegCache: Convert DSPJitSignExtend into an enum class 
Prevents general names like SIGN, ZERO, and NONE from polluting the
surrounding namespace.
 2017-01-26 18:33:50 -05:00
Lioncash bdd7034fcb DSPJitRegCache: Move allocation order array to the cpp file 
As it's a private static implementation detail that doesn't rely on any
other internals of DSPJitRegCache, it can be hidden.
 2017-01-26 17:12:55 -05:00
Lioncash 8f5ce50a25 DSPAssembler: Migrate VerifyParams over to an OpcodeType param instead of bool 2017-01-26 05:17:05 -05:00
Lioncash 6cb6707a4e DSPTables: Hide remaining exposed opcode tables 
All opcode tables are now internal.
 2017-01-26 05:17:01 -05:00
Lioncash f4415dd99c DSPEmitter: Amend member variable naming 
Amends the variable names to follow our coding style.
 2017-01-25 19:26:57 -05:00
Mat M ec9b49436c Merge pull request #4754 from Orphis/deploy_mac_fix 
macOS: Fix deploy-mac.py which fails when no dylib path has to be cha…
 2017-01-25 19:16:13 -05:00
Lioncash c2e3bd8d2f DSPAssembler: Amend printf specifiers in ShowError 
code_line is a u32.
 2017-01-25 17:20:25 -05:00
Lioncash 992b7f7ac0 DSPAssembler: Replace char buffer + sprintf with StringFromFormat 2017-01-25 17:20:21 -05:00
Mat M 1bc5e4bc45 Merge pull request #4749 from Orphis/cmake_cleanup 
CMake cleanup
 2017-01-25 10:35:22 -05:00
Lioncash 3734d6f16c DSPJitRegCache: Make GetReg return by value 
Using out-references for this sort of thing is a C++03-ism.
 2017-01-24 23:10:34 -05:00
Lioncash ed627a8cff DSPAssembler: Replace malloced output buffer with std::vector 
Same thing, less manual memory management.
 2017-01-23 22:03:40 -05:00
Lioncash 7a58a82a37 BPMemory: Add const specifier to member functions where applicable 2017-01-23 16:07:03 -05:00
Lioncash 1f596a23af BPMemory: Eliminate union type punning 
This is undefined behavior in C++.
 2017-01-23 16:05:32 -05:00
Lioncash 70cf774a5c RenderBase: Forward declare EFBAccessType 2017-01-23 12:41:26 -05:00
Mat M 93faf26217 Merge pull request #4721 from RisingFog/remove_dead_audiodump_code 
Remove dead audio dumping code
 2017-01-23 09:17:11 -05:00
Lioncash fd772f6726 ES: Move the key table into the cpp file 
This is a static implementation detail, so there's no need to bind it to the class directly.

This also makes the tables read-only.
 2017-01-23 08:16:28 -05:00
Lioncash a9da2d9e20 ControllerEmu: Add missing virtual destructor to BooleanSetting 2017-01-23 05:08:19 -05:00
Lioncash 34768617d2 Attachment: Make constructors explicit where applicable 2017-01-23 04:42:27 -05:00
Lioncash 34262ee3d8 Attachment: Move implementation details into the cpp file 2017-01-23 04:42:26 -05:00
Lioncash c87ee2a00e Attachment: Use std::array over C arrays 2017-01-23 04:42:21 -05:00
Lioncash 940aa6f32d VideoBackendBase: Convert FieldType into an enum class 2017-01-23 03:54:01 -05:00
Lioncash 5b461f50af VideoBackendBase: Convert EFBAccessType into an enum class 2017-01-23 03:53:38 -05:00
Lioncash 4b2f40a634 Attachment: Make class members non-public 2017-01-22 23:53:13 -05:00
Mat M a2caa0d733 Merge pull request #4719 from ligfx/removeandroidtoolchainfile 
Android: remove unused android.toolchain.cmake
 2017-01-22 22:46:31 -05:00
Lioncash fbcf86870d SI_Device: Remove const specifiers from SIDevice_Create declaration's parameters 
These are only relevant on the definition of the function.
 2017-01-22 22:34:23 -05:00
Lioncash 0adb0dfeef SI_Device: Move implementation details into the cpp file 
Any changes to the base class' default behavior now won't require
all SI device source files to be recompiled.
 2017-01-22 22:33:27 -05:00
Lioncash fb8f19f553 SI_Device: Amend variable naming 2017-01-22 22:20:16 -05:00
Lioncash f41e5eac2e SI_Device: Move protected interface below public interface 2017-01-22 22:10:43 -05:00
Lioncash 7f4ef74542 SI_Device: Move the null device implementation to its own source files 2017-01-22 21:18:51 -05:00
Lioncash a97aef2e94 Jit: Eliminate JIT global usages 2017-01-22 06:01:30 -05:00
Lioncash a18ab5e154 JitArm64_LoadStore: Eliminate JIT global usages 2017-01-22 05:59:38 -05:00
Lioncash 4601499179 JitArm64_LoadStoreFloating: Eliminate JIT global usages 2017-01-22 05:57:44 -05:00
Lioncash 7c0b96f638 EXI_Device: Move the dummy implementation to its own source files 2017-01-22 02:15:36 -05:00
Lioncash d6bdbfe90e DSPAssembler: Use std::string instead of malloced char buffers in AssembleFile 2017-01-22 01:15:36 -05:00
Lioncash cbe1ec51df DSPAssembler: Make AssembleFile take a std::string 
File paths passed to it would have been implicitly converted to std::strings
prior to this function being reached, so it gets rid of some string churn.
It also makes it safer since nullptr can't be passed in.
 2017-01-22 01:15:31 -05:00
Lioncash d2ff34e510 EXI_Channel: Remove const qualifiers from member function declaration parameters 
Const used on value types only really has a use when used within the
definition.
 2017-01-21 22:36:09 -05:00
Lioncash 387769b4e2 EXI_Channel: Move SetEXIINT implementation into the cpp file 2017-01-21 22:36:09 -05:00
Lioncash edf8a79005 EXI_Channel: Make constructor explicit 2017-01-21 22:36:09 -05:00
Lioncash 5a85001d30 EXI_Channel: Amend variable casing 2017-01-21 22:36:04 -05:00
Lioncash 0dee9bc4f0 MMU: Change '0' literals to 'false' in IsOptimizableGatherPipeWrite 2017-01-21 21:16:41 -05:00
Lioncash 688225616e EXI_Channel: In-class initialize variables 2017-01-21 18:44:54 -05:00
Lioncash 489e4c49bc EXI_Channel: Move private interface below public interface 2017-01-21 18:42:18 -05:00
Lioncash 794d0a9d7c Core: Move SI source files to their own directory 2017-01-20 19:33:24 -05:00
Lioncash 8078c18a80 Core: Move EXI source files to their own directory 
Keeps related source files together and cleans up the root directory of HW
a little bit.
 2017-01-20 16:06:35 -05:00
Mat M b05fc9d369 Merge pull request #4692 from Orphis/cmake_cleanup 
CMake cleanups for Windows
 2017-01-20 15:25:34 -05:00
Lioncash 4d92ffb949 Interpreter: Amend parameter naming 
Drops prefixed underscores from parameters

The C++14 standard states in section 2.10 subsection 3.2:

"Each identifier that begins with an underscore is reserved to the
implementation for use as a name in the global namespace."

It's highly unlikely an implementation will ever use '_inst' as a global
identifier, however it's better to just amend the names and alleviate
the concern altogether.
 2017-01-20 14:51:00 -05:00
Lioncash c73f4bd226 DSPTables: Hide main opcode tables 
Hides the opcode tables that the interpreter and JIT interface with to
execute instructions.

This does not, however, hide the read-only tables that the assembler and
disassembler use.
 2017-01-19 17:46:07 -05:00
Lioncash 2b5b21f2a4 DSPAssembler: Rename FindOpcode parameters 
Having opcod and opcode as parameter names is kind of silly.
 2017-01-19 17:46:01 -05:00
Lioncash 14f0e66809 DSPTables: Use std::array instead of C arrays 2017-01-19 17:07:31 -05:00
Lioncash d266be5b56 PowerPC: Explicitly savestate PowerPCState members 
Makes it more obvious which data is going into the savestate.
It also allows PowerPCState and InstructionCache to potentially
contain members that don't necessarily need to be saved to the save state.

It also gets rid of any potential padding data being put into the save
state.
 2017-01-18 23:44:46 -05:00
Lioncash c761f98ede PowerPC: Simplify TLB resetting 
Member initializers and std::array make this trivial for fixed value initialization.
 2017-01-18 19:31:04 -05:00
Lioncash b2351ddb29 PowerPC: Move CPU core initialization to its own function 2017-01-18 19:13:52 -05:00
Lioncash e86def732a PowerPC: Move zeroing of segment registers into ResetRegisters 2017-01-18 16:03:31 -05:00
Lioncash cf1c194b88 DSPLLE: Amend variable casing 2017-01-18 12:50:58 -05:00
Lioncash 0f70650e93 DSPHLE: Amend variable casing 2017-01-18 12:44:27 -05:00
Lioncash a57b378116 DSPEmulator: Amend variable casing 2017-01-18 12:20:13 -05:00
Lioncash bba6a31eb6 Interpreter_Tables: Amend leftover comment 2017-01-18 03:03:44 -05:00
Lioncash 06488477a9 Interpreter_Tables: Ensure all instructions fit within m_allInstruction at compile-time 2017-01-18 03:03:42 -05:00
Lioncash 6c61021eb1 PPCTables: Use std::array instead of raw C arrays 2017-01-18 03:03:00 -05:00
Lioncash 1a1ce42889 Interpreter_Tables: Use std::array for instruction tables 2017-01-18 03:02:55 -05:00
Lioncash e4ea9f7ace Interpreter: Use std::array for instruction tables 2017-01-17 22:06:52 -05:00
Lioncash f0abdbdeb5 Interpreter: Correct member variable casing 2017-01-17 21:50:01 -05:00
Lioncash e9b506638f Interpreter: Make m_EndBlock private 2017-01-17 21:16:14 -05:00
Lioncash 722162b54a IPC_HLE: Namespace IOS HLE 
Gets all of the IOS HLE code out of the global scope.
 2017-01-17 20:46:58 -05:00
Lioncash f1542c8e5a Common: Namespace Network.h/.cpp 
Necessary to avoid namespace clashes with IOS HLE's namespace name.
 2017-01-17 20:46:48 -05:00
Lioncash bb49012445 IR: Deduplicate code in Reset and FoldFallbackToInterpreter 2017-01-17 20:35:02 -05:00
Lioncash 89473d5996 IR: Clean up getNumberOfOperands 
- Use std::array
- Make arrays constexpr where their contents aren't modified.
 2017-01-17 20:22:38 -05:00
Lioncash d3aed03563 IR: Make trivial helper functions constexpr 2017-01-17 19:42:36 -05:00
Lioncash d1f39185dd IR: Convert typedefs to using aliases 2017-01-17 19:40:56 -05:00
Lioncash 1516c22a22 JitILBase: Make the IRBuilder instance protected 
There's no need to make it public.
 2017-01-17 14:55:45 -05:00
Lioncash e924814d62 JitILBase: Move protected members below public 2017-01-17 14:45:40 -05:00
Mat M 81358dbf20 Merge pull request #4674 from Orphis/require_gcc5 
cmake: Enforce minimum GCC version
 2017-01-17 14:35:38 -05:00
Mat M ad36d4915c Merge pull request #4668 from lioncash/cmake 
CMakeLists: Make CMake 3.5.0 the minimum requirement
 2017-01-17 14:34:03 -05:00
Lioncash bae0158fc1 CMakeLists: Make CMake 3.5.0 the minimum requirement 2017-01-17 13:36:39 -05:00
Lioncash 8346f86ee4 IR: Remove unnecessary semicolon on namespace brace 2017-01-16 19:54:42 -05:00
Lioncash 67fc73e82c IR: Make getNumInsts return type size_t 
There's no need to cast here.
 2017-01-16 19:38:30 -05:00
Lioncash 459a6e73c3 IR: Remove unused function 2017-01-16 19:32:13 -05:00
Lioncash cd12b2c55f IR: Make IRBuilder uncopyable 
Hiding and not implementing the copy constructor is a pre-C++11 thing.
It should also be noted that a copy constructor, as defined by the
language, contains a const qualifier on its parameter, so this wouldn't
have prevented copies from being performed.
 2017-01-16 18:59:17 -05:00
Lioncash a8b2dd7fc3 IR: Use std::array instead of raw C arrays 2017-01-16 18:54:30 -05:00
Lioncash ef3e6de875 IR: Move implementation of the constructor and Reset into the cpp file 
Neither of these are intended to be called extremely frequently to warrant
this.
 2017-01-16 18:36:11 -05:00
Lioncash 47fc72f0a8 IR: Get rid of an unimplemented member function prototype 2017-01-16 18:11:54 -05:00
Lioncash 4f75590fdb IR: Move private details below public details 2017-01-16 18:08:11 -05:00
Lioncash 43910e474b IR_X86: Use member initializers where applicable for RegInfo 2017-01-16 17:29:09 -05:00
Lioncash bc7374a5e1 IR_X86: Use std::array instead of raw C arrays in RegInfo 2017-01-16 17:29:09 -05:00
Lioncash 45f7883ed8 IR_X86: Make RegInfo uncopyable 
Hiding and not implementing the copy constructor is a pre-C++11 thing.
It should also be noted that a copy constructor, as defined by the language,
contains a const qualifier on its parameter, so this wouldn't have
prevented copies from being performed.

It also follows that if the copy constructor is deleted, then copy
assignment should also be forbidden.
 2017-01-16 17:27:03 -05:00
Lioncash 6788cb7266 HW/DSP: Correct prefixes of translation-unit-local variables 
These aren't globals.
 2017-01-16 14:53:37 -05:00
Lioncash 8cc4815fe2 HW/DSP: Hide the DSP state global 2017-01-16 14:14:03 -05:00
Lioncash c6ec5de659 HW/DSP: Use member initializers with structs/unions where applicable 2017-01-15 16:03:12 -05:00
Lioncash 3848c2a018 MemoryView: Get rid of a type-punning cast from u32 to float 
This is undefined behavior. The bits should be memcpyed.
 2017-01-15 12:16:41 -05:00
Lioncash 2108bf1be6 MemoryView: Separate memory string composition from OnPaint 
OnPaint should only care about drawing data, not directly creating
said data.
 2017-01-15 12:13:08 -05:00
Lioncash 0a6f0dfb74 Common: Add bit utility header 
This attempts to make some bit arithmetic more self-documenting and also
make it easier during review to identify potential off-by-one errors by
making it possible to just specify which bits are being extracted.

Functions both support the case where bits being extracted can vary and
fixed bit extraction. In the case the bits are fixed, compile-time asserts
are present to prevent accidental API usage at compile-time.

e.g. Instead of shifting and masking to get bits 10 to 15,
Common::ExtractBits<10, 15>(value) can just be done instead.
 2017-01-14 11:16:02 -05:00
Lioncash 45415e1057 ColorUtil: Make decodeCI8image's pal parameter const 2017-01-13 17:07:26 -05:00
Lioncash 35cc4a4202 DSPInterpreter: Get rid of a #define constant 
This constant isn't particularly helpful, mainly because it's not
applicable to all DSP instructions. Some instructions don't have encoding
space for registers, and not all instructions that do encode registers
have one at the first five bits.

This change also has the benefit of removing all includes to the
interpreter within the JIT code, which keeps them fully separate from one
another. Changes to the interpreter header won't require some of the JIT
code to be rebuilt.
 2017-01-12 20:36:52 -05:00
Lioncash 0035a4ef3d GCMemcard: Const-correctness changes 
A few function reference and pointer parameters are only read from.
 2017-01-12 20:01:19 -05:00