Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
41,301 Commits 1 Branch 0 Tags
bfb417fa98c324c3045e0892a23535a9b4ebde4d
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Mai bfb417fa98 Merge pull request #12481 from AdmiralCurtiss/globals-systemtimers 
Core/SystemTimers: Refactor to class, move to System.
 2024-01-05 01:50:29 -05:00
Lioncache a23cf2121d VideoCommon/PixelEngine: Generify lock guards 
We don't need to specify the type of the mutex being passed in.
 2023-12-22 14:19:29 -05:00
Lioncache 0505f057ca VideoCommon/PixelEngine: Remove global system accessor in UpdateInterrupts() 
Now that the system instance is passed through, this is no longer necessary.
 2023-12-22 14:19:29 -05:00
Lioncache e539dbba4c VideoCommon/PixelEngine: Passthrough system instance in constructor 
Simplifies the interface in terms of usage
 2023-12-22 14:19:26 -05:00
Mai b1438c224f Merge pull request #12439 from lioncash/sprintf 
Core: Use fmt over sprintf in trivial cases
 2023-12-21 17:17:21 -05:00
Mai 6c2da5229e Merge pull request #12458 from JosJuice/jitarm64-logic-i2r-not-nothing 
JitArm64: Fix the "do nothing" cases of ANDI2R and friends
 2023-12-21 17:13:20 -05:00
Mai f7b655e5da Merge pull request #12456 from iwubcode/android_reduce_pixel_samplers_to_8 
VideoCommon: revert max pixel samplers back to 8 for Android
 2023-12-21 10:35:48 -05:00
Lioncache f97b2d472a VideoCommon/CommandProcessor: Pass system instance through constructor 
Makes the use of the interface a little less noisy, especially given
how much of the interface depends on an instance being present.
 2023-12-20 09:02:53 -05:00
Lioncache b0d244b772 VideoCommon/Fifo: Pass system instance through FifoManager constructor 
Given how many member functions make use of the system instance,
it's likely just better to pass the system instance in on construction.

Makes the interface a little less noisy to use.
 2023-12-18 22:03:25 -05:00
Lioncache dec53848f5 CheatSearch: Get rid of global system accessors 
We can retrieve the system via the CPUThreadGuard instances.
 2023-12-18 19:24:35 -05:00
Lioncache 00f494307f UICommon: Remove global system accessor in TriggerSTMPowerEvent() 
This can be passed through via the IOS instance.
 2023-12-18 19:17:16 -05:00
Lioncache c0b7e9cd94 Core/HLE/HLE: Remove global system accessor from ExecuteFromJIT() 
We can just pass in our system instance via the ABI function helpers.
 2023-12-18 19:11:52 -05:00
Lioncache f4277a901a Core/HLE/HLE: Remove global system accessors 
We can get rid of the global system accessors by requiring passing in
relevant state that the function needs and making callsites do the work.

This *does* add a global accessor to the PPCAnalyzer, however, this already
has global accessors present elsewhere within its code, so they can be removed
all at once in a follow up change.
 2023-12-18 19:11:49 -05:00
Lioncache f1b18d8ae3 Core/IOS/ES: Remove global system accessor in InitializeEmulationState() 
We can pass the core timing instance into the function.
 2023-12-18 19:06:45 -05:00
Lioncache ca5695aef2 Core/Debugger/PPCDebugInterface: Remove global system accessor 
We can use the CPUThreadGuard instance to get the active system instance.
 2023-12-18 16:57:50 -05:00
Lioncache 3802c7bf11 Core/PatchEngine: Get rid of global system accessors 
We can pass the system instance into ApplyFramePatches() instead,
especially considering the patch engine callback already has it
available.
 2023-12-18 16:48:25 -05:00
Lioncache cea58759d9 Core/GeckoCode: unsigned int -> u32 
Same thing for all intents and purposes, less to read.
 2023-12-18 16:39:04 -05:00
Lioncache bb866248cf Core/GeckoCode: Avoid signed conversion in RunCodeHandler() 
i is being used alongside unsigned types, so it should be unsigned as well.
 2023-12-18 16:38:41 -05:00
Lioncache 1ceaa8c52a Core/GeckoCode: Remove global system accessor 
We can use the CPUThreadGuard instance to retrieve the system instance instead.
 2023-12-18 16:35:52 -05:00
Lioncache 472c65ed35 Core/Debugger_SymbolMap: Make GetCallstack() less verbose 
This also allows the constructed CallstackEntry instances to be moved into
the output vector, rather than being copied.
 2023-12-18 15:46:32 -05:00
Lioncache 75ec350dc4 Core/Debugger_SymbolMap: Remove redundant system parameters from interface 
The CPU thread guard already allows access to the system instance. We can
remove the system parameter to reduce rendundancy here.
 2023-12-18 15:46:22 -05:00
Lioncache 514b3e6f55 Core/Debugger_SymbolMap: Remove AddAutoBreakpoints() 
This is wholly unused in current code.
 2023-12-18 15:24:58 -05:00
Lioncache 04300114f7 Core/HLE/HLE_OS: Mark helpers as static where applicable 
Previously, these were given external linkage when they're only used within
this translation unit.
 2023-12-18 13:44:55 -05:00
Lioncache c4df659e21 HLE_OS: Get rid of global system accessors 
Thread guards provide access to the current active system instance.
 2023-12-18 13:39:53 -05:00
Lioncache c3c39de212 HLE_Misc: Get rid of global system accessors 
Thread guards provide access to the current active system instance.
 2023-12-18 13:33:07 -05:00
Lioncache affe928987 Common/TraversalServer: Make use of fmt more 
We can convert printf and fprintf over to the use of fmt as well,
given that we've converted the sprintf calls over.
 2023-12-18 13:08:57 -05:00
Lioncache dc85194fac Common/TraversalServer: Make use of fmt over sprintf where applicable 
Resolves some deprecation warnings on macOS. This is better anyway, given fmt
has generic type formatting.
 2023-12-18 13:08:57 -05:00
Lioncache 1764b13423 Core/DSP/DSPTables: Make pdregname() and pdregnamelong() return std::string 
Keeps the interface consistent.
 2023-12-18 13:08:57 -05:00
Lioncache 62740d97a8 Core/DSP/DSPTables: Make use of fmt::format in pdname() 
Resolves a deprecation warning on macOS. Also, we can convert
the function to just return a std::string instead of using a
static internal buffer, which is gross and thread-unsafe.
 2023-12-18 13:08:57 -05:00
Lioncache 9abcc1c08b Core/NetPlayServer: Use fmt::format_to_n in GetInterfaceHost() 
Lets us avoid some noisy deprecation warnings on macOS (and also lets us use
a more generic formatting specifier).
 2023-12-18 13:08:57 -05:00
Lioncache 2b877fc92b Core/IOS/Top: Make use of fmt::format_to_n where applicable 
Same behavior, but avoids deprecation warnings on macOS builds and also lets us
use generic print formatting.
 2023-12-18 13:08:57 -05:00
Lioncache 04822d5a2c Core/IOS/ES: Make use of fmt::format where applicable 
Eliminates a deprecation warnings on macOS. While we're in the
same area, we can remove the call to GetPointer() and instead
use CopyToEmu() to copy the string data back to the emulated memory.
 2023-12-18 13:05:04 -05:00
Lioncache e6db08e03a Core/IOS/IOS: Remove global system accessor from Init() 
Removes the final global system accessor from the main IOS code by
passing the system instance through it.
 2023-12-18 12:28:21 -05:00
Lioncache 1f50a2fd5b Core/IOS/IOS: Remove global system accessor from WriteReturnValue() 
We can pass the memory instance into it instead of using the global accessor.
 2023-12-18 12:22:01 -05:00
Lioncache b8c657b06f Core/IOS/IOS: Remove global system accessor from RAMOverrideForIOSMemoryValues() 
We can allow passing in the memory instance instead of directly going for the
global system instance.
 2023-12-18 12:10:25 -05:00
Lioncache a13bcd87d4 Core/IOS/IOS: Remove global system accessors from internal functions 
These functions can all be modified to take in the required instance,
rather than using the global system accessor.
 2023-12-18 12:04:58 -05:00
Lioncache 0c9f9ca8b6 Core/IOS/IOS: Remove global system accessor from destructor 
An EmulationKernel already houses a reference to the current system
 2023-12-18 11:55:30 -05:00
Lioncache 0d75d658b1 Core/IOS/IOS: Remove system parameters from BootstrapPPC() and BootIOS() 
An EmulationKernel instance already houses a reference to the currently active system instance.
 2023-12-18 11:54:03 -05:00
Lioncache 69523de5d5 Core/EXI/EXI_DeviceMemoryCard: Remove global system accessor 
We can pass the core timing instance into the Init() call.
 2023-12-18 11:15:51 -05:00
Mai de8bc32dc5 Merge pull request #12362 from CasualPokePlayer/sysconf_widescreen 
Add SYSCONF widescreen setting to dtm header
 2023-12-17 15:19:02 -05:00
Mai 51a44aa5d2 Merge pull request #12431 from JosJuice/jitarm64-rlwnmx-call-rlwinmx 
JitArm64: Call rlwinmx implementation from rlwnmx with imm b
 2023-12-17 15:18:00 -05:00
Mai bcd74a81a9 Merge pull request #12370 from iwubcode/more_samplers 
VideoBackends / VideoCommon: update max pixel shader samplers from 8 to 16
 2023-12-17 14:50:23 -05:00
Mai 559ea0593c Merge pull request #12432 from JosJuice/jitarm64-logic-i2r-opt 
JitArm64: Add additional optimized cases to ANDI2R and friends
 2023-12-17 14:45:55 -05:00
Mai f0f0f97554 Merge pull request #12433 from mitaclaw/windows-arm-debug-fix 
Fix Windows ARM64 debug build errors
 2023-12-17 14:43:55 -05:00
Mai 0125b5182f Merge pull request #12409 from iwubcode/custom_material_graphics_mod_action_data 
VideoCommon: prepare graphics mods for custom shader material data
 2023-12-17 14:42:34 -05:00
Mai b27c15fab6 Merge pull request #12382 from iwubcode/shader_asset_default_value 
VideoCommon: update shader asset to provide a variant default value
 2023-12-17 14:41:55 -05:00
Mai f589c04aa7 Merge pull request #12372 from iwubcode/texture_usage_flag 
VideoBackends / VideoCommon: add type enum to dictate how the texture is used; support texture 2d
 2023-12-17 14:40:39 -05:00
Mai e6c85bf8f0 Merge pull request #12428 from JosJuice/jitarm64-rlwinmx-shift-only 
JitArm64: Add rlwinmx case for only shifting
 2023-12-17 10:45:59 -05:00
Mai 519234949e Merge pull request #12429 from JosJuice/jitarm64-mtsrin-64-bit 
JitArm64: Use 64-bit register for address in mtsrin
 2023-12-17 10:45:36 -05:00
Lioncash 27806d8d7b WiiNetConfig: Eliminate usages of the global system accessor 
We can pass in the existing memory manager instance into the functions
instead of using the global accessor to access it.
 2023-12-14 16:46:52 -05:00
Lioncash 1573b50bb3 HW/CPU: Remove remaining global system accessors 
We can just pass in the m_system member instead.
 2023-12-14 16:14:59 -05:00
Lioncash 5e9763c0fa IOS/MIOS: Eliminate global system accessors 
We can pass the system instance through the EmulationKernel instance.
 2023-12-14 16:05:59 -05:00
Lioncash 88431cfbca WC24PatchEngine: Make GetNetworkPatch() take a std::string_view 
Makes it consistent with GetNetworkPatchByPayload()
 2023-12-14 14:24:49 -05:00
Lioncash fa70a8fd01 WC24PatchEngine: Make a few functions internally linked 
These are only used within this translation unit, so we can remove the
IniFile dependency from the header.
 2023-12-14 14:23:41 -05:00
Lioncash 14abdab314 SysConf: std::move fs pointer in constructor 
Just gets rid of a trivial atomic reference count increment and
decrement. Not a super heavyweight thing, but it is essentially "free"
to get rid of.
 2023-12-14 14:01:17 -05:00
Lioncash a20b4b5669 DolphinQt/Host: Convert inclusion of Fifo.cpp to Fifo.h 
Quite a bizarre include.

Also resolves an indirect include (lol), since this TU was
including the system header that way.
 2023-12-14 05:24:51 -05:00
Lioncash 6bbdf36a7b GameListModel: Remove fallthrough in data() 
A harmless case of it, but this can still cause warnings.
 2023-12-14 04:25:40 -05:00
Lioncash 5450b64951 Externals/expr: Resolve -Wshadow warning 
We already made changes to this library, so we can also resolve the lone
shadowing warning within it.
 2023-12-13 15:29:31 -05:00
Lioncash dbc792a3ec Common/Crypto/SHA1: Resolve -Wignored-attributes warnings 
See commit 417d1310d22b11d5d724625721b5fec09eda099a for an explanation
on why we do this.
 2023-12-13 13:04:53 -05:00
Lioncash bced5fac18 Common/Crypto/AES: Resolve -Wignored-attributes warnings 
The alias for __m128i is typically something like:

typedef long long __m128i __attribute__((__vector_size__(16), __may_alias__));

and the part that ends up not getting preserved is the __may_alias__
attribute specifier.

So, in order to preserve that, we can just use a wrapper struct, so the
data type itself isn't being passed through the template.
 2023-12-13 13:02:51 -05:00
Lioncash dfb2783c25 GBAWidget: Add missing override specifiers 2023-12-13 10:12:18 -05:00
Lioncash 67a06d17b1 GBAWidget: Use std::span with SetVideoBuffer() 
Previously we were always taking the buffer by value, even if it wasn't
being stored anywhere and only read from.

We can use a std::span for the same thing.
 2023-12-13 10:11:52 -05:00
Lioncash e27a4b5d72 Externals/mbedtls: Disable -Wdocumentation related warnings 
It's actually kind of wild that these flags are enabled by default.
They produce an incredible amount of console output spam.

Let's remove them, especially since we've made other changes to this
CMakeLists.txt
 2023-12-12 21:56:27 -05:00
Lioncash ecd7fa4380 DSPInterpreter: Mark IsProperlySignExtended() as [[maybe_unused]] 
This function is used in debug asserts, so in release builds this will
go unused and otherwise generate a warning
 2023-12-12 21:02:15 -05:00
Lioncash e06480a8ab Software/SWGfx: Default destructor in cpp file 
Fixes a build failure with clang 17.

The destructor needs to be in the cpp file, since we have a forward
declared std::unique_ptr type as part of the class. So technically the
default inline destructor could invoke without seeing the full data type
definition.
 2023-12-12 20:33:43 -05:00
Mai ea3033731d Merge pull request #12240 from iwubcode/material_asset_additional_properties 
VideoCommon: add additional data types to material asset
 2023-12-12 18:38:20 -05:00
Mai 022b0a00a2 Merge pull request #12406 from Tilka/xf_assert_msg 
VideoCommon: add message to XF load assert
 2023-12-12 18:36:28 -05:00
Lioncash 91f691296c IOS/Crypto/Sha: Handle ShaCommandUnknown in IOCtlV 
Resolves a -Wswitch warning.
 2023-12-12 17:42:36 -05:00
Lioncash c14b3539c9 CPUThreadConfigCallback: Mark static ID as [[maybe_unused]] 
This isn't used, but is likely kept around so the one-timed execution of
a magic static is taken advantage of.
 2023-12-12 17:30:37 -05:00
Lioncash e883bbc57a ConfigFloatSlider: Resolve -Wshadow warning 
Fairly straightforward variable shadowing.
 2023-12-12 17:07:37 -05:00
Lioncash 79c84c98ed WC24PatchEngine: Resolve -Wshadow warning 
While not captured, we're definitely shadowing the result variable
outside the lambda.
 2023-12-12 17:03:42 -05:00
Lioncash 81d5370141 HLE_OS: Resolve -Wshadow warnings 
We get a warning about shadowing the va_list type and just
run-of-the-mill variable shadowing, which we can easily fix.
 2023-12-12 17:01:32 -05:00
Lioncash a812a1f938 LightingShaderGen: Resolve -Wshadow warnings 
Given how the lambda doesn't capture anything, we can move this to a
internally linked function, which prevents any name shadowing.
 2023-12-12 16:55:06 -05:00
Lioncash 915e43dfba CheatSearchWidget: Make use of CPUThreadGuard parameter in UpdateTableRows 
Previously, the parameter wasn't being used, because it was being
shadowed by another CPUThreadGuard at its only would-be usage point.
 2023-12-12 16:41:00 -05:00
Lioncash b0b1308160 PPCDebugInterface: Silence trivial -Wmaybe-uninitialized warning 
We can just initialize register_index, even if it gets overwritten later
on via Common::FromChars.
 2023-12-12 15:42:28 -05:00
Lioncash 18032f19a5 AchievementManager: Resolve -Wshadow warnings 
Renames some variables to avoid shadowing warnings on gcc.

Also gets rid of a FilereaderState struct, since one is already defined
in the declaration of the AchievementManager class.
 2023-12-12 15:37:20 -05:00
Lioncash ded2d55438 ExpressionParser: Avoid some miscellaneous copies 
Just some trivial copies that can be eliminated or turned into moves.
 2023-12-12 14:03:41 -05:00
Lioncash a5bbeb721a ExpressionParser: Mark constructors explicit where applicable 
Makes for consistency with the surrounding code.
 2023-12-12 14:00:27 -05:00
Lioncash ea71a76ea9 ExpressionParser: Pass control qualifiers by const reference 
These aren't necessarily cheap to copy, since a control qualifier will
have around 3 std::strings inside of it, so passing by value can churn
allocations a little bit.
 2023-12-12 13:50:46 -05:00
Lioncash 9aea481e59 ExpressionParser: Make use of std::erase_if 2023-12-12 13:31:58 -05:00
Lioncash 196f8e5123 MappingCommon: Make use of std::erase_if 2023-12-12 13:31:18 -05:00
Lioncash 888a8692b4 SysConf: Make use of std::erase_if 2023-12-12 13:30:39 -05:00
Lioncash 01d15994fe PatchEngine: Make use of std::erase 2023-12-12 13:30:08 -05:00
Lioncash e69ac2d43e Socket: Make use of std::erase_if 2023-12-12 13:29:33 -05:00
Lioncash 96eac73d11 NetKDRequest: Make use of std::erase 2023-12-12 13:27:54 -05:00
Lioncash e7f7dde546 Formats: Make use of std::erase_if 2023-12-12 13:27:17 -05:00
Lioncash df227aa03c I2CBus: Make use of std::erase_if 2023-12-12 13:26:47 -05:00
Lioncash ff0e7fbf08 GeckoCodeConfig: Make use of std::erase_if 2023-12-12 13:26:16 -05:00
Lioncash 84ae0c1c7e ActionReplay: Make use of std::erase_if 2023-12-12 13:25:26 -05:00
Lioncash 50e4dc5dba Watches: Make use of std::erase_if 2023-12-12 13:24:40 -05:00
Lioncash b728e37086 RiivolutionParser: Remove usages of global system accessor 
We can retrieve the encompassing system instance through the
CPUThreadGuard instance instead.
 2023-12-12 12:48:40 -05:00
Lioncash c2e39e0d68 RiivolutionParser: Make use of std::span where applicable 
The main interface for these only take in patches and iterate over them
in a contiguous sequence, so we can reasonably generify the interface.
 2023-12-12 12:38:43 -05:00
Lioncash 4c7a4831cb CustomAssetLibrary: Remove unused GetAssetSize() function 
There's a direct analogue of this function within
DirectFilesystemAssetLibrary that *is* used, however, so we can get rid
of this one.
 2023-12-11 22:00:52 -05:00
Lioncash e011c3b383 Core/SyncIdentifier: Default operator== 
Lets us remove a bunch of code and a dependency on the <tuple> header.
 2023-12-11 19:39:55 -05:00
Lioncash 4229d76ad6 VertexLoaderTest: Resolve -Wdangling-else warnings 
The ways the assertion macros expand end up generating -Wdangling-else
warnings. Trivial enough to fix by just bracing the if statements.
 2023-12-11 18:45:25 -05:00
Lioncash 0e51c0f8fc JitArm64_RegCache: Resolve -Wsign-compare warning 2023-12-11 18:15:50 -05:00
Lioncash 4c3a5eb1c5 JitArm64_SystemRegisters: Resolve -Wsign-compare warning 2023-12-11 18:11:34 -05:00
Lioncash 017b9a0af7 FloatUtilsTest: Resolve -Wsign-compare warning 2023-12-11 18:08:52 -05:00
Lioncash 4bef3b93b4 AndroidCommon: Resolve -Wsign-compare warning 2023-12-11 18:06:40 -05:00
Lioncash f97316a1e6 TraversalClient: Resolve -Wsign-compare warning 2023-12-11 18:01:29 -05:00