Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
41,201 Commits 1 Branch 0 Tags
c3c39de2128e582121415d3cf232ed4a7c0f306f
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncache c3c39de212 HLE_Misc: Get rid of global system accessors 
Thread guards provide access to the current active system instance.
 2023-12-18 13:33:07 -05:00
Lioncache 69523de5d5 Core/EXI/EXI_DeviceMemoryCard: Remove global system accessor 
We can pass the core timing instance into the Init() call.
 2023-12-18 11:15:51 -05:00
Mai de8bc32dc5 Merge pull request #12362 from CasualPokePlayer/sysconf_widescreen 
Add SYSCONF widescreen setting to dtm header
 2023-12-17 15:19:02 -05:00
Mai 51a44aa5d2 Merge pull request #12431 from JosJuice/jitarm64-rlwnmx-call-rlwinmx 
JitArm64: Call rlwinmx implementation from rlwnmx with imm b
 2023-12-17 15:18:00 -05:00
Mai bcd74a81a9 Merge pull request #12370 from iwubcode/more_samplers 
VideoBackends / VideoCommon: update max pixel shader samplers from 8 to 16
 2023-12-17 14:50:23 -05:00
Mai 559ea0593c Merge pull request #12432 from JosJuice/jitarm64-logic-i2r-opt 
JitArm64: Add additional optimized cases to ANDI2R and friends
 2023-12-17 14:45:55 -05:00
Mai f0f0f97554 Merge pull request #12433 from mitaclaw/windows-arm-debug-fix 
Fix Windows ARM64 debug build errors
 2023-12-17 14:43:55 -05:00
Mai 0125b5182f Merge pull request #12409 from iwubcode/custom_material_graphics_mod_action_data 
VideoCommon: prepare graphics mods for custom shader material data
 2023-12-17 14:42:34 -05:00
Mai b27c15fab6 Merge pull request #12382 from iwubcode/shader_asset_default_value 
VideoCommon: update shader asset to provide a variant default value
 2023-12-17 14:41:55 -05:00
Mai f589c04aa7 Merge pull request #12372 from iwubcode/texture_usage_flag 
VideoBackends / VideoCommon: add type enum to dictate how the texture is used; support texture 2d
 2023-12-17 14:40:39 -05:00
Mai e6c85bf8f0 Merge pull request #12428 from JosJuice/jitarm64-rlwinmx-shift-only 
JitArm64: Add rlwinmx case for only shifting
 2023-12-17 10:45:59 -05:00
Mai 519234949e Merge pull request #12429 from JosJuice/jitarm64-mtsrin-64-bit 
JitArm64: Use 64-bit register for address in mtsrin
 2023-12-17 10:45:36 -05:00
Lioncash 27806d8d7b WiiNetConfig: Eliminate usages of the global system accessor 
We can pass in the existing memory manager instance into the functions
instead of using the global accessor to access it.
 2023-12-14 16:46:52 -05:00
Lioncash 1573b50bb3 HW/CPU: Remove remaining global system accessors 
We can just pass in the m_system member instead.
 2023-12-14 16:14:59 -05:00
Lioncash 5e9763c0fa IOS/MIOS: Eliminate global system accessors 
We can pass the system instance through the EmulationKernel instance.
 2023-12-14 16:05:59 -05:00
Lioncash 88431cfbca WC24PatchEngine: Make GetNetworkPatch() take a std::string_view 
Makes it consistent with GetNetworkPatchByPayload()
 2023-12-14 14:24:49 -05:00
Lioncash fa70a8fd01 WC24PatchEngine: Make a few functions internally linked 
These are only used within this translation unit, so we can remove the
IniFile dependency from the header.
 2023-12-14 14:23:41 -05:00
Lioncash 14abdab314 SysConf: std::move fs pointer in constructor 
Just gets rid of a trivial atomic reference count increment and
decrement. Not a super heavyweight thing, but it is essentially "free"
to get rid of.
 2023-12-14 14:01:17 -05:00
Lioncash a20b4b5669 DolphinQt/Host: Convert inclusion of Fifo.cpp to Fifo.h 
Quite a bizarre include.

Also resolves an indirect include (lol), since this TU was
including the system header that way.
 2023-12-14 05:24:51 -05:00
Lioncash 6bbdf36a7b GameListModel: Remove fallthrough in data() 
A harmless case of it, but this can still cause warnings.
 2023-12-14 04:25:40 -05:00
Lioncash 5450b64951 Externals/expr: Resolve -Wshadow warning 
We already made changes to this library, so we can also resolve the lone
shadowing warning within it.
 2023-12-13 15:29:31 -05:00
Lioncash dbc792a3ec Common/Crypto/SHA1: Resolve -Wignored-attributes warnings 
See commit 417d1310d22b11d5d724625721b5fec09eda099a for an explanation
on why we do this.
 2023-12-13 13:04:53 -05:00
Lioncash bced5fac18 Common/Crypto/AES: Resolve -Wignored-attributes warnings 
The alias for __m128i is typically something like:

typedef long long __m128i __attribute__((__vector_size__(16), __may_alias__));

and the part that ends up not getting preserved is the __may_alias__
attribute specifier.

So, in order to preserve that, we can just use a wrapper struct, so the
data type itself isn't being passed through the template.
 2023-12-13 13:02:51 -05:00
Lioncash dfb2783c25 GBAWidget: Add missing override specifiers 2023-12-13 10:12:18 -05:00
Lioncash 67a06d17b1 GBAWidget: Use std::span with SetVideoBuffer() 
Previously we were always taking the buffer by value, even if it wasn't
being stored anywhere and only read from.

We can use a std::span for the same thing.
 2023-12-13 10:11:52 -05:00
Lioncash e27a4b5d72 Externals/mbedtls: Disable -Wdocumentation related warnings 
It's actually kind of wild that these flags are enabled by default.
They produce an incredible amount of console output spam.

Let's remove them, especially since we've made other changes to this
CMakeLists.txt
 2023-12-12 21:56:27 -05:00
Lioncash ecd7fa4380 DSPInterpreter: Mark IsProperlySignExtended() as [[maybe_unused]] 
This function is used in debug asserts, so in release builds this will
go unused and otherwise generate a warning
 2023-12-12 21:02:15 -05:00
Lioncash e06480a8ab Software/SWGfx: Default destructor in cpp file 
Fixes a build failure with clang 17.

The destructor needs to be in the cpp file, since we have a forward
declared std::unique_ptr type as part of the class. So technically the
default inline destructor could invoke without seeing the full data type
definition.
 2023-12-12 20:33:43 -05:00
Mai ea3033731d Merge pull request #12240 from iwubcode/material_asset_additional_properties 
VideoCommon: add additional data types to material asset
 2023-12-12 18:38:20 -05:00
Mai 022b0a00a2 Merge pull request #12406 from Tilka/xf_assert_msg 
VideoCommon: add message to XF load assert
 2023-12-12 18:36:28 -05:00
Lioncash 91f691296c IOS/Crypto/Sha: Handle ShaCommandUnknown in IOCtlV 
Resolves a -Wswitch warning.
 2023-12-12 17:42:36 -05:00
Lioncash c14b3539c9 CPUThreadConfigCallback: Mark static ID as [[maybe_unused]] 
This isn't used, but is likely kept around so the one-timed execution of
a magic static is taken advantage of.
 2023-12-12 17:30:37 -05:00
Lioncash e883bbc57a ConfigFloatSlider: Resolve -Wshadow warning 
Fairly straightforward variable shadowing.
 2023-12-12 17:07:37 -05:00
Lioncash 79c84c98ed WC24PatchEngine: Resolve -Wshadow warning 
While not captured, we're definitely shadowing the result variable
outside the lambda.
 2023-12-12 17:03:42 -05:00
Lioncash 81d5370141 HLE_OS: Resolve -Wshadow warnings 
We get a warning about shadowing the va_list type and just
run-of-the-mill variable shadowing, which we can easily fix.
 2023-12-12 17:01:32 -05:00
Lioncash a812a1f938 LightingShaderGen: Resolve -Wshadow warnings 
Given how the lambda doesn't capture anything, we can move this to a
internally linked function, which prevents any name shadowing.
 2023-12-12 16:55:06 -05:00
Lioncash 915e43dfba CheatSearchWidget: Make use of CPUThreadGuard parameter in UpdateTableRows 
Previously, the parameter wasn't being used, because it was being
shadowed by another CPUThreadGuard at its only would-be usage point.
 2023-12-12 16:41:00 -05:00
Lioncash b0b1308160 PPCDebugInterface: Silence trivial -Wmaybe-uninitialized warning 
We can just initialize register_index, even if it gets overwritten later
on via Common::FromChars.
 2023-12-12 15:42:28 -05:00
Lioncash 18032f19a5 AchievementManager: Resolve -Wshadow warnings 
Renames some variables to avoid shadowing warnings on gcc.

Also gets rid of a FilereaderState struct, since one is already defined
in the declaration of the AchievementManager class.
 2023-12-12 15:37:20 -05:00
Lioncash ded2d55438 ExpressionParser: Avoid some miscellaneous copies 
Just some trivial copies that can be eliminated or turned into moves.
 2023-12-12 14:03:41 -05:00
Lioncash a5bbeb721a ExpressionParser: Mark constructors explicit where applicable 
Makes for consistency with the surrounding code.
 2023-12-12 14:00:27 -05:00
Lioncash ea71a76ea9 ExpressionParser: Pass control qualifiers by const reference 
These aren't necessarily cheap to copy, since a control qualifier will
have around 3 std::strings inside of it, so passing by value can churn
allocations a little bit.
 2023-12-12 13:50:46 -05:00
Lioncash 9aea481e59 ExpressionParser: Make use of std::erase_if 2023-12-12 13:31:58 -05:00
Lioncash 196f8e5123 MappingCommon: Make use of std::erase_if 2023-12-12 13:31:18 -05:00
Lioncash 888a8692b4 SysConf: Make use of std::erase_if 2023-12-12 13:30:39 -05:00
Lioncash 01d15994fe PatchEngine: Make use of std::erase 2023-12-12 13:30:08 -05:00
Lioncash e69ac2d43e Socket: Make use of std::erase_if 2023-12-12 13:29:33 -05:00
Lioncash 96eac73d11 NetKDRequest: Make use of std::erase 2023-12-12 13:27:54 -05:00
Lioncash e7f7dde546 Formats: Make use of std::erase_if 2023-12-12 13:27:17 -05:00
Lioncash df227aa03c I2CBus: Make use of std::erase_if 2023-12-12 13:26:47 -05:00
Lioncash ff0e7fbf08 GeckoCodeConfig: Make use of std::erase_if 2023-12-12 13:26:16 -05:00
Lioncash 84ae0c1c7e ActionReplay: Make use of std::erase_if 2023-12-12 13:25:26 -05:00
Lioncash 50e4dc5dba Watches: Make use of std::erase_if 2023-12-12 13:24:40 -05:00
Lioncash b728e37086 RiivolutionParser: Remove usages of global system accessor 
We can retrieve the encompassing system instance through the
CPUThreadGuard instance instead.
 2023-12-12 12:48:40 -05:00
Lioncash c2e39e0d68 RiivolutionParser: Make use of std::span where applicable 
The main interface for these only take in patches and iterate over them
in a contiguous sequence, so we can reasonably generify the interface.
 2023-12-12 12:38:43 -05:00
Lioncash 4c7a4831cb CustomAssetLibrary: Remove unused GetAssetSize() function 
There's a direct analogue of this function within
DirectFilesystemAssetLibrary that *is* used, however, so we can get rid
of this one.
 2023-12-11 22:00:52 -05:00
Lioncash e011c3b383 Core/SyncIdentifier: Default operator== 
Lets us remove a bunch of code and a dependency on the <tuple> header.
 2023-12-11 19:39:55 -05:00
Lioncash 4229d76ad6 VertexLoaderTest: Resolve -Wdangling-else warnings 
The ways the assertion macros expand end up generating -Wdangling-else
warnings. Trivial enough to fix by just bracing the if statements.
 2023-12-11 18:45:25 -05:00
Lioncash 0e51c0f8fc JitArm64_RegCache: Resolve -Wsign-compare warning 2023-12-11 18:15:50 -05:00
Lioncash 4c3a5eb1c5 JitArm64_SystemRegisters: Resolve -Wsign-compare warning 2023-12-11 18:11:34 -05:00
Lioncash 017b9a0af7 FloatUtilsTest: Resolve -Wsign-compare warning 2023-12-11 18:08:52 -05:00
Lioncash 4bef3b93b4 AndroidCommon: Resolve -Wsign-compare warning 2023-12-11 18:06:40 -05:00
Lioncash f97316a1e6 TraversalClient: Resolve -Wsign-compare warning 2023-12-11 18:01:29 -05:00
Lioncash 49f44c1334 VertexManagerBase: Resolve -Wsign-compare warning 2023-12-11 18:00:34 -05:00
Lioncash f490b990f5 DolphinQT/Host: Remove unimplemented prototypes 
Remnants of prior existing code.
 2023-12-11 17:30:56 -05:00
Lioncash d705c31d1a DolphinQT/Host: Remove unused TLS variable tls_is_host_thread 
This is never accessed or read from.
 2023-12-11 17:27:57 -05:00
Lioncash e8b4796273 PostProcessing: Mark helper functions as static 
These didn't have any prototypes and were generating
-Wmissing-declaration warnings.
 2023-12-11 17:07:59 -05:00
Lioncash abb5cc3a3a ShaderAsset: Mark ParseShaderProperties() as static 
This had no function prototype, so this can be internally linked.

Resolves a -Wmissing-declaration warning.
 2023-12-11 17:05:06 -05:00
Lioncash b4b624b97b WC24PatchEngine: Mark LoadPatches() as static 
Resolves a -Wmissing-declaration warning, since no prototype existed for
the function.
 2023-12-11 17:02:15 -05:00
Lioncash 2b2ee61e79 CustomShaderCache: Resolve -Wreorder warnings 
Lays out the initializer lists to be in the same order that
initialization would occur in.
 2023-12-11 16:59:03 -05:00
Lioncash 9472da788d ConfigFloatSlider: Resolve -Wreorder warnings 
Orders the initializer list the way that the members would actually be
initialized in.

Resolves some -Wreorder warnings
 2023-12-11 16:15:48 -05:00
Lioncash 5d1514418e GraphicsModListWidget: Add string specifier to By and Description fields 
Translators should always know where text is going to be appended and
have the ability to move things around to fit the language better.
 2023-12-11 15:43:41 -05:00
Lioncash d90537cc18 AchievementManager: Return by reference from GetLock() 
This makes the API a little nicer to use, since you don't need to do
a mandatory dereference when passing the lock into any kind of scope
guard.
 2023-12-11 13:51:50 -05:00
Lioncash 3c7fa0738c AchievementsWindow: Add missing override specifier 2023-12-11 13:47:59 -05:00
Lioncash dbf28df64c DolphinQT: Remove unnecessary includes from achievement files 
Reduces the amount of dependencies being pulled in on both local and
external headers.
 2023-12-11 13:40:55 -05:00
Lioncash e55f9ed102 AchievementManager: Make GetInstance() return a reference 
The internal static member will always have a valid lifetime. Makes this
consistent with other instance based objects in our code.
 2023-12-11 13:36:39 -05:00
Lioncash cdf8849e17 GameFile: Default GameBanner operator== 
Same behavior, but less code.
 2023-12-11 11:36:35 -05:00
Lioncash ff38362216 GameFileCache: Use std::span with Update() 
All we're really doing is iterating over a sequence of strings, so we
don't need to tie this specifically to std::vector.
 2023-12-11 11:12:09 -05:00
Lioncash 2ca80adeb2 GameFileCache: Pass std::function by reference rather than by value 
std::function is internally allowed to allocate, and these functions
aren't being stored anywhere (only called), so we can freely get rid
of some minor overhead here by passing by reference.

This change also creates aliases for the functions, so that there isn't
a lot of visual noise when reading the function signatures.
 2023-12-11 11:09:18 -05:00
Lioncash 88a973131c Common/SettingsHandler: Use std::string_view more 
We don't need to enforce the use of std::string instances with
AddSetting(). We can accept views and only construct one string,
rather than three temporaries.
 2023-12-11 07:54:43 -05:00
Lioncash 04b9f6c28d Common/SettingsHandler: Use std::erase in Decrypt() 
Same behavior, way less verbose code.
 2023-12-11 07:49:43 -05:00
Mai d84ed054ee Merge pull request #12374 from iwubcode/custom_texture_potential_crash_fix 
VideoCommon: prevent a potential custom texture crash
 2023-12-11 07:42:48 -05:00
Mai 6e0bc2a4db Merge pull request #12384 from AdmiralCurtiss/font-load-offset 
HW/CEXIIPL: Fix loading files at nonzero offset in LoadFileToIPL().
 2023-12-10 20:53:22 -05:00
Mai c2b642d0b7 Merge pull request #12381 from AdmiralCurtiss/re-enable-achievement-nag 
AchievementManager: Only nag user about disabled achievements when they were actually enabled before.
 2023-12-10 20:16:24 -05:00
Mai bdd28f1f26 Merge pull request #12378 from JosJuice/jitarm64-a-early-discard 
JitArm64: Add additional condition for lmw/stmw a discard
 2023-12-10 20:15:57 -05:00
Mai db1620db42 Merge pull request #12377 from JosJuice/jitarm64-a-d-discard-guard 
JitArm64: Guard against discarding a in lmw/stmw
 2023-12-10 12:19:41 -05:00
Lioncash f4b1a199e8 VFFUtil: Use std::span with WriteToVFF 
Same behavior, but allows different containers to be used.

In one case it also gets rid of needing to construct a std::vector.
 2023-12-10 10:17:39 -05:00
Mai e2472e4f50 Merge pull request #12352 from JosJuice/jitarm64-flush-in-long-inst 
JitArm64: Flush in the middle of lmw/stmw/mfcr
 2023-12-10 09:15:07 -05:00
Mai f249e414ad Merge pull request #12366 from AdmiralCurtiss/exi-ipl-fixes 
HW/CEXIIPL: Various fixes.
 2023-12-10 09:12:18 -05:00
Mai c23febe947 Merge pull request #12368 from AdmiralCurtiss/enet-submodule 
Externals/enet: Convert to submodule.
 2023-12-10 09:08:10 -05:00
Mai fb0934de71 Merge pull request #11289 from AdmiralCurtiss/mmu-msi-ir 
MMU: Use MSR.IR for Host instruction reads.
 2023-12-10 09:06:05 -05:00
Lioncash 0df7908025 VideoCommon/Present: Remove use of g_presenter inside Presenter class 
There's no need to self reference a global of the class itself when we
can just call the function directly.
 2023-12-09 20:15:32 -05:00
Lioncash 5f6c76af51 VideoCommon: Use std::span for BoundingBox::Write() 
Crosses off a lingering TODO.

Also amends a few nearby cases where a u32 cast was being repromoted to
size_t.
 2023-12-09 16:33:21 -05:00
Mai bec4c77325 Merge pull request #12367 from AdmiralCurtiss/mail-includes 
IOS/KD/Mail: Add missing includes.
 2023-12-09 15:25:24 -05:00
Mai dd227fea5a Merge pull request #12364 from JosJuice/android-emulation-settings-reload 
Android: Fix crash after process recreation
 2023-12-08 21:24:05 -05:00
Mai 636b892b7c Merge pull request #12360 from TryTwo/bugfix_wiimote_signal_spam 
WiimoteDevice. Bugfix. Remove signal spam while starting a game.
 2023-12-08 21:07:51 -05:00
Mai e0f4111561 Merge pull request #11663 from JosJuice/android-config-change-callback 
Android: Use config changed callback for tracking recursive scan setting
 2023-12-07 16:48:02 -05:00
Mai 3a4cf579ff Merge pull request #12247 from LillyJadeKatrin/retroachievements-challenges 
RetroAchievements - Challenge Icons
 2023-12-07 16:46:43 -05:00
Mai 2ece642cf8 Merge pull request #12357 from AdmiralCurtiss/ipl-bounds 
Core/Boot: Check bounds in Load_BS2().
 2023-12-06 19:57:26 -05:00
Mai b4276049fc Merge pull request #12216 from LillyJadeKatrin/retroachievements-rehash 
RetroAchievements - Improved Game Loading
 2023-12-05 18:22:38 -05:00