Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
45,961 Commits 1 Branch 0 Tags
c863abc0d3b5d9f25a9b83bbdebd48bd29197617
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash e52109a356 DSPJitRegCache: Take DynamicReg instances by reference in FlushRegs() 
A DynamicReg instance is 80 bytes in size, so this just gets rid of some
unnecessary copy churn.
 2024-02-28 10:27:35 -05:00
Lioncash 7bf77a56f4 VertexManagerBase: Initialize m_ticks_elapsed on construction 
Ensures that this always has a deterministic value on construction like
everything else in the class.
 2024-02-28 10:21:08 -05:00
Mai 5a81916ee9 Merge pull request #12598 from mitaclaw/case-insensitive 
CodeWidget: Simplify Case-Insensitive Contains
 2024-02-28 08:48:10 -05:00
Mai aae61894f8 Merge pull request #12595 from LillyJadeKatrin/retroachievements-bugfix-2 
Clear active challenges when game closes
 2024-02-27 02:30:34 -05:00
Mai 22d96ef5b5 Merge pull request #12590 from iwubcode/graphics_mod_action_factory_name 
VideoCommon: move factory names to be a static inside each action class
 2024-02-18 17:13:03 -05:00
Mai 27415b0ba1 Merge pull request #12587 from AdmiralCurtiss/localtime 
Core: Fix crash when inspecting a savestate with a timestamp that causes localtime() to error out
 2024-02-18 17:12:29 -05:00
Mai cd9a7db4c1 Merge pull request #12589 from AdmiralCurtiss/ios-fs-logs 
IOS/FS: Display the invalid path in the ASSERT in BuildFilename().
 2024-02-18 17:11:53 -05:00
Mai 21300bb21b Merge pull request #12457 from iwubcode/asset_memory_limit 
VideoCommon: handle asset memory going over reserved limit correctly
 2024-02-16 15:46:52 -05:00
Mai 946aa45abd Merge pull request #12558 from AGuy27/patch-1 
Create Strike Force Bowling INI
 2024-02-16 15:44:33 -05:00
Mai a583526a1c Merge pull request #12575 from n8pjl/werror-nonnull 
IOFile: avoid clearing errors on null file struct
 2024-02-13 07:43:19 -05:00
Mai 9e6d701fbc Merge pull request #12577 from iwubcode/mesh_for_asset_loader 
VideoCommon: make mesh asset data loadable by asset loader
 2024-02-13 07:42:57 -05:00
Mai 3869694944 Merge pull request #12576 from AdmiralCurtiss/ax-accelerator-in-ctor 
Core/DSPHLE: Construct accelerator in AX and AXWii constructors.
 2024-02-12 21:21:42 -05:00
Mai aa66842172 Merge pull request #12574 from sepalani/exi-exit 
EXI: Don't kill Dolphin when receiving BBA_IOB
 2024-02-11 20:32:33 -05:00
Mai c62d1997dc Merge pull request #12562 from iwubcode/mesh_asset 
VideoCommon: add functionality to prepare for a custom mesh asset to be used by graphics mods
 2024-02-11 20:30:25 -05:00
Mai 80d77ac0b4 Merge pull request #12568 from noahpistilli/kd-register-default-id 
IOS/KD: Correctly handle registration of the default user ID
 2024-02-11 13:52:40 -05:00
Mai dd15c012f3 Merge pull request #12573 from JosJuice/android-wii-menu-download-size 
Android: Mention download size in the Wii Menu not installed message
 2024-02-11 13:52:01 -05:00
Mai 9b3fdfb37b Merge pull request #12572 from JosJuice/android-menu-init-guard 
Android: Don't check Wii Menu version before directory initialization
 2024-02-11 13:51:30 -05:00
Mai 30ea51fdd1 Merge pull request #12571 from OatmealDome/mvk-1.2.7 
Externals: Update MoltenVK to 1.2.7
 2024-02-11 13:50:08 -05:00
Mai c61f9d92c7 Merge pull request #12570 from AdmiralCurtiss/system-ios 
Core: Move Emulation IOS instance to System.
 2024-02-08 08:59:01 -05:00
Mai ca81d8b8a6 Merge pull request #12565 from LillyJadeKatrin/retroachievements-bugfix 
Retain Save State Folder
 2024-02-07 14:03:12 -05:00
Mai a50ab40a5f Merge pull request #12566 from JosJuice/arm64-add-imm-sp 
Arm64Emitter: Don't optimize ADD to MOV for SP
 2024-02-06 17:53:17 -05:00
Mai 9240f579ea Merge pull request #12561 from JosJuice/profile-consistency 
InputCommon: Fix profile path inconsistencies
 2024-02-05 09:47:08 -05:00
Lioncash 4f40bdf501 VertexLoaderManager: Use fill() in Init() 
Same behavior, less code.
 2024-02-01 23:04:40 -05:00
Lioncash ea95c82a01 VertexLoaderManager: Remove unused entry struct 
This isn't used anywhere, so it can be removed.
 2024-02-01 23:04:39 -05:00
Lioncash db80abbadd AchievementManager: Tidy up GetRichPresence() 
This can be a direct return.
 2024-02-01 23:03:24 -05:00
Lioncash c14414a151 AchievementManager: clear name in CloseGame()/LogOut() 
A little more idiomatic.
 2024-02-01 23:03:24 -05:00
Lioncash 2d8af7b7f8 AchievementManager: Replace memsets where applicable 
We can just use brace initialization to zero these out. Smaller to
write and a little quicker to read.
 2024-02-01 23:03:24 -05:00
Lioncash 184fe932ed AchievementManager: std::move leaderboard info in FetchBoardInfo() 
Avoids churning some allocations.
 2024-02-01 23:03:24 -05:00
Lioncash 76c381e6f7 AchievementManager: Ensure update callback is always valid 
This way we don't need to do any validity checking aside from the
initial setting of the callback. Also cuts down on line noise.
 2024-02-01 23:03:23 -05:00
Lioncash 2b83cc739a AchievementManager: Convert .compare() into equality operators 
These perform a default comparison, which is the same as using the
equality operators.
 2024-02-01 23:03:23 -05:00
Lioncash 394418b415 AchievementManager: Remove unnecessary .get() 
Same behavior, less code.
 2024-02-01 23:03:23 -05:00
Lioncash 161efff6c9 AchievementManager: Remove long qualifier 
We can remove the long qualifying on some ResponseType instances to
lessen the amount of reading.
 2024-02-01 23:03:23 -05:00
Lioncash 7096f99f79 CustomPipeline: Mark arrays as constexpr 
Ensures that these go into the ro section.
 2024-02-01 23:02:45 -05:00
Lioncash 59211589b9 CustomPipeline: Make use of emplace_back() in GlobalConflicts() 
We can use the string_view arguments to directly construct strings
inside of the global_result vector.
 2024-02-01 23:02:45 -05:00
Lioncash 353ceedb50 CustomPipeline: Resolve unused variable warning 
We can just use holds_alternative here instead.
 2024-02-01 23:02:45 -05:00
Mai 438f5c3412 Merge pull request #12548 from AdmiralCurtiss/dead-automatic-start 
Core/ConfigManager: Remove dead bAutomaticStart flag.
 2024-01-31 17:42:24 -05:00
Lioncash 5ade2e39ef Core/Movie: Remove lingering global system instance accessors 
The movie manager is already passed in a reference to the relevant
system, so we can use that instead.
 2024-01-31 13:30:24 -05:00
Lioncash 16d8b6e6b3 Common/HookableEvent: std::move callback instance in Register() 
Potentially avoids reallocations if the capture buffer of the callback
is quite large.
 2024-01-31 13:16:50 -05:00
Lioncash cac66317aa VideoCommon/Statistics: Remove global system accessor from s_after_frame_event 
Instead, we make the event take a reference to the system and then pass
it in when the event is triggered.

This does introduce two other accessors, but these are much easier to
refactor out over time, and without modification to the existing event
interface.
 2024-01-31 13:12:09 -05:00
Lioncash 0dfefacdf4 VertexLoaderBase: Collapse std namespace for hash and mark noexcept 
Makes the hash specialization a little less noisy. Also we mark it
noexcept, since hashes shouldn't be throwing exceptions (and this can be
optimized on).
 2024-01-31 12:43:00 -05:00
Lioncash 8e4b2565cd TextureConfig: Collapse std namespace for hash 
Lets us collapse the namespacing and make the specialization a little
less noisy.
 2024-01-31 12:41:33 -05:00
Lioncash b63dcd504d RenderState: Collapse std namespace for hash 
We can specify the namespace on the hash to make the specialization a
little less noisy.
 2024-01-31 12:40:10 -05:00
Lioncash 5bfaa3a966 NativeVertexFormat: Collapse std namespace and mark hash noexcept 
We can just tag the std:: onto the end of the specialization to make it
less noisy.

Also mark it as noexcept, since hashes shouldn't throw exceptions.
 2024-01-31 12:37:44 -05:00
Lioncash 40b050fe37 GraphicsModGroup: std::move graphics_mod in Load() 
The config object is quite heavyweight, so we should move this instead
of copying.
 2024-01-31 12:27:43 -05:00
Lioncash ccacda5e2c GraphicsModGroup: Simplify try_add_mod() 
We can use contains() here, and also move the mod config if it's valid
instead of copying it, since it contains quite a bit of allocated data.
 2024-01-31 12:23:21 -05:00
Lioncash 81aca79145 GraphicsModListWidget: Pass optional by const reference 
All we do is read from it, so we don't need to copy the string if we
happen to have one.
 2024-01-31 12:09:35 -05:00
Lioncash a1879ea099 GraphicsModGroup: Allow heterogenous lookup for GetMod() 
Allows using keys that aren't directly std::string as the key. This lets
us use std::string_view for the incoming path name, making it more
flexible with other string types.
 2024-01-31 12:05:17 -05:00
Mai 30fdf25f8f Merge pull request #12542 from AdmiralCurtiss/system-sconfig 
Migrate m_is_mios and bWii from SConfig to System.
 2024-01-31 09:57:17 -05:00
Mai e0828815e7 Merge pull request #12540 from mitaclaw/encode-reg-to-64 
Add Missing EncodeRegTo64 in JitArm64::dcbx
 2024-01-30 13:08:03 -05:00
Mai a553308775 Merge pull request #12443 from iwubcode/custom_pipeline_action_material_cubemap 
VideoCommon: update custom pipeline action to support a variety of texture samplers, support for materials, and more!
 2024-01-26 12:39:37 -05:00
Lioncash 7a59ecc39d GraphicsTarget: Reduce object churn a little 2024-01-24 23:00:01 -05:00
Lioncash 1b7da37114 GraphicsTargetGroup: Reduce object churn a little 2024-01-24 22:52:58 -05:00
Lioncash 24f952c12b GraphicsModFeature: Reduce object churn a little 2024-01-24 22:48:53 -05:00
Lioncash 0385b40bd8 GraphicsModAsset: Reduce object churn a little 2024-01-24 22:47:22 -05:00
Lioncash 2253d9a95d GraphicsModGroup: Mark move constructor and assignment as noexcept 
Allows containers to optimize off of std::move_if_noexcept
 2024-01-24 22:41:30 -05:00
Lioncash 0327b11e0b GraphicsModGroup: Reduce object churn 
We can emplace and move to avoid doing object copies.
 2024-01-24 22:40:05 -05:00
Lioncash e3e20df185 GraphicsMod: Avoid some object churn 
We have quite a bit of allocation churn going on here, so we can emplace
and move where appropriate to alleviate that a little.
 2024-01-24 22:34:50 -05:00
Lioncash 7b6463ef1f ShaderAsset: Emplace value instances when possible in ToJson() 
Constructs elements directly inside the container and also makes it
shorter to read in certain instances.
 2024-01-24 18:47:44 -05:00
Mai 97160ddc83 Merge pull request #12531 from LillyJadeKatrin/retroachievements-bugfix 
Add host URL setting to achievements config
 2024-01-24 16:17:17 -05:00
Lioncash a65aaccd59 DolphinQt/MenuBar: Hide assembler option if debug UI is disabled 
Fixes a little visual inconsistency in the UI, where the assembler would
always be shown, but all other debug-related utilities would be hidden.
 2024-01-23 18:57:23 -05:00
Lioncash 100242a380 GekkoSyntaxHighlight: Collapse cases for builtin color formats 
Same behavior, but without as much duplication.
 2024-01-23 18:39:59 -05:00
Lioncash e4fa5614d1 GekkoSyntaxHighlight: Fix FPR terminal highlighting being treated as GPRs 
Copy-paste error. Ultimately GPR and FPRs use the same highlighting
style anyway, so this is mostly just a correctness change.
 2024-01-23 18:38:06 -05:00
Lioncash 6cb3389696 CodeTrace: Use std::set::lower_bound() over std::lower_bound() 
std::set's lower_bound() is optimized better than the generic
implementation of std::lower_bound()

std::lower_bound() works best on random access iterators, where the
number of comparisons can be logarithmic. However, since std::set's
iterators are bidirectional iterators, the comparisons will actually be
linear in practice when using std::lower_bound().

So, we can use std::set's version which is guaranteed to be logarithmic.
 2024-01-23 17:21:22 -05:00
Lioncash 258161bab7 DolphinAnalytics: Use #ifdef instead of #if for platform testing 2024-01-23 16:51:31 -05:00
Lioncash 4ccc5178a6 PowerPC: Use #ifdef instead of #if for platform testing 
This way we don't assume these symbols are always defined.
 2024-01-23 16:47:43 -05:00
Lioncash f695ae5730 JitInterface: Use #ifdef instead of #if for platform testing 
\#if assumes the symbols will always be defined, but they aren't
depending on the platform.
 2024-01-23 16:42:36 -05:00
Lioncash a9f89a7d3b WiimoteEmu: check for __APPLE__ with defined() 
This is only defined on certain platforms and isn't always defined.
 2024-01-23 16:40:21 -05:00
Lioncash 3c64d030c5 FreeLookManager: check for __APPLE__ with defined() 
Previously this was treating the identifier as if it were always defined
by default
 2024-01-23 16:40:10 -05:00
Lioncash b06e1880b6 Jit64AsmCommon: Remove redundant m_jit member from CommonAsmRoutines 
We pass a JIT instance all the way down to EmuCodeBlock, which is
accessible under protected as well, so this isn't really necessary.
 2024-01-23 16:27:02 -05:00
Lioncash adb79d4e32 WiimoteReal: Explicitly break instead of fallthrough in IsBalanceBoard() 
Same behavior, no compiler warnings.
 2024-01-23 16:22:10 -05:00
Lioncash 28e93827db EXI_DeviceAGP: Annotate fallthrough with [[fallthrough]] 
Same behavior, but eleminates compiler warnings.
 2024-01-23 16:19:23 -05:00
Lioncash 7ef0262f8a PPCAnalyst: Merge duplicate expression in ReorderInstructionsCore() 
The type checking is duplicated here, which makes this seem a little
weird, so we can get rid of it.
 2024-01-23 16:08:24 -05:00
Lioncash 6a86b35e88 State: Make use of re-entrant variant of localtime 
Makes this member function thread-safe. We can also unify the string
handling to make it easier to maintain.
 2024-01-23 15:28:30 -05:00
Lioncash 1b3f61041a Movie: Remove global system accessor from GetRTCDisplay() 
We can just use m_system instance reference instead.
 2024-01-23 15:15:13 -05:00
Lioncash 763562357b Movie: Mark getters as const 
These don't modify internal member state.
 2024-01-23 15:15:13 -05:00
Lioncash c0b0023b64 Movie: Use re-entrant variant of gmtime in GetRTCDisplay() 
Makes this member function thread-safe.
 2024-01-23 15:15:10 -05:00
Lioncash f03da37693 NetKDTime: Use re-entrant variants of gmtime 
Makes these implementations more thread-safe by design. These likely
won't be run on any other thread, but we may as well just use the
re-entrant variant if it's available.
 2024-01-23 14:30:44 -05:00
Mai 0b1087e9c9 Merge pull request #12520 from iwubcode/material_serialize_to_json 
VideoCommon: add function to serialize MaterialAsset to json
 2024-01-23 14:18:25 -05:00
Lioncash 5aeadb1ef8 PostProcessing: Don't potentially leak memory in BlitFromTexture() 
All release() does is relinquish the pointer, rather than free the
memory associated with it.
 2024-01-23 13:34:40 -05:00
Lioncash a3f9f2c7aa PostProcessing: Remove unnecessary get() calls in BlitFromTexture() 
We can just use operator-> instead.
 2024-01-23 13:34:16 -05:00
Mai e12933f8dd Merge pull request #12515 from iwubcode/shader_asset_helper_functions 
VideoCommon: add some helper functions for shader asset
 2024-01-23 13:21:00 -05:00
Lioncash 49eadbb824 AchievementSettings: Move pragma once out of ifdef 
Makes the header a little more consistent with others (and also we
should still have a header guard be present at all times).
 2024-01-23 11:56:50 -05:00
Lioncash 9f82efa3e2 Jit64/JitRegCache: Simplify GetAllocationOrder() 
Given we have fixed allocation orders, we can just directly return a
span instead of a pointer and a size via an out parameter.

Makes it a little more convenient, since we get both pieces of info at
once, and also have the ability to iterate directly off the span out of
the box.
 2024-01-23 11:03:59 -05:00
Mai 713572e874 Merge pull request #12510 from JosJuice/android-revert-attach-early 
Revert "Android: Attach CPU thread to JVM early"
 2024-01-21 10:23:15 -05:00
Mai d64705d691 Merge pull request #12512 from JosJuice/assembler-dirty-flag 
DolphinQt: Rework dirty flag handling in AssemblerWidget::TabTextForEditor
 2024-01-21 10:22:46 -05:00
Mai 6aacbc4c35 Merge pull request #12488 from JosJuice/jitarm64-psq-stxx-w0 
JitArm64: Remove unnecessary locking of W0 in psq_stXX
 2024-01-15 15:14:59 -05:00
Mai 5534f510e0 Merge pull request #12498 from AdmiralCurtiss/globals-socket 
Core/IOS/Network/Socket: Avoid global system accessor.
 2024-01-15 15:13:41 -05:00
Mai e3d39fcc0d Merge pull request #12502 from AdmiralCurtiss/globals-movie 
Core/Movie: Refactor to class, move to System.
 2024-01-15 15:12:00 -05:00
Mai c76dee7807 Merge pull request #12285 from iwubcode/serialize_graphics_mods 
VideoCommon: add ability to serialize graphics mod to json object
 2024-01-13 14:15:14 -05:00
Mai 8760aca8ec Merge pull request #12500 from AdmiralCurtiss/globals-fiforecorder 
FifoRecorder: Move instance to System.
 2024-01-13 06:38:39 -05:00
Mai d36baf633c Merge pull request #12499 from AdmiralCurtiss/globals-mmiorw 
Core/HW/MMIO: Pass System through Read() and Write().
 2024-01-13 06:37:49 -05:00
Mai 35a326a1e1 Merge pull request #12497 from AdmiralCurtiss/globals-fifoplayer 
Core/FifoPlayer: Avoid global System accessor.
 2024-01-13 06:36:46 -05:00
Mai 6725c25600 Merge pull request #12494 from AdmiralCurtiss/globals-wiiipc 
Core/IOS/WiiIPC: Refactor to class, move to System.
 2024-01-12 02:08:00 -05:00
Mai ab3655fbea Merge pull request #12496 from AdmiralCurtiss/globals-gba 
Core/HW/GBACore: Avoid global System accessor.
 2024-01-12 02:05:57 -05:00
Lioncash 409d2ecad3 SI_Device: Remove global system accessors 
We can pass the system timer instance through to avoid needing the
global accessor.
 2024-01-08 11:03:26 -05:00
Lioncash 7398d0b6ef SI_DeviceGBAEmu: Remove global system accessors 
We can pass the system timer instance in from the existing system
instance instead of the global accessor.
 2024-01-08 10:56:41 -05:00
Lioncash c2adc3ffed Externals: Update fmt to 10.2.1 
Keeps the tracked external up to date.
 2024-01-08 10:45:07 -05:00
Mai 63453bda4d Merge pull request #12485 from AdmiralCurtiss/globals-dsp 
Core/DSPHLE: Clean up global System access.
 2024-01-08 04:48:30 -05:00
Mai 00fb709c74 Merge pull request #12487 from AdmiralCurtiss/globals-axaccel 
Core/DSPHLE: Deglobalize HLEAccelerator state in AX and AXWii UCodes.
 2024-01-08 04:17:30 -05:00
Mai 180d053ec1 Merge pull request #12486 from AdmiralCurtiss/globals-aesndaccel 
Core/DSPHLE: Move AESndAccelerator instance into AESndUCode.
 2024-01-07 20:36:01 -05:00