Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
25,480 Commits 1 Branch 0 Tags
cbe43e58a777cb84e46cd719afa86d1fa91d0e74
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash 745f92b4e5 TransformUnit: Get rid of pointer casting in TransformColor() where applicable 
The casts to u32* are technically undefined behavior. The u8* cast is
left, as char/unsigned char is exempted from this rule to allow for
bvtewise inspection of objects (and this is what s8/u8 are typedefs of
on platforms we support).
 2017-08-06 19:04:31 -04:00
Lioncash 4d35a3105e TransformUnit: Make LightColor()'s chan parameter const 
Also marks references/pointers const where applicable
 2017-08-06 18:15:05 -04:00
Lioncash 2363be4c63 ElidedButton: Make constructor explicit 
Prevents implicit conversions to ElidedButton.
 2017-08-06 17:31:29 -04:00
Lioncash 5153271278 ElidedButton: Add missing override specifier on paintEvent() 2017-08-06 17:26:07 -04:00
Lioncash f0308151a8 File: Make GetSize() a const member function 2017-08-06 07:57:43 -04:00
Lioncash 01c262fe47 Filesystem: Declare FileInfo iterator's move constructor and assignment operator noexcept 
Prevents potential extra copies being created in the context of
std::move_if_noexcept.
 2017-08-05 12:29:02 -04:00
Lioncash f6c21e002b General: Remove unnecessary semicolons 2017-07-30 16:39:53 -04:00
Lioncash b3c1bff34b SysConf: Add explicit to single-argument constructor 
Prevents implicit construction from FromWhichRoot values.
 2017-07-30 15:35:16 -04:00
Lioncash fb42c3eddc DolphinQt2: Add missing include guards 2017-07-26 16:31:58 -04:00
Lioncash 80b938b403 DolphinQt2: Remove unimplemented prototypes 
Also removes an unnecessary includes in related files
 2017-07-26 16:26:55 -04:00
Mat M 63f1f122fa Merge pull request #5729 from ligfx/qtremoveoldsyntax 
DolphinQt2: update old SLOT/SIGNAL syntax
 2017-07-24 18:48:20 -05:00
Lioncash 7373474888 ListProxyModel: Add missing include guard 2017-07-24 19:46:25 -04:00
Lioncash 5859914da5 TraversalClient: Fix memory leaks in ReleaseTraversalClient() 
release() relinquishes ownership of a pointer, it doesn't actually free
it.
 2017-07-22 18:19:25 -04:00
Mat M 898bbffaa7 Merge pull request #5724 from JonnyH/WIP/fix-some-ODR-warnings 
Fix some GCC ODR warnings
 2017-06-29 18:48:47 -04:00
Mat M 4320c641f7 Merge pull request #5675 from Tilka/warning 
Fix two warnings
 2017-06-23 20:46:32 -04:00
Lioncash 82c66e2bab FifoRecorder: Don't allocate ~100.7MB on program startup 
So, a FifoRecorder instance is instantiated as a file-local variable and
used as a singleton (ugh). Most users likely don't regularly use the
FIFO player/FIFO recorder, so this is kind of a substantial waste of
memory.

FifoRecorder's internal RAM and ExRAM vectors are 33554432 and 67108864
bytes respectively, which is around 100.66MB in total.

Just on the game list view on a clean build with nothing loaded, this
knocks debug build memory usage down from ~232.4MB to ~137.5MB, and
release build memory usage down from ~101MB to ~5.7MB.
 2017-06-19 02:47:26 -04:00
Lioncash 59a947d41d AbstractTexture: Return config by const reference 
Returning by const value isn't really necessary (and usually an indicator const reference was intended).
 2017-06-18 23:38:42 -04:00
Lioncash 07cddf6f7f AbstractTexture: Add missing includes (and remove unnecessary ones) 2017-06-18 23:29:22 -04:00
Mat M 4c2b078017 Merge pull request #5644 from lioncash/vsfilter 
VideoCommon: Fix VS filter for AbstractTexture.cpp
 2017-06-18 23:15:43 -04:00
Lioncash 0c57543205 VideoCommon: Fix VS filter for AbstractTexture.cpp 
This would cause failures when building with VS.
 2017-06-18 22:58:02 -04:00
Lioncash 251de89b5c HttpRequest: Use std::chrono for indicating time periods 
Allows the use of chrono time points, on top of being more indicative of
time periods used at call sites, if custom timeouts are specified.
 2017-06-18 15:48:37 -04:00
Mat M 220ce425cd Merge pull request #5580 from lioncash/header 
Core: Remove unnecessary header inclusions
 2017-06-15 19:08:56 -04:00
Lioncash dd4203bec8 Core: Remove unnecessary includes 
Also moves a cpp file's related header file to the top of the inclusions if it isn't already there.
 2017-06-15 18:52:22 -04:00
Lioncash b003108b8b Core: Add WiimoteCommon headers to the VS project 2017-06-15 18:38:21 -04:00
Lioncash a093b58aad Core: Move SignatureDB and Config source files into filters 
Keeps things organized instead of being in the root of Core's source
tree when using the filter view.
 2017-06-07 21:57:49 -04:00
Lioncash d9bb2ce3af DVDInterface: Amend lint formatting issues 2017-06-07 01:20:54 -04:00
Lioncash b676edd80c Core: include what you use 
Eliminates a swath of indirectly included standard headers
 2017-06-07 01:20:48 -04:00
Lioncash b0427731b3 ElfReader: default the destructor 2017-06-06 23:03:59 -04:00
Lioncash 1af1795695 ElfReader: Make constructors explicit 2017-06-06 23:03:59 -04:00
Lioncash 1876505707 DolReader: Make constructors explicit 2017-06-06 23:03:59 -04:00
Lioncash 927a4a16f8 Boot: Make BootExecutableReader constructors explicit 2017-06-06 22:54:25 -04:00
Lioncash acac2aeb9b Movie: Use std::put_time in GetRTCDisplay() 
No need for a fixed buffer.
 2017-06-06 20:56:04 -04:00
Lioncash e5260dee6b ec_wii: Add missing <string> header 2017-06-06 20:37:43 -04:00
Lioncash 1ffc311bf3 Core: Fix vcxproj filter 
This would cause the core project to fail to load.
 2017-06-06 20:29:03 -04:00
Mat M 0e6bd74ed6 Merge pull request #5525 from lioncash/overload 
Device: Provide operator!= counterparts to operator== for DeviceQualifier
 2017-06-03 19:41:53 -04:00
Lioncash 5862d1fc41 Device: Provide operator!= counterparts to operator== for DeviceQualifier 
Makes comparison logic symmetric
 2017-06-03 19:34:35 -04:00
Lioncash d6b6b070bc D3D/Render: Get rid of undefined behavior in Create3DVisionTexture 
pSysMem is of the type const void* -- because of this, it makes the
original delete[] call undefined behavior, as deleting a void pointer is
undefined behavior.

Also punning types into existence, like what was done for the stereo
image header is undefined behavior as well. The proper way to do this is
to either manually add all individual bytes manually, or memcpy the
struct into memory.

As we want to deallocate the memory before returning, and because
pSysMem is a const void*, we keep a unique_ptr to the data and just pass
pSysMem a raw pointer to the data.
 2017-05-28 23:28:00 -04:00
Lioncash 278e406f0b D3D/Render: Use std::array where applicable 2017-05-28 23:28:00 -04:00
Lioncash 0c3958bbe5 D3D/Render: Join variable with declaration 2017-05-28 23:27:59 -04:00
Lioncash 3ee447e5f7 D3D/Render: Get rid of unnecessary casts 2017-05-28 23:27:59 -04:00
Lioncash ba5b215c42 D3D/Render: Mark translation unit local variables as static 2017-05-28 23:27:59 -04:00
Mat M 9fa1e8f45f Merge pull request #5493 from lioncash/include 
CubebStream: Add missing <vector> include
 2017-05-28 02:08:35 -04:00
Lioncash 3e7af2a2cd CubebStream: Add missing <vector> include 2017-05-27 23:50:39 -04:00
Mat M 905232fd2b Merge pull request #5313 from ligfx/addcubeb 
Add CubebStream output backend and replace PortAudio for microphones
 2017-05-27 21:39:03 -04:00
Mat M 7192226971 Merge pull request #5474 from sepalani/bl-fix 
CodeView: Fix missing bl details
 2017-05-27 17:40:18 -04:00
Mat M 7b70fce79b Merge pull request #5476 from ligfx/ffmpegbuildcleanup 
CMake/MSVC: cleanups around FFMpeg
 2017-05-27 17:36:55 -04:00
Mat M b7cc4d73dc Merge pull request #5469 from ligfx/cmakecleanupunittests 
CMake: various cleanups for UnitTests
 2017-05-23 02:08:58 -04:00
Mat M 3f437337a1 Merge pull request #5466 from lioncash/db 
SignatureDB: Minor cleanup
 2017-05-22 21:25:36 -04:00
Mat M 4bfd464b0c Merge pull request #5468 from leoetlino/headers 
Fix some header includes
 2017-05-22 21:22:04 -04:00
Lioncash 73b72c6a62 TitleDatabase: Remove unused <iostream> header 
Many implementations of <iostream> inject a static constructor into the
translation unit, it's included in, even if nothing from the header is used.
 2017-05-21 17:51:47 -04:00
Lioncash c3bab0b0e7 SignatureDB: Remove unnecessary header 2017-05-21 17:39:44 -04:00
Lioncash bbe1e643fb SignatureDB: in-class initialize DBFunc members 2017-05-21 17:39:42 -04:00
Lioncash d0089191e1 SignatureDB: default the format handler destructor 2017-05-21 17:39:41 -04:00
Lioncash 5301efddd0 SignatureDB: Remove unnecessary qualifiers and virtual keywords 2017-05-21 17:39:40 -04:00
Lioncash 3c94962332 SignatureDB: Move two functions into the cpp file 
These are implementation details.
 2017-05-21 17:39:34 -04:00
Mat M b47d44ab15 Merge pull request #5445 from JosJuice/remove-jitil 
Remove JITIL
 2017-05-19 21:33:38 -04:00
Mat M 1880a97bb0 Merge pull request #4424 from Helios747/remove_more_features 
Remove D3D12
 2017-05-18 20:04:40 -04:00
Lioncash 35aa55931f MainAndroid: Resolve -Wmissing-variable-declarations warnings 2017-05-18 19:55:05 -04:00
Mat M 35a8771e68 Merge pull request #5427 from lioncash/host 
Host: Get rid of Host_SetStartupDebuggingParameters()
 2017-05-18 19:04:25 -04:00
Lioncash 7baabe99d1 Host: Get rid of Host_SetStartupDebuggingParameters() 
This is something that should be the responsibility of the frontend
booting the game. Making this part of the host 'interface' inherently
requires frontends to leak internal details (much like the other
UI-related functions in the interface).

This also decouples more behavior from the debugger and the
initialization process in the wx frontend. This also eliminates several
usages of the parent menubar in the debugger code window.
 2017-05-14 19:12:59 -04:00
Lioncash 198d686a41 MEGASignatureDB: Add missing override specifiers 2017-05-14 16:20:45 -04:00
Mat M 7a25dde8df Merge pull request #5387 from leoetlino/constexpr 
Contributing: Use constexpr for compile-time constants
 2017-05-07 17:56:37 -04:00
Mat M ef4a1f0ec7 Merge pull request #5384 from leoetlino/disable 
WX: Disable NAND import when emulation is running
 2017-05-06 19:38:07 -04:00
Mat M 4ba786a164 Merge pull request #5381 from JosJuice/cached-title-id 
DolphinWX: Use title ID from ISOFile when possible
 2017-05-06 19:37:25 -04:00
Mat M f3052b7a15 Merge pull request #5318 from ligfx/cmakehidapi 
CMake: clean up HIDAPI build
 2017-05-03 19:54:06 -04:00
Mat M d48c3ce63e Merge pull request #5361 from ligfx/signaturedbwarning 
SignatureDB: fix prevented copy elision
 2017-05-02 23:09:49 -04:00
Mat M 7c3905a612 Merge pull request #5140 from sepalani/signature_db 
SignatureDB: Rewrite FormatHandler API
 2017-05-02 19:23:46 -04:00
Mat M c51e40f92f Merge pull request #5357 from ligfx/jitintegerwarning 
Jit64: fix braces warning in Jit_Integer
 2017-05-02 18:44:02 -04:00
Mat M d66e0e38d3 Merge pull request #5359 from ligfx/nandimporterwarning 
NANDImporter: fix printf warning
 2017-05-02 18:43:28 -04:00
Lioncash 9e71031e23 Frame: Normalize member names 2017-05-01 05:13:19 -04:00
Mat M 1bad3bef4b Merge pull request #5344 from lioncash/table 
MemoryWindow: Minor cleanup
 2017-04-30 18:32:29 -04:00
Mat M 344767a258 Merge pull request #5336 from JosJuice/memcard-shiftjis 
Fix display of Japanese text in the Memory Card Manager
 2017-04-30 18:22:47 -04:00
Mat M d5534e069c Merge pull request #5334 from spycrab/wx_gamelist_cleanup 
Refactor GameListCtrl
 2017-04-30 18:21:50 -04:00
Mat M eb8dbe03ad Merge pull request #5349 from JosJuice/more-incorrect-trans 
Remove incorrect usage of _trans
 2017-04-30 18:20:19 -04:00
Mat M 4f2ecf03b3 Merge pull request #5348 from JosJuice/host-code-ip-address 
Mark "Host Code:" and "IP Address:" as translatable
 2017-04-30 18:19:21 -04:00
Lioncash 683462679b MemoryWindow: Remove unused member variable 2017-04-30 06:35:59 -04:00
Lioncash 9a778786df MemoryWindow: Convert event table over to bound events 
Event tables are the old method of performing event binding.
 2017-04-30 06:35:41 -04:00
Lioncash aad9fd6751 MemoryWindow: Localize sizer creation code 
Keeps specific UI element initialization separate from one another.
 2017-04-30 06:20:26 -04:00
Lioncash 402faf3758 MemoryWindow: Make constructor explicit 2017-04-30 03:22:36 -04:00
Lioncash 7941a05a80 MemoryWindow: Add missing translation markers for UI strings 2017-04-30 03:22:35 -04:00
Lioncash 4c70f05fe0 MemoryWindow: Get rid of unnecessary std::string constructions 
std::string's operator+ will handle this. Also move std::string to where
they're actually needed. There's no need to construct an unnecessary
string if the first failure case occurs.
 2017-04-30 03:22:34 -04:00
Lioncash 7cf78a00eb MemoryWindow: Normalize variable naming 2017-04-30 03:22:25 -04:00
Mat M 255fd14db6 Merge pull request #5316 from ligfx/cmakewxwidgets 
Various CMake cleanups for DolphinWX
 2017-04-25 21:21:54 -04:00
Mat M 9090f37347 Merge pull request #5299 from FRtranslator/Tools_menu_reorder 
Reorder the Tools menu, with more separators
 2017-04-22 17:41:01 -04:00
Mat M 4c711de309 Merge pull request #5301 from JosJuice/delete-wxinputbase 
Delete WXInputBase
 2017-04-22 17:37:38 -04:00
Mat M 4517231a1a Merge pull request #5287 from sepalani/rso 
Generate Symbols From RSO Modules added
 2017-04-20 20:06:03 -04:00
Lioncash a58d5fa8ee MMU: Get rid of pointer casts 
These sort of casts invoke undefined behavior (u8, u16, u32, and u64 all have
completely different alignment requirements).
 2017-04-17 20:52:57 -04:00
Lioncash 9cfc671c69 MMU: Get rid of unnecessary temporaries in HostRead_[8|16|32] functions 2017-04-17 19:13:47 -04:00
Mat M e53969b6f2 Merge pull request #5278 from spycrab/issue_10213 
Lazily initialize m_main_config_dialog to fix analytics issue (Issue #10213)
 2017-04-16 07:12:29 -04:00
Mat M d22509984c Merge pull request #5252 from JosJuice/pitch-text 
Update text about pitch depending on emulation speed
 2017-04-16 05:48:57 -04:00
Lioncash 8811937756 JitArm64_RegCache: Use std::array where applicable 
There's no need to use std::vector for fixed enum values.
 2017-04-12 22:34:34 -04:00
Mat M 733df23e98 Merge pull request #5251 from JosJuice/audio-backend-tooltip 
Remove audio backend tooltip
 2017-04-12 17:10:13 -04:00
Mat M 21544f8661 Merge pull request #5228 from JosJuice/why-did-this-exist 
Get rid of some nonsense related to booting DOL/ELF files
 2017-04-12 08:07:54 -04:00
Mat M 8ecc5e9b7a Merge pull request #5246 from MerryMage/math-util 
Jit64AsmCommon: Make frsqrte and fres PIE-compliant
 2017-04-11 16:11:19 -04:00
Mat M ae80a7541d Merge pull request #5239 from sepalani/is-valid-instruction 
PPCTables: Do not consider OPTYPE_UNKNOWN as valid instruction
 2017-04-10 16:50:22 -04:00
Lioncash c7ab6861c2 RenderBase: Return a tuple from ConvertStereoRectangle instead of using out parameters 2017-04-09 15:11:59 -04:00
Lioncash 671b5f9747 RenderBase: Return a tuple from CalculateTargetScale instead of using out parameters 2017-04-09 14:41:51 -04:00
Mat M 188f2b3cc5 Merge pull request #5231 from JosJuice/vertex-rounding-condition 
Simplify condition for enabling/disabling vertex rounding checkbox
 2017-04-09 05:35:53 -04:00
Lioncash cc803db042 RenderBase: Eliminate renderer global accesses within the Renderer class 
There's no need to access these globals, the instance itself has access
to these data members and functions.
 2017-04-08 20:15:39 -04:00
Lioncash caf25653d8 RenderBase: const correctness 2017-04-08 20:11:29 -04:00