Commit Graph
100 Commits
Author SHA1 Message Date
JosJuice 8c3e33a9ac Merge pull request #4573 from Techjar/Techjar-patch-1
Should fix being unable to change memory card slot A
2016-12-27 10:29:38 +01:00
JosJuice 0f1ce0e1f4 Remove incorrect usage of "ASCII" and "ANSI"
Windows-1252 was sometimes being referred to as ASCII or ANSI
in Dolphin, which is incorrect. ASCII is only a subset of
Windows-1252, and ANSI is (rather improperly) used in Windows
to refer to the current code page (which often is 1252 on
Western systems, but can also be something entirely different).

The commit also replaces "SJIS" with "Shift JIS". "SJIS"
isn't misleading, but "Shift JIS" is more commonly used.
2016-12-26 15:49:39 +01:00
JosJuice 8e4a781974 VolumeDirectory: Modernize variable names 2016-12-26 11:45:22 +01:00
JosJuice 00aa2d37e9 VolumeDirectory: Don't use references inappropriately
Integers should be passed as pointers when a function
modifies them (to make it clear that they get modified).
2016-12-26 09:52:18 +01:00
JosJuice 3196f697bb VolumeDirectory: Use a range-based for loop in ComputeNameSize 2016-12-25 23:01:42 +01:00
JosJuice f3987d13ea VolumeDirectory: Make m_totalNameSize a local variable
After BuildFST finishes executing, it's never needed again.
2016-12-25 22:57:14 +01:00
JosJuice a502f069e8 VolumeDirectory: Sort the FST
We can't rely on the OS returning files and directories
in a deterministic order, so we should sort them on our own
if we want VolumeDirectory to work for movies and netplay.
2016-12-25 22:35:38 +01:00
JosJuice e56bec9c87 Fix outdated comments in ScanDirectoryTree 2016-12-25 21:57:33 +01:00
JosJuice 70d9440d10 Fix player name not being loaded when using "Host with Netplay..." 2016-12-25 16:36:19 +01:00
JosJuice 3e4f682b76 Game INI updates
- F.ini: PR #4189 removes the need for 1x IR according to JMC
- GWO.ini: Just force integral resolution, not auto resolution
- GALP01.ini: I have no idea why EFBScale would be forced here
- GINX69.ini: I think JMC said it's fixed, but I can't find his post...
- SNS.ini: https://bugs.dolphin-emu.org/issues/9891
- P INIs: https://bugs.dolphin-emu.org/issues/9938
2016-12-25 09:36:49 +01:00
JosJuice c0710d3593 Mark strings added by PR #4461 for translation
Also fix the HKGP_FRANE_ADVANCE typo.
2016-12-24 19:26:21 +01:00
JosJuice 55fe77e986 Movie: Replace incorrect name and comment for numControllers
Also add similar comments to the variables memcards and bongos.
2016-12-24 18:27:56 +01:00
JosJuice 09c6148aba Automatic translation resources sync with Transifex 2016-12-24 16:05:08 +01:00
JosJuice 222b52e511 Merge pull request #4547 from lioncash/proto
CommandProcessor: Remove unimplemented prototypes
2016-12-24 08:51:55 +01:00
JosJuice 14b77ec3f4 Merge pull request #4530 from lioncash/header
SignatureDB: Add missing license headers
2016-12-19 22:11:02 +01:00
JosJuice 9bd514ed1c Add TGC disc image compatibility 2016-12-18 18:57:36 +01:00
JosJuice d64f56fb01 Automatic translation resources sync with Transifex 2016-12-17 15:59:16 +01:00
JosJuice 07dd6d08e4 Automatic translation resources sync with Transifex 2016-12-10 13:09:28 +01:00
JosJuice 4baa368f8b Automatic translation resources sync with Transifex 2016-12-01 08:37:36 +01:00
JosJuice 2ceea61bbf Merge pull request #4477 from kirbyUK/master
Create G2RE52.ini (Shrek SuperSlam)
2016-11-30 20:46:31 +01:00
JosJuice 3cfc49a613 Merge pull request #4472 from JosJuice/revert-absolute-path
IOS HLE: Replace broken path traversal prevention
2016-11-29 18:34:22 +01:00
JosJuice 0c6fd47460 Add unit test for StringUtil's newly added JoinStrings 2016-11-27 22:11:14 +01:00
JosJuice 841e5893f4 IOS HLE: Add unit test for path/filename escaping 2016-11-27 22:11:05 +01:00
JosJuice 7a4f19ed98 IOS HLE: Correct handling of paths that don't start with / 2016-11-27 22:10:41 +01:00
JosJuice c74c317ab5 IOS HLE: More robust escaping of NAND paths
Prevents path traversal without needing an absolute path
function, and also improves accuracy (character sequences
like ../ appear to have no special meaning in IOS).

This removes the creation and usage of /sys/replace,
because the new escapes are too complicated to all
be representable in its format and because no other
NAND handling software seems to use /sys/replace.
2016-11-26 22:49:46 +01:00
JosJuice de355a8521 Revert "IOS HLE: Prevent accessing host file system"
This reverts commit 141f3bfb3a.
The implementation of getting absolute paths wasn't working
on non-Windows systems, which is a huge problem for IOS HLE.
2016-11-26 15:50:28 +01:00
JosJuice 9bfea4a0f2 Merge pull request #4447 from JosJuice/hthh-hle-issues
Fix exploitable HLE problems reported by hthh
2016-11-24 15:53:23 +01:00
JosJuice 2a5d22b3a7 Automatic translation resources sync with Transifex 2016-11-19 11:26:03 +01:00
JosJuice 141f3bfb3a IOS HLE: Prevent accessing host file system 2016-11-13 10:03:23 +01:00
JosJuice a79c449493 Avoid buffer over-reads in /dev/net/ip/top
Also fixes the less serious problem of buffer overflows
in emulated memory when BufferOutSize is less than 2.
2016-11-13 08:44:05 +01:00
JosJuice b47e607105 HLE_OS: More bounds checking in GetStringVA 2016-11-12 19:17:15 +01:00
JosJuice 3d80d454ce HLE_OS: Implement %n in GetStringVA
%n writes to a pointer that's provided as a parameter.
We didn't have a custom implementation of this before,
meaning that %n would trigger a write to the host
memory instead of the emulated memory!
2016-11-12 19:16:55 +01:00
JosJuice 656999d4c2 Correct bounds checking for /dev/sdio/slot0
The bounds checks in IOCtl were using 0x200 as the size of
m_Registers, which is more than the actual size, 0x200 / 4.

This commit turns m_Registers into an std::array to allow
for a correct and obvious way of getting its size.
2016-11-12 19:09:03 +01:00
JosJuice 3b78fec24e Automatic translation resources sync with Transifex 2016-11-12 12:09:00 +01:00
JosJuice d88295d5a1 Merge pull request #4421 from Pringo/wiimote-log
Change "Wiimote" to "Wii Remote" in Logs
2016-11-04 17:03:11 +01:00
JosJuice e18ceca7af Automatic translation resources sync with Transifex 2016-11-02 19:06:18 +01:00
JosJuice 25070d149e Merge pull request #4412 from JosJuice/more-debug-text
More debug text fixes
2016-11-02 17:58:59 +01:00
JosJuice 3c6742f66f More debug text fixes
Also a few small non-debug text changes.
2016-11-02 17:46:52 +01:00
JosJuice 5102e76a7f Merge pull request #4371 from JosJuice/gettextize-debug
gettextize: Remove "Debug" check
2016-10-31 13:18:02 +01:00
JosJuice 479b909935 Merge pull request #4381 from JosJuice/small-debug-text
DolphinWX: Small debug text fixes
2016-10-31 13:13:51 +01:00
JosJuice f1dc6c3106 Merge pull request #4404 from mbc07/gameini-just-dance
[GameINI] Update INIs of newer Just Dance games
2016-10-31 12:54:29 +01:00
JosJuice d80086adf5 Add debug i18n comments and revise existing i18n comments 2016-10-30 16:37:29 +01:00
JosJuice 9950209bbf EXI_DeviceIPL: Unify GetGCTime epoch handling 2016-10-29 18:30:00 +02:00
JosJuice 1081497cad DiscIO/SConfig: Rename GetUniqueID to GetGameID
We call this "game ID" everywhere else, and it's not
actually completely unique.
2016-10-29 15:24:02 +02:00
JosJuice 8155a253c6 EXI_DeviceIPL: Remove old unused code 2016-10-29 13:14:18 +02:00
JosJuice d6731d34ef Remove VolumeCreator logs
These logs are very rarely useful and cause the issue
https://bugs.dolphin-emu.org/issues/9767
2016-10-29 13:08:24 +02:00
JosJuice a319f8777d DolphinWX: Small debug text fixes 2016-10-28 12:18:32 +02:00
JosJuice b0e2642883 Automatic translation resources sync with Transifex 2016-10-24 12:39:07 +02:00
JosJuice 2fc2baf376 Merge pull request #4369 from lioncash/config
DolphinWX: Minor include changes to config panes/dialogs
2016-10-21 22:04:09 +02:00
JosJuice a2644cd102 Merge pull request #4363 from lioncash/wx-menu
DolphinWX: Move main menu creation into a wxMenuBar subclass
2016-10-21 21:44:56 +02:00
JosJuice 31a27a06ed gettextize: Remove "Debug" check
If the strings for the debugger shouldn't be included
in translations, we simply shouldn't use any translation
macro for those strings, instead of having a special
check to exclude debugger-related code from being
searched for translatable strings.

The "Debug" check is a hack that essentially nobody has
been aware of (including me). For instance, 14facbc made
a lot of strings translatable just because they were
moved to a file that doesn't have "Debug" in its path,
and as far as I know, nobody noticed that change until
the newly translatable strings were live on Transifex.
2016-10-21 15:59:55 +02:00
JosJuice c170f0b460 Movie: Add missing calls to UpdateWantDeterminism
Fixes https://bugs.dolphin-emu.org/issues/9681
2016-10-20 14:47:45 +02:00
JosJuice ae2cf370e1 Movie: Add missing includes 2016-10-20 14:22:42 +02:00
JosJuice 8f0083a4fa Automatic translation resources sync with Transifex 2016-10-16 14:53:42 +02:00
JosJuice 7876430a71 Merge pull request #4120 from JosJuice/dvdthread-queue
DVDThread queue
2016-10-16 14:48:06 +02:00
JosJuice a6bb1b642a DVDInterface: Better memory locality for DTK byteswapping 2016-10-15 15:28:23 +02:00
JosJuice e1f6ab5592 DVDThread: Remove s_dvd_thread_done_working and fix race condition
s_dvd_thread_done_working makes the logic more complicated,
and degasus pointed out a race condition that can happen if
the CPU thread calls WaitForIdle right in between the DVD
thread executing done_working.Set() and done_working.Reset()
while there is work left to do. To avoid this, let's just get
rid of s_dvd_thread_done_working. It's a relic from the old
DVDThread design. Thanks to the last few commits, WaitUntilIdle
only gets called rarely (disc change and savestate), so it's
not a problem if WaitUntilIdle ends up being slower.
2016-10-15 15:28:15 +02:00
JosJuice f1879cc356 DVDInterface: Reorder variables
Might as well do this while I'm already breaking
savestate compatibility.
2016-10-15 15:28:11 +02:00
JosJuice 98fb037dee DVDInterface: Handle DTK beyond 4 GiB
Might as well do this while I'm already breaking
savestate compatibility.
2016-10-15 15:28:06 +02:00
JosJuice a450e33fb3 DVDInterface: Read DTK data in DVDThread 2016-10-15 15:28:02 +02:00
JosJuice 28bfd52d3a DVDInterface: Prepare for reading DTK data in DVDThread 2016-10-15 15:27:54 +02:00
JosJuice aabb17b7c9 DVDThread: Use queues
This makes it possible to submit a read without waiting for
the previous read to finish.
2016-10-15 15:27:16 +02:00
JosJuice a2f352c422 DVDThread: Use structs for requests and results
This is a preparation for adding a queue to DVDThread.
Currently, s_read_request and s_read_result act somewhat like
queues that only can contain one object.
2016-10-15 11:32:11 +02:00
JosJuice 283c681f30 Automatic translation resources sync with Transifex 2016-10-09 15:46:48 +02:00
JosJuice 6ff2bd3243 DolphinWX: Delete traversal settings when pressing Reset
Deleting instead of overwriting makes the INI cleaner.
Also, in case we change defaults in the future, users will
get the new default when using a new version even if
they have pressed the Reset button in an older version.
2016-10-02 17:04:03 +02:00
JosJuice 337f573484 DolphinWX: Less duplication for setting traversal server label 2016-10-02 16:43:43 +02:00
JosJuice abc39f6c6f DolphinWX: Use constants for default traversal server 2016-10-02 16:36:12 +02:00
JosJuice 7a165db94f DolphinWX: Less duplication between GetTraversalPort/Server
They now also return their results the regular way.
2016-10-02 16:33:59 +02:00
JosJuice e5325fd082 Automatic translation resources sync with Transifex 2016-10-02 12:54:51 +02:00
JosJuice a714460ee3 Merge pull request #4256 from lioncash/anyof
PPCAnalyst: Compress loop into std::any_of
2016-09-29 15:47:29 +02:00
JosJuice d44b2de01d DVDInterface: Try to enforce disc inside status on savestate load 2016-09-27 16:51:14 +02:00
JosJuice 75dd4d0aee DVDInterface: Make changing discs savestate-safe 2016-09-27 16:51:14 +02:00
JosJuice a1486d48ef Merge pull request #4199 from vlad54rus/patch-1
[Gameini] Serious Sam: Next Encounter
2016-09-25 22:50:04 +02:00
JosJuice 58d0e22354 Merge pull request #4239 from lioncash/header
Null: Add missing header guard
2016-09-24 09:28:21 +02:00
JosJuice 2c8b9d18a8 Automatic translation resources sync with Transifex 2016-09-18 11:28:51 +02:00
JosJuice 22b5d89bf1 Merge pull request #4056 from Pringo/master
Update Menu Ellipses Usage
2016-09-16 20:28:51 +02:00
JosJuice 609d147dca Automatic translation resources sync with Transifex 2016-09-11 15:56:33 +02:00
JosJuice 4ce4b8d8bf Add .tx folder with config 2016-09-11 15:13:31 +02:00
JosJuice 2677806e95 Remove .tx from .gitignore
It contains a configuration that has no reason to be different
for different people. It's not used for storing things like
usernames or passwords.
2016-09-11 14:47:36 +02:00
JosJuice d0a323cce7 Merge pull request #4192 from TylerAldrich/typo_fix
Boot: Fix minor comment typo
2016-09-07 17:35:35 +02:00
JosJuice ec428756a6 Merge pull request #4169 from Armada651/dvd-triforce
DVDInterface: Remove unused Triforce buffer.
2016-09-01 17:20:20 +02:00
JosJuice 081cad709a Merge pull request #4046 from CharlesCorrin/master
GameSettings - Fix flickering cutscenes in Castlevania - The Adventure ReBirth
2016-08-30 18:27:52 +02:00
JosJuice fb6492e702 gettextize: Pipe list of file names to xgettext
This avoids an "Argument list too long" error with MINGW64 bash.
$CPP_FILE_LIST is tens of kilobytes large.
2016-08-28 17:20:10 +02:00
JosJuice 9f6000bb27 Move code into Movie::SignalDiscChange
DVDInterface shouldn't need to know anything about
the DTM format's 40-character limitation.

Also replacing "filename" in variable names with "path"
to make it clearer which variables contain the whole path
and which ones only contain the filename.
2016-08-21 12:51:14 +02:00
JosJuice 31c530c7b3 Merge pull request #3386 from lioncash/memory
Common: Namespace MemoryUtil
2016-08-19 11:04:45 +02:00
JosJuice f63461175c DolphinWX: Loose language matching in interface config 2016-08-12 15:29:34 +02:00
JosJuice ed9007cab7 Save GUI language as string instead of wxLanguage enum
When 5.0-211 updated wxWidgets to 3.1.0, some entries in the
wxLanguage enum were moved and added, changing the wxLanguage
values. Because we save Dolphin's interface language to disk
as a wxLanguage, the language you have set will mean something
different depending on whether you have the updated wx version
or not. For instance, setting the language to English with the
updated version and then using an older version will make
Dolphin use Dutch. Because we can't rely on the enum anymore,
I'm replacing the "Language" setting with a "LanguageCode"
setting that uses standard ISO 639 codes.
2016-08-12 14:52:01 +02:00
JosJuice 3bb0e7e3f5 Remove AM Baseboard
Let's stop pretending that we support Triforce emulation.
Keeping this code around just in case someone will make
major improvements in the future isn't really worth it.

I'm keeping the Triforce game INIs so users will know that
the compatibility rating for Triforce games is 1 star (broken).
2016-08-11 12:53:44 +02:00
JosJuice 3443a10030 CoreTiming: Merge ScheduleEvent variants into one function
Now Core::IsCPUThread() only gets called once when using the AnyThread
variant. Also, I think the enum approach makes calling code clearer.
2016-08-11 12:45:57 +02:00
JosJuice c9fa6318a2 Fix choosing certain localized EXI devices 2016-08-10 20:04:33 +02:00
JosJuice ccc4e6de02 DolphinWX: Don't translate OSD messages
OSD messages other than these one and a half aren't translated,
and OSD only supports ASCII. (Also, that "Wiimote %i %s" uses %s
like it does is bad for translation, but that's easy to fix.)
2016-08-10 18:18:25 +02:00
JosJuice b8e04c9513 Replace some unnamed tick constants with GetTicksPerSecond()
These operations should always take the same amount of time,
not the same amount of ticks. The number of ticks per second
is different for GameCube and Wii.
2016-08-10 17:34:23 +02:00
JosJuice 47c8bb26f8 Remove Immediate variants of ScheduleEvent
Usage of these are replaced with regular equivalents in order
to avoid executing event handlers in the middle of JIT blocks.
2016-08-10 16:34:06 +02:00
JosJuice 8d899ab01e Fix GWL.ini mistake made in 2e02c10
The patches are different, so they can't be in the region-neutral INI.
2016-07-22 10:26:31 +02:00
JosJuice 0a15aaaa12 Move DiscIO enums to a new file
At first there weren't many enums in Volume.h, but the number has been
growing, and I'm planning to add one more for regions. To not make
Volume.h too large, and to avoid needing to include Volume.h in code
that doesn't use volume objects, I'm moving the enums to a new file.
I'm also turning them into enum classes while I'm at it.
2016-07-13 17:29:27 +02:00
JosJuice 8df4437b6c Movie: Don't access g_netplay_initial_gctime directly
Using the global variable directly is ugly and might not be threadsafe.
2016-07-11 16:49:58 +02:00
JosJuice 53e7eed28d DiscScrubber: Fix issue 9356 2016-07-11 11:46:15 +02:00
JosJuice b960b5677b Don't ScheduleEvent from wrong thread when inserting SD card 2016-07-08 00:02:06 +02:00
JosJuice 31226b8503 DiscScrubber: Replace unused blocks with 0x00 instead of 0xFF 2016-07-07 11:51:58 +02:00
JosJuice 3b7c614124 DolphinWX: Fix a mix-up
Caused by a commit of mine, cb3b1b6
2016-07-06 18:31:18 +02:00