Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
25,909 Commits 1 Branch 0 Tags
d217e797f29b2d727bd7a45dcacd15603b739aa6
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Lioncash 343bde2712 Software/TextureSampler: const correctness 2017-09-11 20:13:47 -04:00
Mat M a9b339fb65 Merge pull request #6048 from spycrab/qt_fix_tools 
Qt: Fix "Load Wii System Menu" being in the wrong place
 2017-09-10 02:18:13 -04:00
Lioncash 696e1b40b5 Common: Move version strings to their own header 
Ideally Common.h wouldn't be a header in the Common library, and instead be renamed to something else, like PlatformCompatibility.h or something, but even then, there's still some things in the header that don't really fall under that label

This moves the version strings out to their own version header that doesn't dump a bunch of other unrelated things into scope, like what Common.h was doing.

This also places them into the Common namespace, as opposed to letting them sit in the global namespace.
 2017-09-09 19:28:10 -04:00
Lioncash 46579fe41c SWVertexLoader: Make SWVertexLoader a final class 
It doesn't make sense to allow extending this class based off the way
the VertexLoader API is set up.
 2017-09-09 15:33:30 -04:00
Lioncash dd8b41326c SWVertexLoader: Make SetFormat() and ResetBuffer() private 
SetFormat() is only ever used internally. ResetBuffer() is only
used to implement the VertexManagerBase class interface, so
there's no need to make it protected.
 2017-09-09 15:33:30 -04:00
Lioncash 29a362be43 SWVertexLoader: Remove GetIndexBuffer() 
It's only ever used in one place internally and is arguably unnecessary.
 2017-09-09 15:33:22 -04:00
Lioncash 4d2a4924cb SWVertexLoader: Normalize class variable names 
Follows our coding style.
 2017-09-09 15:32:41 -04:00
Mat M e86713ca67 Merge pull request #6044 from JonnyH/WIP/x11-buildfix 
Buildfix for X11 where HAVE_XRANDR is disabled
 2017-09-09 14:59:40 -04:00
Mat M 3e47baa40c Merge pull request #6022 from spycrab/qt_sw_dialog 
Qt/SettingsWindow: Fix window not being detected as a dialog
 2017-09-04 14:06:13 -04:00
Lioncash baee3a9c74 Software/Tev: const correctness 2017-09-03 14:15:21 -04:00
Mat M edf4bfaf5f Merge pull request #5989 from lioncash/constantmgr 
ConstantManager: Use std::array where applicable
 2017-09-03 13:18:10 -04:00
Lioncash 36e299ca80 D3DTexture: Remove unused bindflags D3DTexture2D member variable 2017-09-03 13:12:26 -04:00
Lioncash 52099d1b0a D3DTexture: in-class initialize class members where applicable 2017-09-03 13:08:06 -04:00
Lioncash 2237a6a04c OGL/VertexManager: Make vertex and index buffer handles private 
These are only ever read, but not written to outside of the VertexManager class.
 2017-09-02 20:51:54 -04:00
Lioncash 2d45204f12 VideoBackends: Add the explicit keyword to WorkItem-derived class constructors 
Prevents implicit conversions
 2017-09-02 17:35:20 -04:00
Lioncash 5059332d95 OGL/ProgramShaderCache: Remove unnecessary virtual keyword 
This is superfluous, considering the override keyword is present.
 2017-09-02 17:27:19 -04:00
Mat M 657195fad5 Merge pull request #6006 from JonnyH/WIP/parse-imgtec-gl_version-string 
Parse IMGTEC's GL_VERSION string format
 2017-09-02 17:10:59 -04:00
Lioncash 64de8a9d0b D3D: Eliminate redundant ID3D11DeviceChild* casts 2017-09-02 14:45:14 -04:00
Lioncash 6f97e3faa6 AsyncShaderCompiler: use std::make_unique in CreateWorkItem() 
Same behavior, simpler code.
 2017-09-02 14:08:00 -04:00
Lioncash 62615c601e AsyncShaderCompiler: Forward arguments to the specified type's constructor in CreateWorkItem() 
As this just hands off the arguments to another type's constructor,
perfect forwarding should be used here to preserve any potential move semantics.
 2017-09-02 14:06:48 -04:00
Lioncash f6e3a39c0e CommandProcessor: Remove unnecessary include 
Gets rid of some indirect inclusion.
 2017-09-02 13:34:21 -04:00
Mat M b073db51e5 Merge pull request #6000 from spycrab/qt_fix_older 
Qt: Fix building on <= 5.7.x
 2017-09-01 22:02:18 -04:00
Lioncash 9c1f9c1c00 ConstantManager: Use std::array where applicable 
Modernizes the arrays and makes future simplifications possible (e.g. usages within the software renderer).

It also makes cases where we use array->pointer decay explicit.
 2017-08-27 15:41:36 -04:00
Lioncash bc57ab3923 Clipper: Copy both color sequences in CopyVertex as opposed to one 
This is likely an oversight.
 2017-08-22 22:45:28 -04:00
Lioncash ffaa9a3bea SW NativeVertexFormat: Utilize std::array where applicable 
Gets rid of some hardcoded looping bounds, and also simplifies code in
some places, sometimes allowing for removal of a loop altogether.
 2017-08-22 22:39:28 -04:00
Mat M 5aed9a67ef Merge pull request #5904 from leoetlino/indirect-include 
PowerPC: Fix indirect includes for GDBStub
 2017-08-20 19:59:53 -04:00
Lioncash 7a5577498b CommonTypes: Qualify standard integral types in typedefs with std:: 
Given a relatively recent proposal (P0657R0), which calls for deprecation of putting stuff into the global namespace when using C++ headers, this just futureproofs our code a little more.

Technically this is what we should have been doing initially, since an
implementation is allowed to not provide these types in the global
namespace and still be compliant.
 2017-08-20 19:34:52 -04:00
Lioncash 745f92b4e5 TransformUnit: Get rid of pointer casting in TransformColor() where applicable 
The casts to u32* are technically undefined behavior. The u8* cast is
left, as char/unsigned char is exempted from this rule to allow for
bvtewise inspection of objects (and this is what s8/u8 are typedefs of
on platforms we support).
 2017-08-06 19:04:31 -04:00
Lioncash 4d35a3105e TransformUnit: Make LightColor()'s chan parameter const 
Also marks references/pointers const where applicable
 2017-08-06 18:15:05 -04:00
Lioncash 2363be4c63 ElidedButton: Make constructor explicit 
Prevents implicit conversions to ElidedButton.
 2017-08-06 17:31:29 -04:00
Lioncash 5153271278 ElidedButton: Add missing override specifier on paintEvent() 2017-08-06 17:26:07 -04:00
Lioncash f0308151a8 File: Make GetSize() a const member function 2017-08-06 07:57:43 -04:00
Lioncash 01c262fe47 Filesystem: Declare FileInfo iterator's move constructor and assignment operator noexcept 
Prevents potential extra copies being created in the context of
std::move_if_noexcept.
 2017-08-05 12:29:02 -04:00
Lioncash f6c21e002b General: Remove unnecessary semicolons 2017-07-30 16:39:53 -04:00
Lioncash b3c1bff34b SysConf: Add explicit to single-argument constructor 
Prevents implicit construction from FromWhichRoot values.
 2017-07-30 15:35:16 -04:00
Lioncash fb42c3eddc DolphinQt2: Add missing include guards 2017-07-26 16:31:58 -04:00
Lioncash 80b938b403 DolphinQt2: Remove unimplemented prototypes 
Also removes an unnecessary includes in related files
 2017-07-26 16:26:55 -04:00
Mat M 63f1f122fa Merge pull request #5729 from ligfx/qtremoveoldsyntax 
DolphinQt2: update old SLOT/SIGNAL syntax
 2017-07-24 18:48:20 -05:00
Lioncash 7373474888 ListProxyModel: Add missing include guard 2017-07-24 19:46:25 -04:00
Lioncash 5859914da5 TraversalClient: Fix memory leaks in ReleaseTraversalClient() 
release() relinquishes ownership of a pointer, it doesn't actually free
it.
 2017-07-22 18:19:25 -04:00
Mat M 898bbffaa7 Merge pull request #5724 from JonnyH/WIP/fix-some-ODR-warnings 
Fix some GCC ODR warnings
 2017-06-29 18:48:47 -04:00
Mat M 4320c641f7 Merge pull request #5675 from Tilka/warning 
Fix two warnings
 2017-06-23 20:46:32 -04:00
Lioncash 82c66e2bab FifoRecorder: Don't allocate ~100.7MB on program startup 
So, a FifoRecorder instance is instantiated as a file-local variable and
used as a singleton (ugh). Most users likely don't regularly use the
FIFO player/FIFO recorder, so this is kind of a substantial waste of
memory.

FifoRecorder's internal RAM and ExRAM vectors are 33554432 and 67108864
bytes respectively, which is around 100.66MB in total.

Just on the game list view on a clean build with nothing loaded, this
knocks debug build memory usage down from ~232.4MB to ~137.5MB, and
release build memory usage down from ~101MB to ~5.7MB.
 2017-06-19 02:47:26 -04:00
Lioncash 59a947d41d AbstractTexture: Return config by const reference 
Returning by const value isn't really necessary (and usually an indicator const reference was intended).
 2017-06-18 23:38:42 -04:00
Lioncash 07cddf6f7f AbstractTexture: Add missing includes (and remove unnecessary ones) 2017-06-18 23:29:22 -04:00
Mat M 4c2b078017 Merge pull request #5644 from lioncash/vsfilter 
VideoCommon: Fix VS filter for AbstractTexture.cpp
 2017-06-18 23:15:43 -04:00
Lioncash 0c57543205 VideoCommon: Fix VS filter for AbstractTexture.cpp 
This would cause failures when building with VS.
 2017-06-18 22:58:02 -04:00
Lioncash 251de89b5c HttpRequest: Use std::chrono for indicating time periods 
Allows the use of chrono time points, on top of being more indicative of
time periods used at call sites, if custom timeouts are specified.
 2017-06-18 15:48:37 -04:00
Mat M 220ce425cd Merge pull request #5580 from lioncash/header 
Core: Remove unnecessary header inclusions
 2017-06-15 19:08:56 -04:00
Lioncash dd4203bec8 Core: Remove unnecessary includes 
Also moves a cpp file's related header file to the top of the inclusions if it isn't already there.
 2017-06-15 18:52:22 -04:00
Lioncash b003108b8b Core: Add WiimoteCommon headers to the VS project 2017-06-15 18:38:21 -04:00
Lioncash a093b58aad Core: Move SignatureDB and Config source files into filters 
Keeps things organized instead of being in the root of Core's source
tree when using the filter view.
 2017-06-07 21:57:49 -04:00
Lioncash d9bb2ce3af DVDInterface: Amend lint formatting issues 2017-06-07 01:20:54 -04:00
Lioncash b676edd80c Core: include what you use 
Eliminates a swath of indirectly included standard headers
 2017-06-07 01:20:48 -04:00
Lioncash b0427731b3 ElfReader: default the destructor 2017-06-06 23:03:59 -04:00
Lioncash 1af1795695 ElfReader: Make constructors explicit 2017-06-06 23:03:59 -04:00
Lioncash 1876505707 DolReader: Make constructors explicit 2017-06-06 23:03:59 -04:00
Lioncash 927a4a16f8 Boot: Make BootExecutableReader constructors explicit 2017-06-06 22:54:25 -04:00
Lioncash acac2aeb9b Movie: Use std::put_time in GetRTCDisplay() 
No need for a fixed buffer.
 2017-06-06 20:56:04 -04:00
Lioncash e5260dee6b ec_wii: Add missing <string> header 2017-06-06 20:37:43 -04:00
Lioncash 1ffc311bf3 Core: Fix vcxproj filter 
This would cause the core project to fail to load.
 2017-06-06 20:29:03 -04:00
Mat M 0e6bd74ed6 Merge pull request #5525 from lioncash/overload 
Device: Provide operator!= counterparts to operator== for DeviceQualifier
 2017-06-03 19:41:53 -04:00
Lioncash 5862d1fc41 Device: Provide operator!= counterparts to operator== for DeviceQualifier 
Makes comparison logic symmetric
 2017-06-03 19:34:35 -04:00
Lioncash d6b6b070bc D3D/Render: Get rid of undefined behavior in Create3DVisionTexture 
pSysMem is of the type const void* -- because of this, it makes the
original delete[] call undefined behavior, as deleting a void pointer is
undefined behavior.

Also punning types into existence, like what was done for the stereo
image header is undefined behavior as well. The proper way to do this is
to either manually add all individual bytes manually, or memcpy the
struct into memory.

As we want to deallocate the memory before returning, and because
pSysMem is a const void*, we keep a unique_ptr to the data and just pass
pSysMem a raw pointer to the data.
 2017-05-28 23:28:00 -04:00
Lioncash 278e406f0b D3D/Render: Use std::array where applicable 2017-05-28 23:28:00 -04:00
Lioncash 0c3958bbe5 D3D/Render: Join variable with declaration 2017-05-28 23:27:59 -04:00
Lioncash 3ee447e5f7 D3D/Render: Get rid of unnecessary casts 2017-05-28 23:27:59 -04:00
Lioncash ba5b215c42 D3D/Render: Mark translation unit local variables as static 2017-05-28 23:27:59 -04:00
Mat M 9fa1e8f45f Merge pull request #5493 from lioncash/include 
CubebStream: Add missing <vector> include
 2017-05-28 02:08:35 -04:00
Lioncash 3e7af2a2cd CubebStream: Add missing <vector> include 2017-05-27 23:50:39 -04:00
Mat M 905232fd2b Merge pull request #5313 from ligfx/addcubeb 
Add CubebStream output backend and replace PortAudio for microphones
 2017-05-27 21:39:03 -04:00
Mat M 7192226971 Merge pull request #5474 from sepalani/bl-fix 
CodeView: Fix missing bl details
 2017-05-27 17:40:18 -04:00
Mat M 7b70fce79b Merge pull request #5476 from ligfx/ffmpegbuildcleanup 
CMake/MSVC: cleanups around FFMpeg
 2017-05-27 17:36:55 -04:00
Mat M b7cc4d73dc Merge pull request #5469 from ligfx/cmakecleanupunittests 
CMake: various cleanups for UnitTests
 2017-05-23 02:08:58 -04:00
Mat M 3f437337a1 Merge pull request #5466 from lioncash/db 
SignatureDB: Minor cleanup
 2017-05-22 21:25:36 -04:00
Mat M 4bfd464b0c Merge pull request #5468 from leoetlino/headers 
Fix some header includes
 2017-05-22 21:22:04 -04:00
Lioncash 73b72c6a62 TitleDatabase: Remove unused <iostream> header 
Many implementations of <iostream> inject a static constructor into the
translation unit, it's included in, even if nothing from the header is used.
 2017-05-21 17:51:47 -04:00
Lioncash c3bab0b0e7 SignatureDB: Remove unnecessary header 2017-05-21 17:39:44 -04:00
Lioncash bbe1e643fb SignatureDB: in-class initialize DBFunc members 2017-05-21 17:39:42 -04:00
Lioncash d0089191e1 SignatureDB: default the format handler destructor 2017-05-21 17:39:41 -04:00
Lioncash 5301efddd0 SignatureDB: Remove unnecessary qualifiers and virtual keywords 2017-05-21 17:39:40 -04:00
Lioncash 3c94962332 SignatureDB: Move two functions into the cpp file 
These are implementation details.
 2017-05-21 17:39:34 -04:00
Mat M b47d44ab15 Merge pull request #5445 from JosJuice/remove-jitil 
Remove JITIL
 2017-05-19 21:33:38 -04:00
Mat M 1880a97bb0 Merge pull request #4424 from Helios747/remove_more_features 
Remove D3D12
 2017-05-18 20:04:40 -04:00
Lioncash 35aa55931f MainAndroid: Resolve -Wmissing-variable-declarations warnings 2017-05-18 19:55:05 -04:00
Mat M 35a8771e68 Merge pull request #5427 from lioncash/host 
Host: Get rid of Host_SetStartupDebuggingParameters()
 2017-05-18 19:04:25 -04:00
Lioncash 7baabe99d1 Host: Get rid of Host_SetStartupDebuggingParameters() 
This is something that should be the responsibility of the frontend
booting the game. Making this part of the host 'interface' inherently
requires frontends to leak internal details (much like the other
UI-related functions in the interface).

This also decouples more behavior from the debugger and the
initialization process in the wx frontend. This also eliminates several
usages of the parent menubar in the debugger code window.
 2017-05-14 19:12:59 -04:00
Lioncash 198d686a41 MEGASignatureDB: Add missing override specifiers 2017-05-14 16:20:45 -04:00
Mat M 7a25dde8df Merge pull request #5387 from leoetlino/constexpr 
Contributing: Use constexpr for compile-time constants
 2017-05-07 17:56:37 -04:00
Mat M ef4a1f0ec7 Merge pull request #5384 from leoetlino/disable 
WX: Disable NAND import when emulation is running
 2017-05-06 19:38:07 -04:00
Mat M 4ba786a164 Merge pull request #5381 from JosJuice/cached-title-id 
DolphinWX: Use title ID from ISOFile when possible
 2017-05-06 19:37:25 -04:00
Mat M f3052b7a15 Merge pull request #5318 from ligfx/cmakehidapi 
CMake: clean up HIDAPI build
 2017-05-03 19:54:06 -04:00
Mat M d48c3ce63e Merge pull request #5361 from ligfx/signaturedbwarning 
SignatureDB: fix prevented copy elision
 2017-05-02 23:09:49 -04:00
Mat M 7c3905a612 Merge pull request #5140 from sepalani/signature_db 
SignatureDB: Rewrite FormatHandler API
 2017-05-02 19:23:46 -04:00
Mat M c51e40f92f Merge pull request #5357 from ligfx/jitintegerwarning 
Jit64: fix braces warning in Jit_Integer
 2017-05-02 18:44:02 -04:00
Mat M d66e0e38d3 Merge pull request #5359 from ligfx/nandimporterwarning 
NANDImporter: fix printf warning
 2017-05-02 18:43:28 -04:00
Lioncash 9e71031e23 Frame: Normalize member names 2017-05-01 05:13:19 -04:00
Mat M 1bad3bef4b Merge pull request #5344 from lioncash/table 
MemoryWindow: Minor cleanup
 2017-04-30 18:32:29 -04:00
Mat M 344767a258 Merge pull request #5336 from JosJuice/memcard-shiftjis 
Fix display of Japanese text in the Memory Card Manager
 2017-04-30 18:22:47 -04:00
Mat M d5534e069c Merge pull request #5334 from spycrab/wx_gamelist_cleanup 
Refactor GameListCtrl
 2017-04-30 18:21:50 -04:00