Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
26,037 Commits 1 Branch 0 Tags
d790660b598a4d9b5d9a2dadd1a375beb83a8788
Commit Graph
8 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Mike Harris 3c3d0fa6f5 Remove 'all' as a Platform enum. 
This will remove the 'all games' row on the TV view.
 2017-09-29 09:38:14 -07:00
Mike Harris cc77a4963f Convert platform ints to a proper enum Platform. 
This is good practice (see Effective Java chapter 6), and adds
compile-time checks.
 2017-09-29 09:38:14 -07:00
Mike Harris 487591c760 Change from using tags in ImageCardView to setting a per-platform background. 
This allows us to use a real ImageCardView instead of extending the
class.
 2017-09-29 09:38:14 -07:00
Mike Harris 2d740147fe remove dupe log tag 2017-09-29 09:38:14 -07:00
Mike Harris 7db88e831e Remove prefix of tag, args and keys with packagename. 
Prefixing everything with a constant packagename is not needed for
internal keys, and just adds complexity.

Rename ARGUMENT_ prefix to ARG_ to match (most) of the rest of the
codebase.

Restrict visiblity of above as much as possible.
 2017-09-26 17:15:58 -07:00
Mike Harris ab90a3029d Move Save/LoadFragment's layout ID inline and private. 
Fix the hack of using the layout resource ID as a save/load ID, and
instead use a proper enum.
 2017-09-26 17:15:57 -07:00
Mike Harris 96525cbaaa Remove unused FRAGMENT_TAG, and move the fragment's layout ID inline. 
FRAGMENT_ID wasn't actually the fragment's ID (that's misleading, and
sounds like the tag). It's actually the layout resource ID. There's no point in making that a static constant.
 2017-09-25 22:47:52 -07:00
Mike Harris 252af9c1bd Remove the debug strings.xml definition of application_id. 
This is handled by gradle, we don't need a separate strings.xml for
debug.
 2017-09-25 22:20:52 -07:00