Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
33,013 Commits 1 Branch 0 Tags
eae68194b30610c60f224c676f573de024ed3a78
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Léo Lam d1439a1fa9 IOS/USB: Move scan thread logic into a separate class 
This moves the scan thread logic and variables into a separate
ScanThread class. By turning ScanThread instances into members of the
most derived class, this ensures that the scan thread is always
properly stopped when the most derived class is destructed and fixes
a race condition that could cause the scan thread to call virtual
member functions from a derived class whose members have already
been destructed.

A drawback of this approach is that the scan thread must be the last
member variable, so this commit also adds static assertions to ensure
that the assumption stays valid.
 2020-08-17 15:14:45 +02:00
Léo Lam 55c931d624 Merge pull request #8995 from Tilka/warnings 
Fix some more GCC warnings
 2020-08-17 14:49:28 +02:00
Léo Lam 6104018fe1 Merge pull request #9020 from Tilka/usb 
IOS/USB: fix potential race condition
 2020-08-17 12:15:26 +02:00
Léo Lam c9945670f0 Merge pull request #9029 from shuffle2/vs-clean 
vs/msbuild: fix the build generating log files in source dirs
 2020-08-17 12:13:45 +02:00
Léo Lam fee6bef252 Merge pull request #9032 from shuffle2/msbuild-unittests 
UnitTests: avoid using glob to find compilation units
 2020-08-17 12:11:59 +02:00
Léo Lam a660033e8c Merge pull request #8792 from leoetlino/video-backend 
Migrate video backend setting to the new config system
 2020-05-24 15:26:44 +02:00
Léo Lam 1203e626b3 Merge pull request #8800 from sepalani/kd-shutdown 
IOS/KD: Implement IOCTL_NWC24_REQUEST_SHUTDOWN
 2020-05-24 15:24:51 +02:00
Léo Lam 166633bf27 Merge pull request #8826 from iwubcode/try_parse_any_base 
Common / Core: Update StringUtil to allow specifying the base
 2020-05-24 15:13:49 +02:00
Léo Lam 7449c7153c Merge pull request #8830 from JosJuice/delete-empty-rfl-db 
CheckNAND: Delete RFL_DB.dat if empty
 2020-05-24 15:12:39 +02:00
Léo Lam 8df56cb319 Migrate video backend setting to the new config system 
Fixes https://bugs.dolphin-emu.org/issues/12087
 2020-05-22 16:54:53 +02:00
Léo Lam 393ce529af Merge pull request #8771 from Leseratte10/master 
Add /dev/dolphin interface to allow game to read the REAL product code
 2020-05-22 16:49:31 +02:00
Léo Lam 7aec045ef7 Merge pull request #8799 from Ebola16/AT 
Android: Consistent TODO formatting
 2020-05-22 16:44:43 +02:00
Léo Lam 47ee5ac284 WiiRoot: Fix empty files being created when source is missing 
CopyNandFile must not create empty files on the destination filesystem
if the source file doesn't exist.

Otherwise, this can lead to an empty Mii database being created in the
session Wii root if there's no database in the configured Wii root and
netplay or Movie is used -- that database would then be copied back to
the configured root, which causes games like MKW to complain about
corrupted Mii data even when the player has stopped using netplay.

This commit also simplifies CreateFullPath usage.
There's no need to manually extract the directory from the path,
FS::CreateFullPath does it automatically just like File::CreateFullPath
 2020-05-09 16:47:45 +02:00
Léo Lam 1bedbdf3c0 Merge pull request #8687 from howard0su/warning_jitblock 
Jit: remove warning -Winvalid-offsetof
 2020-05-04 18:35:08 +02:00
Léo Lam 7c0ef725ab Merge pull request #8744 from cristian64/save_restore_netplay_browser_settings 
DolphinQt: Saving and restoring NetPlay Session Browser dialog's settings.
 2020-05-04 00:50:26 +02:00
Léo Lam c53ecdd689 Merge pull request #8686 from sepalani/thread-tab 
Debugger: Add a Thread widget
 2020-05-04 00:50:10 +02:00
Léo Lam 947d6732a8 Merge pull request #8712 from sepalani/console-type 
Boot: Add ConsoleType enum class
 2020-05-03 23:10:44 +02:00
Léo Lam 9ffa72ad1f Merge pull request #8691 from howard0su/warning_wiimote 
WiimoteEmu: Cleanup warnings of -Wparentheses
 2020-05-03 18:31:57 +02:00
Léo Lam 297bbceadf Remove redundant "Emulation" from "DSP HLE Emulation" 
HLE stands for "high-level emulation", so "DSP HLE Emulation" would
mean "DSP High-Level Emulation Emulation"
 2020-05-03 17:54:05 +02:00
Léo Lam 6e01855e8e Merge pull request #8770 from Ebola16/ADSP 
Android: Add DSP Emulation Engine
 2020-05-03 17:51:46 +02:00
Léo Lam 907b1302b0 Merge pull request #8775 from leoetlino/rect 
MathUtil: Fix Rectangle::GetWidth/Height for unsigned types
 2020-05-03 15:41:38 +02:00
Léo Lam 920cf38889 Merge pull request #8757 from sepalani/so-cleanup 
IOS/KD: Cleanup sockets on IOCTL_NWC24_CLEANUP_SOCKET
 2020-05-03 15:41:14 +02:00
Léo Lam 1b26929119 Merge pull request #8789 from JosJuice/windows-cmake-errors 
Fix Windows CMake build errors
 2020-05-03 15:33:58 +02:00
Léo Lam 07ab79db64 MathUtil: Fix Rectangle::GetWidth/Height for unsigned types 
`std::abs(x - y)` where x and y are unsigned integers fails to compile
with an "call of overloaded 'abs(unsigned int)' is ambiguous" error
on GCC, and even if it did compile, that expression still wouldn't
give the correct result since `x - y` is unsigned.
 2020-05-03 14:41:58 +02:00
Léo Lam 0ab9475f8e Merge pull request #8786 from JosJuice/user-style-not-path 
DolphinQt: Store name of user style, not path
 2020-05-03 14:11:55 +02:00
Léo Lam 90ba73c6c2 Merge pull request #8787 from leoetlino/config-config 
Remove redundant Config prefix from ConfigInfo/ConfigLocation
 2020-05-03 14:07:41 +02:00
Léo Lam 19da101164 Remove redundant Config prefix from ConfigInfo/ConfigLocation 
Both structs are already in the Config namespace.
 2020-05-02 14:40:14 +02:00
Léo Lam 47d1dec723 Merge pull request #8783 from JosJuice/i18n-comments 
DolphinQt: Add some i18n comments for recently added strings
 2020-05-02 02:12:27 +02:00
Léo Lam c72b18361f Merge pull request #8784 from JosJuice/memory-size-mismatch 
Don't assume fixed width for "Emulated memory size mismatch!" message
 2020-05-02 02:11:57 +02:00
Léo Lam ac18f7e884 Merge pull request #7996 from AdmiralCurtiss/memcard-manager-create-new 
GCMemcard/MemcardManager: Make creating a new card more explicit and UX-friendly.
 2020-04-29 00:20:08 +02:00
Léo Lam 4b00ddf9aa Merge pull request #8722 from Minty-Meeo/master 
Configurable MEM1 and MEM2 sizes at runtime via Dolphin.ini
 2020-04-28 22:11:12 +02:00
Léo Lam 401b582b40 Merge pull request #8151 from lioncash/jit_tables 
Jit64/Jit64_Tables: Construct tables at compile-time
 2020-04-28 18:03:07 +02:00
Léo Lam 82012c4cd6 Merge pull request #8272 from lioncash/overload 
DolphinQt: Use qOverload where applicable
 2020-04-28 16:59:43 +02:00
Léo Lam 58de3c59ce Merge pull request #8654 from 3t13nn3/HotkeyControllerProfile 
Qt: Fix Hotkey Controller Profile display with boxes for each Wiimote
 2020-04-28 16:17:36 +02:00
Léo Lam 93abbc66aa Merge pull request #8688 from howard0su/cleanup_strncpy 
Remove warning of -Wstringop-truncation
 2020-04-28 14:28:30 +02:00
Léo Lam 7390767008 Merge pull request #8668 from sepalani/rso-autodetect 
RSO: Auto-detect RSO location in RAM
 2020-04-28 14:27:13 +02:00
Léo Lam 0fe4985f8d Merge pull request #8689 from howard0su/cleanup_sign 
Remove warnings of -Wsign-compare
 2020-04-28 13:36:21 +02:00
Léo Lam d11a83e205 Merge pull request #8694 from howard0su/cleanup_switch 
Cleanup warnings of -Wswitch
 2020-04-28 13:35:15 +02:00
Léo Lam 586af0a55e Merge pull request #8695 from howard0su/warning_hw 
HW: cleanup warnings of -Wtype-limits
 2020-04-28 13:13:22 +02:00
Léo Lam fa7d6c8993 Merge pull request #8769 from Ebola16/SCDDD 
Android: Fix MenuTag typo
 2020-04-28 12:06:04 +02:00
Léo Lam 8f578fd2b9 Merge pull request #8704 from JosJuice/setting-txt-output-null 
SettingsHandler: Don't output null bytes
 2020-04-28 12:02:39 +02:00
Léo Lam 7a77abb815 Merge pull request #8753 from sepalani/network-tab 
Debugger: Add a Network widget
 2020-04-27 20:38:12 +02:00
Léo Lam 88ae4c7914 Merge pull request #8729 from JosJuice/android-touch-ir-default 
Android: Use touch emulation of IR by default
 2020-04-27 17:56:01 +02:00
Léo Lam c36a78eff8 Merge pull request #8707 from tellowkrinkle/FixCMakeSymlinkMac 
Match path type to BundleUtilities when running fixup_bundle
 2020-04-27 17:53:54 +02:00
Léo Lam b7ba72c7e5 Merge pull request #8766 from teconmoon/patch-1 
Don't defer EFB Copies to RAM - PMTTYD Issues
 2020-04-27 17:52:47 +02:00
Léo Lam 5909d13236 Merge pull request #8710 from Ebola16/QTDP 
Qt: Display default Paths
 2020-04-27 17:49:31 +02:00
Léo Lam d040f91c3a Merge pull request #8709 from Ebola16/AS 
Android: Split General settings
 2020-04-27 17:13:57 +02:00
Léo Lam e6351e1d4b Merge pull request #8719 from CookiePLMonster/dolby-pro-logic-quality-fixup-ii 
AudioPane: Do not enable DPL II quality slider with HLE audio on init
 2020-04-27 17:11:56 +02:00
Léo Lam 1ca682e6a1 Merge pull request #8723 from seanyeh/fix-confirm-dialog-enter 
Qt/GameList: Use KeyPress instead of KeyRelease
 2020-04-27 17:00:58 +02:00
Léo Lam 71f409dac4 Merge pull request #8726 from xperia64/dns_improvements 
Respect Core::WantsDeterminism for DNS servers on Linux
 2020-04-27 16:43:24 +02:00
Léo Lam 9d44af4c31 Merge pull request #8696 from howard0su/cleanup_shadow 
Cleanup warnings of -Wmissing-declarations
 2020-04-27 15:33:01 +02:00
Léo Lam bab04155b6 Merge pull request #8745 from AdmiralCurtiss/savestate-load-callback-qt 
Qt/Debugger: Refresh on savestate load.
 2020-04-27 15:29:55 +02:00
Léo Lam b175e9e6ac Merge pull request #8748 from Ebola16/WAD 
Android: Add Install WAD to menu_game_grid
 2020-04-27 15:15:39 +02:00
Léo Lam 75e79ece73 Merge pull request #8751 from jordan-woyak/point-fix 
WiimoteEmu: Apply "Tilt" and "Point" rotations separately for proper tilted pointing.
 2020-04-27 14:55:19 +02:00
Léo Lam 03c569ac16 Merge pull request #8762 from degasus/ext_lib 
Externals: Add bzip2 and libLZMA.
 2020-04-27 12:18:05 +02:00
Léo Lam f2f8168966 Merge pull request #8764 from JosJuice/volumeverifier-dual-layer-desync 
VolumeVerifier: Show desync warning for dual layer discs too
 2020-04-27 12:04:45 +02:00
Léo Lam 2673280614 Merge pull request #8389 from sepalani/fix-so 
Socket: Abort pending ops on close
 2020-04-22 07:19:25 +02:00
Léo Lam b2cf106ae9 IOS/FS: Fix FST write failure on some platforms 
On some platforms (like Windows), the temporary file must be closed
before it can be renamed.

I guess nobody noticed this for so long because (1) the FS code has a
failsafe for missing FST entries (because existing users do not have
a FST), and most games do not care about file metadata;
(2) the write failures can only be seen in the logs.

Because we don't want this to break, I have turned the ERROR_LOGs into
PanicAlerts.
 2020-04-18 12:42:12 +02:00
Léo Lam 5b10f4b71e Merge pull request #8673 from JosJuice/preserve-setting-txt 
Boot: Do a better job of preserving certain parts of settings.txt
 2020-03-24 10:16:17 +01:00
Léo Lam 584eee818c Merge pull request #8660 from TheRealPSV/master 
Android: Set up Day/Night mode for system-compatible optional dark theme
 2020-03-24 10:03:35 +01:00
Léo Lam b3ad3c3b07 Merge pull request #8683 from AlexApps99/cmdl 
Parse arguments before Qt
 2020-03-24 10:02:24 +01:00
Léo Lam 53c34d962d Merge pull request #8665 from AdmiralCurtiss/debugger_columns 
Qt/CodeViewWidget: Make columns resizable by the user and set sensible defaults.
 2020-03-19 01:40:30 +01:00
Léo Lam 0b91ea28c1 Merge pull request #8677 from JosJuice/comma-operator 
Android/JNI: Remove odd usage of the comma operator
 2020-03-18 13:13:16 +01:00
Léo Lam 4711b76cc4 Merge pull request #8655 from Techjar/fix-hotkey-groups 
Core/HotkeyManager: Fix group names in config
 2020-03-18 12:03:07 +01:00
Léo Lam bb430fb5a5 Merge pull request #8675 from Pokechu22/disc-update 
Fix Load Wii System Menu not updating after performing a disc update
 2020-03-18 11:54:07 +01:00
Léo Lam d1e8e3e903 Merge pull request #8671 from leoetlino/bt-passthrough-error 
BTReal: Improve error handling for device opening
 2020-03-18 11:52:22 +01:00
Léo Lam 0461170363 Merge pull request #8672 from JosJuice/wii-setting-backup 
Back up Wii setting.txt and SYSCONF while emulating
 2020-03-16 22:21:15 +01:00
Léo Lam d4085382dc Merge pull request #8598 from JosJuice/channel-sync-android-tv 
Android: More robust check for whether to sync channels
 2020-03-16 20:53:47 +01:00
Léo Lam c86832849a Merge pull request #8535 from JosJuice/movie-save-detection 
Movie: Make checking for existing GC saves more reliable
 2020-03-16 00:19:14 +01:00
Léo Lam f7fb2c4280 Merge pull request #8583 from Craftyawesome/readme-updates 
Readme.md Tweak Command Line section
 2020-03-16 00:07:54 +01:00
Léo Lam f81c0658c0 Merge pull request #8503 from JosJuice/android-stick-calibration 
Android: Use square stick calibration
 2020-03-15 23:42:05 +01:00
Léo Lam 5038ae384b Merge pull request #8427 from CookiePLMonster/wil-submodule 
Add Windows Implementation Libraries as an external library
 2020-03-15 23:28:53 +01:00
Léo Lam 57274cbf91 Merge pull request #8565 from Pokechu22/log-scroll-bar 
Always display the horizontal scroll bar when log word wrap is off
 2020-03-15 23:14:23 +01:00
Léo Lam a66ee4ea42 Merge pull request #8597 from SirMangler/master 
Hotkeys: Toggle Freelook Hotkey
 2020-03-15 22:40:51 +01:00
Léo Lam d9eec2ef04 Merge pull request #8609 from jordan-woyak/separate-hotkey-background-input 
DolphinQt: Give hotkeys their own "background input" setting.
 2020-03-15 22:35:49 +01:00
Léo Lam 466c079bf4 Merge pull request #8604 from Techjar/netplay-index-direct 
Core/NetPlayServer: Fix session not being added to index on direct connection type
 2020-03-15 22:22:00 +01:00
Léo Lam 73e7f2a839 BTReal: Improve error handling for device opening 
This commit attempts to improve error handling for device opening by
reducing panic alert spam when opening one or several devices fails.
Currently, Dolphin shows a panic alert for every device that we fail
to open, and another panic alert at the end if no usable device was
found. That is certainly a bit excessive -- we should only keep the
very last panic alert (the one that is shown if everything fails)
and we can just put the error for the last device open operation there.

This also changes the PanicAlert to a CriticalAlert to ensure the
message is visible even if the user has disabled regular panic alerts.

The message has also been reworded and should hopefully be clearer.
 2020-03-15 22:10:24 +01:00
Léo Lam d297080f52 Merge pull request #8669 from container1234/mbp 
Breakpoints: Fix crash after clearing all memory breakpoints
 2020-03-15 18:40:05 +01:00
Léo Lam 3c1f5c675d Merge pull request #8628 from iwubcode/texturepack_game_id_file 
VideoCommon: Allow texture folders to be determined by a <gameid>.txt
 2020-03-15 18:37:46 +01:00
Léo Lam 24a01642e0 Merge pull request #8642 from AdmiralCurtiss/debugger_branch_arrows 
Qt/CodeViewWidget: Implement branch arrows.
 2020-03-15 16:45:36 +01:00
Léo Lam 5db7add9c7 Merge pull request #8667 from Mystro256/master 
Allow for some shared minizip/fmt
 2020-03-15 16:25:11 +01:00
Léo Lam 19a46dd67b Merge pull request #8652 from sonic2kk/qtshortcuts 
Qt: Use Builtin QKeySequence Shortcuts
 2020-03-15 15:07:47 +01:00
Léo Lam 4944e4b429 Merge pull request #8647 from jordan-woyak/minor-input-cleanups 
InputCommon: Minor ReshapableInput related cleanups.
 2020-03-15 15:06:54 +01:00
Léo Lam 0bf05009d0 Merge pull request #8650 from jordan-woyak/ir-cleanup 
HW/WiimoteEmu: Camera logic cleanups.
 2020-03-15 15:04:48 +01:00
Léo Lam 97aaee1577 Merge pull request #8198 from mazes-80/system-fmt 
Build system: default to fmt shared library when available
 2020-03-15 14:36:28 +01:00
Léo Lam 33492e4df0 Merge pull request #8670 from Leseratte10/master 
Fix settings.txt parsing in case of weird line endings
 2020-03-15 14:28:26 +01:00
Léo Lam 44b4c2db49 Common: Avoid std::function overhead in ScopeGuard 
So far in all our uses of ScopeGuard, the type of the callable is
usually just a lambda or a function pointer, so there is no need
to rely on std::function's type erasure.

While the cost of using std::function is probably negligible, it still
causes some unnecessary overhead that can be avoided by making
ScopeGuard a templated class. Thanks to class template argument
deduction in C++17 most existing usages do not even need to be changed.

See https://godbolt.org/z/KcoPni for a comparison between
a ScopeGuard that uses std::function and one that doesn't
 2020-02-15 21:33:31 +01:00
Léo Lam aa21fe17b8 Merge pull request #8618 from encounter/debugger-floating-fix 
DolphinQt/Debugger: Fix crash with floating debugger windows
 2020-02-09 15:50:47 +01:00
Léo Lam 166e86b97f Merge pull request #8619 from JosJuice/directoryblob-check-seek 
DiscIO: Check for DirectoryBlob seek failure
 2020-02-09 15:49:37 +01:00
Léo Lam fb0f543777 Merge pull request #8574 from JosJuice/volumeverifier-assert-small-file 
VolumeVerifier: Improve the messages shown for files that are too small
 2020-02-09 15:48:57 +01:00
Léo Lam 0491831483 Merge pull request #8592 from phcoder/devid 
ButtonManager: Fix handling of empty device id.
 2020-02-02 16:52:12 +01:00
Léo Lam 06d0b1ad48 Merge pull request #8594 from leoetlino/fs-createfullpath-fix 
IOS/FS: Fix CreateFullPath to not create directories that already exist
 2020-02-02 16:50:02 +01:00
Léo Lam 4c9b1f3e0b Merge pull request #8599 from Pokechu22/di-interrupt-mask-ioctls 
Fix DI interrupt mask ioctl names
 2020-02-02 16:49:27 +01:00
Léo Lam bbc8631357 IOS/FS: Fix CreateFullPath to not create directories that already exist 
This fixes CreateFullPath to not create directories when it is known
that they already exist, instead of calling CreateDirectory anyway
and checking if the error is AlreadyExists. (That doesn't work
now that we have an accurate implementation of CreateDirectory
that performs permission checks before checking for existence.)

I'm not sure what I was thinking when I wrote that function.

Also adds some tests for CreateFullPath.
 2020-01-30 18:07:03 +01:00
Léo Lam f1f293bd49 WiiRoot: Fix CopySysmenuFilesToFS directory creation 
Fixes a regression from #8539.

CreateDirectory was the correct function to use for creating
directories since parent directories already exist and are
not owned by the system menu.
 2020-01-30 13:53:39 +01:00
Léo Lam 57f4837e4d Merge pull request #8589 from lioncash/translatable 
DolphinQt/GCMemcardManager: Mark string as translatable within GetErrorMessagesForErrorCode()
 2020-01-27 23:20:03 +01:00
Léo Lam 1b90b62e63 Merge pull request #8588 from lioncash/unimplemented-fn 
DolphinQt: Remove unimplemented function prototypes
 2020-01-27 23:19:19 +01:00
Léo Lam c02e7de55a IOS/ES: Remove now unnecessary title sorting hack 
ES now uses FS to access the filesystem and FS's ReadDirectory now
returns file lists that are correctly ordered.
 2020-01-25 17:54:58 +01:00
Léo Lam 031c63eb8a UnitTests/FS: Improve deletion test 
* Test recursive directory deletion
* Test "in use" check for both files and directories
 2020-01-25 17:54:58 +01:00
Léo Lam 150c832532 Tools: Add a small Python tool to print FSTs 2020-01-25 17:54:58 +01:00