Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
28,298 Commits 1 Branch 0 Tags
eb9969a1e290d968b506921936a0d51bf5501607
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Léo Lam eb9969a1e2 Merge pull request #7025 from lioncash/integrity 
VolumeWii: Use ReadSwapped for retrieving the partition data size in CheckIntegrity()
 2018-05-30 10:55:13 +02:00
Léo Lam c3de9d7b0e Merge pull request #7020 from sepalani/ida-scripts 
Tools: Dolphin symbol map IDA scripts added
 2018-05-30 10:52:49 +02:00
Léo Lam 24e0b4bf52 Merge pull request #7024 from lioncash/discio 
VolumeGC/VolumeWii: Dehardcode sizes where applicable
 2018-05-30 10:22:18 +02:00
Léo Lam a4ec3ddef1 Don't switch to blank NAND in the middle of emulation 
Switching to blank NAND when emulation is running is an extremely bad
idea. It's akin to opening up a Wii and replacing the NAND chip while
you're playing a game on it.

Except we're not even replacing it with a NAND that has the same
contents. The blank NAND has nothing in it except the save file for
the current game, which is likely to result in the emulated software
getting inconsistent results and possibly even crashing depending on
how it caches title information.

An example of games that check the saves for other games is
Mario Kart Wii -- it checks the filesystem for Super Mario Galaxy saves
to decide whether to unlock characters. With this 'switch NAND
while emulation is active' misfeature, this will likely break.
And that's the main problem: it encourages sloppy emulation and no one
really knows how many things it can break.

Just don't let the user do horrible things like that during emulation.
If they want to use a blank NAND, they can do so by starting input
recording before launching a game. It's likely they will want to do
this if they plan to share their DTM anyway.
 2018-05-29 15:41:11 +02:00
Léo Lam 60c38d7781 Merge pull request #7007 from spycrab/qt_gecko_sort 
Qt/GeckoCodeWidget: Autosort list and fix accessing the wrong element
 2018-05-29 14:48:32 +02:00
Léo Lam 00d91db2ec Merge pull request #7008 from spycrab/ddos_sux 
Fix "Download Codes" hitting DDOS protection
 2018-05-29 14:42:24 +02:00
Léo Lam 86bbf540cf Merge pull request #7009 from lioncash/dsp 
DSPEmulator: Default destructor in the cpp file
 2018-05-29 14:16:50 +02:00
Léo Lam f05eb10026 Merge pull request #7003 from lioncash/host 
Common: Move host communication enum to Host.h
 2018-05-28 20:57:34 +02:00
Léo Lam a9f022a067 Merge pull request #6993 from lioncash/nan 
Interpreter_FPUtils: Set VXSNAN if any input operands are a signaling NaN in remaining NI_* functions
 2018-05-28 18:49:13 +02:00
Léo Lam bda668925a Merge pull request #6989 from lcsondes/fix-vector-assert 
UICommon: fix m_cached_files pruning.
 2018-05-28 12:41:22 +02:00
Léo Lam 0cba9bb218 Merge pull request #7000 from lioncash/wii-extension 
WiimoteEmu: Get rid of pointer casting in extension GetState() functions
 2018-05-28 12:39:01 +02:00
Léo Lam 686e29f2d3 Merge pull request #6995 from lioncash/cd 
CDUtils: Namespace code under the Common namespace
 2018-05-28 01:05:03 +02:00
Léo Lam 5fdf171967 Merge pull request #6994 from lioncash/symbol 
SymbolDB: Minor changes
 2018-05-28 00:16:34 +02:00
Léo Lam 31045f39ca Merge pull request #6992 from JosJuice/update-wiitdb 
Sync wiitdb files with GameTDB
 2018-05-27 23:16:49 +02:00
Léo Lam 44879f163e Config: Fix path settings not being saved 
Forgot to add a few lines while cherry-picking the config changes
for https://dolp.in/pr6950

Fixes https://bugs.dolphin-emu.org/issues/11171
 2018-05-27 21:03:01 +02:00
Léo Lam 145258ad27 Debug: Add missing override specifiers 2018-05-27 14:39:01 +02:00
Léo Lam 3798127cf7 Merge pull request #6926 from leoetlino/hardcoded-numbers 
IOSC: Remove some hardcoded offsets and magic numbers
 2018-05-27 14:17:28 +02:00
Léo Lam bea1e38c67 Move ECCSignature to Common::ec and give it a less confusing name 2018-05-27 14:01:38 +02:00
Léo Lam 44827ba369 Use CertECC struct instead of hardcoded offsets 2018-05-27 14:01:38 +02:00
Léo Lam e9ce75ccc4 Merge pull request #6977 from lioncash/add 
Interpreter_FPUtils: Set FPSCR.VXSNAN if either operand to NI_add() is a signaling NaN
 2018-05-27 10:21:20 +02:00
Léo Lam 8f003f995b Merge pull request #6981 from lioncash/const 
CodeWidget/CodeViewWidget: Make symbol pointers const where applicable
 2018-05-27 10:20:38 +02:00
Léo Lam 2bc9a4a902 Merge pull request #6982 from JosJuice/gametracker-race 
DolphinQt2: Fix a race condition in GameTracker
 2018-05-27 10:19:48 +02:00
Léo Lam f568e41fac Merge pull request #6972 from JosJuice/default-jit 
When CPU core is invalid, fall back to JIT instead of interpreter
 2018-05-26 20:18:31 +02:00
Léo Lam 92ec97f899 Merge pull request #6947 from JosJuice/unencrypted-wii-disc 
Make the support for unencrypted Wii disc images less broken
 2018-05-26 11:56:51 +02:00
Léo Lam 3f81c30e8a Merge pull request #6949 from leoetlino/stop 
Remove useless BootManager::Stop
 2018-05-26 11:45:14 +02:00
Léo Lam 98e288cb4b Merge pull request #6966 from lioncash/fmul 
Interpreter_FPUtils: Set FPSCR.VXSNAN if either operand to NI_mul() is a signaling NaN
 2018-05-26 11:43:11 +02:00
Léo Lam f802dc14c1 Remove useless BootManager::Stop 
It's not used anywhere other than in DolphinQt2, where the usage is
incorrect and stupid since we shouldn't be trying to stop the core
and 'restore config' that was changed by the core at app exit time,
but immediately when the core is being shut down.
 2018-05-26 11:33:13 +02:00
Léo Lam f64cbc86b1 Merge pull request #6968 from lioncash/mmu 
MMU: Normalize parameter naming
 2018-05-26 11:18:32 +02:00
Léo Lam 41fe7970da Merge pull request #6969 from lioncash/namespace 
Common: Namespace GekkoDisassembler.cpp/.h
 2018-05-26 11:18:10 +02:00
Léo Lam 3d44dc3981 Merge pull request #6958 from lioncash/rsqrte 
Interpreter_FloatingPoint: Handle SNaN flag setting in frsqrte
 2018-05-25 15:11:28 +02:00
Léo Lam 56217fd42f Merge pull request #6956 from lioncash/flag 
Interpreter_FPUtils: Set the FPSCR.VX bit if any invalid operation exception bits are set
 2018-05-25 15:10:05 +02:00
Léo Lam 9d1785718f Merge pull request #6955 from lioncash/nan 
Interpreter_FloatingPoint: Set FPSCR.VXSNAN if input to fres is a signaling NaN
 2018-05-25 15:09:04 +02:00
Léo Lam 647309a650 Merge pull request #6959 from leoetlino/gcc 
ES/Formats: Work around a GCC bug
 2018-05-25 13:08:57 +02:00
Léo Lam 7c6844e895 ES/Formats: Work around a GCC bug 
In old GCC versions, capturing 'this' does not work for some lambdas.
The workaround is to not use auto for the parameter (even though the
type is obvious). This can be dropped once we require GCC 7.
 2018-05-24 21:27:40 +02:00
Léo Lam dfb1dbad47 Merge pull request #6951 from JosJuice/game-inis-2018-05-23 
Update game INIs
 2018-05-23 21:32:22 +02:00
Léo Lam c99ac40700 Port FS, SD and dump path to onion config 
This ports the Wii filesystem root, Wii SD card path and dump path
settings to the new config system (OnionConfig).

My initial plan was to wait until DolphinWX was removed before porting
most of the Main (Core, DSP, General) settings to onion config, but
I've decided to submit a small part of those changes to fix
[issue 10566](https://bugs.dolphin-emu.org/issues/10566).

Removes the need to manually set the FileUtil path in the UI frontends
and gets rid of some more members that don't really belong in SConfig.

Also fixes a bug which would cause the dump path not to get created
after change.
 2018-05-23 16:07:18 +02:00
Léo Lam 93f49b1ca4 Config: Make Load() and Save() slightly faster 
Only invoke config changed callbacks from Config::Save, not
Layer::Save. The latter results in callbacks being called
once per layer, up to 7 times per save.
 2018-05-23 16:07:18 +02:00
Léo Lam 4fd1674c49 Core: Only init Wii FS contents in Wii mode 
There's no filesystem when not in Wii mode, so... bad things
would happen.
 2018-05-23 13:39:53 +02:00
Léo Lam da03ff2e25 Merge pull request #6944 from leoetlino/init-fs-contents 
Move Wii FS content init to happen after Boot
 2018-05-23 11:37:10 +02:00
Léo Lam 0e9255c469 Merge pull request #6932 from sepalani/debug-patches 
DebugInterface: MemoryPatches methods added
 2018-05-22 19:15:51 +02:00
Léo Lam 43680f314c Merge pull request #6942 from lioncash/const 
BreakPoints: Make OverlapsMemcheck() a const member function
 2018-05-22 19:14:27 +02:00
Léo Lam 593f58be6c Move Wii FS content init to happen after Boot 
Initialising Wii filesystem contents should be done after Boot and
not in HW to ensure that we operate with the correct title context
and to make sure required title directories exist (so that Movie and
Netplay code can copy data from and to the temporary NAND).
 2018-05-22 19:05:45 +02:00
Léo Lam 32c4f3d158 Merge pull request #6930 from lioncash/post 
VideoCommon/PostProcessing: Minor changes
 2018-05-21 21:12:27 +02:00
Léo Lam db5c2ffb41 Merge pull request #6931 from lioncash/vulkan-post 
Vulkan/PostProcessing: Make file-scope std::string instances const char arrays
 2018-05-21 21:11:40 +02:00
Léo Lam 4e63117501 Merge pull request #6933 from lioncash/sign 
Interpreter_SystemRegisters: Get rid of implicit sign conversions
 2018-05-21 21:08:14 +02:00
Léo Lam cb850707c0 WiiSave: Fix typo 2018-05-21 16:41:15 +02:00
Léo Lam af97df74e1 Merge pull request #6895 from leoetlino/hardcoded 
IOSC: Fix hardcoded MS and CA IDs
 2018-05-21 15:27:31 +02:00
Léo Lam 12e2012465 IOSC: Fix hardcoded MS and CA IDs 
The values that are used for the MS and CA IDs come from the SEEPROM.
Also, the default CA and MS values are respectively 2 and 3,
not 1 and 2.
 2018-05-21 15:11:25 +02:00
Léo Lam 3d8e63fffd Merge pull request #6914 from leoetlino/verifysign 
ES: Implement VerifySign (last remaining unimplemented, actually used ioctlv)
 2018-05-20 23:11:49 +02:00
Léo Lam 79edd57b96 Merge pull request #6920 from lioncash/priv 
Interpreter_SystemRegisters: Check processor privilege level in mfspr and mtspr
 2018-05-20 23:08:59 +02:00
Léo Lam 73fde6d84d Merge pull request #6923 from lioncash/prototype 
DolphinQt2/GeckoCodeWidget: Remove unimplemented OnDelete() prototype
 2018-05-20 23:02:26 +02:00
Léo Lam 4284952538 Merge pull request #6919 from lioncash/nop 
Interpreter_LoadStore: No-op dcbt and dcbtst if HID0.NOOPTI is set
 2018-05-20 20:33:38 +02:00
Léo Lam 5ce1b83d97 Merge pull request #6918 from lioncash/cast 
Interpreter_LoadStore: Remove unnecessary cast in lhzx()
 2018-05-20 20:21:16 +02:00
Léo Lam 4b0f8d9f85 ES: Implement VerifySign 
This implements ES_VerifySign which is notably used by the system menu
when importing saves.

Now *all* ES commands that are actually used by titles are implemented.
 2018-05-20 20:04:53 +02:00
Léo Lam cec7fded60 IOSC: Implement VerifyPublicKeySign for ECC 2018-05-20 20:04:53 +02:00
Léo Lam b86f1ea7b3 ES / IOSC: Add support for ECC certificates 2018-05-20 20:04:53 +02:00
Léo Lam a974c69058 Merge pull request #6866 from leoetlino/ec-cleanup 
ec: General cleanup
 2018-05-20 20:04:19 +02:00
Léo Lam 67ce7e34e9 UnitTests: Add basic tests for ec crypto code 
Verifies that PrivToPub and ComputeSharedSecret give expected results.
 2018-05-20 19:59:26 +02:00
Léo Lam 355b1b5d5b ec: Improve readability and clarity 
- Move all of the ec functions into the Common::ec namespace.

- Give the public functions better names and some usage information.

- Move all of the "elt" related functions into an "elt" class including
  all of the arithmetic operations, so that the logic becomes clearer
  and feels less like assembly.

  This also makes it much more obvious what the parameters are, instead
  of only using unsigned char* (which doesn't tell anything about what
  the pointer is used for or the size).

- Similarly, add a new "Point" class and move point functions there.
  Overload the arithmetic operators to make calculations easier to read
 2018-05-20 19:59:26 +02:00
Léo Lam e83591f188 ec: Avoid exposing internal function 2018-05-20 19:59:26 +02:00
Léo Lam b9dd94b9b2 bn: Use int instead of u32 for sizes 
The loops relied on unsigned integer overflow, which is not immediately
obvious. Replace them with less clever variants that are clearer.

Also implement bn_compare using std::memcmp.
 2018-05-20 19:59:26 +02:00
Léo Lam 56e91bfdc1 Merge pull request #6429 from JosJuice/png-banners-uicommon 
Reimplement custom PNG banners in game list
 2018-05-20 15:39:07 +02:00
Léo Lam 86c676ab04 Merge pull request #6291 from JosJuice/remove-soil 
Replace usage of SOIL with libpng
 2018-05-20 14:16:31 +02:00
Léo Lam 0706add584 Merge pull request #6699 from 404-Name-Not-Found/alphabetize-gecko-qt 
Adds a toggleable function for sorting the gecko codes alphabetically to the gecko code menu
 2018-05-20 11:13:38 +02:00
Léo Lam eae45e0e2c Merge pull request #6911 from lioncash/analyst 
PPCAnalyst: Replace memset usages with list initialization
 2018-05-20 10:45:44 +02:00
Léo Lam 464bfb073e Merge pull request #6912 from spycrab/qt_jit_widget 
Qt/JITWidget: Add object name
 2018-05-20 10:44:21 +02:00
Léo Lam 9387b7dd32 Merge pull request #6910 from lioncash/analyst 
PPCAnalyst: Clean up indexing expressions in Analyze()
 2018-05-19 23:25:59 +02:00
Léo Lam c6bd237534 Merge pull request #6908 from Tilka/warnings 
Fix -Wignored-qualifiers warnings
 2018-05-19 21:06:29 +02:00
Léo Lam 9ec557761d Merge pull request #6909 from spycrab/qt_gfx_progscan 
Qt/AdvancedWidget: Save progressive scan when toggled
 2018-05-19 21:05:52 +02:00
Léo Lam e54880e9f3 Merge pull request #6903 from spycrab/qt_toolbar 
Qt/ToolBar: Fix checkbox not properly reflecting toolbar visibility
 2018-05-19 17:19:06 +02:00
Léo Lam fc525bdf8f Merge pull request #6898 from leoetlino/certreader 
ES/Formats: Deduplicate signed blob reading code
 2018-05-19 12:11:02 +02:00
Léo Lam d399b0f59e Merge pull request #6900 from lioncash/buffer 
PPCAnalyst: Make CodeBuffer an alias for std::vector<CodeOp>
 2018-05-19 12:10:19 +02:00
Léo Lam 33c5fd6f5a IOSC: Verify that RSA signature size is correct 2018-05-18 23:12:07 +02:00
Léo Lam 964d00447d IOSC: Reuse CertReader for cert imports 2018-05-18 23:12:07 +02:00
Léo Lam 90e86fa9a6 ES/Formats: Move sha1 calculation to SignedBlobReader 2018-05-18 22:40:38 +02:00
Léo Lam fbf79f837f Merge pull request #6896 from leoetlino/title-import 
ES: Fix content check in ImportTitleDone
 2018-05-18 22:38:55 +02:00
Léo Lam 69a6724b34 Merge pull request #6897 from lioncash/sw-efb 
EfbInterface: Minor changes
 2018-05-18 22:38:00 +02:00
Léo Lam 8af0f1bfc5 Merge pull request #6899 from lioncash/mem 
MMU: Use Common::BitCast where applicable
 2018-05-18 22:18:48 +02:00
Léo Lam f82e2f0b92 ES: Fix content check in ImportTitleDone 
ImportTitleDone only checks if all required contents have been imported
for system titles.

This fixes the system menu not being able to recreate title directories
to copy a save back to the NAND by using title import functionality.
 2018-05-18 20:59:33 +02:00
Léo Lam 473cbfa951 ES: Add more logging in title import functions 
...to make troubleshooting easier.
 2018-05-18 20:59:29 +02:00
Léo Lam bb2c3bd572 Merge pull request #6894 from lioncash/mem 
BPMemory: Use Common::BitCast where applicable
 2018-05-18 20:35:18 +02:00
Léo Lam 49c9c1ee40 Merge pull request #6853 from aldelaro5/qt-debugger-hotkey-fixes 
Qt debugger hotkey fixes
 2018-05-18 19:06:17 +02:00
Léo Lam 47fd8c6eff Merge pull request #6855 from aldelaro5/qt-render-min-width 
Qt: allow to resize the render widget however wanted on render to main
 2018-05-16 14:11:51 +02:00
Léo Lam 4de2c5040d Merge pull request #6867 from jackoalan/code-view-bg 
Qt/CodeViewWidget: Dynamic background dimming for dark themes
 2018-05-16 14:08:02 +02:00
Léo Lam 9335400f65 Merge pull request #6862 from aldelaro5/qt-unify-pause-play 
Qt: make the pause play button only one button
 2018-05-16 14:07:35 +02:00
Léo Lam 159f6115e2 Merge pull request #6851 from lioncash/usage 
BreakpointWidget: Move variables closer to usage sites in OnLoad()
 2018-05-14 19:18:05 +02:00
Léo Lam b5761f9dc7 Merge pull request #6852 from lioncash/code 
CodeViewWidget: Minor changes
 2018-05-14 19:17:35 +02:00
Léo Lam 5b15060127 Merge pull request #6857 from spycrab/qt_minor_win 
Qt: Minor window fixes
 2018-05-14 19:11:56 +02:00
Léo Lam f8e5e7126c Merge pull request #6849 from leoetlino/oops 
WiiSave: Fix out-of-bounds read
 2018-05-13 23:34:32 +02:00
Léo Lam 345838d517 Merge pull request #6842 from spycrab/qt_map_apply 
Qt/Mapping: Fix mapping changes not being applied instantly
 2018-05-13 23:34:18 +02:00
Léo Lam 3fbfa4335e WiiSave: Fix out-of-bounds read 
Fixes the count argument for WriteArray. (I used it like WriteBytes.)
Whoops.
 2018-05-13 23:18:28 +02:00
Léo Lam 2be8c35d6d Merge pull request #6844 from leoetlino/wii-save-cleanup2 
WiiSave: Reuse IOS services where possible
 2018-05-13 23:08:28 +02:00
Léo Lam 8f44423a5b Merge pull request #6846 from spycrab/qt_native_sep 
Qt: Use native dir separators
 2018-05-13 22:10:10 +02:00
Léo Lam 6c38e4b47f Merge pull request #6847 from lioncash/fs-include 
FilesystemWidget: Replace DiscIO includes with forward declarations
 2018-05-13 22:08:09 +02:00
Léo Lam 1fe92b8be7 Merge pull request #6845 from lioncash/patch-dlg 
NewPatchDialog/PatchesWidget: Use forward declarations where applicable
 2018-05-13 22:00:43 +02:00
Léo Lam 07b57c7ac6 Merge pull request #6843 from lioncash/patch 
PatchEngine: Minor changes
 2018-05-13 21:58:55 +02:00
Léo Lam b405a1fbb1 WiiSave: Reuse ES::GetInstalledTitles 
Same thing, less code, no manual FS access.
 2018-05-13 21:28:35 +02:00
Léo Lam a2ffe010f3 WiiSave: Reuse IOSC::Sign for signing 2018-05-13 21:28:35 +02:00
Léo Lam 07caac1d23 WiiSave: Reuse IOSC for AES decryption/encryption 
The SD key is already in IOSC.

This also prevents WiiSave from exposing an external library as part
of its interface.
 2018-05-13 21:25:58 +02:00
Léo Lam e67cbd462b Merge pull request #6841 from spycrab/qt_fix_rtmfocus 
Qt/RenderWidget: Fix render-to-main focus
 2018-05-13 21:16:26 +02:00