Yaya48/dolphin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
38,937 Commits 1 Branch 0 Tags
83b7b01265598067494eca228175e5b5805e36a2
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Scott Mansell 83b7b01265 Fix XFB duplicate detection 
Frame duplicate detection was inverted. Huge problem for 60fps games
where it would see all frames as "duplicates" and nothing would ever be
presented.
 2023-02-09 18:36:20 +13:00
Scott Mansell d3ddd96cee Make sure m_prev_efb_format is initilized 2023-02-09 18:36:20 +13:00
Scott Mansell 59a4b026f6 Better documentation for HookableEvent. 2023-02-09 18:36:20 +13:00
Scott Mansell 8c8bd0e7ac Rename to HookableEvent. Because naming conflict 2023-02-09 18:36:20 +13:00
Scott MansellMaiBhaaLiwubcode
 		60f2b5af7b Apply suggestions from code review 
Co-authored-by: Mai <[email protected]>
Co-authored-by: BhaaL <[email protected]>
Co-authored-by: iwubcode <[email protected]>
 2023-02-09 18:36:20 +13:00
Scott Mansell e0a1631659 Add comment about "end of frame" 2023-02-09 18:36:20 +13:00
Scott MansellandMai 43b6a49012 Apply suggestions from code review 
Co-authored-by: Mai <[email protected]>
 2023-02-09 18:36:20 +13:00
Scott MansellandBhaaL 05fad53fa0 Update STATE_VERSION 
Co-authored-by: BhaaL <[email protected]>
 2023-02-09 18:36:20 +13:00
Scott Mansell e2de281897 Make sure pixel shaders pick up Initial EFB Scale 2023-02-09 18:36:20 +13:00
Scott Mansell cf9a6f8477 Lint fixes 2023-02-09 18:36:20 +13:00
Scott Mansell f7ad825736 fix fbdev 2023-02-09 18:36:20 +13:00
Scott Mansell 628af9d564 Fix builds with FFMPEG disabled 2023-02-09 18:36:20 +13:00
Scott Mansell 4422af1272 Cleanup headers 2023-02-09 18:36:20 +13:00
Scott Mansell 5803786beb Move UseVertexDepthRange() out of Renderer 
There wasn't really a good place for it, but this will do
 2023-02-09 18:36:20 +13:00
Scott Mansell 2cfc02a116 Move m_prev_efb_format into FramebufferManager 2023-02-09 18:36:20 +13:00
Scott Mansell 9b5397abdb Move WidescreenHeuristic to it's own class 
It's about the only thing left in renderer
 2023-02-09 18:36:20 +13:00
Scott Mansell 31cfe8250d Lint fixes 2023-02-09 18:36:20 +13:00
Scott Mansell 11de923dcb Move xfb tracking and IR scaling out of RenderBase 2023-02-09 18:36:20 +13:00
Scott Mansell e009002411 Refactor ClearRegion 
And fix bug where opengl was getting the wrong coordinates
 2023-02-09 18:36:20 +13:00
Scott Mansell b753641dd4 Add some descriptions to new classes 2023-01-31 19:41:24 +13:00
Scott Mansell abfc75f362 Cleanup headers 2023-01-31 19:41:24 +13:00
Scott Mansell ec8f46b02c Expose Renderer's Framecount 
We don't want to move it, because we want to complete
this refactor without changing savestate version
 2023-01-31 19:41:24 +13:00
Scott Mansell 3be63221c7 Renderer still needs to track swaps for savestates 2023-01-31 19:41:24 +13:00
Scott Mansell 3ae78b8e76 Also use events for config changed 2023-01-31 19:41:24 +13:00
Scott Mansell 0da69055d9 Split out everying remaining from Swap 2023-01-31 19:41:24 +13:00
Scott Mansell 2a18b34a73 Wire up frame before/after events 2023-01-31 19:41:24 +13:00
Scott Mansell 154cb4f722 Introduce an Event system to VideoCommon 
A lot of the remaining complexity in Renderer is the massive Swap function
which tries to handle a bunch of FrameBegin/FrameEnd events.

Rather than create a new place for it. This event system will try
to distribute it all over the place
 2023-01-31 19:41:24 +13:00
Scott Mansell d6cd8de1a7 Delete unused EFBHasAlphaChannel function 2023-01-31 19:41:24 +13:00
Scott Mansell 9d125a6e43 Move ConfigChanged out of RenderBase 
There is this nice VideoConfig file that's perfect for it
 2023-01-31 19:41:24 +13:00
Scott Mansell ca5ec13e13 Move GraphicsMod out of RenderBase 2023-01-31 19:41:24 +13:00
Scott Mansell 55d15bdd6e Move utiltily drawing out of RenderBase 2023-01-31 19:41:24 +13:00
Scott Mansell 99d3e489ea Move BoundingBox out of RenderBase 
They were essentially just pass-though methods
 2023-01-31 19:41:24 +13:00
Scott Mansell 35a69cb1bb Fix missing include 2023-01-31 19:41:24 +13:00
Scott Mansell 8ad59f8ccf Add AbstractGfx for DX12 2023-01-31 19:41:24 +13:00
Scott Mansell 5a2d119bda Implement AbstractGfx for Dx11 2023-01-31 19:41:24 +13:00
Scott Mansell 8bc8e43dd6 Add virtual Initialize() to PerfQueryBase 
Both DX12 and Vulkan already had one.
 2023-01-31 19:41:24 +13:00
Scott Mansell 3c73707dfe Fix dead code. 2023-01-31 19:41:24 +13:00
Scott Mansell eaae5b4a45 Implement AbstactGfx for Metal 2023-01-31 19:41:24 +13:00
Scott Mansell 89d9ec0a84 Fix warning 2023-01-31 19:41:24 +13:00
Scott Mansell b007b8e104 Replace BeginUI/EndUI 2023-01-31 19:41:24 +13:00
Scott Mansell 18c799f0b6 Present: Set surface info before initializing ImGui 
Otherwise you get subtle bugs in vulkan that take hours to track down.
 2023-01-31 19:41:24 +13:00
Scott Mansell 06ae08ca8b Fix misnamed local variable 2023-01-31 19:41:24 +13:00
Scott Mansell f158ff300b Handle VideoSoftware's present fallback better 
Not a good idea to abuse bSupportsPostProcessing
 2023-01-31 19:41:24 +13:00
Scott Mansell 26e00c3bb4 Fix warning about using & with bools 2023-01-31 19:41:23 +13:00
Scott Mansell 74d3b3443a Fix warning about compare sign mismatch 2023-01-31 19:41:23 +13:00
Scott Mansell 8f5b196019 Minimise include polution from RenderState 2023-01-31 19:41:23 +13:00
Scott Mansell 2a2014af09 Implement AbstractGfx for Vulkan 2023-01-31 19:41:23 +13:00
Scott Mansell 58b70b2fb2 Don't set common globals from Video Backends 2023-01-31 19:41:23 +13:00
Scott Mansell d37f83ffeb Implement AbstractGfx for Software & Null 2023-01-31 19:41:23 +13:00
Scott Mansell f0336a3129 Implement AbstractGfx for OpenGL 
Mostly involves moving contents of OGLRender
to OGLGfx and OGLConfig
 2023-01-31 18:46:04 +13:00
Scott Mansell 8a23629345 Split AbstractGfx out of Renderer 
Almost all the virtual functions in Renderer are part of dolphin's
"graphics api abstraction layer", which has slowly formed over the
last decade or two.

Most of the work was done previously with the introduction of the
various "AbstractX" classes, associated with texture cache cleanups
and implementation of newer graphics APIs (Direct3D 12, Vulkan, Metal).
We are simply taking the last step and yeeting these functions out
of Renderer.

This "AbstractGfx" class is now completely agnostic of any details
from the flipper/hollywood GPU we are emulating, though somewhat
specialized.

(Will not build, this commit only contains changes outside VideoBackends)
 2023-01-31 18:46:02 +13:00
Scott Mansell e57eb04ed3 Rename FrameDump.{cpp,h} to FrameDumpFFMpeg.{cpp,h} 
The name kind of conflicts with a new FrameDumper class
 2023-01-31 18:45:29 +13:00
Scott Mansell 0d4537d60f Move Presenting, Dumping and ImGui out of Renderer 2023-01-31 18:45:21 +13:00
Scott Mansell c38c76abad Refactor to remove virtual from RenderXFBToScreen 
Slightly simplifies the upcoming refactor
 2023-01-31 18:29:47 +13:00
Scott Mansell a01d5283ec TextureCache: Add content locking 
Texture cache occasionally mutates textures for efficiency.
Which is awkward if we want to borrow those textures from texture cache
to do something else, such as a graphics debugger, or async presentation
on another thread.

Content locking provides a way to signal that the contents of a texture
cache entry should not change. Texture cache will be forced to use
alternative strategies.
 2023-01-31 18:29:47 +13:00
Scott Mansell 606c18210d TextureCache: Refactor with smart pointers 
The whole ownership model was getting a bit of a mess, with a some
of special cases to deal with. And I'm planning to make it even more
complex in the future.
So here is some upfront work to convert it over to reference counted
pointers.
 2023-01-31 18:29:47 +13:00
Scott Mansell c1fd4a2013 Move TCacheEntry out of TextureCacheBase 
Allows for fowards declaration
 2023-01-31 18:29:47 +13:00
Scott Mansell 6d7303993c Merge pull request #11509 from Sam-Belliveau/improved-speed-counter 
Tie Speed to CPU Speed and not VPS
 2023-01-30 20:41:03 +13:00
Scott Mansell 13d14282a0 Merge pull request #11511 from TellowKrinkle/MTLHD4000 
VideoCommon: Avoid creating pipelines with no render targets
 2023-01-30 19:31:36 +13:00
Scott Mansell 5a8b8658f1 Merge pull request #11514 from JMC47/cpuculldefaults 
Add CPU Cull to Twilight Princess and Metroid Prime Series
 2023-01-30 19:29:35 +13:00
Scott Mansell 6ad182edd9 Ignore nullability-completeness warnings in VMA 
These cause a lot of warnings when compiling with clang.
And the example VmaUsage.h appears to disable them
 2023-01-30 03:11:51 +13:00
Scott Mansell 7c202ab411 Reset throttle on savestate load 2023-01-16 14:18:42 +13:00
Scott Mansell 3f6795f5e8 Merge pull request #10971 from Zopolis4/readmemakeup 
Fix minor typo in readme
 2022-08-10 19:32:13 +12:00
Scott Mansell a89fe51543 Merge pull request #10973 from phire/freebsd_fmt_consteval 
Workaround FreeBSD/clang/fmt bug
 2022-08-10 19:29:14 +12:00
Scott Mansell 12a5f73418 Workaround Freebsd/clang/fmt bug 2022-08-10 18:46:10 +12:00
Scott Mansell 2747ab7765 Merge pull request #10653 from t895/tv-card 
Android: Consistent TV card colors
 2022-08-10 16:42:45 +12:00
Scott Mansell 1dbe2a4ea2 Merge pull request #10431 from Zopolis4/readmemakover 
Rewrite readme
 2022-08-10 14:40:24 +12:00
Scott Mansell 4f96d2f1c3 Merge pull request #10944 from Sage-King/NetPlayServerUpdates 
NetPlayServer.cpp OnConnect() Minor Code Updates
 2022-08-10 10:54:53 +12:00
Scott Mansell 4c2d707538 Merge pull request #10940 from InvoxiPlayGames/ipc-discord 
Add Discord presence ioctlv to /dev/dolphin
 2022-08-08 08:11:42 +12:00
Scott Mansell 04beb23877 Merge pull request #10943 from Pokechu22/gormiti-gameini 
GameSettings: Use Safe Texture Cache and add patch for black screens for Gormiti: The Lords of Nature!
 2022-08-05 22:56:28 +12:00
Scott Mansell ebf95370ef Merge pull request #10946 from Pokechu22/remove-iLog 
VideoCommon: Remove old iLog field
 2022-08-05 22:42:09 +12:00
Scott Mansell 1ea0c7752e Merge pull request #10897 from Hibyehello/LogManager-Fix 
LogManager: Dynamically get last log type
 2022-07-28 11:54:22 +12:00
Scott Mansell 8f0d702e5f Merge pull request #10778 from maxdunbar/patch-1 
Readme: Referencing the wiki when building for linux
 2022-07-25 10:18:16 +12:00
Scott Mansell 4db1816368 cmake: Require cmake 3.15 for MSVC 
We need these policies, but we kind of want to avoid requiring cmake
3.15 for all platforms
 2022-05-22 00:29:47 +02:00
Scott Mansell 876f6651b4 cmake: fix PCH to work with msvc/ninja 
Ninja puts way more effort into compiling targets in parallel, and
ignores dependenceis until link time.

So we need to jump though hoops to force ninja to compile
pch.cpp before any targets which depend on the PCH.
 2022-05-22 00:29:47 +02:00
Scott Mansell 89fda54820 cmake: fix ninja/msvc builds 
If you don't set this policy, then cmake doesn't even try
to select a runtime library
 2022-05-22 00:29:47 +02:00
Scott Mansell 0909e00117 cmake: fix MSVC PCH support 
I'm not sure if the previous implementation ever worked.
 2022-05-22 00:29:47 +02:00
Scott Mansell 2348017ee8 cmake: ignore external warnings in MSVC 
Since we also treat all warnings as errors, we need to
ignore these to successfully build.
 2022-05-22 00:29:46 +02:00
Scott Mansell 987f270083 cmake: fix buggy target sources on windows 
I have no idea why cmake supports PUBLIC on target_sources,
but it does. It causes all targets that depend on this target
to try and include the files in their sources.
Except it doesn't take paths into account, so it breaks. Mabye
it would work if you used an abolute source? But I'm not sure
there is a sane usecase.
 2022-05-22 00:29:46 +02:00
Scott Mansell 54d89b955a cmake: add missing FFmpeg dependency on windows 2022-05-22 00:29:46 +02:00
Scott Mansell d2df9afda2 cmake: Fix libusb on windows 2022-05-22 00:29:46 +02:00
Scott Mansell c5c4169bc8 Merge pull request #10255 from Pokechu22/sw-zfreeze 
Software: Fix zfreeze with CullMode::All
 2022-04-15 11:12:49 +12:00
Scott Mansell 36678dca59 Merge pull request #10585 from Pokechu22/apple-m1-unit-tests-f-string 
Apple M1: Fix "Building and running unit tests" message
 2022-04-15 10:43:59 +12:00
Scott Mansell 0327bc2ab6 Merge pull request #10256 from malleoz/show-rerecord-count 
Renderbase: Show rerecord count
 2021-12-03 14:42:10 +13:00
Scott Mansell e92e90d147 Merge pull request #10263 from dolphin-emu/revert-10217-bombermanjetters 
Revert "Force Dual Core on for Bomberman Jetters"
 2021-12-03 01:28:33 +13:00
Scott Mansell 26e4e67d45 Merge pull request #10258 from Pokechu22/fifoplayer-efb-clear 
FifoPlayer: Clear EFB before starting playback
 2021-12-03 00:22:27 +13:00
Scott Mansell 57d251c2f0 Merge pull request #10242 from smitdylan2001/master 
Fixed Gamecube naming to GameCube
 2021-11-30 06:58:55 +13:00
Scott Mansell 676c500cdc Merge pull request #10214 from OatmealDome/mvk-better-incremental 
MoltenVK: Don't run fetchDependencies unnecessarily
 2021-11-25 11:47:36 +13:00
Scott Mansell f5c550e9cb Delay singlecore gpu interrupts 
Fixes Bomberman Jetters in single core mode.

When single core mode pauses the CPU to execute the GPU
FIFO it greedily executes the whole thing. Before this commit,
Finish and Token interrupts would happen instantly, not even
taking into account how long the current FIFO window has
taken to execute. The interrupts would be effectively backdated
to the start of this execution window.

This commit does two things: It pipes the current FIFO window
execution time though to the interrupt scheduling and it enforces
a minimum delay of 500 cycles before an interrupt will be fired.
 2021-11-25 11:11:01 +13:00
Scott Mansell 9bbc843542 VideoSoftware: Fix copy filter clamping 2021-11-17 09:29:16 +13:00
Scott Mansell 7128befb39 Fix copy filter clamping regression in Spyro 
This fixes horizontal lines in the bloom effect of Spyro: A Hero's Tail,
which is a regression caused by PR #10204

Screenshot of regression:
https://user-images.githubusercontent.com/138484/142030503-90fcd8d5-63d3-4820-874a-72e9be0c4768.png

Fixed:
https://user-images.githubusercontent.com/138484/142031598-b85ff55c-1302-4e4d-bcb2-57848974056b.png

Spyro uses an 640x80 pixel sub-buffer within the EFB to calculate
it's bloom effects, which it places below the main 640x448 buffer.

EFB layout:
https://user-images.githubusercontent.com/138484/142030573-e933b6ae-c37e-4be6-86d4-0bc779b92535.png
Note: Colors are wrong because the main color buffer uses RGBA6,
      while the bloom is calculated in RGB8

This allows it to do bloom without backing up part of the EFB to
main memory, as most games do.

But, since some of the sub-buffers used in the bloom effect are taller
than 80 pixels, they need to be sliced up into smaller sub, sub buffers
which get combined later when copied to main memory.

At one point, a 320x224 buffer is broken up into 320x80, 320x64 and
320x80 slices. These are copied out with the copy filter set to a
vertical blur.

Because there was an off-by-one errror in the clamping coordinates,
the bottom line of the color buffer would be blurred into
the top of each slice.

Final combined EFB copy:
https://user-images.githubusercontent.com/138484/142031360-2c076839-7c96-4b3b-a093-d899d0a2c7ae.png

Fixed version:
https://user-images.githubusercontent.com/138484/142031370-72e41a35-3b3e-4662-a483-79203e357ecc.png

Before #10204 the copy filter wasn't enabled for efb copies, and most
other games don't do this type of slicing.

FIFO CI shows that a few other games are effected, it's always just a minor difference to the top line where there was previously a slight hint of garbage.
 2021-11-17 06:12:46 +13:00
Scott Mansell b997048cfe Merge pull request #10142 from aldelaro5/gdb-stub-rework 
Rework the entire logic of the GDB stub
 2021-10-24 01:51:29 +13:00
Scott Mansell 13985b774e Merge pull request #10170 from ooshlablu/deb-package-cpack-generation 
Enable deb package generation with cpack
 2021-10-17 13:38:56 +13:00
Scott Mansell 0d5f2810e7 Merge pull request #10166 from fpdotmonkey/heed-tev-switch-warning 
Silence the -Wswitch warnings in Tev
 2021-10-14 20:42:11 +13:00
Scott Mansell edb66dab84 TextureCache: Remove deleted textures from bound_textures 
Fixes issue where vulkan might crash trying to bind a deleted
texture.
 2021-10-12 15:51:24 +13:00
Scott Mansell d771bee0fe TMEM: Add some helpful comments 2021-10-12 15:51:24 +13:00
Scott Mansell a33cf27885 TMEM: Handle savestate and init 2021-10-12 15:51:24 +13:00
Scott Mansell 88bd10cd30 Extend TMEM cache implementation 
Now works with games that deliberately avoid invalidating TMEM because
they know textures are too large to fit:

 * Sonic Riders
 * Metal Arms: Glitch in the System
 * Godzilla: Destroy All Monsters Melee
 * NHL Slapshot
 * Tak and the Power of Juju
 * Night at the Museum: Battle of the Smithsonian
 * 428: Fūsa Sareta Shibuya de
 2021-10-12 15:51:24 +13:00
Scott Mansell eee302c040 Merge pull request #10158 from phire/bb-missing-include 
BoundingBox: Add missing include
 2021-10-10 16:15:10 +13:00
Scott Mansell 5a8455e8ce BoundingBox: Add missing include 2021-10-10 13:21:31 +13:00